author | Holger Weiß <holger@zedat.fu-berlin.de> | |
Mon, 29 Mar 2010 10:22:19 +0000 (12:22 +0200) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Wed, 31 Mar 2010 21:21:39 +0000 (14:21 -0700) | ||
commit | 21e403a7b956a95a36f218439f82b1c8af869257 | |
tree | 9dfe35c59f028f08dc63d5732232d002392e4ac6 | tree | snapshot |
parent | 7a49c254cdaec6b15a6e2818e29fdb34fc6f7717 | commit | diff |
Don't redefine htonl and ntohl on big-endian
Since commit 0fcabdeb52b79775173d009ccc179db104dfbb66, compat/bswap.h
redefined htonl and ntohl to bswap32 not only if bswap32 has been
defined earlier in compat/bswap.h (which is done only on selected
platforms), but also if bswap32 has been defined anywhere else. This
broke Git at least for NetBSD systems running on big-endian machines
(where ntohl and htonl should, of course, be NOOPs), since NetBSD
defines a bswap32 macro in the system headers.
So, we now undefine any previously defined bswap32 in compat/bswap.h
before defining our own.
Signed-off-by: Holger Weiß <holger@zedat.fu-berlin.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Since commit 0fcabdeb52b79775173d009ccc179db104dfbb66, compat/bswap.h
redefined htonl and ntohl to bswap32 not only if bswap32 has been
defined earlier in compat/bswap.h (which is done only on selected
platforms), but also if bswap32 has been defined anywhere else. This
broke Git at least for NetBSD systems running on big-endian machines
(where ntohl and htonl should, of course, be NOOPs), since NetBSD
defines a bswap32 macro in the system headers.
So, we now undefine any previously defined bswap32 in compat/bswap.h
before defining our own.
Signed-off-by: Holger Weiß <holger@zedat.fu-berlin.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/bswap.h | diff | blob | history |