author | Pierre Habouzit <madcoder@debian.org> | |
Thu, 20 Sep 2007 08:43:11 +0000 (10:43 +0200) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Fri, 21 Sep 2007 06:17:22 +0000 (23:17 -0700) | ||
commit | 19247e5510279f018f8358a72b38cc5aa62fac8a | |
tree | 6ee9736265daacbd734b103451f3608ef370d45b | tree | snapshot |
parent | e03e05ff73a6f6b4f32eb5cd13b4f1e43275e42f | commit | diff |
nfv?asprintf are broken without va_copy, workaround them.
* drop nfasprintf.
* move nfvasprintf into imap-send.c back, and let it work on a 8k buffer,
and die() in case of overflow. It should be enough for imap commands, if
someone cares about imap-send, he's welcomed to fix it properly.
* replace nfvasprintf use in merge-recursive with a copy of the strbuf_addf
logic, it's one place, we'll live with it.
To ease the change, output_buffer string list is replaced with a strbuf ;)
* rework trace.c to call vsnprintf itself. It's used to format strerror()s
and git command names, it should never be more than a few octets long, let
it work on a 8k static buffer with vsnprintf or die loudly.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
* drop nfasprintf.
* move nfvasprintf into imap-send.c back, and let it work on a 8k buffer,
and die() in case of overflow. It should be enough for imap commands, if
someone cares about imap-send, he's welcomed to fix it properly.
* replace nfvasprintf use in merge-recursive with a copy of the strbuf_addf
logic, it's one place, we'll live with it.
To ease the change, output_buffer string list is replaced with a strbuf ;)
* rework trace.c to call vsnprintf itself. It's used to format strerror()s
and git command names, it should never be more than a few octets long, let
it work on a 8k static buffer with vsnprintf or die loudly.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
cache.h | diff | blob | history | |
imap-send.c | diff | blob | history | |
merge-recursive.c | diff | blob | history | |
trace.c | diff | blob | history |