Code

list-objects: add "void *data" parameter to show functions
authorChristian Couder <chriscool@tuxfamily.org>
Mon, 6 Apr 2009 19:28:36 +0000 (21:28 +0200)
committerJunio C Hamano <gitster@pobox.com>
Wed, 8 Apr 2009 05:12:38 +0000 (22:12 -0700)
commit11c211fa06fc396e8ee8132ef83e2f2763ff6976
tree852484cc0f26ae0fd0f968b384040e591b09b9d0
parente89aa6d2f546b2d4f2d88c15ce7e343751d6922f
list-objects: add "void *data" parameter to show functions

The goal of this patch is to get rid of the "static struct rev_info
revs" static variable in "builtin-rev-list.c".

To do that, we need to pass the revs to the "show_commit" function
in "builtin-rev-list.c" and this in turn means that the
"traverse_commit_list" function in "list-objects.c" must be passed
functions pointers to functions with 2 parameters instead of one.

So we have to change all the callers and all the functions passed
to "traverse_commit_list".

Anyway this makes the code more clean and more generic, so it
should be a good thing in the long run.

Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin-pack-objects.c
builtin-rev-list.c
list-objects.c
list-objects.h
upload-pack.c