author | Dmitry Ivankov <divanorama@gmail.com> | |
Thu, 22 Sep 2011 19:47:05 +0000 (01:47 +0600) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Thu, 22 Sep 2011 20:30:59 +0000 (13:30 -0700) | ||
commit | 0bc69881a611c582f3b89a475882161d83c56494 | |
tree | aceec5dfeddcc08f6cde658da692f45e3ca1d0dd | tree | snapshot |
parent | 2c9c8ee2de3fc6af5a28cbeec15edcf9fe43537c | commit | diff |
fast-import: don't allow to note on empty branch
'reset' command makes fast-import start a branch from scratch. It's name
is kept in lookup table but it's sha1 is null_sha1 (special value).
'notemodify' command can be used to add a note on branch head given it's
name. lookup_branch() is used it that case and it doesn't check for
null_sha1. So fast-import writes a note for null_sha1 object instead of
giving a error.
Add a check to deny adding a note on empty branch and add a corresponding
test.
Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
'reset' command makes fast-import start a branch from scratch. It's name
is kept in lookup table but it's sha1 is null_sha1 (special value).
'notemodify' command can be used to add a note on branch head given it's
name. lookup_branch() is used it that case and it doesn't check for
null_sha1. So fast-import writes a note for null_sha1 object instead of
giving a error.
Add a check to deny adding a note on empty branch and add a corresponding
test.
Signed-off-by: Dmitry Ivankov <divanorama@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
fast-import.c | diff | blob | history | |
t/t9300-fast-import.sh | diff | blob | history |