author | Junio C Hamano <gitster@pobox.com> | |
Mon, 20 Jun 2011 19:31:59 +0000 (12:31 -0700) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Mon, 20 Jun 2011 20:09:04 +0000 (13:09 -0700) | ||
commit | 085479e7001b6feb7e9be02e77d84e27be796774 | |
tree | 79ac03db029aec24eba22a5cc050b85047537977 | tree | snapshot |
parent | daab4eeafa0dc620d67ccb57c28e08f6f8b3868c | commit | diff |
cygwin: trust executable bit by default
Earlier 7974843 (compat/cygwin.c: make runtime detection of lstat/stat
lessor impact, 2008-10-23) fixed the low-level "do we use cygwin specific
hacks for stat/lstat?" logic not to call into git_default_config() from
random codepaths that are typically very late in the program, to prevent
the call from potentially overwriting other variables that are initialized
from the configuration.
However, it forgot that on Cygwin, trust-executable-bit should default to
true.
Noticed by J6t, confirmed by Ramsay Jones, and the brown paper bag is on
Gitster's head.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Earlier 7974843 (compat/cygwin.c: make runtime detection of lstat/stat
lessor impact, 2008-10-23) fixed the low-level "do we use cygwin specific
hacks for stat/lstat?" logic not to call into git_default_config() from
random codepaths that are typically very late in the program, to prevent
the call from potentially overwriting other variables that are initialized
from the configuration.
However, it forgot that on Cygwin, trust-executable-bit should default to
true.
Noticed by J6t, confirmed by Ramsay Jones, and the brown paper bag is on
Gitster's head.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
compat/cygwin.c | diff | blob | history |