author | Jeff King <peff@peff.net> | |
Thu, 21 Oct 2010 14:49:47 +0000 (10:49 -0400) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Thu, 21 Oct 2010 22:44:53 +0000 (15:44 -0700) | ||
commit | 07cd7265274ba6aed2589e6b22eae7d413640037 | |
tree | fd40e5561ce7a3d99428ad830623a819c64fae91 | tree | snapshot |
parent | 1bb28d87e1d8897db662f48455d369860758fbdd | commit | diff |
diff: report bogus input to -C/-M/-B
We already detect invalid input to these functions, but we
simply exit with an error code, never saying anything as
simple as "your input was wrong". Let's fix that.
Before:
$ git diff -CM
$ echo $?
128
After:
$ git diff -CM
error: invalid argument to -C: M
$ echo $?
128
There should be no problems with having diff_opt_parse print
to stderr, as there is already precedent in complaining
about bogus --color and --output arguments.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
We already detect invalid input to these functions, but we
simply exit with an error code, never saying anything as
simple as "your input was wrong". Let's fix that.
Before:
$ git diff -CM
$ echo $?
128
After:
$ git diff -CM
error: invalid argument to -C: M
$ echo $?
128
There should be no problems with having diff_opt_parse print
to stderr, as there is already precedent in complaining
about bogus --color and --output arguments.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff.c | diff | blob | history |