author | Junio C Hamano <junkio@cox.net> | |
Sat, 4 Jun 2005 06:02:23 +0000 (23:02 -0700) | ||
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | |
Sun, 5 Jun 2005 21:14:58 +0000 (14:14 -0700) | ||
commit | 0601e131c95940701c153e35ba73b97914ec0b3f | |
tree | d42cc611e197f54e1429f4ffebf3ba0d105073b1 | tree | snapshot |
parent | 5aa7d94cd6376b2c9a7fa7bdc33fb306b940360a | commit | diff |
[PATCH] diff.c: locate_size_cache() fix.
This fixes two bugs.
- declaration of auto variable "cmp" was preceeded by a
statement, causing compilation error on real C compilers;
noticed and patch given by Yoichi Yuasa.
- the function's calling convention was overloading its size
parameter to mean "largest possible value means do not add
entry", which was a bad taste. Brought up during a
discussion with Peter Baudis.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
This fixes two bugs.
- declaration of auto variable "cmp" was preceeded by a
statement, causing compilation error on real C compilers;
noticed and patch given by Yoichi Yuasa.
- the function's calling convention was overloading its size
parameter to mean "largest possible value means do not add
entry", which was a bad taste. Brought up during a
discussion with Peter Baudis.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
diff.c | diff | blob | history |