author | Shawn O. Pearce <spearce@spearce.org> | |
Sat, 17 Apr 2010 20:07:34 +0000 (13:07 -0700) | ||
committer | Junio C Hamano <gitster@pobox.com> | |
Sat, 17 Apr 2010 20:55:45 +0000 (13:55 -0700) | ||
commit | 03b6aeb27443f117a3d8375f01bc38baeeff65a5 | |
tree | 7dae2836758a59be2841541a4b542f50e945ff0a | tree | snapshot |
parent | f78683f3a85ca16ae16e1180703d3280b272f45d | commit | diff |
http.c: Remove bad free of static block
The filename variable here is pointing to a block of memory that
was allocated by sha1_file.c and is also held in a static variable
scoped within the sha1_pack_name() function. Doing a free() here is
returning that memory to the allocator while we might still try to
reuse it on a subsequent sha1_pack_name() invocation. That's not
acceptable, so don't free it.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
The filename variable here is pointing to a block of memory that
was allocated by sha1_file.c and is also held in a static variable
scoped within the sha1_pack_name() function. Doing a free() here is
returning that memory to the allocator while we might still try to
reuse it on a subsequent sha1_pack_name() invocation. That's not
acceptable, so don't free it.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
http.c | diff | blob | history |