X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=tig.c;h=f842de567b03108f63dbfe44f3ec7af3bed82a9d;hb=9b2d063f47427490f4a605ccc708cdfab522f9d9;hp=3c128876a7fbc383c9b1f3802e045d6f5262cd4b;hpb=a7b1c1c096424f4af7f9083d2437cb6b6d0eb5f4;p=tig.git

diff --git a/tig.c b/tig.c
index 3c12887..f842de5 100644
--- a/tig.c
+++ b/tig.c
@@ -142,7 +142,6 @@ static int load_refs(void);
 
 enum format_flags {
 	FORMAT_ALL,		/* Perform replacement in all arguments. */
-	FORMAT_DASH,		/* Perform replacement up until "--". */
 	FORMAT_NONE		/* No replacement should be performed. */
 };
 
@@ -520,6 +519,7 @@ utf8_length(const char **start, size_t skip, int *width, size_t max_width, int *
 #define DATE_INFO \
 	DATE_(NO), \
 	DATE_(DEFAULT), \
+	DATE_(LOCAL), \
 	DATE_(RELATIVE), \
 	DATE_(SHORT)
 
@@ -584,7 +584,13 @@ mkdate(const struct time *time, enum date date)
 		}
 	}
 
-	gmtime_r(&time->sec, &tm);
+	if (date == DATE_LOCAL) {
+		time_t date = time->sec + time->tz;
+		localtime_r(&date, &tm);
+	}
+	else {
+		gmtime_r(&time->sec, &tm);
+	}
 	return strftime(buf, sizeof(buf), DATE_FORMAT, &tm) ? buf : NULL;
 }
 
@@ -672,6 +678,25 @@ argv_from_env(const char **argv, const char *name)
 	return !env || argv_from_string(argv, &argc, env);
 }
 
+static void
+argv_free(const char *argv[])
+{
+	int argc;
+
+	for (argc = 0; argv[argc]; argc++)
+		free((void *) argv[argc]);
+	argv[0] = NULL;
+}
+
+static void
+argv_copy(const char *dst[], const char *src[])
+{
+	int argc;
+
+	for (argc = 0; src[argc]; argc++)
+		dst[argc] = src[argc];
+}
+
 
 /*
  * Executing external commands.
@@ -719,6 +744,13 @@ io_init(struct io *io, const char *dir, enum io_type type)
 	io->dir = dir;
 }
 
+static void
+io_prepare(struct io *io, const char *dir, enum io_type type, const char *argv[])
+{
+	io_init(io, dir, type);
+	argv_copy(io->argv, argv);
+}
+
 static bool
 io_format(struct io *io, const char *dir, enum io_type type,
 	  const char *argv[], enum format_flags flags)
@@ -844,56 +876,42 @@ io_start(struct io *io)
 static bool
 io_run(struct io *io, const char **argv, const char *dir, enum io_type type)
 {
-	io_init(io, dir, type);
-	if (!format_argv(io->argv, argv, FORMAT_NONE))
-		return FALSE;
+	io_prepare(io, dir, type, argv);
 	return io_start(io);
 }
 
-static int
-io_complete(struct io *io)
+static bool
+io_complete(enum io_type type, const char **argv, const char *dir, int fd)
 {
-	return io_start(io) && io_done(io);
+	struct io io = {};
+
+	io_prepare(&io, dir, type, argv);
+	io.pipe = fd;
+	return io_start(&io) && io_done(&io);
 }
 
-static int
+static bool
 io_run_bg(const char **argv)
 {
-	struct io io = {};
-
-	if (!io_format(&io, NULL, IO_BG, argv, FORMAT_NONE))
-		return FALSE;
-	return io_complete(&io);
+	return io_complete(IO_BG, argv, NULL, -1);
 }
 
 static bool
 io_run_fg(const char **argv, const char *dir)
 {
-	struct io io = {};
-
-	if (!io_format(&io, dir, IO_FG, argv, FORMAT_NONE))
-		return FALSE;
-	return io_complete(&io);
+	return io_complete(IO_FG, argv, dir, -1);
 }
 
 static bool
-io_run_append(const char **argv, enum format_flags flags, int fd)
+io_run_append(const char **argv, int fd)
 {
-	struct io io = {};
-
-	if (!io_format(&io, NULL, IO_AP, argv, flags)) {
-		close(fd);
-		return FALSE;
-	}
-
-	io.pipe = fd;
-	return io_complete(&io);
+	return io_complete(IO_AP, argv, NULL, -1);
 }
 
 static bool
-io_run_rd(struct io *io, const char **argv, const char *dir, enum format_flags flags)
+io_run_rd(struct io *io, const char **argv, const char *dir)
 {
-	return io_format(io, dir, IO_RD, argv, flags) && io_start(io);
+	return io_format(io, dir, IO_RD, argv, FORMAT_NONE) && io_start(io);
 }
 
 static bool
@@ -1030,8 +1048,8 @@ io_run_buf(const char **argv, char buf[], size_t bufsize)
 {
 	struct io io = {};
 
-	return io_run_rd(&io, argv, NULL, FORMAT_NONE)
-	    && io_read_buf(&io, buf, bufsize);
+	io_prepare(&io, NULL, IO_RD, argv);
+	return io_start(&io) && io_read_buf(&io, buf, bufsize);
 }
 
 static int
@@ -1078,8 +1096,8 @@ io_run_load(const char **argv, const char *separators,
 {
 	struct io io = {};
 
-	return io_format(&io, NULL, IO_RD, argv, FORMAT_NONE)
-		? io_load(&io, separators, read_property) : ERR;
+	io_prepare(&io, NULL, IO_RD, argv);
+	return io_load(&io, separators, read_property);
 }
 
 
@@ -1167,7 +1185,8 @@ enum request {
 #define REQ_(req, help) REQ_##req
 
 	/* Offset all requests to avoid conflicts with ncurses getch values. */
-	REQ_OFFSET = KEY_MAX + 1,
+	REQ_UNKNOWN = KEY_MAX + 1,
+	REQ_OFFSET,
 	REQ_INFO
 
 #undef	REQ_GROUP
@@ -1199,7 +1218,7 @@ get_request(const char *name)
 		if (enum_equals(req_info[i], name, namelen))
 			return req_info[i].request;
 
-	return REQ_NONE;
+	return REQ_UNKNOWN;
 }
 
 
@@ -1272,6 +1291,8 @@ LINE(AUTHOR,	   "author ",		COLOR_GREEN,	COLOR_DEFAULT,	0), \
 LINE(COMMITTER,	   "committer ",	COLOR_MAGENTA,	COLOR_DEFAULT,	0), \
 LINE(SIGNOFF,	   "    Signed-off-by", COLOR_YELLOW,	COLOR_DEFAULT,	0), \
 LINE(ACKED,	   "    Acked-by",	COLOR_YELLOW,	COLOR_DEFAULT,	0), \
+LINE(TESTED,	   "    Tested-by",	COLOR_YELLOW,	COLOR_DEFAULT,	0), \
+LINE(REVIEWED,	   "    Reviewed-by",	COLOR_YELLOW,	COLOR_DEFAULT,	0), \
 LINE(DEFAULT,	   "",			COLOR_DEFAULT,	COLOR_DEFAULT,	A_NORMAL), \
 LINE(CURSOR,	   "",			COLOR_WHITE,	COLOR_GREEN,	A_BOLD), \
 LINE(STATUS,	   "",			COLOR_GREEN,	COLOR_DEFAULT,	0), \
@@ -1405,7 +1426,7 @@ struct keybinding {
 	enum request request;
 };
 
-static const struct keybinding default_keybindings[] = {
+static struct keybinding default_keybindings[] = {
 	/* View switching */
 	{ 'm',		REQ_VIEW_MAIN },
 	{ 'd',		REQ_VIEW_DIFF },
@@ -1515,12 +1536,28 @@ static void
 add_keybinding(enum keymap keymap, enum request request, int key)
 {
 	struct keybinding_table *table = &keybindings[keymap];
+	size_t i;
+
+	for (i = 0; i < keybindings[keymap].size; i++) {
+		if (keybindings[keymap].data[i].alias == key) {
+			keybindings[keymap].data[i].request = request;
+			return;
+		}
+	}
 
 	table->data = realloc(table->data, (table->size + 1) * sizeof(*table->data));
 	if (!table->data)
 		die("Failed to allocate keybinding");
 	table->data[table->size].alias = key;
 	table->data[table->size++].request = request;
+
+	if (request == REQ_NONE && keymap == KEYMAP_GENERIC) {
+		int i;
+
+		for (i = 0; i < ARRAY_SIZE(default_keybindings); i++)
+			if (default_keybindings[i].alias == key)
+				default_keybindings[i].request = REQ_NONE;
+	}
 }
 
 /* Looks for a key binding first in the given map, then in the generic map, and
@@ -1747,8 +1784,10 @@ add_builtin_run_requests(void)
 	int i;
 
 	for (i = 0; i < ARRAY_SIZE(reqs); i++) {
-		enum request req;
+		enum request req = get_keybinding(reqs[i].keymap, reqs[i].key);
 
+		if (req != reqs[i].key)
+			continue;
 		req = add_run_request(reqs[i].keymap, reqs[i].key, reqs[i].argc, reqs[i].argv);
 		if (req != REQ_NONE)
 			add_keybinding(reqs[i].keymap, req, reqs[i].key);
@@ -1994,7 +2033,7 @@ option_bind_command(int argc, const char *argv[])
 		return ERR;
 	}
 
-	if (set_keymap(&keymap, argv[0]) == ERR) {
+	if (!set_keymap(&keymap, argv[0])) {
 		config_msg = "Unknown key map";
 		return ERR;
 	}
@@ -2006,7 +2045,7 @@ option_bind_command(int argc, const char *argv[])
 	}
 
 	request = get_request(argv[2]);
-	if (request == REQ_NONE) {
+	if (request == REQ_UNKNOWN) {
 		static const struct enum_map obsolete[] = {
 			ENUM_MAP("cherry-pick",		REQ_NONE),
 			ENUM_MAP("screen-resize",	REQ_NONE),
@@ -2021,9 +2060,9 @@ option_bind_command(int argc, const char *argv[])
 			return ERR;
 		}
 	}
-	if (request == REQ_NONE && *argv[2]++ == '!')
+	if (request == REQ_UNKNOWN && *argv[2]++ == '!')
 		request = add_run_request(keymap, key, argc - 2, argv + 2);
-	if (request == REQ_NONE) {
+	if (request == REQ_UNKNOWN) {
 		config_msg = "Unknown request name";
 		return ERR;
 	}
@@ -2122,8 +2161,6 @@ load_options(void)
 	const char *tigrc_system = getenv("TIGRC_SYSTEM");
 	char buf[SIZEOF_STR];
 
-	add_builtin_run_requests();
-
 	if (!tigrc_system)
 		tigrc_system = SYSCONFDIR "/tigrc";
 	load_option_file(tigrc_system);
@@ -2135,6 +2172,10 @@ load_options(void)
 	}
 	load_option_file(tigrc_user);
 
+	/* Add _after_ loading config files to avoid adding run requests
+	 * that conflict with keybindings. */
+	add_builtin_run_requests();
+
 	return OK;
 }
 
@@ -2161,7 +2202,22 @@ static char ref_commit[SIZEOF_REF]	= "HEAD";
 static char ref_head[SIZEOF_REF]	= "HEAD";
 static char ref_branch[SIZEOF_REF]	= "";
 
+enum view_type {
+	VIEW_MAIN,
+	VIEW_DIFF,
+	VIEW_LOG,
+	VIEW_TREE,
+	VIEW_BLOB,
+	VIEW_BLAME,
+	VIEW_BRANCH,
+	VIEW_HELP,
+	VIEW_PAGER,
+	VIEW_STATUS,
+	VIEW_STAGE,
+};
+
 struct view {
+	enum view_type type;	/* View type */
 	const char *name;	/* View name */
 	const char *cmd_env;	/* Command line set via environment */
 	const char *id;		/* Points to either of ref_{head,commit,blob} */
@@ -2194,6 +2250,7 @@ struct view {
 	/* If non-NULL, points to the view that opened this view. If this view
 	 * is closed tig will switch back to the parent view. */
 	struct view *parent;
+	struct view *prev;
 
 	/* Buffering */
 	size_t lines;		/* Total number of lines */
@@ -2246,12 +2303,11 @@ static struct view_ops status_ops;
 static struct view_ops tree_ops;
 static struct view_ops branch_ops;
 
-#define VIEW_STR(name, env, ref, ops, map, git) \
-	{ name, #env, ref, ops, map, git }
+#define VIEW_STR(type, name, env, ref, ops, map, git) \
+	{ type, name, #env, ref, ops, map, git }
 
 #define VIEW_(id, name, ops, git, ref) \
-	VIEW_STR(name, TIG_##id##_CMD, ref, ops, KEYMAP_##id, git)
-
+	VIEW_STR(VIEW_##id, name, TIG_##id##_CMD, ref, ops, KEYMAP_##id, git)
 
 static struct view views[] = {
 	VIEW_(MAIN,   "main",   &main_ops,   TRUE,  ref_head),
@@ -2268,7 +2324,6 @@ static struct view views[] = {
 };
 
 #define VIEW(req) 	(&views[(req) - REQ_OFFSET - 1])
-#define VIEW_REQ(view)	((view) - views + REQ_OFFSET + 1)
 
 #define foreach_view(view, i) \
 	for (i = 0; i < ARRAY_SIZE(views) && (view = &views[i]); i++)
@@ -2276,6 +2331,18 @@ static struct view views[] = {
 #define view_is_displayed(view) \
 	(view == display[0] || view == display[1])
 
+static enum request
+view_request(struct view *view, enum request request)
+{
+	if (!view || !view->lines)
+		return request;
+	return view->ops->request(view, request, &view->line[view->lineno]);
+}
+
+
+/*
+ * View drawing.
+ */
 
 static inline void
 set_view_attr(struct view *view, enum line_type type)
@@ -2544,7 +2611,7 @@ update_view_title(struct view *view)
 
 	assert(view_is_displayed(view));
 
-	if (view != VIEW(REQ_VIEW_STATUS) && view->lines) {
+	if (view->type != VIEW_STATUS && view->lines) {
 		unsigned int view_lines = view->offset + view->height;
 		unsigned int lines = view->lines
 				   ? MIN(view_lines, view->lines) * 100 / view->lines
@@ -2666,6 +2733,11 @@ redraw_display(bool clear)
 	}
 }
 
+
+/*
+ * Option management
+ */
+
 static void
 toggle_enum_option_do(unsigned int *opt, const char *help,
 		      const struct enum_map *map, size_t size)
@@ -3089,15 +3161,6 @@ reset_view(struct view *view)
 	view->update_secs = 0;
 }
 
-static void
-free_argv(const char *argv[])
-{
-	int argc;
-
-	for (argc = 0; argv[argc]; argc++)
-		free((void *) argv[argc]);
-}
-
 static const char *
 format_arg(const char *name)
 {
@@ -3134,7 +3197,7 @@ format_argv(const char *dst_argv[], const char *src_argv[], enum format_flags fl
 	int argc;
 	bool noreplace = flags == FORMAT_NONE;
 
-	free_argv(dst_argv);
+	argv_free(dst_argv);
 
 	for (argc = 0; src_argv[argc]; argc++) {
 		const char *arg = src_argv[argc];
@@ -3146,8 +3209,6 @@ format_argv(const char *dst_argv[], const char *src_argv[], enum format_flags fl
 			const char *value;
 
 			if (!next || noreplace) {
-				if (flags == FORMAT_DASH && !strcmp(arg, "--"))
-					noreplace = TRUE;
 				len = strlen(arg);
 				value = "";
 
@@ -3325,7 +3386,7 @@ update_view(struct view *view)
 		/* Keep the displayed view in sync with line number scaling. */
 		if (digits != view->digits) {
 			view->digits = digits;
-			if (opt_line_number || view == VIEW(REQ_VIEW_BLAME))
+			if (opt_line_number || view->type == VIEW_BLAME)
 				redraw = TRUE;
 		}
 	}
@@ -3335,7 +3396,8 @@ update_view(struct view *view)
 		end_update(view, TRUE);
 
 	} else if (io_eof(view->pipe)) {
-		report("");
+		if (view_is_displayed(view))
+			report("");
 		end_update(view, FALSE);
 	}
 
@@ -3432,6 +3494,7 @@ open_view(struct view *prev, enum request request, enum open_flags flags)
 	if (split) {
 		display[1] = view;
 		current_view = 1;
+		view->parent = prev;
 	} else if (!nomaximize) {
 		/* Maximize the current view. */
 		memset(display, 0, sizeof(display));
@@ -3439,9 +3502,9 @@ open_view(struct view *prev, enum request request, enum open_flags flags)
 		display[current_view] = view;
 	}
 
-	/* No parent signals that this is the first loaded view. */
+	/* No prev signals that this is the first loaded view. */
 	if (prev && view != prev) {
-		view->parent = prev;
+		view->prev = prev;
 	}
 
 	/* Resize the view when switching between split- and full-screen,
@@ -3544,7 +3607,7 @@ open_run_request(enum request request)
 
 	if (format_argv(argv, req->argv, FORMAT_ALL))
 		open_external_viewer(argv, NULL);
-	free_argv(argv);
+	argv_free(argv);
 }
 
 /*
@@ -3561,22 +3624,13 @@ view_driver(struct view *view, enum request request)
 
 	if (request > REQ_NONE) {
 		open_run_request(request);
-		/* FIXME: When all views can refresh always do this. */
-		if (view == VIEW(REQ_VIEW_STATUS) ||
-		    view == VIEW(REQ_VIEW_MAIN) ||
-		    view == VIEW(REQ_VIEW_LOG) ||
-		    view == VIEW(REQ_VIEW_BRANCH) ||
-		    view == VIEW(REQ_VIEW_STAGE))
-			request = REQ_REFRESH;
-		else
-			return TRUE;
+		view_request(view, REQ_REFRESH);
+		return TRUE;
 	}
 
-	if (view && view->lines) {
-		request = view->ops->request(view, request, &view->line[view->lineno]);
-		if (request == REQ_NONE)
-			return TRUE;
-	}
+	request = view_request(view, request);
+	if (request == REQ_NONE)
+		return TRUE;
 
 	switch (request) {
 	case REQ_MOVE_UP:
@@ -3654,16 +3708,7 @@ view_driver(struct view *view, enum request request)
 	case REQ_PREVIOUS:
 		request = request == REQ_NEXT ? REQ_MOVE_DOWN : REQ_MOVE_UP;
 
-		if ((view == VIEW(REQ_VIEW_DIFF) &&
-		     view->parent == VIEW(REQ_VIEW_MAIN)) ||
-		   (view == VIEW(REQ_VIEW_DIFF) &&
-		     view->parent == VIEW(REQ_VIEW_BLAME)) ||
-		   (view == VIEW(REQ_VIEW_STAGE) &&
-		     view->parent == VIEW(REQ_VIEW_STATUS)) ||
-		   (view == VIEW(REQ_VIEW_BLOB) &&
-		     view->parent == VIEW(REQ_VIEW_TREE)) ||
-		   (view == VIEW(REQ_VIEW_MAIN) &&
-		     view->parent == VIEW(REQ_VIEW_BRANCH))) {
+		if (view->parent) {
 			int line;
 
 			view = view->parent;
@@ -3672,9 +3717,7 @@ view_driver(struct view *view, enum request request)
 			if (view_is_displayed(view))
 				update_view_title(view);
 			if (line != view->lineno)
-				view->ops->request(view, REQ_ENTER,
-						   &view->line[view->lineno]);
-
+				view_request(view, REQ_ENTER);
 		} else {
 			move_view(view, request);
 		}
@@ -3745,8 +3788,7 @@ view_driver(struct view *view, enum request request)
 		break;
 
 	case REQ_STOP_LOADING:
-		for (i = 0; i < ARRAY_SIZE(views); i++) {
-			view = &views[i];
+		foreach_view(view, i) {
 			if (view->pipe)
 				report("Stopped loading the %s view", view->name),
 			end_update(view, TRUE);
@@ -3770,13 +3812,12 @@ view_driver(struct view *view, enum request request)
 		break;
 
 	case REQ_VIEW_CLOSE:
-		/* XXX: Mark closed views by letting view->parent point to the
+		/* XXX: Mark closed views by letting view->prev point to the
 		 * view itself. Parents to closed view should never be
 		 * followed. */
-		if (view->parent &&
-		    view->parent->parent != view->parent) {
-			maximize_view(view->parent);
-			view->parent = view;
+		if (view->prev && view->prev != view) {
+			maximize_view(view->prev);
+			view->prev = view;
 			break;
 		}
 		/* Fall-through */
@@ -3884,8 +3925,8 @@ parse_timezone(struct time *time, const char *zone)
 
 	tz  = ('0' - zone[1]) * 60 * 60 * 10;
 	tz += ('0' - zone[2]) * 60 * 60;
-	tz += ('0' - zone[3]) * 60;
-	tz += ('0' - zone[4]);
+	tz += ('0' - zone[3]) * 60 * 10;
+	tz += ('0' - zone[4]) * 60;
 
 	if (zone[0] == '-')
 		tz = -tz;
@@ -3985,7 +4026,9 @@ select_commit_parent(const char *id, char rev[SIZEOF_REV], const char *path)
 		return FALSE;
 	}
 
-	if (parents > 1 && !open_commit_parent_menu(buf, &parents))
+	if (parents == 1)
+		parents = 0;
+	else if (!open_commit_parent_menu(buf, &parents))
 		return FALSE;
 
 	string_copy_rev(rev, &buf[41 * parents]);
@@ -4039,7 +4082,7 @@ add_pager_refs(struct view *view, struct line *line)
 
 	list = get_ref_list(commit_id);
 	if (!list) {
-		if (view == VIEW(REQ_VIEW_DIFF))
+		if (view->type == VIEW_DIFF)
 			goto try_add_describe_ref;
 		return;
 	}
@@ -4056,7 +4099,7 @@ add_pager_refs(struct view *view, struct line *line)
 			is_tag = TRUE;
 	}
 
-	if (!is_tag && view == VIEW(REQ_VIEW_DIFF)) {
+	if (!is_tag && view->type == VIEW_DIFF) {
 try_add_describe_ref:
 		/* Add <tag>-g<commit_id> "fake" reference. */
 		if (!add_describe_ref(buf, &bufpos, commit_id, sep))
@@ -4082,8 +4125,8 @@ pager_read(struct view *view, char *data)
 		return FALSE;
 
 	if (line->type == LINE_COMMIT &&
-	    (view == VIEW(REQ_VIEW_DIFF) ||
-	     view == VIEW(REQ_VIEW_LOG)))
+	    (view->type == VIEW_DIFF ||
+	     view->type == VIEW_LOG))
 		add_pager_refs(view, line);
 
 	return TRUE;
@@ -4098,8 +4141,8 @@ pager_request(struct view *view, enum request request, struct line *line)
 		return request;
 
 	if (line->type == LINE_COMMIT &&
-	   (view == VIEW(REQ_VIEW_LOG) ||
-	    view == VIEW(REQ_VIEW_PAGER))) {
+	   (view->type == VIEW_LOG ||
+	    view->type == VIEW_PAGER)) {
 		open_view(view, REQ_VIEW_DIFF, OPEN_SPLIT);
 		split = 1;
 	}
@@ -4132,7 +4175,7 @@ pager_select(struct view *view, struct line *line)
 	if (line->type == LINE_COMMIT) {
 		char *text = (char *)line->data + STRING_SIZE("commit ");
 
-		if (view != VIEW(REQ_VIEW_PAGER))
+		if (view->type != VIEW_PAGER)
 			string_copy_rev(view->ref, text);
 		string_copy_rev(ref_commit, text);
 	}
@@ -4487,7 +4530,7 @@ tree_read_date(struct view *view, char *text, bool *read_date)
 			return TRUE;
 		}
 
-		if (!io_run_rd(&io, log_file, opt_cdup, FORMAT_NONE)) {
+		if (!io_run_rd(&io, log_file, opt_cdup)) {
 			report("Failed to load tree data");
 			return TRUE;
 		}
@@ -4622,14 +4665,15 @@ tree_draw(struct view *view, struct line *line, unsigned int lineno)
 }
 
 static void
-open_blob_editor()
+open_blob_editor(const char *id)
 {
+	const char *blob_argv[] = { "git", "cat-file", "blob", id, NULL };
 	char file[SIZEOF_STR] = "/tmp/tigblob.XXXXXX";
 	int fd = mkstemp(file);
 
 	if (fd == -1)
 		report("Failed to create temporary file");
-	else if (!io_run_append(blob_ops.argv, FORMAT_ALL, fd))
+	else if (!io_run_append(blob_argv, fd))
 		report("Failed to save blob data to file");
 	else
 		open_editor(file);
@@ -4641,6 +4685,7 @@ static enum request
 tree_request(struct view *view, enum request request, struct line *line)
 {
 	enum open_flags flags;
+	struct tree_entry *entry = line->data;
 
 	switch (request) {
 	case REQ_VIEW_BLAME:
@@ -4656,7 +4701,7 @@ tree_request(struct view *view, enum request request, struct line *line)
 		if (line->type != LINE_TREE_FILE) {
 			report("Edit only supported for files");
 		} else if (!is_head_commit(view->vid)) {
-			open_blob_editor();
+			open_blob_editor(entry->id);
 		} else {
 			open_editor(opt_file);
 		}
@@ -4707,7 +4752,7 @@ tree_request(struct view *view, enum request request, struct line *line)
 		break;
 
 	case LINE_TREE_FILE:
-		flags = display[0] == view ? OPEN_SPLIT : OPEN_DEFAULT;
+		flags = view_is_displayed(view) ? OPEN_SPLIT : OPEN_DEFAULT;
 		request = REQ_VIEW_BLOB;
 		break;
 
@@ -4807,7 +4852,7 @@ blob_request(struct view *view, enum request request, struct line *line)
 {
 	switch (request) {
 	case REQ_EDIT:
-		open_blob_editor();
+		open_blob_editor(view->vid);
 		return REQ_NONE;
 	default:
 		return pager_request(view, request, line);
@@ -4840,18 +4885,6 @@ static struct view_ops blob_ops = {
  *     reading output from git-blame.
  */
 
-static const char *blame_head_argv[] = {
-	"git", "blame", "--incremental", "--", "%(file)", NULL
-};
-
-static const char *blame_ref_argv[] = {
-	"git", "blame", "--incremental", "%(ref)", "--", "%(file)", NULL
-};
-
-static const char *blame_cat_file_argv[] = {
-	"git", "cat-file", "blob", "%(ref):%(file)", NULL
-};
-
 struct blame_commit {
 	char id[SIZEOF_REV];		/* SHA1 ID. */
 	char title[128];		/* First line of the commit message. */
@@ -4872,14 +4905,19 @@ blame_open(struct view *view)
 {
 	char path[SIZEOF_STR];
 
-	if (!view->parent && *opt_prefix) {
+	if (!view->prev && *opt_prefix) {
 		string_copy(path, opt_file);
 		if (!string_format(opt_file, "%s%s", opt_prefix, path))
 			return FALSE;
 	}
 
 	if (*opt_ref || !io_open(&view->io, "%s%s", opt_cdup, opt_file)) {
-		if (!io_run_rd(&view->io, blame_cat_file_argv, opt_cdup, FORMAT_ALL))
+		const char *blame_cat_file_argv[] = {
+			"git", "cat-file", "blob", path, NULL
+		};
+
+		if (!string_format(path, "%s:%s", opt_ref, opt_file) ||
+		    !io_run_rd(&view->io, blame_cat_file_argv, opt_cdup))
 			return FALSE;
 	}
 
@@ -4969,13 +5007,16 @@ static bool
 blame_read_file(struct view *view, const char *line, bool *read_file)
 {
 	if (!line) {
-		const char **argv = *opt_ref ? blame_ref_argv : blame_head_argv;
+		const char *blame_argv[] = {
+			"git", "blame", "--incremental",
+				*opt_ref ? opt_ref : "--incremental", "--", opt_file, NULL
+		};
 		struct io io = {};
 
-		if (view->lines == 0 && !view->parent)
+		if (view->lines == 0 && !view->prev)
 			die("No blame exist for %s", view->vid);
 
-		if (view->lines == 0 || !io_run_rd(&io, argv, opt_cdup, FORMAT_ALL)) {
+		if (view->lines == 0 || !io_run_rd(&io, blame_argv, opt_cdup)) {
 			report("Failed to load blame data");
 			return TRUE;
 		}
@@ -5144,7 +5185,7 @@ setup_blame_parent_line(struct view *view, struct blame *blame)
 static enum request
 blame_request(struct view *view, enum request request, struct line *line)
 {
-	enum open_flags flags = display[0] == view ? OPEN_SPLIT : OPEN_DEFAULT;
+	enum open_flags flags = view_is_displayed(view) ? OPEN_SPLIT : OPEN_DEFAULT;
 	struct blame *blame = line->data;
 
 	switch (request) {
@@ -5409,7 +5450,7 @@ branch_open(struct view *view)
 			"--simplify-by-decoration", "--all", NULL
 	};
 
-	if (!io_run_rd(&view->io, branch_log, NULL, FORMAT_NONE)) {
+	if (!io_run_rd(&view->io, branch_log, NULL)) {
 		report("Failed to load branch data");
 		return TRUE;
 	}
@@ -5870,7 +5911,7 @@ status_enter(struct view *view, struct line *line)
 		die("line type %d not handled in switch", line->type);
 	}
 
-	split = view_is_displayed(view) ? OPEN_SPLIT : 0;
+	split = view_is_displayed(view) ? OPEN_SPLIT : OPEN_DEFAULT;
 	open_view(view, REQ_VIEW_STAGE, OPEN_PREPARED | split);
 	if (view_is_displayed(VIEW(REQ_VIEW_STAGE))) {
 		if (status) {
@@ -6750,7 +6791,7 @@ main_read(struct view *view, char *line)
 	if (!line) {
 		int i;
 
-		if (!view->lines && !view->parent)
+		if (!view->lines && !view->prev)
 			die("No revisions match the given arguments.");
 		if (view->lines > 0) {
 			commit = view->line[view->lines - 1].data;
@@ -6840,7 +6881,7 @@ main_read(struct view *view, char *line)
 static enum request
 main_request(struct view *view, enum request request, struct line *line)
 {
-	enum open_flags flags = display[0] == view ? OPEN_SPLIT : OPEN_DEFAULT;
+	enum open_flags flags = view_is_displayed(view) ? OPEN_SPLIT : OPEN_DEFAULT;
 
 	switch (request) {
 	case REQ_ENTER:
@@ -7806,6 +7847,10 @@ main(int argc, const char *argv[])
 		/* Some low-level request handling. This keeps access to
 		 * status_win restricted. */
 		switch (request) {
+		case REQ_NONE:
+			report("Unknown key, press %s for help",
+			       get_key(view->keymap, REQ_VIEW_HELP));
+			break;
 		case REQ_PROMPT:
 		{
 			char *cmd = read_prompt(":");