X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=t%2Funit%2Fcore%2Fstore_test.c;h=d132508537a76789ca3e9effe2240473ff8f5e88;hb=ebfd78eb79806777c3de889d75a62665ff78eaca;hp=fb2c24bf20d596450c36f67e5b7791a96c2b5122;hpb=dfa8850d084337223b41c03385317bf7359c8643;p=sysdb.git diff --git a/t/unit/core/store_test.c b/t/unit/core/store_test.c index fb2c24b..d132508 100644 --- a/t/unit/core/store_test.c +++ b/t/unit/core/store_test.c @@ -53,10 +53,17 @@ populate(void) sdb_store_attribute("h1", "k2", &datum, 1); sdb_store_attribute("h1", "k3", &datum, 2); + sdb_store_metric("h1", "m1", /* store */ NULL, 2); + sdb_store_metric("h1", "m2", /* store */ NULL, 1); + sdb_store_metric("h2", "m1", /* store */ NULL, 1); + sdb_store_service("h2", "s1", 1); sdb_store_service("h2", "s2", 2); datum.type = SDB_TYPE_INTEGER; + datum.data.integer = 42; + sdb_store_metric_attr("h1", "m1", "k3", &datum, 2); + datum.data.integer = 123; sdb_store_service_attr("h2", "s2", "k1", &datum, 2); datum.data.integer = 4711; @@ -220,6 +227,103 @@ START_TEST(test_store_attr) } END_TEST +START_TEST(test_store_metric) +{ + sdb_metric_store_t store1 = { "dummy-type1", "dummy-id1" }; + sdb_metric_store_t store2 = { "dummy-type2", "dummy-id2" }; + + struct { + const char *host; + const char *metric; + sdb_metric_store_t *store; + sdb_time_t last_update; + int expected; + } golden_data[] = { + { "k", "m", NULL, 1, -1 }, + { "k", "m", NULL, 1, -1 }, /* retry to ensure the host is not created */ + { "k", "m", &store1, 1, -1 }, + { "l", "m1", NULL, 1, 0 }, + { "l", "m1", &store1, 2, 0 }, + { "l", "m1", &store1, 3, 0 }, + { "l", "m1", NULL, 3, 1 }, + { "l", "m2", &store1, 1, 0 }, + { "l", "m2", &store2, 2, 0 }, + { "l", "m2", NULL, 3, 0 }, + { "m", "m", &store1, 1, 0 }, + { "m", "m", NULL, 2, 0 }, + { "m", "m", NULL, 2, 1 }, + { "m", "m", &store1, 3, 0 }, + { "m", "m", &store2, 4, 0 }, + { "m", "m", NULL, 5, 0 }, + }; + + size_t i; + + sdb_store_host("m", 1); + sdb_store_host("l", 1); + for (i = 0; i < SDB_STATIC_ARRAY_LEN(golden_data); ++i) { + int status; + + status = sdb_store_metric(golden_data[i].host, + golden_data[i].metric, golden_data[i].store, + golden_data[i].last_update); + fail_unless(status == golden_data[i].expected, + "sdb_store_metric(%s, %s, %p, %d) = %d; expected: %d", + golden_data[i].host, golden_data[i].metric, + golden_data[i].store, golden_data[i].last_update, + status, golden_data[i].expected); + } +} +END_TEST + +START_TEST(test_store_metric_attr) +{ + struct { + const char *host; + const char *metric; + const char *attr; + const sdb_data_t value; + sdb_time_t last_update; + int expected; + } golden_data[] = { + { "k", "m1", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, -1 }, + /* retry, it should still fail */ + { "k", "m1", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, -1 }, + { "l", "mX", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, -1 }, + /* retry, it should still fail */ + { "l", "mX", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, -1 }, + { "l", "m1", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, 0 }, + { "l", "m1", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, 1 }, + { "l", "m1", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 2, 0 }, + { "l", "m1", "a2", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, 0 }, + { "l", "m1", "a2", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, 1 }, + { "l", "m2", "a2", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, 0 }, + { "m", "m1", "a1", { SDB_TYPE_INTEGER, { .integer = 123 } }, 1, 0 }, + }; + + size_t i; + + sdb_store_host("m", 1); + sdb_store_host("l", 1); + sdb_store_metric("m", "m1", NULL, 1); + sdb_store_metric("l", "m1", NULL, 1); + sdb_store_metric("l", "m2", NULL, 1); + + for (i = 0; i < SDB_STATIC_ARRAY_LEN(golden_data); ++i) { + int status; + + status = sdb_store_metric_attr(golden_data[i].host, + golden_data[i].metric, golden_data[i].attr, + &golden_data[i].value, golden_data[i].last_update); + fail_unless(status == golden_data[i].expected, + "sdb_store_metric_attr(%s, %s, %s, %d, %d) = %d; " + "expected: %d", golden_data[i].host, golden_data[i].metric, + golden_data[i].attr, golden_data[i].value.data.integer, + golden_data[i].last_update, status, golden_data[i].expected); + } +} +END_TEST + START_TEST(test_store_service) { struct { @@ -304,7 +408,8 @@ START_TEST(test_store_service_attr) END_TEST static void -verify_json_output(sdb_strbuf_t *buf, const char *expected, int flags) +verify_json_output(sdb_strbuf_t *buf, const char *expected, + sdb_store_matcher_t *filter, int flags) { int pos; size_t len1, len2; @@ -325,9 +430,10 @@ verify_json_output(sdb_strbuf_t *buf, const char *expected, int flags) } fail_unless(pos == -1, - "sdb_store_tojson(%x) returned unexpected result\n" + "sdb_store_tojson(, %p, %x) returned unexpected result\n" " got: %s\n %*s\n expected: %s", - flags, sdb_strbuf_string(buf), pos + 1, "^", expected); + filter, flags, sdb_strbuf_string(buf), pos + 1, "^", + expected); } /* verify_json_output */ START_TEST(test_store_tojson) @@ -337,7 +443,8 @@ START_TEST(test_store_tojson) struct { struct { - sdb_store_matcher_t *(*m)(sdb_store_cond_t *); + sdb_store_matcher_t *(*m)(sdb_store_expr_t *, + sdb_store_expr_t *); int field; sdb_data_t value; } filter; @@ -345,7 +452,7 @@ START_TEST(test_store_tojson) const char *expected; } golden_data[] = { { { NULL, 0, SDB_DATA_INIT }, 0, - "{\"hosts\":[" + "[" "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [" @@ -359,12 +466,30 @@ START_TEST(test_store_tojson) "\"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": []}" "], " - "\"metrics\": [], " + "\"metrics\": [" + "{\"name\": \"m1\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": [" + "{\"name\": \"k3\", \"value\": 42, " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": []}" + "]}," + "{\"name\": \"m2\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": []}" + "], " "\"services\": []}," "{\"name\": \"h2\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [], " - "\"metrics\": [], " + "\"metrics\": [" + "{\"name\": \"m1\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": []}" + "], " "\"services\": [" "{\"name\": \"s1\", " "\"last_update\": \"1970-01-01 00:00:00 +0000\", " @@ -382,9 +507,9 @@ START_TEST(test_store_tojson) "\"update_interval\": \"0s\", \"backends\": []}" "]}" "]}" - "]}" }, + "]" }, { { NULL, 0, SDB_DATA_INIT }, SDB_SKIP_SERVICES, - "{\"hosts\":[" + "[" "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [" @@ -398,14 +523,32 @@ START_TEST(test_store_tojson) "\"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": []}" "], " - "\"metrics\": []}," + "\"metrics\": [" + "{\"name\": \"m1\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": [" + "{\"name\": \"k3\", \"value\": 42, " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": []}" + "]}," + "{\"name\": \"m2\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": []}" + "]}," "{\"name\": \"h2\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [], " - "\"metrics\": []}" - "]}" }, + "\"metrics\": [" + "{\"name\": \"m1\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": []}" + "]}" + "]" }, { { NULL, 0, SDB_DATA_INIT }, SDB_SKIP_METRICS, - "{\"hosts\":[" + "[" "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [" @@ -440,16 +583,27 @@ START_TEST(test_store_tojson) "\"update_interval\": \"0s\", \"backends\": []}" "]}" "]}" - "]}" }, + "]" }, { { NULL, 0, SDB_DATA_INIT }, SDB_SKIP_ATTRIBUTES, - "{\"hosts\":[" + "[" "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " - "\"metrics\": [], " + "\"metrics\": [" + "{\"name\": \"m1\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": []}," + "{\"name\": \"m2\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": []}" + "], " "\"services\": []}," "{\"name\": \"h2\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " - "\"metrics\": [], " + "\"metrics\": [" + "{\"name\": \"m1\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": []}" + "], " "\"services\": [" "{\"name\": \"s1\", " "\"last_update\": \"1970-01-01 00:00:00 +0000\", " @@ -458,17 +612,24 @@ START_TEST(test_store_tojson) "\"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": []}" "]}" - "]}" }, + "]" }, { { NULL, 0, SDB_DATA_INIT }, SDB_SKIP_ALL, - "{\"hosts\":[" + "[" "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": []}," "{\"name\": \"h2\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": []}" - "]}" }, + "]" }, + { { sdb_store_eq_matcher, SDB_FIELD_NAME, + { SDB_TYPE_STRING, { .string = "h1" } } }, 0, + "[" + "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": [], \"metrics\": [], \"services\": []}" + "]" }, { { sdb_store_gt_matcher, SDB_FIELD_LAST_UPDATE, { SDB_TYPE_DATETIME, { .datetime = 1 } } }, 0, - "{\"hosts\":[" + "[" "{\"name\": \"h2\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [], " @@ -483,10 +644,10 @@ START_TEST(test_store_tojson) "\"update_interval\": \"0s\", \"backends\": []}," "]}" "]}" - "]}" }, + "]" }, { { sdb_store_le_matcher, SDB_FIELD_LAST_UPDATE, { SDB_TYPE_DATETIME, { .datetime = 1 } } }, 0, - "{\"hosts\":[" + "[" "{\"name\": \"h1\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [" @@ -494,18 +655,23 @@ START_TEST(test_store_tojson) "\"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": []}," "], " - "\"metrics\": [], " + "\"metrics\": [" + "{\"name\": \"m2\", " + "\"last_update\": \"1970-01-01 00:00:00 +0000\", " + "\"update_interval\": \"0s\", \"backends\": [], " + "\"attributes\": []}" + "], " "\"services\": []}" - "]}" }, + "]" }, { { sdb_store_ge_matcher, SDB_FIELD_LAST_UPDATE, { SDB_TYPE_DATETIME, { .datetime = 3 } } }, 0, - "{\"hosts\":[" + "[" "{\"name\": \"h2\", \"last_update\": \"1970-01-01 00:00:00 +0000\", " "\"update_interval\": \"0s\", \"backends\": [], " "\"attributes\": [], " "\"metrics\": [], " "\"services\": []}" - "]}" }, + "]" }, }; buf = sdb_strbuf_create(0); @@ -514,37 +680,36 @@ START_TEST(test_store_tojson) for (i = 0; i < SDB_STATIC_ARRAY_LEN(golden_data); ++i) { sdb_store_matcher_t *filter = NULL; - char filter_str[1024]; int status; sdb_strbuf_clear(buf); if (golden_data[i].filter.m) { - sdb_store_expr_t *expr; - sdb_store_cond_t *c = NULL; - - expr = sdb_store_expr_constvalue(&golden_data[i].filter.value); - fail_unless(expr != NULL, + sdb_store_expr_t *field; + sdb_store_expr_t *value; + + field = sdb_store_expr_fieldvalue(golden_data[i].filter.field); + fail_unless(field != NULL, + "INTERNAL ERROR: sdb_store_expr_fieldvalue() = NULL"); + value = sdb_store_expr_constvalue(&golden_data[i].filter.value); + fail_unless(value != NULL, "INTERNAL ERROR: sdb_store_expr_constvalue() = NULL"); - c = sdb_store_obj_cond(golden_data[i].filter.field, expr); - sdb_object_deref(SDB_OBJ(expr)); - fail_unless(c != NULL, - "INTERNAL ERROR: sdb_store_obj_cond() = NULL"); - filter = golden_data[i].filter.m(c); - sdb_object_deref(SDB_OBJ(c)); + + filter = golden_data[i].filter.m(field, value); fail_unless(filter != NULL, "INTERNAL ERROR: sdb_store_*_matcher() = NULL"); - } - if (sdb_store_matcher_tostring(filter, filter_str, sizeof(filter_str))) - snprintf(filter_str, sizeof(filter_str), "ERR"); + sdb_object_deref(SDB_OBJ(field)); + sdb_object_deref(SDB_OBJ(value)); + } status = sdb_store_tojson(buf, filter, golden_data[i].flags); fail_unless(status == 0, - "sdb_store_tojson(, %s, %x) = %d; expected: 0", - filter_str, golden_data[i].flags, status); + "sdb_store_tojson(, %p, %x) = %d; expected: 0", + filter, golden_data[i].flags, status); - verify_json_output(buf, golden_data[i].expected, golden_data[i].flags); + verify_json_output(buf, golden_data[i].expected, + filter, golden_data[i].flags); sdb_object_deref(SDB_OBJ(filter)); } sdb_strbuf_destroy(buf); @@ -571,15 +736,33 @@ START_TEST(test_get_field) fail_unless(check < 0, "sdb_store_get_field(NULL, SDB_FIELD_LAST_UPDATE, NULL) = %d; " "expected: <0"); - check = sdb_store_get_field(host, SDB_FIELD_LAST_UPDATE, NULL); - fail_unless(check < 0, - "sdb_store_get_field(, SDB_FIELD_LAST_UPDATE, NULL) = %d; " - "expected: <0"); check = sdb_store_get_field(NULL, SDB_FIELD_LAST_UPDATE, &value); fail_unless(check < 0, "sdb_store_get_field(NULL, SDB_FIELD_LAST_UPDATE, ) = %d; " "expected: <0"); + check = sdb_store_get_field(host, SDB_FIELD_LAST_UPDATE, NULL); + fail_unless(check == 0, + "sdb_store_get_field(, SDB_FIELD_LAST_UPDATE, NULL) = %d; " + "expected: 0"); + /* 'name' is dynamically allocated; make sure it's not leaked even + * if there is no result parameter */ + check = sdb_store_get_field(host, SDB_FIELD_NAME, NULL); + fail_unless(check == 0, + "sdb_store_get_field(, SDB_FIELD_LAST_UPDATE, NULL) = %d; " + "expected: 0"); + + check = sdb_store_get_field(host, SDB_FIELD_NAME, &value); + fail_unless(check == 0, + "sdb_store_get_field(, SDB_FIELD_NAME, ) = " + "%d; expected: 0"); + fail_unless((value.type == SDB_TYPE_STRING) + && (! strcmp(value.data.string, "host")), + "sdb_store_get_field(, SDB_FIELD_NAME, ) " + "returned value {%d, %s}; expected {%d, host}", + value.type, value.data.string, SDB_TYPE_STRING); + sdb_data_free_datum(&value); + check = sdb_store_get_field(host, SDB_FIELD_LAST_UPDATE, &value); fail_unless(check == 0, "sdb_store_get_field(, SDB_FIELD_LAST_UPDATE, ) = " @@ -611,6 +794,19 @@ START_TEST(test_get_field) "sdb_store_get_field(, SDB_FIELD_INTERVAL, ) " "returned value {%d, %lu}; expected {%d, 10}", value.type, value.data.datetime, SDB_TYPE_DATETIME); + + check = sdb_store_get_field(host, SDB_FIELD_BACKEND, &value); + fail_unless(check == 0, + "sdb_store_get_field(, SDB_FIELD_BACKEND, ) = " + "%d; expected: 0"); + /* there are no backends in this test */ + fail_unless((value.type == (SDB_TYPE_ARRAY | SDB_TYPE_STRING)) + && (value.data.array.length == 0) + && (value.data.array.values == NULL), + "sdb_store_get_field(, SDB_FIELD_BACKEND, ) " + "returned value {%d, %lu, %p}; expected {%d, 0, NULL}", + value.type, value.data.array.length, value.data.array.values, + SDB_TYPE_ARRAY | SDB_TYPE_STRING); } END_TEST @@ -671,64 +867,87 @@ START_TEST(test_interval) END_TEST static int -iter_incr(sdb_store_obj_t *obj, void *user_data) +scan_count(sdb_store_obj_t *obj, void *user_data) { intptr_t *i = user_data; fail_unless(obj != NULL, - "sdb_store_iterate callback received NULL obj; expected: " + "sdb_store_scan callback received NULL obj; expected: " ""); fail_unless(i != NULL, - "sdb_store_iterate callback received NULL user_data; " + "sdb_store_scan callback received NULL user_data; " "expected: "); ++(*i); return 0; -} /* iter_incr */ +} /* scan_count */ static int -iter_error(sdb_store_obj_t *obj, void *user_data) +scan_error(sdb_store_obj_t *obj, void *user_data) { intptr_t *i = user_data; fail_unless(obj != NULL, - "sdb_store_iterate callback received NULL obj; expected: " + "sdb_store_scan callback received NULL obj; expected: " ""); fail_unless(i != NULL, - "sdb_store_iterate callback received NULL user_data; " + "sdb_store_scan callback received NULL user_data; " "expected: "); ++(*i); return -1; -} /* iter_error */ +} /* scan_error */ -START_TEST(test_iterate) +START_TEST(test_scan) { intptr_t i = 0; int check; /* empty store */ - check = sdb_store_iterate(iter_incr, &i); + check = sdb_store_scan(SDB_HOST, /* m, filter = */ NULL, NULL, + scan_count, &i); fail_unless(check == -1, - "sdb_store_iterate(), empty store = %d; expected: -1", check); + "sdb_store_scan(HOST), empty store = %d; expected: -1", check); fail_unless(i == 0, - "sdb_store_iterate called callback %d times; expected: 0", (int)i); + "sdb_store_scan(HOST) called callback %d times; " + "expected: 0", (int)i); populate(); - check = sdb_store_iterate(iter_incr, &i); + check = sdb_store_scan(SDB_HOST, /* m, filter = */ NULL, NULL, + scan_count, &i); fail_unless(check == 0, - "sdb_store_iterate() = %d; expected: 0", check); + "sdb_store_scan(HOST) = %d; expected: 0", check); fail_unless(i == 2, - "sdb_store_iterate called callback %d times; expected: 1", (int)i); + "sdb_store_scan(HOST) called callback %d times; " + "expected: 1", (int)i); i = 0; - check = sdb_store_iterate(iter_error, &i); + check = sdb_store_scan(SDB_HOST, /* m, filter = */ NULL, NULL, + scan_error, &i); fail_unless(check == -1, - "sdb_store_iterate(), error callback = %d; expected: -1", check); + "sdb_store_scan(HOST), error callback = %d; expected: -1", check); fail_unless(i == 1, - "sdb_store_iterate called callback %d times " + "sdb_store_scan(HOST) called callback %d times " "(callback returned error); expected: 1", (int)i); + + i = 0; + check = sdb_store_scan(SDB_SERVICE, /* m, filter = */ NULL, NULL, + scan_count, &i); + fail_unless(check == 0, + "sdb_store_scan(SERVICE) = %d; expected: 0", check); + fail_unless(i == 2, + "sdb_store_scan(SERVICE) called callback %d times; " + "expected: 2", (int)i); + + i = 0; + check = sdb_store_scan(SDB_METRIC, /* m, filter = */ NULL, NULL, + scan_count, &i); + fail_unless(check == 0, + "sdb_store_scan(METRIC) = %d; expected: 0", check); + fail_unless(i == 3, + "sdb_store_scan(METRIC) called callback %d times; " + "expected: 3", (int)i); } END_TEST @@ -743,11 +962,13 @@ core_store_suite(void) tcase_add_test(tc, test_store_host); tcase_add_test(tc, test_store_get_host); tcase_add_test(tc, test_store_attr); + tcase_add_test(tc, test_store_metric); + tcase_add_test(tc, test_store_metric_attr); tcase_add_test(tc, test_store_service); tcase_add_test(tc, test_store_service_attr); tcase_add_test(tc, test_get_field); tcase_add_test(tc, test_interval); - tcase_add_test(tc, test_iterate); + tcase_add_test(tc, test_scan); tcase_add_unchecked_fixture(tc, NULL, sdb_store_clear); suite_add_tcase(s, tc);