X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fzone.c;h=d9e46f5ad1ea690ca022b2732c09a3918046f558;hb=02f8dbc0985310574ea2837cd5e3c06cccda203d;hp=c5eacefd17da7e9aa49a2da28ef76b6c3c759969;hpb=5a7b3083a24416a12f59734209ebec47298c4d8b;p=collectd.git

diff --git a/src/zone.c b/src/zone.c
index c5eacefd..d9e46f5a 100644
--- a/src/zone.c
+++ b/src/zone.c
@@ -17,16 +17,24 @@
  *
  * Authors:
  *   Mathijs Mohlmann
+ *   Dagobert Michelsen (forward-porting)
  **/
 
-#define _BSD_SOURCE
+#if HAVE_CONFIG_H
+# include "config.h"
+# undef HAVE_CONFIG_H
+#endif
+/* avoid procfs.h error "Cannot use procfs in the large file compilation environment" */
+#if !defined(_LP64) && _FILE_OFFSET_BITS == 64
+#  undef _FILE_OFFSET_BITS
+#  undef _LARGEFILE64_SOURCE
+#endif
 
 #include "collectd.h"
+
 #include "common.h"
 #include "plugin.h"
 
-#include <sys/types.h>
-#include <sys/vm_usage.h>
 #include <procfs.h>
 #include <zone.h>
 
@@ -40,35 +48,35 @@ typedef struct zone_stats {
 	ushort_t      pctmem;
 } zone_stats_t;
 
-static long pagesize;
-
 static int
-zone_compare(const zoneid_t *a, const zoneid_t *b)
+zone_compare(const void *a, const void *b)
 {
-	if (*a == *b)
+	if (*(const zoneid_t *)a == *(const zoneid_t *)b)
 		return(0);
-	if (*a < *b)
+	if (*(const zoneid_t *)a < *(const zoneid_t *)b)
 		return(-1);
 	return(1);
 }
 
 static int
-zone_read_procfile(char *pidstr, char *file, void *buf, size_t bufsize)
+zone_read_procfile(char const *pidstr, char const *name, void *buf, size_t bufsize)
 {
 	int fd;
 
 	char procfile[MAX_PROCFS_PATH];
-	(void)snprintf(procfile, MAX_PROCFS_PATH, "/proc/%s/%s", pidstr, file);
-	while ((fd = open(procfile, O_RDONLY)) == -1) {
-		if ((errno != EMFILE) || (errno != ENFILE)) {
-			return(1);
-		}
+	(void)snprintf(procfile, sizeof(procfile), "/proc/%s/%s", pidstr, name);
+	if ((fd = open(procfile, O_RDONLY)) == -1) {
+		return (1);
 	}
 
-	if (pread(fd, buf, bufsize, 0) != bufsize) {
+	if (sread(fd, buf, bufsize) != 0) {
+		char errbuf[1024];
+		ERROR ("zone plugin: Reading \"%s\" failed: %s", procfile,
+				sstrerror (errno, errbuf, sizeof (errbuf)));
 		close(fd);
 		return (1);
 	}
+
 	close(fd);
 	return (0);
 }
@@ -98,12 +106,13 @@ zone_find_stats(c_avl_tree_t *tree, zoneid_t zoneid)
 	zoneid_t     *key = NULL;
 
 	if (c_avl_get(tree, (void **)&zoneid, (void **)&ret)) {
-		if (!(ret = malloc(sizeof(zone_stats_t)))) {
+		if (!(ret = malloc(sizeof(*ret)))) {
 			WARNING("zone plugin: no memory");
 			return(NULL);
 		}
-		if (!(key = malloc(sizeof(zoneid_t)))) {
+		if (!(key = malloc(sizeof(*key)))) {
 			WARNING("zone plugin: no memory");
+			free(ret);
 			return(NULL);
 		}
 		*key = zoneid;
@@ -125,7 +134,7 @@ zone_submit_values(c_avl_tree_t *tree)
 	while (c_avl_pick (tree, (void **)&zoneid, (void **)&stats) == 0)
 	{
 		if (getzonenamebyid(*zoneid, zonename, sizeof( zonename )) == -1) {
-			WARNING("zone plugin: error retreiving zonename");
+			WARNING("zone plugin: error retrieving zonename");
 		} else {
 			zone_submit_value(zonename, (gauge_t)FRC2PCT(stats->pctcpu));
 		}
@@ -138,29 +147,30 @@ zone_submit_values(c_avl_tree_t *tree)
 static c_avl_tree_t *
 zone_scandir(DIR *procdir)
 {
-	char         *pidstr;
 	pid_t         pid;
 	dirent_t     *direntp;
 	psinfo_t      psinfo;
 	c_avl_tree_t *tree;
 	zone_stats_t *stats;
-/*	size_t    physmem = sysconf(_SC_PHYS_PAGES) * pagesize;*/
 
-	if (!(tree=c_avl_create((void *) zone_compare))) {
+	if (!(tree=c_avl_create(zone_compare))) {
 		WARNING("zone plugin: Failed to create tree");
 		return(NULL);
 	}
 
-	for (rewinddir(procdir); (direntp = readdir(procdir)); ) {
-		pidstr = direntp->d_name;
+	rewinddir(procdir);
+	while ((direntp = readdir(procdir))) {
+		char const *pidstr = direntp->d_name;
 		if (pidstr[0] == '.')	/* skip "." and ".."  */
 			continue;
+
 		pid = atoi(pidstr);
 		if (pid == 0 || pid == 2 || pid == 3)
 			continue;	/* skip sched, pageout and fsflush */
-		if (zone_read_procfile(pidstr, "psinfo", &psinfo, 
-				  sizeof(psinfo_t)) != 0)
+
+		if (zone_read_procfile(pidstr, "psinfo", &psinfo, sizeof(psinfo_t)) != 0)
 			continue;
+
 		stats = zone_find_stats(tree, psinfo.pr_zoneid);
 		if( stats ) {
 			stats->pctcpu += psinfo.pr_pctcpu;
@@ -170,20 +180,21 @@ zone_scandir(DIR *procdir)
 	return(tree);
 }
 
-
 static int zone_read (void)
 {
 	DIR          *procdir;
 	c_avl_tree_t *tree;
 
-	pagesize = sysconf(_SC_PAGESIZE);
 	if ((procdir = opendir("/proc")) == NULL) {
 		ERROR("zone plugin: cannot open /proc directory\n");
-		exit(1);
+		return (-1);
 	}
 
 	tree=zone_scandir(procdir);
 	closedir(procdir);
+	if (tree == NULL) {
+		return (-1);
+	}
 	zone_submit_values(tree); /* this also frees tree */
 	return (0);
 }