X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Futils_dns.c;h=eefde9683de10c25f100a9ec99056bf6e77ba549;hb=311c7cf4b61bc02793fe3455202b2cbbfe4860e6;hp=80a2ee577f7213c4182a57b70e5f220d6d4d92fa;hpb=d19bcbf5c310f3656503e64ba26829256112ded4;p=collectd.git
diff --git a/src/utils_dns.c b/src/utils_dns.c
index 80a2ee57..71a14d87 100644
--- a/src/utils_dns.c
+++ b/src/utils_dns.c
@@ -1,12 +1,12 @@
/*
* collectd - src/utils_dns.c
- * Modifications Copyright (C) 2006 Florian octo Forster
- * Copyright (C) 2002 The Measurement Factory, Inc.
+ * Copyright (C) 2006 Florian octo Forster
+ * Copyright (C) 2002 The Measurement Factory, Inc.
* All rights reserved.
- *
+ *
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
- *
+ *
* 1. Redistributions of source code must retain the above copyright notice,
* this list of conditions and the following disclaimer.
* 2. Redistributions in binary form must reproduce the above copyright notice,
@@ -30,50 +30,22 @@
*
* Authors:
* The Measurement Factory, Inc.
- * Florian octo Forster
+ * Florian octo Forster
*/
+#define _DEFAULT_SOURCE
#define _BSD_SOURCE
#include "collectd.h"
#include "plugin.h"
#include "common.h"
-#if HAVE_NETINET_IN_SYSTM_H
-# include
-#endif
-#if HAVE_NETINET_IN_H
-# include
-#endif
-#if HAVE_NETINET_IP6_H
-# include
-#endif
-#if HAVE_NETINET_IP_COMPAT_H
-# include
-#endif
-#if HAVE_ARPA_INET_H
-# include
-#endif
-#if HAVE_SYS_SOCKET_H
-# include
-#endif
-
-#if HAVE_ARPA_NAMESER_H
-# include
-#endif
-#if HAVE_ARPA_NAMESER_COMPAT_H
-# include
-#endif
-
#if HAVE_NET_IF_ARP_H
# include
#endif
#if HAVE_NET_IF_H
# include
#endif
-#if HAVE_NETINET_IF_ETHER_H
-# include
-#endif
#if HAVE_NET_PPP_DEFS_H
# include
#endif
@@ -81,23 +53,42 @@
# include
#endif
-#if HAVE_NETDB_H
-# include
+#if HAVE_NETINET_IN_SYSTM_H
+# include
+#endif
+#if HAVE_NETINET_IN_H
+# include
+#endif
+#if HAVE_NETINET_IP6_H
+# include
+#endif
+#if HAVE_NETINET_IF_ETHER_H
+# include
#endif
-
#if HAVE_NETINET_IP_H
# include
#endif
#ifdef HAVE_NETINET_IP_VAR_H
# include
#endif
-#if HAVE_NETINET_IP6_H
-# include
-#endif
#if HAVE_NETINET_UDP_H
# include
#endif
+#if HAVE_ARPA_INET_H
+# include
+#endif
+#if HAVE_ARPA_NAMESER_H
+# include
+#endif
+#if HAVE_ARPA_NAMESER_COMPAT_H
+# include
+#endif
+
+#if HAVE_NETDB_H
+# include
+#endif
+
#if HAVE_PCAP_H
# include
#endif
@@ -132,6 +123,10 @@
# error "`struct udphdr' is unusable."
#endif
+#if HAVE_NETINET_IP6_H && HAVE_STRUCT_IP6_EXT
+# define HAVE_IPV6 1
+#endif
+
#include "utils_dns.h"
/*
@@ -303,7 +298,7 @@ rfc1035NameUnpack(const char *buf, size_t sz, off_t * off, char *name, size_t ns
if (ns <= 0)
return 4; /* probably compression loop */
do {
- if ((*off) >= sz)
+ if ((*off) >= ((off_t) sz))
break;
c = *(buf + (*off));
if (c > 191) {
@@ -315,11 +310,11 @@ rfc1035NameUnpack(const char *buf, size_t sz, off_t * off, char *name, size_t ns
s = ntohs(s);
(*off) += sizeof(s);
/* Sanity check */
- if ((*off) >= sz)
+ if ((*off) >= ((off_t) sz))
return 1; /* message too short */
ptr = s & 0x3FFF;
/* Make sure the pointer is inside this message */
- if (ptr >= sz)
+ if (ptr >= ((off_t) sz))
return 2; /* bad compression ptr */
if (ptr < DNS_MSG_HDR_SZ)
return 2; /* bad compression ptr */
@@ -353,7 +348,7 @@ rfc1035NameUnpack(const char *buf, size_t sz, off_t * off, char *name, size_t ns
if (no > 0)
*(name + no - 1) = '\0';
/* make sure we didn't allow someone to overflow the name buffer */
- assert(no <= ns);
+ assert(no <= ((off_t) ns));
return 0;
}
@@ -447,7 +442,7 @@ handle_udp(const struct udphdr *udp, int len)
return 1;
}
-#if HAVE_NETINET_IP6_H
+#if HAVE_IPV6
static int
handle_ipv6 (struct ip6_hdr *ipv6, int len)
{
@@ -516,16 +511,16 @@ handle_ipv6 (struct ip6_hdr *ipv6, int len)
return (1); /* Success */
} /* int handle_ipv6 */
-/* #endif HAVE_NETINET_IP6_H */
+/* #endif HAVE_IPV6 */
-#else /* if !HAVE_NETINET_IP6_H */
+#else /* if !HAVE_IPV6 */
static int
handle_ipv6 (__attribute__((unused)) void *pkg,
__attribute__((unused)) int len)
{
return (0);
}
-#endif /* !HAVE_NETINET_IP6_H */
+#endif /* !HAVE_IPV6 */
static int
handle_ip(const struct ip *ip, int len)