X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Futils%2Fdbi.c;h=261d3b249e5265b089db34f9e4c54e64de34d017;hb=61c35f1909b2496c7edac288a59f75604c7c179e;hp=380a841321a1c6507f0c6f07a7f322e2d3e8ba6b;hpb=b5e349aa592e8cf4b946e82283a98a14968de192;p=sysdb.git diff --git a/src/utils/dbi.c b/src/utils/dbi.c index 380a841..261d3b2 100644 --- a/src/utils/dbi.c +++ b/src/utils/dbi.c @@ -25,7 +25,12 @@ * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#if HAVE_CONFIG_H +# include "config.h" +#endif /* HAVE_CONFIG_H */ + #include "utils/dbi.h" +#include "utils/error.h" #include @@ -36,6 +41,62 @@ #include #include +/* + * pre 0.9 DBI compat layer + */ + +#if LIBDBI_VERSION < 900 +#include + +typedef void *dbi_inst; + +static pthread_mutex_t dbi_lock = PTHREAD_MUTEX_INITIALIZER; +static int dbi_initialized = 0; + +static int +initialize_r(const char *driverdir, dbi_inst __attribute__((unused)) *pInst) +{ + int status = 0; + pthread_mutex_lock(&dbi_lock); + if (! dbi_initialized) + status = dbi_initialize(driverdir); + dbi_initialized = 1; + pthread_mutex_unlock(&dbi_lock); + return status; +} /* initialize_r */ + +static dbi_driver +driver_open_r(const char *name, dbi_inst __attribute__((unused)) Inst) +{ + dbi_driver driver; + pthread_mutex_lock(&dbi_lock); + driver = dbi_driver_open(name); + pthread_mutex_unlock(&dbi_lock); + return driver; +} /* driver_open_r */ + +static dbi_driver +driver_list_r(dbi_driver Current, dbi_inst __attribute__((unused)) Inst) +{ + dbi_driver driver; + pthread_mutex_lock(&dbi_lock); + driver = dbi_driver_list(Current); + pthread_mutex_unlock(&dbi_lock); + return driver; +} /* driver_list_r */ + +static void +shutdown_r(dbi_inst __attribute__((unused)) Inst) +{ + /* do nothing; we don't know if DBI is still in use */ +} /* shutdown_r */ + +#define dbi_initialize_r initialize_r +#define dbi_driver_open_r driver_open_r +#define dbi_driver_list_r driver_list_r +#define dbi_shutdown_r shutdown_r +#endif /* LIBDBI_VERSION < 900 */ + /* * private data types */ @@ -55,6 +116,7 @@ struct sdb_dbi_client { char *database; dbi_conn conn; + dbi_inst inst; sdb_dbi_options_t *options; }; @@ -83,7 +145,7 @@ sdb_dbi_get_field(dbi_result res, unsigned int i, data->data.decimal = dbi_result_get_double_idx(res, i); break; case SDB_TYPE_STRING: - data->data.string = dbi_result_get_string_idx(res, i); + data->data.string = dbi_result_get_string_copy_idx(res, i); break; case SDB_TYPE_DATETIME: { @@ -95,14 +157,14 @@ sdb_dbi_get_field(dbi_result res, unsigned int i, case SDB_TYPE_BINARY: { size_t length = dbi_result_get_field_length_idx(res, i); - const unsigned char *datum = dbi_result_get_binary_idx(res, i); + unsigned char *datum = dbi_result_get_binary_copy_idx(res, i); data->data.binary.length = length; data->data.binary.datum = datum; } break; default: - fprintf(stderr, "dbi: Unexpected type %i while " - "parsing query result.\n", type); + sdb_log(SDB_LOG_ERR, "dbi: Unexpected type %i while " + "parsing query result.", type); return -1; } @@ -128,11 +190,11 @@ sdb_dbi_get_data(sdb_dbi_client_t *client, dbi_result res, for (i = 0; i < num_fields; ++i) { types[i] = dbi_result_get_field_type_idx(res, i + 1); if (types[i] == DBI_TYPE_ERROR) { - fprintf(stderr, "dbi: failed to fetch data: %s\n", + sdb_log(SDB_LOG_ERR, "dbi: failed to fetch data: %s", sdb_dbi_strerror(client->conn)); return -1; } - types[i] = DBI_TYPE_TO_SC(types[i]); + types[i] = DBI_TYPE_TO_SDB(types[i]); } num_rows = dbi_result_get_numrows(res); @@ -140,8 +202,10 @@ sdb_dbi_get_data(sdb_dbi_client_t *client, dbi_result res, return -1; for (n = 0; n < num_rows; ++n) { + int status; + if (! dbi_result_seek_row(res, n + 1)) { - fprintf(stderr, "dbi: Failed to retrieve row %llu: %s\n", + sdb_log(SDB_LOG_ERR, "dbi: Failed to retrieve row %llu: %s", n, sdb_dbi_strerror(client->conn)); continue; } @@ -151,7 +215,11 @@ sdb_dbi_get_data(sdb_dbi_client_t *client, dbi_result res, types[i], &data[i])) continue; - if (callback(client, num_fields, data, user_data)) + status = callback(client, num_fields, data, user_data); + for (i = 0; i < num_fields; ++i) + sdb_data_free_datum(&data[i]); + + if (status) continue; ++success; @@ -171,7 +239,7 @@ sdb_dbi_options_create(void) { sdb_dbi_options_t *options; - options = malloc(sizeof(options)); + options = malloc(sizeof(*options)); if (! options) return NULL; @@ -252,6 +320,11 @@ sdb_dbi_client_create(const char *driver, const char *database) client->conn = NULL; client->options = NULL; + if (dbi_initialize_r(/* driverdir = */ NULL, &client->inst) < 0) { + free(client); + return NULL; + } + client->driver = strdup(driver); client->database = strdup(database); if ((! client->driver) || (! client->database)) { @@ -283,26 +356,30 @@ sdb_dbi_client_connect(sdb_dbi_client_t *client) if ((! client) || (! client->driver) || (! client->database)) return -1; - if (client->conn) + if (client->conn) { dbi_conn_close(client->conn); + client->conn = NULL; + } - driver = dbi_driver_open(client->driver); + driver = dbi_driver_open_r(client->driver, client->inst); if (! driver) { - fprintf(stderr, "dbi: failed to open DBI driver '%s'; " + sdb_error_set("dbi: failed to open DBI driver '%s'; " "possibly it's not installed.\n", client->driver); - fprintf(stderr, "dbi: known drivers:\n"); - for (driver = dbi_driver_list(NULL); driver; - driver = dbi_driver_list(driver)) { - fprintf(stderr, "\t- %s\n", dbi_driver_get_name(driver)); + sdb_error_append("dbi: known drivers:\n"); + for (driver = dbi_driver_list_r(NULL, client->inst); driver; + driver = dbi_driver_list_r(driver, client->inst)) { + sdb_error_append("\t- %s\n", dbi_driver_get_name(driver)); } + sdb_error_chomp(); + sdb_error_log(SDB_LOG_ERR); return -1; } client->conn = dbi_conn_open(driver); if (! client->conn) { - fprintf(stderr, "dbi: failed to open connection object.\n"); + sdb_log(SDB_LOG_ERR, "dbi: failed to open connection object."); return -1; } @@ -316,31 +393,36 @@ sdb_dbi_client_connect(sdb_dbi_client_t *client) continue; /* else: error */ - fprintf(stderr, "dbi: failed to set option '%s': %s\n", + sdb_error_set("dbi: failed to set option '%s': %s\n", client->options->options[i].key, sdb_dbi_strerror(client->conn)); - fprintf(stderr, "dbi: known driver options:\n"); + sdb_error_append("dbi: known driver options:\n"); for (opt = dbi_conn_get_option_list(client->conn, NULL); opt; opt = dbi_conn_get_option_list(client->conn, opt)) - fprintf(stderr, "\t- %s\n", opt); + sdb_error_append("\t- %s\n", opt); + sdb_error_chomp(); + sdb_error_log(SDB_LOG_ERR); dbi_conn_close(client->conn); + client->conn = NULL; return -1; } } if (dbi_conn_set_option(client->conn, "dbname", client->database)) { - fprintf(stderr, "dbi: failed to set option 'dbname': %s\n", + sdb_log(SDB_LOG_ERR, "dbi: failed to set option 'dbname': %s", sdb_dbi_strerror(client->conn)); dbi_conn_close(client->conn); + client->conn = NULL; return -1; } if (dbi_conn_connect(client->conn) < 0) { - fprintf(stderr, "dbi: failed to connect to database '%s': %s\n", + sdb_log(SDB_LOG_ERR, "dbi: failed to connect to database '%s': %s", client->database, sdb_dbi_strerror(client->conn)); dbi_conn_close(client->conn); + client->conn = NULL; return -1; } return 0; @@ -374,14 +456,14 @@ sdb_dbi_exec_query(sdb_dbi_client_t *client, const char *query, res = dbi_conn_query(client->conn, query); if (! res) { - fprintf(stderr, "dbi: failed to execute query '%s': %s\n", + sdb_log(SDB_LOG_ERR, "dbi: failed to execute query '%s': %s", query, sdb_dbi_strerror(client->conn)); return -1; } if (dbi_result_get_numrows(res) == DBI_ROW_ERROR) { - fprintf(stderr, "dbi: failed to fetch rows for query '%s': %s\n", - query, sdb_dbi_strerror(client->conn)); + sdb_log(SDB_LOG_ERR, "dbi: failed to fetch rows for query " + "'%s': %s", query, sdb_dbi_strerror(client->conn)); dbi_result_free(res); return -1; } @@ -398,9 +480,9 @@ sdb_dbi_exec_query(sdb_dbi_client_t *client, const char *query, int i; if (n != (int)num_fields) { - fprintf(stderr, "dbi: number of returned fields (%i) does not " - "match the number of requested fields (%i) " - "for query '%s'.\n", num_fields, n, query); + sdb_log(SDB_LOG_ERR, "dbi: number of returned fields (%i) " + "does not match the number of requested fields (%i) " + "for query '%s'.", num_fields, n, query); dbi_result_free(res); return -1; } @@ -414,12 +496,12 @@ sdb_dbi_exec_query(sdb_dbi_client_t *client, const char *query, unsigned int type = va_arg(types, unsigned int); - field_type = DBI_TYPE_TO_SC(field_type); + field_type = DBI_TYPE_TO_SDB(field_type); /* column count starts at 1 */ if ((unsigned int)field_type != type) { - fprintf(stderr, "dbi: type of column '%s' (%u) does not match " - "requested type (%u).\n", + sdb_log(SDB_LOG_ERR, "dbi: type of column '%s' (%u) " + "does not match requested type (%u).", dbi_result_get_field_name(res, (unsigned int)i + 1), field_type, type); status = -1; @@ -461,6 +543,11 @@ sdb_dbi_client_destroy(sdb_dbi_client_t *client) if (client->conn) dbi_conn_close(client->conn); + client->conn = NULL; + + if (client->inst) + dbi_shutdown_r(client->inst); + client->inst = NULL; if (client->options) sdb_dbi_options_destroy(client->options);