X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Futils%2Fchannel.c;h=c72953e956911b9e69ffc6ab44889283c5d319b7;hb=2d39d666abde2d66a55ac4536da3f250d9513f48;hp=92d793e468c441b044c24d76bedd2d9dc51510f0;hpb=618c44a3534e738138455caba68c925eb39f94e3;p=sysdb.git

diff --git a/src/utils/channel.c b/src/utils/channel.c
index 92d793e..c72953e 100644
--- a/src/utils/channel.c
+++ b/src/utils/channel.c
@@ -25,10 +25,16 @@
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#if HAVE_CONFIG_H
+#	include "config.h"
+#endif /* HAVE_CONFIG_H */
+
 #include "utils/channel.h"
 
 #include <assert.h>
+#include <errno.h>
 
+#include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ -54,7 +60,9 @@ struct sdb_channel {
 
 	size_t head;
 	size_t tail;
-	_Bool full;
+	bool  full;
+
+	bool shutdown;
 };
 
 /*
@@ -77,7 +85,7 @@ channel_write(sdb_channel_t *chan, const void *data)
 {
 	assert(chan);
 
-	if (chan->full)
+	if (chan->full || chan->shutdown)
 		return -1;
 	else if (! data)
 		return 0;
@@ -167,21 +175,16 @@ int
 sdb_channel_select(sdb_channel_t *chan, int *wantread, void *read_data,
 		int *wantwrite, void *write_data, const struct timespec *timeout)
 {
-	struct timespec abstime;
 	int status = 0;
 
-	if (! chan)
+	if (! chan) {
+		errno = EINVAL;
 		return -1;
+	}
 
-	if ((! wantread) && (! read_data) && (! wantwrite) && (! write_data))
+	if ((! wantread) && (! read_data) && (! wantwrite) && (! write_data)) {
+		errno = EINVAL;
 		return -1;
-
-	if (timeout) {
-		if (clock_gettime(CLOCK_REALTIME, &abstime))
-			return -1;
-
-		abstime.tv_sec += timeout->tv_sec;
-		abstime.tv_nsec += timeout->tv_nsec;
 	}
 
 	pthread_mutex_lock(&chan->lock);
@@ -202,15 +205,41 @@ sdb_channel_select(sdb_channel_t *chan, int *wantread, void *read_data,
 				break;
 		}
 
-		if (timeout)
+		if (chan->shutdown) {
+			if (read_status)
+				status = EBADF;
+			break;
+		}
+
+		if (timeout) {
+			struct timespec abstime;
+
+			if (clock_gettime(CLOCK_REALTIME, &abstime)) {
+				pthread_mutex_unlock(&chan->lock);
+				return -1;
+			}
+
+			abstime.tv_sec += timeout->tv_sec;
+			abstime.tv_nsec += timeout->tv_nsec;
+
+			if (abstime.tv_nsec > 1000000000) {
+				abstime.tv_nsec -= 1000000000;
+				abstime.tv_sec += 1;
+			}
+
 			status = pthread_cond_timedwait(&chan->cond, &chan->lock,
 					&abstime);
+		}
 		else
 			status = pthread_cond_wait(&chan->cond, &chan->lock);
 	}
-
 	pthread_mutex_unlock(&chan->lock);
-	return status;
+
+	if (status) {
+		errno = status;
+		return -1;
+	}
+	return 0;
 } /* sdb_channel_select */
 
 int
@@ -241,5 +270,14 @@ sdb_channel_read(sdb_channel_t *chan, void *data)
 	return status;
 } /* sdb_channel_read */
 
+int
+sdb_channel_shutdown(sdb_channel_t *chan)
+{
+	if (! chan)
+		return -1;
+	chan->shutdown = 1;
+	return 0;
+} /* sdb_channel_shutdown */
+
 /* vim: set tw=78 sw=4 ts=4 noexpandtab : */