X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fstyle.cpp;h=a4094621f8d9712abc32bf5f7d551f0513b27ee6;hb=294d8e81765f1327f8507c57f3c80665909edbc4;hp=680ebee53756d1644dfccbeb347928f59df7ca54;hpb=ae4a5f5acfd1b122058a5213fbc62d31e79a465a;p=inkscape.git diff --git a/src/style.cpp b/src/style.cpp index 680ebee53..a4094621f 100644 --- a/src/style.cpp +++ b/src/style.cpp @@ -1,9 +1,7 @@ -#define __SP_STYLE_C__ - -/** \file - * SVG stylesheets implementation. - * - * Authors: +/** @file + * @brief SVG stylesheets implementation. + */ +/* Authors: * Lauris Kaplinski * Peter Moulder * bulia byak @@ -19,6 +17,9 @@ # include "config.h" #endif +#include +#include + #include "libcroco/cr-sel-eng.h" #include "xml/croco-node-iface.h" @@ -38,9 +39,11 @@ #include "style.h" #include "svg/css-ostringstream.h" #include "xml/repr.h" +#include "xml/simple-document.h" #include "unit-constants.h" -#include "isnan.h" +#include "2geom/isnan.h" #include "macros.h" +#include "preferences.h" #include "sp-filter-reference.h" @@ -80,13 +83,14 @@ static void sp_style_read_ilength(SPILength *val, gchar const *str); static void sp_style_read_ilengthornormal(SPILengthOrNormal *val, gchar const *str); static void sp_style_read_itextdecoration(SPITextDecoration *val, gchar const *str); static void sp_style_read_icolor(SPIPaint *paint, gchar const *str, SPStyle *style, SPDocument *document); -static void sp_style_read_ipaint(SPIPaint *paint, gchar const *str, SPStyle *style, SPDocument *document); static void sp_style_read_ifontsize(SPIFontSize *val, gchar const *str); +static void sp_style_read_ibaselineshift(SPIBaselineShift *val, gchar const *str); static void sp_style_read_ifilter(gchar const *str, SPStyle *style, SPDocument *document); static void sp_style_read_penum(SPIEnum *val, Inkscape::XML::Node *repr, gchar const *key, SPStyleEnum const *dict, bool can_explicitly_inherit); static void sp_style_read_plength(SPILength *val, Inkscape::XML::Node *repr, gchar const *key); static void sp_style_read_pfontsize(SPIFontSize *val, Inkscape::XML::Node *repr, gchar const *key); +static void sp_style_read_pbaselineshift(SPIBaselineShift *val, Inkscape::XML::Node *repr, gchar const *key); static void sp_style_read_pfloat(SPIFloat *val, Inkscape::XML::Node *repr, gchar const *key); static gint sp_style_write_ifloat(gchar *p, gint len, gchar const *key, SPIFloat const *val, SPIFloat const *base, guint flags); @@ -96,12 +100,11 @@ static gint sp_style_write_istring(gchar *p, gint len, gchar const *key, SPIStri static gint sp_style_write_ilength(gchar *p, gint len, gchar const *key, SPILength const *val, SPILength const *base, guint flags); static gint sp_style_write_ipaint(gchar *b, gint len, gchar const *key, SPIPaint const *paint, SPIPaint const *base, guint flags); static gint sp_style_write_ifontsize(gchar *p, gint len, gchar const *key, SPIFontSize const *val, SPIFontSize const *base, guint flags); +static gint sp_style_write_ibaselineshift(gchar *p, gint len, gchar const *key, SPIBaselineShift const *val, SPIBaselineShift const *base, guint flags); static gint sp_style_write_ilengthornormal(gchar *p, gint const len, gchar const *const key, SPILengthOrNormal const *const val, SPILengthOrNormal const *const base, guint const flags); static gint sp_style_write_itextdecoration(gchar *p, gint const len, gchar const *const key, SPITextDecoration const *const val, SPITextDecoration const *const base, guint const flags); static gint sp_style_write_ifilter(gchar *b, gint len, gchar const *key, SPIFilter const *filter, SPIFilter const *base, guint flags); -static void sp_style_paint_clear(SPStyle *style, SPIPaint *paint); - static void sp_style_filter_clear(SPStyle *style); #define SPS_READ_IENUM_IF_UNSET(v,s,d,i) if (!(v)->set) {sp_style_read_ienum((v), (s), (d), (i));} @@ -115,6 +118,9 @@ static void sp_style_filter_clear(SPStyle *style); #define SPS_READ_IFONTSIZE_IF_UNSET(v,s) if (!(v)->set) {sp_style_read_ifontsize((v), (s));} #define SPS_READ_PFONTSIZE_IF_UNSET(v,r,k) if (!(v)->set) {sp_style_read_pfontsize((v), (r), (k));} +#define SPS_READ_IBASELINE_SHIFT_IF_UNSET(v,s) if (!(v)->set) {sp_style_read_ibaselineshift((v), (s));} +#define SPS_READ_PBASELINE_SHIFT_IF_UNSET(v,r,k) if (!(v)->set) {sp_style_read_pbaselineshift((v), (r), (k));} + static void sp_style_merge_from_object_stylesheet(SPStyle *, SPObject const *); struct SPStyleEnum { @@ -255,6 +261,13 @@ static SPStyleEnum const enum_writing_mode[] = { {NULL, -1} }; +static SPStyleEnum const enum_baseline_shift[] = { + {"baseline", SP_CSS_BASELINE_SHIFT_BASELINE}, + {"sub", SP_CSS_BASELINE_SHIFT_SUB}, + {"super", SP_CSS_BASELINE_SHIFT_SUPER}, + {NULL, -1} +}; + static SPStyleEnum const enum_visibility[] = { {"hidden", SP_CSS_VISIBILITY_HIDDEN}, {"collapse", SP_CSS_VISIBILITY_COLLAPSE}, @@ -328,6 +341,7 @@ static SPStyleEnum const enum_enable_background[] = { static void sp_style_object_release(SPObject *object, SPStyle *style) { + (void)object; // TODO style->object = NULL; } @@ -337,6 +351,7 @@ sp_style_object_release(SPObject *object, SPStyle *style) static void sp_style_filter_ref_modified(SPObject *obj, guint flags, SPStyle *style) { + (void)flags; // TODO SPFilter *filter=static_cast(obj); if (style->getFilter() == filter) { @@ -357,7 +372,7 @@ sp_style_filter_ref_changed(SPObject *old_ref, SPObject *ref, SPStyle *style) } if ( SP_IS_FILTER(ref)) { - style->filter_modified_connection = + style->filter_modified_connection = ref->connectModified(sigc::bind(sigc::ptr_fun(&sp_style_filter_ref_modified), style)); } @@ -371,9 +386,10 @@ sp_style_filter_ref_changed(SPObject *old_ref, SPObject *ref, SPStyle *style) static void sp_style_paint_server_ref_modified(SPObject *obj, guint flags, SPStyle *style) { + (void)flags; // TODO SPPaintServer *server = static_cast(obj); - if ((style->fill.type == SP_PAINT_TYPE_PAINTSERVER) + if ((style->fill.isPaintserver()) && style->getFillPaintServer() == server) { if (style->object) { @@ -387,14 +403,14 @@ sp_style_paint_server_ref_modified(SPObject *obj, guint flags, SPStyle *style) */ style->object->requestModified(SP_OBJECT_MODIFIED_FLAG | SP_OBJECT_STYLE_MODIFIED_FLAG); } - } else if ((style->stroke.type == SP_PAINT_TYPE_PAINTSERVER) + } else if ((style->stroke.isPaintserver()) && style->getStrokePaintServer() == server) { if (style->object) { /// \todo fixme: style->object->requestModified(SP_OBJECT_MODIFIED_FLAG | SP_OBJECT_STYLE_MODIFIED_FLAG); } - } else { + } else if (server) { g_assert_not_reached(); } } @@ -409,7 +425,7 @@ sp_style_fill_paint_server_ref_changed(SPObject *old_ref, SPObject *ref, SPStyle style->fill_ps_modified_connection.disconnect(); } if (SP_IS_PAINT_SERVER(ref)) { - style->fill_ps_modified_connection = + style->fill_ps_modified_connection = ref->connectModified(sigc::bind(sigc::ptr_fun(&sp_style_paint_server_ref_modified), style)); } @@ -426,7 +442,7 @@ sp_style_stroke_paint_server_ref_changed(SPObject *old_ref, SPObject *ref, SPSty style->stroke_ps_modified_connection.disconnect(); } if (SP_IS_PAINT_SERVER(ref)) { - style->stroke_ps_modified_connection = + style->stroke_ps_modified_connection = ref->connectModified(sigc::bind(sigc::ptr_fun(&sp_style_paint_server_ref_modified), style)); } @@ -469,11 +485,11 @@ sp_style_new_from_object(SPObject *object) g_return_val_if_fail(object != NULL, NULL); g_return_val_if_fail(SP_IS_OBJECT(object), NULL); - SPStyle *style = sp_style_new(SP_OBJECT_DOCUMENT(object)); + SPStyle *style = sp_style_new( object->document ); style->object = object; style->release_connection = object->connectRelease(sigc::bind<1>(sigc::ptr_fun(&sp_style_object_release), style)); - if (object && SP_OBJECT_IS_CLONED(object)) { + if (object && object->cloned) { style->cloned = true; } @@ -532,8 +548,8 @@ sp_style_unref(SPStyle *style) style->fill_ps_modified_connection.~connection(); style->stroke_ps_modified_connection.~connection(); - sp_style_paint_clear(style, &style->fill); - sp_style_paint_clear(style, &style->stroke); + style->fill.clear(); + style->stroke.clear(); sp_style_filter_clear(style); g_free(style->stroke_dash.dash); @@ -555,7 +571,7 @@ sp_style_read(SPStyle *style, SPObject *object, Inkscape::XML::Node *repr) sp_style_clear(style); - if (object && SP_OBJECT_IS_CLONED(object)) { + if (object && object->cloned) { style->cloned = true; } @@ -621,6 +637,7 @@ sp_style_read(SPStyle *style, SPObject *object, Inkscape::XML::Node *repr) enum_writing_mode, true); SPS_READ_PENUM_IF_UNSET(&style->text_anchor, repr, "text-anchor", enum_text_anchor, true); + SPS_READ_PBASELINE_SHIFT_IF_UNSET(&style->baseline_shift, repr, "baseline-shift"); /* opacity */ if (!style->opacity.set) { @@ -642,7 +659,7 @@ sp_style_read(SPStyle *style, SPObject *object, Inkscape::XML::Node *repr) if (!style->fill.set) { val = repr->attribute("fill"); if (val) { - sp_style_read_ipaint(&style->fill, val, style, (object) ? SP_OBJECT_DOCUMENT(object) : NULL); + style->fill.read( val, *style, (object) ? SP_OBJECT_DOCUMENT(object) : NULL ); } } /* fill-opacity */ @@ -658,7 +675,7 @@ sp_style_read(SPStyle *style, SPObject *object, Inkscape::XML::Node *repr) if (!style->stroke.set) { val = repr->attribute("stroke"); if (val) { - sp_style_read_ipaint(&style->stroke, val, style, (object) ? SP_OBJECT_DOCUMENT(object) : NULL); + style->stroke.read( val, *style, (object) ? SP_OBJECT_DOCUMENT(object) : NULL ); } } SPS_READ_PLENGTH_IF_UNSET(&style->stroke_width, repr, "stroke-width"); @@ -705,16 +722,30 @@ sp_style_read(SPStyle *style, SPObject *object, Inkscape::XML::Node *repr) sp_style_read_dash(style, val); } } + if (!style->stroke_dashoffset_set) { - /* fixme */ val = repr->attribute("stroke-dashoffset"); if (sp_svg_number_read_d(val, &style->stroke_dash.offset)) { style->stroke_dashoffset_set = TRUE; + } else if (val && !strcmp(val, "inherit")) { + style->stroke_dashoffset_set = TRUE; + style->stroke_dashoffset_inherit = TRUE; } else { style->stroke_dashoffset_set = FALSE; } } + /* -inkscape-font-specification */ + if (!style->text_private || !style->text->font_specification.set) { + val = repr->attribute("-inkscape-font-specification"); + if (val) { + if (!style->text_private) sp_style_privatize_text(style); + gchar *val_unquoted = attribute_unquote(val); + sp_style_read_istring(&style->text->font_specification, val_unquoted); + if (val_unquoted) g_free (val_unquoted); + } + } + /* font-family */ if (!style->text_private || !style->text->font_family.set) { val = repr->attribute("font-family"); @@ -730,7 +761,7 @@ sp_style_read(SPStyle *style, SPObject *object, Inkscape::XML::Node *repr) if (!style->filter.set) { val = repr->attribute("filter"); if (val) { - sp_style_read_ifilter(val, style, (object) ? SP_OBJECT_DOCUMENT(object) : NULL); + sp_style_read_ifilter(val, style, (object) ? SP_OBJECT_DOCUMENT(object) : NULL); } } SPS_READ_PENUM_IF_UNSET(&style->enable_background, repr, @@ -775,15 +806,33 @@ sp_style_read_from_object(SPStyle *style, SPObject *object) /** - * Read style properties from repr only. + * Read style properties from preferences. + * @param style The style to write to + * @param path Preferences directory from which the style should be read */ void -sp_style_read_from_repr(SPStyle *style, Inkscape::XML::Node *repr) +sp_style_read_from_prefs(SPStyle *style, Glib::ustring const &path) { g_return_if_fail(style != NULL); - g_return_if_fail(repr != NULL); + g_return_if_fail(path != ""); + + Inkscape::Preferences *prefs = Inkscape::Preferences::get(); + + // not optimal: we reconstruct the node based on the prefs, then pass it to + // sp_style_read for actual processing. + Inkscape::XML::SimpleDocument *tempdoc = new Inkscape::XML::SimpleDocument; + Inkscape::XML::Node *tempnode = tempdoc->createElement("temp"); + + std::vector attrs = prefs->getAllEntries(path); + for (std::vector::iterator i = attrs.begin(); i != attrs.end(); ++i) { + tempnode->setAttribute(i->getEntryName().data(), i->getString().data()); + } - sp_style_read(style, NULL, repr); + sp_style_read(style, NULL, tempnode); + + Inkscape::GC::release(tempnode); + Inkscape::GC::release(tempdoc); + delete tempdoc; } @@ -816,6 +865,14 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) g_return_if_fail(val != NULL); switch (id) { + case SP_PROP_INKSCAPE_FONT_SPEC: + if (!style->text_private) sp_style_privatize_text(style); + if (!style->text->font_specification.set) { + gchar *val_unquoted = attribute_unquote(val); + sp_style_read_istring(&style->text->font_specification, val_unquoted); + if (val_unquoted) g_free (val_unquoted); + } + break; /* CSS2 */ /* Font */ case SP_PROP_FONT_FAMILY: @@ -898,6 +955,9 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) case SP_PROP_TEXT_ANCHOR: SPS_READ_IENUM_IF_UNSET(&style->text_anchor, val, enum_text_anchor, true); break; + case SP_PROP_BASELINE_SHIFT: + SPS_READ_IBASELINE_SHIFT_IF_UNSET(&style->baseline_shift, val); + break; /* Text (unimplemented) */ case SP_PROP_TEXT_RENDERING: { /* Ignore the hint. */ @@ -908,9 +968,6 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) case SP_PROP_ALIGNMENT_BASELINE: g_warning("Unimplemented style property SP_PROP_ALIGNMENT_BASELINE: value: %s", val); break; - case SP_PROP_BASELINE_SHIFT: - g_warning("Unimplemented style property SP_PROP_BASELINE_SHIFT: value: %s", val); - break; case SP_PROP_DOMINANT_BASELINE: g_warning("Unimplemented style property SP_PROP_DOMINANT_BASELINE: value: %s", val); break; @@ -951,13 +1008,24 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) /* SVG */ /* Clip/Mask */ case SP_PROP_CLIP_PATH: - g_warning("Unimplemented style property SP_PROP_CLIP_PATH: value: %s", val); + /** \todo + * This is a workaround. Inkscape only supports 'clip-path' as SVG attribute, not as + * style property. By having both CSS and SVG attribute set, editing of clip-path + * will fail, since CSS always overwrites SVG attributes. + * Fixes Bug #324849 + */ + g_warning("attribute 'clip-path' given as CSS"); + style->object->repr->setAttribute("clip-path", val); break; case SP_PROP_CLIP_RULE: g_warning("Unimplemented style property SP_PROP_CLIP_RULE: value: %s", val); break; case SP_PROP_MASK: - g_warning("Unimplemented style property SP_PROP_MASK: value: %s", val); + /** \todo + * See comment for SP_PROP_CLIP_PATH + */ + g_warning("attribute 'mask' given as CSS"); + style->object->repr->setAttribute("mask", val); break; case SP_PROP_OPACITY: if (!style->opacity.set) { @@ -1012,7 +1080,7 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) } case SP_PROP_FILL: if (!style->fill.set) { - sp_style_read_ipaint(&style->fill, val, style, (style->object) ? SP_OBJECT_DOCUMENT(style->object) : NULL); + style->fill.read( val, *style, (style->object) ? SP_OBJECT_DOCUMENT(style->object) : NULL ); } break; case SP_PROP_FILL_OPACITY: @@ -1079,7 +1147,7 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) case SP_PROP_STROKE: if (!style->stroke.set) { - sp_style_read_ipaint(&style->stroke, val, style, (style->object) ? SP_OBJECT_DOCUMENT(style->object) : NULL); + style->stroke.read( val, *style, (style->object) ? SP_OBJECT_DOCUMENT(style->object) : NULL ); } break; case SP_PROP_STROKE_WIDTH: @@ -1092,9 +1160,11 @@ sp_style_merge_property(SPStyle *style, gint id, gchar const *val) break; case SP_PROP_STROKE_DASHOFFSET: if (!style->stroke_dashoffset_set) { - /* fixme */ if (sp_svg_number_read_d(val, &style->stroke_dash.offset)) { style->stroke_dashoffset_set = TRUE; + } else if (val && !strcmp(val, "inherit")) { + style->stroke_dashoffset_set = TRUE; + style->stroke_dashoffset_inherit = TRUE; } else { style->stroke_dashoffset_set = FALSE; } @@ -1282,6 +1352,50 @@ sp_style_merge_font_size_from_parent(SPIFontSize &child, SPIFontSize const &pare } } +// Some shifts are defined relative to parent. +static void +sp_style_merge_baseline_shift_from_parent(SPIBaselineShift &child, SPIBaselineShift const &parent, + SPIFontSize const &pfont_size) +{ + /* 'baseline-shift' */ + if (!child.set || child.inherit) { + /* Inherit the computed value. Reference: http://www.w3.org/TR/SVG11/styling.html#Inheritance */ + child.computed = parent.computed; // Does this make sense (applying a shift a second time)? + } else if (child.type == SP_BASELINE_SHIFT_LITERAL) { + if( child.literal == SP_CSS_BASELINE_SHIFT_BASELINE ) { + child.computed = 0; // No change + } else if (child.literal == SP_CSS_BASELINE_SHIFT_SUB ) { + // Should use subscript position from font relative to alphabetic baseline + // OpenOffice, Adobe: -0.33, Word -0.14, LaTex about -0.2. + child.computed = -0.2 * pfont_size.computed; + } else if (child.literal == SP_CSS_BASELINE_SHIFT_SUPER ) { + // Should use superscript position from font relative to alphabetic baseline + // OpenOffice, Adobe: 0.33, Word 0.35, LaTex about 0.45. + child.computed = 0.4 * pfont_size.computed; + } else { + /* Illegal value */ + } + } else if (child.type == SP_BASELINE_SHIFT_PERCENTAGE) { + // Percentage for baseline shift is relative to computed "line-height" + // which is just font-size (see SVG1.1 'font'). + child.computed = pfont_size.computed * child.value; + } else if (child.type == SP_BASELINE_SHIFT_LENGTH) { + switch (child.unit) { + case SP_CSS_UNIT_EM: + child.computed = child.value * pfont_size.computed; + break; + case SP_CSS_UNIT_EX: + child.computed = child.value * 0.5 * pfont_size.computed; + break; + default: + /* No change */ + break; + } + } + // baseline-shifts are relative to parent baseline + child.computed += parent.computed; +} + /** * Sets computed values in \a style, which may involve inheriting from (or in some other way * calculating from) corresponding computed values of \a parent. @@ -1386,16 +1500,19 @@ sp_style_merge_from_parent(SPStyle *const style, SPStyle const *const parent) } if (!style->line_height.set || style->line_height.inherit) { + style->line_height.value = parent->line_height.value; style->line_height.computed = parent->line_height.computed; style->line_height.normal = parent->line_height.normal; } if (!style->letter_spacing.set || style->letter_spacing.inherit) { + style->letter_spacing.value = parent->letter_spacing.value; style->letter_spacing.computed = parent->letter_spacing.computed; style->letter_spacing.normal = parent->letter_spacing.normal; } if (!style->word_spacing.set || style->word_spacing.inherit) { + style->word_spacing.value = parent->word_spacing.value; style->word_spacing.computed = parent->word_spacing.computed; style->word_spacing.normal = parent->word_spacing.normal; } @@ -1420,6 +1537,10 @@ sp_style_merge_from_parent(SPStyle *const style, SPStyle const *const parent) style->text_anchor.computed = parent->text_anchor.computed; } + /* Baseline Shift... Some shifts are relative to parent. */ + sp_style_merge_baseline_shift_from_parent(style->baseline_shift, parent->baseline_shift, + parent->font_size); + if (style->opacity.inherit) { style->opacity.value = parent->opacity.value; } @@ -1472,11 +1593,7 @@ sp_style_merge_from_parent(SPStyle *const style, SPStyle const *const parent) style->stroke_miterlimit.value = parent->stroke_miterlimit.value; } - if (!style->stroke_dasharray_set && parent->stroke_dasharray_set) { - /** \todo - * This code looks wrong. Why does the logic differ from the - * above properties? Similarly dashoffset below. - */ + if (!style->stroke_dasharray_set || style->stroke_dasharray_inherit) { style->stroke_dash.n_dash = parent->stroke_dash.n_dash; if (style->stroke_dash.n_dash > 0) { style->stroke_dash.dash = g_new(gdouble, style->stroke_dash.n_dash); @@ -1484,7 +1601,7 @@ sp_style_merge_from_parent(SPStyle *const style, SPStyle const *const parent) } } - if (!style->stroke_dashoffset_set && parent->stroke_dashoffset_set) { + if (!style->stroke_dashoffset_set || style->stroke_dashoffset_inherit) { style->stroke_dash.offset = parent->stroke_dash.offset; } @@ -1499,6 +1616,13 @@ sp_style_merge_from_parent(SPStyle *const style, SPStyle const *const parent) } } + if (style->text && parent->text) { + if (!style->text->font_specification.set || style->text->font_specification.inherit) { + g_free(style->text->font_specification.value); + style->text->font_specification.value = g_strdup(parent->text->font_specification.value); + } + } + /* Markers - Free the old value and make copy of the new */ for (unsigned i = SP_MARKER_LOC; i < SP_MARKER_LOC_QTY; i++) { if (!style->marker[i].set || style->marker[i].inherit) { @@ -1552,7 +1676,7 @@ sp_style_merge_paint_prop_from_dying_parent(SPStyle *style, * I haven't given this much attention. See comments below about * currentColor, colorProfile, and relative URIs. */ - if (!child.set || child.inherit || child.currentcolor) { + if (!child.set || child.inherit) { sp_style_merge_ipaint(style, &child, &parent); child.set = parent.set; child.inherit = parent.inherit; @@ -1642,7 +1766,7 @@ sp_style_merge_length_prop_from_dying_parent(LengthT &child, LengthT const &pare * fixme: Have separate ex ratio parameter. * Get x height from libnrtype or pango. */ - if (!isFinite(child.value)) { + if (!IS_FINITE(child.value)) { child.value = child.computed; child.unit = SP_CSS_UNIT_NONE; } @@ -1884,10 +2008,14 @@ sp_style_merge_from_dying_parent(SPStyle *const style, SPStyle const *const pare /* Font */ if (style->text && parent->text) { + sp_style_merge_string_prop_from_dying_parent(style->text->font_specification, + parent->text->font_specification); + sp_style_merge_string_prop_from_dying_parent(style->text->font_family, parent->text->font_family); } + /* Properties that don't inherit by default. Most of these need special handling. */ { /* @@ -1982,9 +2110,6 @@ sp_style_merge_from_dying_parent(SPStyle *const style, SPStyle const *const pare if (!style->filter.set || style->filter.inherit) { - // FIXME: - // instead of just copying over, we need to _really merge_ the two filters by combining their - // filter primitives sp_style_merge_ifilter(style, &parent->filter); } @@ -2038,10 +2163,11 @@ sp_style_merge_from_dying_parent(SPStyle *const style, SPStyle const *const pare } /* Note: this will need length handling once dasharray_offset supports units. */ - if (!style->stroke_dashoffset_set && parent->stroke_dashoffset_set) { + if ((!style->stroke_dashoffset_set || style->stroke_dashoffset_inherit) && parent->stroke_dashoffset_set && !parent->stroke_dashoffset_inherit) { style->stroke_dash.offset = parent->stroke_dash.offset; style->stroke_dashoffset_set = parent->stroke_dashoffset_set; - /* fixme: we don't currently allow stroke-dashoffset to be `inherit'. TODO: Try to + style->stroke_dashoffset_inherit = parent->stroke_dashoffset_inherit; + /* TODO: Try to * represent it as a normal SPILength; though will need to do something about existing * users of stroke_dash.offset and stroke_dashoffset_set. */ } @@ -2049,8 +2175,15 @@ sp_style_merge_from_dying_parent(SPStyle *const style, SPStyle const *const pare static void -sp_style_set_ipaint_to_uri(SPIPaint *paint, const Inkscape::URI *uri) +sp_style_set_ipaint_to_uri(SPStyle *style, SPIPaint *paint, const Inkscape::URI *uri, SPDocument *document) { + // it may be that this style's SPIPaint has not yet created its URIReference; + // now that we have a document, we can create it here + if (!paint->value.href && document) { + paint->value.href = new SPPaintServerReference(document); + paint->value.href->changedSignal().connect(sigc::bind(sigc::ptr_fun((paint == &style->fill)? sp_style_fill_paint_server_ref_changed : sp_style_stroke_paint_server_ref_changed), style)); + } + if (paint->value.href && paint->value.href->getObject()) paint->value.href->detach(); @@ -2065,16 +2198,20 @@ sp_style_set_ipaint_to_uri(SPIPaint *paint, const Inkscape::URI *uri) } static void -sp_style_set_ipaint_to_uri_string (SPIPaint *paint, const gchar *uri) +sp_style_set_ipaint_to_uri_string (SPStyle *style, SPIPaint *paint, const gchar *uri) { - const Inkscape::URI IURI(uri); - sp_style_set_ipaint_to_uri(paint, &IURI); + try { + const Inkscape::URI IURI(uri); + sp_style_set_ipaint_to_uri(style, paint, &IURI, style->document); + } catch (...) { + g_warning("URI failed to parse: %s", uri); + } } void sp_style_set_to_uri_string (SPStyle *style, bool isfill, const gchar *uri) { - sp_style_set_ipaint_to_uri_string (isfill? &style->fill : &style->stroke, uri); + sp_style_set_ipaint_to_uri_string (style, isfill? &style->fill : &style->stroke, uri); } /** @@ -2083,29 +2220,30 @@ sp_style_set_to_uri_string (SPStyle *style, bool isfill, const gchar *uri) static void sp_style_merge_ipaint(SPStyle *style, SPIPaint *paint, SPIPaint const *parent) { - sp_style_paint_clear(style, paint); - if ((paint->set && paint->currentcolor) || parent->currentcolor) { + bool isset = paint->set; + paint->clear(); + paint->set = isset; paint->currentcolor = TRUE; - paint->type = SP_PAINT_TYPE_COLOR; - sp_color_copy(&paint->value.color, &style->color.value.color); + paint->setColor(style->color.value.color); return; } - paint->type = parent->type; - switch (paint->type) { - case SP_PAINT_TYPE_COLOR: - sp_color_copy(&paint->value.color, &parent->value.color); - break; - case SP_PAINT_TYPE_PAINTSERVER: - if (parent->value.href) - sp_style_set_ipaint_to_uri(paint, parent->value.href->getURI()); - break; - case SP_PAINT_TYPE_NONE: - break; - default: - g_assert_not_reached(); - break; + paint->clear(); + if ( parent->isPaintserver() ) { + if (parent->value.href) { + sp_style_set_ipaint_to_uri(style, paint, parent->value.href->getURI(), parent->value.href->getOwnerDocument()); + } else { + g_warning("Expected paint server not found."); + } + } else if ( parent->isColor() ) { + paint->setColor( parent->value.color ); + } else if ( parent->isNoneSet() ) { + paint->noneSet = TRUE; + } else if ( parent->isNone() ) { + // + } else { + g_assert_not_reached(); } } @@ -2117,6 +2255,10 @@ sp_style_merge_ipaint(SPStyle *style, SPIPaint *paint, SPIPaint const *parent) static void sp_style_merge_ifilter(SPStyle *style, SPIFilter const *parent) { + // FIXME: + // instead of just copying over, we need to _really merge_ the two filters by combining their + // filter primitives + sp_style_filter_clear(style); style->filter.set = parent->set; style->filter.inherit = parent->inherit; @@ -2124,7 +2266,13 @@ sp_style_merge_ifilter(SPStyle *style, SPIFilter const *parent) if (style->filter.href && style->filter.href->getObject()) style->filter.href->detach(); - if (style->filter.href && parent->href) { + // it may be that this style has not yet created its SPFilterReference + if (!style->filter.href && style->object && SP_OBJECT_DOCUMENT(style->object)) { + style->filter.href = new SPFilterReference(SP_OBJECT_DOCUMENT(style->object)); + style->filter.href->changedSignal().connect(sigc::bind(sigc::ptr_fun(sp_style_filter_ref_changed), style)); + } + + if (style->filter.href && parent->href && parent->href->getObject()) { try { style->filter.href->attach(*parent->href->getURI()); } catch (Inkscape::BadURIException &e) { @@ -2179,77 +2327,110 @@ sp_style_write_string(SPStyle const *const style, guint const flags) p += sp_style_write_ienum(p, c + BMAX - p, "writing-mode", enum_writing_mode, &style->writing_mode, NULL, flags); p += sp_style_write_ienum(p, c + BMAX - p, "text-anchor", enum_text_anchor, &style->text_anchor, NULL, flags); + p += sp_style_write_ibaselineshift(p, c + BMAX - p, "baseline-shift", &style->baseline_shift, NULL, flags); + /// \todo fixme: Per type methods need default flag too (lauris) - p += sp_style_write_iscale24(p, c + BMAX - p, "opacity", &style->opacity, NULL, flags); - p += sp_style_write_ipaint(p, c + BMAX - p, "color", &style->color, NULL, flags); + + if (style->opacity.value != SP_SCALE24_MAX) { + p += sp_style_write_iscale24(p, c + BMAX - p, "opacity", &style->opacity, NULL, flags); + } + + if (!style->color.noneSet) { // CSS does not permit "none" for color + p += sp_style_write_ipaint(p, c + BMAX - p, "color", &style->color, NULL, flags); + } + p += sp_style_write_ipaint(p, c + BMAX - p, "fill", &style->fill, NULL, flags); - p += sp_style_write_iscale24(p, c + BMAX - p, "fill-opacity", &style->fill_opacity, NULL, flags); - p += sp_style_write_ienum(p, c + BMAX - p, "fill-rule", enum_fill_rule, &style->fill_rule, NULL, flags); + // if fill:none, skip writing fill properties + if (!style->fill.noneSet) { + p += sp_style_write_iscale24(p, c + BMAX - p, "fill-opacity", &style->fill_opacity, NULL, flags); + p += sp_style_write_ienum(p, c + BMAX - p, "fill-rule", enum_fill_rule, &style->fill_rule, NULL, flags); + } + p += sp_style_write_ipaint(p, c + BMAX - p, "stroke", &style->stroke, NULL, flags); - p += sp_style_write_ilength(p, c + BMAX - p, "stroke-width", &style->stroke_width, NULL, flags); - p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linecap", enum_stroke_linecap, &style->stroke_linecap, NULL, flags); - p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linejoin", enum_stroke_linejoin, &style->stroke_linejoin, NULL, flags); + // stroke width affects markers, so write it if there's stroke OR any markers + if (!style->stroke.noneSet || + style->marker[SP_MARKER_LOC].set || + style->marker[SP_MARKER_LOC_START].set || + style->marker[SP_MARKER_LOC_MID].set || + style->marker[SP_MARKER_LOC_END].set) { + p += sp_style_write_ilength(p, c + BMAX - p, "stroke-width", &style->stroke_width, NULL, flags); + } + + // if stroke:none, skip writing stroke properties + if (!style->stroke.noneSet) { + p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linecap", enum_stroke_linecap, &style->stroke_linecap, NULL, flags); + p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linejoin", enum_stroke_linejoin, &style->stroke_linejoin, NULL, flags); + p += sp_style_write_ifloat(p, c + BMAX - p, "stroke-miterlimit", &style->stroke_miterlimit, NULL, flags); + p += sp_style_write_iscale24(p, c + BMAX - p, "stroke-opacity", &style->stroke_opacity, NULL, flags); + + /** \todo fixme: */ + if ((flags == SP_STYLE_FLAG_ALWAYS) + || style->stroke_dasharray_set) + { + if (style->stroke_dasharray_inherit) { + p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:inherit;"); + } else if (style->stroke_dash.n_dash && style->stroke_dash.dash) { + p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:"); + gint i; + for (i = 0; i < style->stroke_dash.n_dash; i++) { + Inkscape::CSSOStringStream os; + if (i) { + os << ", "; + } + os << style->stroke_dash.dash[i]; + p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); + } + if (p < c + BMAX) { + *p++ = ';'; + } + } else { + p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:none;"); + } + } + + /** \todo fixme: */ + if (style->stroke_dashoffset_set) { + if (style->stroke_dashoffset_inherit) { + p += g_snprintf(p, c + BMAX - p, "stroke-dashoffset:inherit;"); + } else { + Inkscape::CSSOStringStream os; + os << "stroke-dashoffset:" << style->stroke_dash.offset << ";"; + p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); + } + } else if (flags == SP_STYLE_FLAG_ALWAYS) { + p += g_snprintf(p, c + BMAX - p, "stroke-dashoffset:0;"); + } + } + + bool marker_none = false; + gchar *master = style->marker[SP_MARKER_LOC].value; if (style->marker[SP_MARKER_LOC].set) { p += g_snprintf(p, c + BMAX - p, "marker:%s;", style->marker[SP_MARKER_LOC].value); } else if (flags == SP_STYLE_FLAG_ALWAYS) { p += g_snprintf(p, c + BMAX - p, "marker:none;"); + marker_none = true; } - if (style->marker[SP_MARKER_LOC_START].set) { + if (style->marker[SP_MARKER_LOC_START].set + && (!master || strcmp(master, style->marker[SP_MARKER_LOC_START].value))) { p += g_snprintf(p, c + BMAX - p, "marker-start:%s;", style->marker[SP_MARKER_LOC_START].value); - } else if (flags == SP_STYLE_FLAG_ALWAYS) { + } else if (flags == SP_STYLE_FLAG_ALWAYS && !marker_none) { p += g_snprintf(p, c + BMAX - p, "marker-start:none;"); } - if (style->marker[SP_MARKER_LOC_MID].set) { + if (style->marker[SP_MARKER_LOC_MID].set + && (!master || strcmp(master, style->marker[SP_MARKER_LOC_MID].value))) { p += g_snprintf(p, c + BMAX - p, "marker-mid:%s;", style->marker[SP_MARKER_LOC_MID].value); - } else if (flags == SP_STYLE_FLAG_ALWAYS) { + } else if (flags == SP_STYLE_FLAG_ALWAYS && !marker_none) { p += g_snprintf(p, c + BMAX - p, "marker-mid:none;"); } - if (style->marker[SP_MARKER_LOC_END].set) { + if (style->marker[SP_MARKER_LOC_END].set + && (!master || strcmp(master, style->marker[SP_MARKER_LOC_END].value))) { p += g_snprintf(p, c + BMAX - p, "marker-end:%s;", style->marker[SP_MARKER_LOC_END].value); - } else if (flags == SP_STYLE_FLAG_ALWAYS) { + } else if (flags == SP_STYLE_FLAG_ALWAYS && !marker_none) { p += g_snprintf(p, c + BMAX - p, "marker-end:none;"); } - p += sp_style_write_ifloat(p, c + BMAX - p, "stroke-miterlimit", &style->stroke_miterlimit, NULL, flags); - - /** \todo fixme: */ - if ((flags == SP_STYLE_FLAG_ALWAYS) - || style->stroke_dasharray_set) - { - if (style->stroke_dasharray_inherit) { - p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:inherit;"); - } else if (style->stroke_dash.n_dash && style->stroke_dash.dash) { - p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:"); - gint i; - for (i = 0; i < style->stroke_dash.n_dash; i++) { - Inkscape::CSSOStringStream os; - if (i) { - os << ", "; - } - os << style->stroke_dash.dash[i]; - p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); - } - if (p < c + BMAX) { - *p++ = ';'; - } - } else { - p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:none;"); - } - } - - /** \todo fixme: */ - if (style->stroke_dashoffset_set) { - Inkscape::CSSOStringStream os; - os << "stroke-dashoffset:" << style->stroke_dash.offset << ";"; - p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); - } else if (flags == SP_STYLE_FLAG_ALWAYS) { - p += g_snprintf(p, c + BMAX - p, "stroke-dashoffset:0;"); - } - - p += sp_style_write_iscale24(p, c + BMAX - p, "stroke-opacity", &style->stroke_opacity, NULL, flags); - p += sp_style_write_ienum(p, c + BMAX - p, "visibility", enum_visibility, &style->visibility, NULL, flags); p += sp_style_write_ienum(p, c + BMAX - p, "display", enum_display, &style->display, NULL, flags); p += sp_style_write_ienum(p, c + BMAX - p, "overflow", enum_overflow, &style->overflow, NULL, flags); @@ -2312,59 +2493,85 @@ sp_style_write_difference(SPStyle const *const from, SPStyle const *const to) p += sp_style_write_ienum(p, c + BMAX - p, "writing-mode", enum_writing_mode, &from->writing_mode, &to->writing_mode, SP_STYLE_FLAG_IFDIFF); p += sp_style_write_ienum(p, c + BMAX - p, "text-anchor", enum_text_anchor, &from->text_anchor, &to->text_anchor, SP_STYLE_FLAG_IFDIFF); + p += sp_style_write_ibaselineshift(p, c + BMAX - p, "baseline-shift", &from->baseline_shift, &to->baseline_shift, SP_STYLE_FLAG_IFDIFF); /// \todo fixme: Per type methods need default flag too if (from->opacity.set && from->opacity.value != SP_SCALE24_MAX) { p += sp_style_write_iscale24(p, c + BMAX - p, "opacity", &from->opacity, &to->opacity, SP_STYLE_FLAG_IFSET); } - p += sp_style_write_ipaint(p, c + BMAX - p, "color", &from->color, &to->color, SP_STYLE_FLAG_IFSET); + + if (!from->color.noneSet) { // CSS does not permit "none" for color + p += sp_style_write_ipaint(p, c + BMAX - p, "color", &from->color, &to->color, SP_STYLE_FLAG_IFSET); + } + p += sp_style_write_ipaint(p, c + BMAX - p, "fill", &from->fill, &to->fill, SP_STYLE_FLAG_IFDIFF); - p += sp_style_write_iscale24(p, c + BMAX - p, "fill-opacity", &from->fill_opacity, &to->fill_opacity, SP_STYLE_FLAG_IFDIFF); - p += sp_style_write_ienum(p, c + BMAX - p, "fill-rule", enum_fill_rule, &from->fill_rule, &to->fill_rule, SP_STYLE_FLAG_IFDIFF); + // if fill:none, skip writing fill properties + if (!from->fill.noneSet) { + p += sp_style_write_iscale24(p, c + BMAX - p, "fill-opacity", &from->fill_opacity, &to->fill_opacity, SP_STYLE_FLAG_IFDIFF); + p += sp_style_write_ienum(p, c + BMAX - p, "fill-rule", enum_fill_rule, &from->fill_rule, &to->fill_rule, SP_STYLE_FLAG_IFDIFF); + } + p += sp_style_write_ipaint(p, c + BMAX - p, "stroke", &from->stroke, &to->stroke, SP_STYLE_FLAG_IFDIFF); - p += sp_style_write_ilength(p, c + BMAX - p, "stroke-width", &from->stroke_width, &to->stroke_width, SP_STYLE_FLAG_IFDIFF); - p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linecap", enum_stroke_linecap, - &from->stroke_linecap, &to->stroke_linecap, SP_STYLE_FLAG_IFDIFF); - p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linejoin", enum_stroke_linejoin, - &from->stroke_linejoin, &to->stroke_linejoin, SP_STYLE_FLAG_IFDIFF); - p += sp_style_write_ifloat(p, c + BMAX - p, "stroke-miterlimit", - &from->stroke_miterlimit, &to->stroke_miterlimit, SP_STYLE_FLAG_IFDIFF); - /** \todo fixme: */ - if (from->stroke_dasharray_set) { - if (from->stroke_dasharray_inherit) { - p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:inherit;"); - } else if (from->stroke_dash.n_dash && from->stroke_dash.dash) { - p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:"); - for (gint i = 0; i < from->stroke_dash.n_dash; i++) { - Inkscape::CSSOStringStream os; - if (i) { - os << ", "; + + // stroke width affects markers, so write it if there's stroke OR any markers + if (!from->stroke.noneSet || + from->marker[SP_MARKER_LOC].set || + from->marker[SP_MARKER_LOC_START].set || + from->marker[SP_MARKER_LOC_MID].set || + from->marker[SP_MARKER_LOC_END].set) { + p += sp_style_write_ilength(p, c + BMAX - p, "stroke-width", &from->stroke_width, &to->stroke_width, SP_STYLE_FLAG_IFDIFF); + } + + // if stroke:none, skip writing stroke properties + if (!from->stroke.noneSet) { + p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linecap", enum_stroke_linecap, + &from->stroke_linecap, &to->stroke_linecap, SP_STYLE_FLAG_IFDIFF); + p += sp_style_write_ienum(p, c + BMAX - p, "stroke-linejoin", enum_stroke_linejoin, + &from->stroke_linejoin, &to->stroke_linejoin, SP_STYLE_FLAG_IFDIFF); + p += sp_style_write_ifloat(p, c + BMAX - p, "stroke-miterlimit", + &from->stroke_miterlimit, &to->stroke_miterlimit, SP_STYLE_FLAG_IFDIFF); + /** \todo fixme: */ + if (from->stroke_dasharray_set) { + if (from->stroke_dasharray_inherit) { + p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:inherit;"); + } else if (from->stroke_dash.n_dash && from->stroke_dash.dash) { + p += g_snprintf(p, c + BMAX - p, "stroke-dasharray:"); + for (gint i = 0; i < from->stroke_dash.n_dash; i++) { + Inkscape::CSSOStringStream os; + if (i) { + os << ", "; + } + os << from->stroke_dash.dash[i]; + p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); } - os << from->stroke_dash.dash[i]; + p += g_snprintf(p, c + BMAX - p, ";"); + } + } + /* fixme: */ + if (from->stroke_dashoffset_set) { + if (from->stroke_dashoffset_inherit) { + p += g_snprintf(p, c + BMAX - p, "stroke-dashoffset:inherit;"); + } else { + Inkscape::CSSOStringStream os; + os << "stroke-dashoffset:" << from->stroke_dash.offset << ";"; p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); } - p += g_snprintf(p, c + BMAX - p, ";"); } + p += sp_style_write_iscale24(p, c + BMAX - p, "stroke-opacity", &from->stroke_opacity, &to->stroke_opacity, SP_STYLE_FLAG_IFDIFF); } - /* fixme: */ - if (from->stroke_dashoffset_set) { - Inkscape::CSSOStringStream os; - os << "stroke-dashoffset:" << from->stroke_dash.offset << ";"; - p += g_strlcpy(p, os.str().c_str(), c + BMAX - p); - } - p += sp_style_write_iscale24(p, c + BMAX - p, "stroke-opacity", &from->stroke_opacity, &to->stroke_opacity, SP_STYLE_FLAG_IFDIFF); /* markers */ - if (from->marker[SP_MARKER_LOC].value != NULL) { - p += g_snprintf(p, c + BMAX - p, "marker:%s;", from->marker[SP_MARKER_LOC].value); + gchar *master = from->marker[SP_MARKER_LOC].value; + if (master != NULL) { + p += g_snprintf(p, c + BMAX - p, "marker:%s;", master); } - if (from->marker[SP_MARKER_LOC_START].value != NULL) { + if (from->marker[SP_MARKER_LOC_START].value != NULL && (!master || strcmp(master, from->marker[SP_MARKER_LOC_START].value))) { p += g_snprintf(p, c + BMAX - p, "marker-start:%s;", from->marker[SP_MARKER_LOC_START].value); } - if (from->marker[SP_MARKER_LOC_MID].value != NULL) { + if (from->marker[SP_MARKER_LOC_MID].value != NULL && (!master || strcmp(master, from->marker[SP_MARKER_LOC_MID].value))) { p += g_snprintf(p, c + BMAX - p, "marker-mid:%s;", from->marker[SP_MARKER_LOC_MID].value); } - if (from->marker[SP_MARKER_LOC_END].value != NULL) { + if (from->marker[SP_MARKER_LOC_END].value != NULL && (!master || strcmp(master, from->marker[SP_MARKER_LOC_END].value))) { p += g_snprintf(p, c + BMAX - p, "marker-end:%s;", from->marker[SP_MARKER_LOC_END].value); } @@ -2406,21 +2613,30 @@ sp_style_clear(SPStyle *style) { g_return_if_fail(style != NULL); - sp_style_paint_clear(style, &style->fill); - sp_style_paint_clear(style, &style->stroke); + style->fill.clear(); + style->stroke.clear(); sp_style_filter_clear(style); - if (style->fill.value.href) + if (style->fill.value.href) { delete style->fill.value.href; - if (style->stroke.value.href) + style->fill.value.href = NULL; + } + if (style->stroke.value.href) { delete style->stroke.value.href; - if (style->filter.href) + style->stroke.value.href = NULL; + } + if (style->filter.href) { delete style->filter.href; + style->filter.href = NULL; + } if (style->stroke_dash.dash) { g_free(style->stroke_dash.dash); } + style->stroke_dasharray_inherit = FALSE; + style->stroke_dashoffset_inherit = FALSE; + /** \todo fixme: Do that text manipulation via parents */ SPObject *object = style->object; SPDocument *document = style->document; @@ -2448,7 +2664,7 @@ sp_style_clear(SPStyle *style) style->text = text; style->text_private = text_private; - /* fixme: */ + style->text->font_specification.set = FALSE; style->text->font.set = FALSE; style->text->font_family.set = FALSE; @@ -2495,6 +2711,13 @@ sp_style_clear(SPStyle *style) style->word_spacing.normal = TRUE; style->word_spacing.value = style->word_spacing.computed = 0.0; + style->baseline_shift.set = FALSE; + style->baseline_shift.type = SP_BASELINE_SHIFT_LITERAL; + style->baseline_shift.unit = SP_CSS_UNIT_NONE; + style->baseline_shift.literal = SP_CSS_BASELINE_SHIFT_BASELINE; + style->baseline_shift.value = 0.0; + style->baseline_shift.computed = 0.0; + style->text_transform.set = FALSE; style->text_transform.value = style->text_transform.computed = SP_CSS_TEXT_TRANSFORM_NONE; @@ -2507,7 +2730,6 @@ sp_style_clear(SPStyle *style) style->writing_mode.set = FALSE; style->writing_mode.value = style->writing_mode.computed = SP_CSS_WRITING_MODE_LR_TB; - style->text_anchor.set = FALSE; style->text_anchor.value = style->text_anchor.computed = SP_CSS_TEXT_ANCHOR_START; @@ -2520,17 +2742,15 @@ sp_style_clear(SPStyle *style) style->overflow.set = FALSE; style->overflow.value = style->overflow.computed = SP_CSS_OVERFLOW_VISIBLE; - style->color.type = SP_PAINT_TYPE_COLOR; - sp_color_set_rgb_float(&style->color.value.color, 0.0, 0.0, 0.0); + style->color.clear(); + style->color.setColor(0.0, 0.0, 0.0); - style->fill.type = SP_PAINT_TYPE_COLOR; - sp_color_set_rgb_float(&style->fill.value.color, 0.0, 0.0, 0.0); + style->fill.clear(); + style->fill.setColor(0.0, 0.0, 0.0); style->fill_opacity.value = SP_SCALE24_MAX; style->fill_rule.value = style->fill_rule.computed = SP_WIND_RULE_NONZERO; - style->stroke.type = SP_PAINT_TYPE_NONE; - style->stroke.set = FALSE; - sp_color_set_rgb_float(&style->stroke.value.color, 0.0, 0.0, 0.0); + style->stroke.clear(); style->stroke_opacity.value = SP_SCALE24_MAX; style->stroke_width.set = FALSE; @@ -2630,8 +2850,9 @@ sp_text_style_new() ts->refcount = 1; sp_text_style_clear(ts); - ts->font.value = g_strdup("Bitstream Vera Sans"); - ts->font_family.value = g_strdup("Bitstream Vera Sans"); + ts->font_specification.value = g_strdup("Sans"); + ts->font.value = g_strdup("Sans"); + ts->font_family.value = g_strdup("Sans"); return ts; } @@ -2643,6 +2864,7 @@ sp_text_style_new() static void sp_text_style_clear(SPTextStyle *ts) { + ts->font_specification.set = FALSE; ts->font.set = FALSE; ts->font_family.set = FALSE; } @@ -2658,6 +2880,7 @@ sp_text_style_unref(SPTextStyle *st) st->refcount -= 1; if (st->refcount < 1) { + g_free(st->font_specification.value); g_free(st->font.value); g_free(st->font_family.value); g_free(st); @@ -2677,6 +2900,7 @@ sp_text_style_duplicate_unset(SPTextStyle *st) SPTextStyle *nt = g_new0(SPTextStyle, 1); nt->refcount = 1; + nt->font_specification.value = g_strdup(st->font_specification.value); nt->font.value = g_strdup(st->font.value); nt->font_family.value = g_strdup(st->font_family.value); @@ -2698,6 +2922,7 @@ sp_text_style_write(gchar *p, guint const len, SPTextStyle const *const st, guin flags = SP_STYLE_FLAG_IFSET; d += sp_style_write_istring(p + d, len - d, "font-family", &st->font_family, NULL, flags); + d += sp_style_write_istring(p + d, len - d, "-inkscape-font-specification", &st->font_specification, NULL, flags); return d; } @@ -2748,7 +2973,7 @@ sp_style_read_iscale24(SPIScale24 *val, gchar const *str) if (sp_svg_number_read_f(str, &value)) { val->set = TRUE; val->inherit = FALSE; - value = CLAMP(value, 0.0f, (gfloat) SP_SCALE24_MAX); + value = CLAMP(value, 0.0, 1.0); val->value = SP_SCALE24_FROM_FLOAT(value); } } @@ -2950,6 +3175,8 @@ sp_style_read_itextdecoration(SPITextDecoration *val, gchar const *str) static void sp_style_read_icolor(SPIPaint *paint, gchar const *str, SPStyle *style, SPDocument *document) { + (void)style; // TODO + (void)document; // TODO paint->currentcolor = FALSE; /* currentColor not a valid . */ if (!strcmp(str, "inherit")) { paint->set = TRUE; @@ -2957,8 +3184,7 @@ sp_style_read_icolor(SPIPaint *paint, gchar const *str, SPStyle *style, SPDocume } else { guint32 const rgb0 = sp_svg_read_color(str, 0xff); if (rgb0 != 0xff) { - paint->type = SP_PAINT_TYPE_COLOR; - sp_color_set_rgb_rgba32(&paint->value.color, rgb0); + paint->setColor(rgb0); paint->set = TRUE; paint->inherit = FALSE; } @@ -2971,67 +3197,63 @@ sp_style_read_icolor(SPIPaint *paint, gchar const *str, SPStyle *style, SPDocume * * \pre paint == \&style.fill || paint == \&style.stroke. */ -static void -sp_style_read_ipaint(SPIPaint *paint, gchar const *str, SPStyle *style, SPDocument *document) +void SPIPaint::read( gchar const *str, SPStyle &style, SPDocument *document ) { - while (isspace(*str)) { + while (g_ascii_isspace(*str)) { ++str; } + clear(); + if (streq(str, "inherit")) { - paint->set = TRUE; - paint->inherit = TRUE; - paint->currentcolor = FALSE; - } else if (streq(str, "currentColor") && paint != &style->color) { - paint->set = TRUE; - paint->inherit = FALSE; - paint->currentcolor = TRUE; - } else if (streq(str, "none") && paint != &style->color) { - paint->type = SP_PAINT_TYPE_NONE; - paint->set = TRUE; - paint->inherit = FALSE; - paint->currentcolor = FALSE; - } else if (strneq(str, "url", 3) && paint != &style->color) { - gchar *uri = extract_uri(str); - if(uri == NULL || uri[0] == '\0') { - paint->type = SP_PAINT_TYPE_NONE; - return; - } - paint->type = SP_PAINT_TYPE_PAINTSERVER; - paint->set = TRUE; - paint->inherit = FALSE; - paint->currentcolor = FALSE; + set = TRUE; + inherit = TRUE; + } else { + if ( strneq(str, "url", 3) ) { + gchar *uri = extract_uri( str, &str ); + while ( g_ascii_isspace(*str) ) { + ++str; + } + // TODO check on and comment the comparrison "paint != &style->color". + if ( uri && *uri && (this != &style.color) ) { + set = TRUE; + + // it may be that this style's SPIPaint has not yet created its URIReference; + // now that we have a document, we can create it here + if (!value.href && document) { + value.href = new SPPaintServerReference(document); + value.href->changedSignal().connect(sigc::bind(sigc::ptr_fun((this == &style.fill)? sp_style_fill_paint_server_ref_changed : sp_style_stroke_paint_server_ref_changed), &style)); + } - // it may be that this style's SPIPaint has not yet created its URIReference; - // now that we have a document, we can create it here - if (!paint->value.href && document) { - paint->value.href = new SPPaintServerReference(document); - paint->value.href->changedSignal().connect(sigc::bind(sigc::ptr_fun((paint == &style->fill)? sp_style_fill_paint_server_ref_changed : sp_style_stroke_paint_server_ref_changed), style)); + // TODO check what this does in light of move away from union + sp_style_set_ipaint_to_uri_string (&style, this, uri); + } + g_free( uri ); } - sp_style_set_ipaint_to_uri_string (paint, uri); - - g_free (uri); - - } else { - guint32 const rgb0 = sp_svg_read_color(str, &str, 0xff); - if (rgb0 != 0xff) { - paint->type = SP_PAINT_TYPE_COLOR; - sp_color_set_rgb_rgba32(&paint->value.color, rgb0); - paint->set = TRUE; - paint->inherit = FALSE; - paint->currentcolor = FALSE; + if (streq(str, "currentColor") && (this != &style.color)) { + set = TRUE; + currentcolor = TRUE; + } else if (streq(str, "none") && (this != &style.color)) { + set = TRUE; + noneSet = TRUE; + } else { + guint32 const rgb0 = sp_svg_read_color(str, &str, 0xff); + if (rgb0 != 0xff) { + setColor( rgb0 ); + set = TRUE; - while (g_ascii_isspace(*str)) { - ++str; - } - if (strneq(str, "icc-color(", 10)) { - SVGICCColor* tmp = new SVGICCColor(); - if ( ! sp_svg_read_icc_color( str, &str, tmp ) ) { - delete tmp; - tmp = 0; + while (g_ascii_isspace(*str)) { + ++str; + } + if (strneq(str, "icc-color(", 10)) { + SVGICCColor* tmp = new SVGICCColor(); + if ( ! sp_svg_read_icc_color( str, &str, tmp ) ) { + delete tmp; + tmp = 0; + } + value.color.icc = tmp; } - paint->value.iccColor = tmp; } } } @@ -3049,6 +3271,7 @@ sp_style_read_ifontsize(SPIFontSize *val, gchar const *str) val->set = TRUE; val->inherit = TRUE; } else if ((*str == 'x') || (*str == 's') || (*str == 'm') || (*str == 'l')) { + // xx-small, x-small, etc. for (unsigned i = 0; enum_font_size[i].key; i++) { if (!strcmp(str, enum_font_size[i].key)) { val->set = TRUE; @@ -3104,6 +3327,45 @@ sp_style_read_ifontsize(SPIFontSize *val, gchar const *str) } +/** + * Set SPIBaselineShift object from string. + */ +static void +sp_style_read_ibaselineshift(SPIBaselineShift *val, gchar const *str) +{ + if (!strcmp(str, "inherit")) { + val->set = TRUE; + val->inherit = TRUE; + } else if ((*str == 'b') || (*str == 's')) { + // baseline or sub or super + for (unsigned i = 0; enum_baseline_shift[i].key; i++) { + if (!strcmp(str, enum_baseline_shift[i].key)) { + val->set = TRUE; + val->inherit = FALSE; + val->type = SP_BASELINE_SHIFT_LITERAL; + val->literal = enum_baseline_shift[i].value; + return; + } + } + /* Invalid */ + return; + } else { + SPILength length; + sp_style_read_ilength(&length, str); + val->set = length.set; + val->inherit = length.inherit; + val->unit = length.unit; + val->value = length.value; + val->computed = length.computed; + if( val->unit == SP_CSS_UNIT_PERCENT ) { + val->type = SP_BASELINE_SHIFT_PERCENTAGE; + } else { + val->type = SP_BASELINE_SHIFT_LENGTH; + } + return; + } +} + /** * Set SPIFilter object from string. @@ -3117,12 +3379,12 @@ sp_style_read_ifilter(gchar const *str, SPStyle * style, SPDocument *document) f->set = TRUE; f->inherit = TRUE; if (f->href && f->href->getObject()) - f->href->detach(); + f->href->detach(); } else if(streq(str, "none")) { f->set = TRUE; f->inherit = FALSE; if (f->href && f->href->getObject()) - f->href->detach(); + f->href->detach(); } else if (strneq(str, "url", 3)) { char *uri = extract_uri(str); if(uri == NULL || uri[0] == '\0') { @@ -3156,7 +3418,7 @@ sp_style_read_ifilter(gchar const *str, SPStyle * style, SPDocument *document) f->set = FALSE; f->inherit = FALSE; if (f->href && f->href->getObject()) - f->href->detach(); + f->href->detach(); } } @@ -3201,6 +3463,19 @@ sp_style_read_pfontsize(SPIFontSize *val, Inkscape::XML::Node *repr, gchar const } +/** + * Set SPIBaselineShift object from repr attribute. + */ +static void +sp_style_read_pbaselineshift(SPIBaselineShift *val, Inkscape::XML::Node *repr, gchar const *key) +{ + gchar const *str = repr->attribute(key); + if (str) { + sp_style_read_ibaselineshift(val, str); + } +} + + /** * Set SPIFloat object from repr attribute. */ @@ -3308,8 +3583,10 @@ sp_style_write_istring(gchar *p, gint const len, gchar const *const key, return g_snprintf(p, len, "%s:inherit;", key); } else { gchar *val_quoted = css2_escape_quote(val->value); - return g_snprintf(p, len, "%s:%s;", key, val_quoted); - g_free (val_quoted); + if (val_quoted) { + return g_snprintf(p, len, "%s:%s;", key, val_quoted); + g_free (val_quoted); + } } } return 0; @@ -3506,18 +3783,30 @@ sp_style_write_itextdecoration(gchar *p, gint const len, gchar const *const key, static bool sp_paint_differ(SPIPaint const *const a, SPIPaint const *const b) { - if (a->type != b->type) + if ( (a->isColor() != b->isColor()) + || (a->isPaintserver() != b->isPaintserver()) + || (a->set != b->set) + || (a->currentcolor != b->currentcolor) + || (a->inherit!= b->inherit) ) { return true; - if (a->type == SP_PAINT_TYPE_COLOR) - return !(sp_color_is_equal(&a->value.color, &b->value.color) - && ((a->value.iccColor == b->value.iccColor) - || (a->value.iccColor && b->value.iccColor - && (a->value.iccColor->colorProfile == b->value.iccColor->colorProfile) - && (a->value.iccColor->colors == b->value.iccColor->colors)))); + } + + // TODO refactor to allow for mixed paints (rgb() *and* url(), etc) + + if ( a->isPaintserver() ) { + return (a->value.href == NULL || b->value.href == NULL || a->value.href->getObject() != b->value.href->getObject()); + } + + if ( a->isColor() ) { + return !( (a->value.color == b->value.color) + && ((a->value.color.icc == b->value.color.icc) + || (a->value.color.icc && b->value.color.icc + && (a->value.color.icc->colorProfile == b->value.color.icc->colorProfile) + && (a->value.color.icc->colors == b->value.color.icc->colors)))); /* todo: Allow for epsilon differences in iccColor->colors, e.g. changes small enough not to show up * in the string representation. */ - if (a->type == SP_PAINT_TYPE_PAINTSERVER) - return (a->value.href == NULL || b->value.href == NULL || a->value.href->getObject() != b->value.href->getObject()); + } + return false; } @@ -3530,43 +3819,66 @@ static gint sp_style_write_ipaint(gchar *b, gint const len, gchar const *const key, SPIPaint const *const paint, SPIPaint const *const base, guint const flags) { + int retval = 0; + if ((flags & SP_STYLE_FLAG_ALWAYS) || ((flags & SP_STYLE_FLAG_IFSET) && paint->set) || ((flags & SP_STYLE_FLAG_IFDIFF) && paint->set && (!base->set || sp_paint_differ(paint, base)))) { + CSSOStringStream css; + if (paint->inherit) { - return g_snprintf(b, len, "%s:inherit;", key); - } else if (paint->currentcolor) { - return g_snprintf(b, len, "%s:currentColor;", key); + css << "inherit"; } else { - switch (paint->type) { - case SP_PAINT_TYPE_COLOR: { - char color_buf[8]; - sp_svg_write_color(color_buf, sizeof(color_buf), sp_color_get_rgba32_ualpha(&paint->value.color, 0)); - if (paint->value.iccColor) { - CSSOStringStream css; - css << color_buf << " icc-color(" << paint->value.iccColor->colorProfile; - for (vector::const_iterator i(paint->value.iccColor->colors.begin()), - iEnd(paint->value.iccColor->colors.end()); - i != iEnd; ++i) { - css << ", " << *i; - } - css << ')'; - return g_snprintf(b, len, "%s:%s;", key, css.gcharp()); - } else { - return g_snprintf(b, len, "%s:%s;", key, color_buf); - } + if ( paint->value.href && paint->value.href->getURI() ) { + const gchar* uri = paint->value.href->getURI()->toString(); + css << "url(" << uri << ")"; + } + + if ( paint->noneSet ) { + if ( !css.str().empty() ) { + css << " "; } - case SP_PAINT_TYPE_PAINTSERVER: - return g_snprintf(b, len, "%s:url(%s);", key, paint->value.href? paint->value.href->getURI()->toString() : ""); - default: - break; + css << "none"; } - return g_snprintf(b, len, "%s:none;", key); + + if ( paint->currentcolor ) { + if ( !css.str().empty() ) { + css << " "; + } + css << "currentColor"; + } + + if ( paint->colorSet && !paint->currentcolor ) { + if ( !css.str().empty() ) { + css << " "; + } + char color_buf[8]; + sp_svg_write_color(color_buf, sizeof(color_buf), paint->value.color.toRGBA32( 0 )); + css << color_buf; + } + + if (paint->value.color.icc && !paint->currentcolor) { + if ( !css.str().empty() ) { + css << " "; + } + css << "icc-color(" << paint->value.color.icc->colorProfile; + for (vector::const_iterator i(paint->value.color.icc->colors.begin()), + iEnd(paint->value.color.icc->colors.end()); + i != iEnd; ++i) { + css << ", " << *i; + } + css << ')'; + } + } + + if ( !css.str().empty() ) { + retval = g_snprintf( b, len, "%s:%s;", key, css.str().c_str() ); } } - return 0; + + return retval; } @@ -3624,6 +3936,67 @@ sp_style_write_ifontsize(gchar *p, gint const len, gchar const *key, } +/* + * baseline-shift is relative to parent. The only time it should + * not be written out is if it is zero (or not set). + */ +static bool +sp_baseline_shift_notzero(SPIBaselineShift const *const a ) +{ + if( a->type == SP_BASELINE_SHIFT_LITERAL ) { + if( a->literal == SP_CSS_BASELINE_SHIFT_BASELINE ) { + return false; + } + } else { + if( a->value == 0.0 ) { + return false; + } + } + return true; +} + +/** + * Write SPIBaselineShift object into string. + */ +static gint +sp_style_write_ibaselineshift(gchar *p, gint const len, gchar const *key, + SPIBaselineShift const *const val, SPIBaselineShift const *const base, + guint const flags) +{ + if ((flags & SP_STYLE_FLAG_ALWAYS) + || ((flags & SP_STYLE_FLAG_IFSET) && val->set) + || ((flags & SP_STYLE_FLAG_IFDIFF) && val->set + && (!base->set || sp_baseline_shift_notzero(val) ))) + { + if (val->inherit) { + return g_snprintf(p, len, "%s:inherit;", key); + } else if (val->type == SP_BASELINE_SHIFT_LITERAL) { + for (unsigned i = 0; enum_baseline_shift[i].key; i++) { + if (enum_baseline_shift[i].value == static_cast< gint > (val->literal) ) { + return g_snprintf(p, len, "%s:%s;", key, enum_baseline_shift[i].key); + } + } + } else if (val->type == SP_BASELINE_SHIFT_LENGTH) { + if( val->unit == SP_CSS_UNIT_EM || val->unit == SP_CSS_UNIT_EX ) { + Inkscape::CSSOStringStream os; + os << key << ":" << val->value << (val->unit == SP_CSS_UNIT_EM ? "em;" : "ex;"); + return g_strlcpy(p, os.str().c_str(), len); + } else { + Inkscape::CSSOStringStream os; + os << key << ":" << val->computed << "px;"; // must specify px, see inkscape bug 1221626, mozilla bug 234789 + return g_strlcpy(p, os.str().c_str(), len); + } + } else if (val->type == SP_BASELINE_SHIFT_PERCENTAGE) { + Inkscape::CSSOStringStream os; + os << key << ":" << (val->value * 100.0) << "%;"; + return g_strlcpy(p, os.str().c_str(), len); + } + } + return 0; +} + + + /** * Write SPIFilter object into string. */ @@ -3632,6 +4005,7 @@ sp_style_write_ifilter(gchar *p, gint const len, gchar const *key, SPIFilter const *const val, SPIFilter const *const base, guint const flags) { + (void)base; // TODO if ((flags & SP_STYLE_FLAG_ALWAYS) || ((flags & SP_STYLE_FLAG_IFSET) && val->set) || ((flags & SP_STYLE_FLAG_IFDIFF) && val->set)) @@ -3647,19 +4021,30 @@ sp_style_write_ifilter(gchar *p, gint const len, gchar const *key, return 0; } - -/** - * Clear paint object, and disconnect style from paintserver (if present). - */ -static void -sp_style_paint_clear(SPStyle *style, SPIPaint *paint) +SPIPaint::SPIPaint() : + set(0), + inherit(0), + currentcolor(0), + colorSet(0), + noneSet(0), + value() { - if (paint->value.href && paint->value.href->getObject()) - paint->value.href->detach(); + value.color.set( 0 ); + value.href = 0; +} - paint->type = SP_PAINT_TYPE_NONE; - delete paint->value.iccColor; - paint->value.iccColor = NULL; +void SPIPaint::clear() +{ + set = false; + inherit = false; + currentcolor = false; + colorSet = false; + noneSet = false; + value.color.set( 0 ); + if ( value.href && value.href->getObject() ) + { + value.href->detach(); + } } @@ -3670,7 +4055,7 @@ static void sp_style_filter_clear(SPStyle *style) { if (style->filter.href && style->filter.href->getObject()) - style->filter.href->detach(); + style->filter.href->detach(); } @@ -3683,13 +4068,15 @@ sp_style_set_property_url (SPObject *item, gchar const *property, SPObject *link if (repr == NULL) return; - g_return_if_fail(linked != NULL); - - gchar *val = g_strdup_printf("url(#%s)", SP_OBJECT_ID(linked)); - SPCSSAttr *css = sp_repr_css_attr_new(); - sp_repr_css_set_property(css, property, val); - g_free(val); + if (linked) { + gchar *val = g_strdup_printf("url(#%s)", linked->getId()); + sp_repr_css_set_property(css, property, val); + g_free(val); + } else { + sp_repr_css_unset_property(css, "filter"); + } + if (recursive) { sp_repr_css_change_recursive(repr, css, "style"); } else { @@ -3761,6 +4148,9 @@ sp_style_unset_property_attrs(SPObject *o) if (style->stroke_dashoffset_set) { repr->setAttribute("stroke-dashoffset", NULL); } + if (style->text_private && style->text->font_specification.set) { + repr->setAttribute("-inkscape-font-specification", NULL); + } if (style->text_private && style->text->font_family.set) { repr->setAttribute("font-family", NULL); } @@ -3820,6 +4210,7 @@ SPCSSAttr * sp_css_attr_unset_text(SPCSSAttr *css) { sp_repr_css_set_property(css, "font", NULL); // not implemented yet + sp_repr_css_set_property(css, "-inkscape-font-specification", NULL); sp_repr_css_set_property(css, "font-size", NULL); sp_repr_css_set_property(css, "font-size-adjust", NULL); // not implemented yet sp_repr_css_set_property(css, "font-style", NULL); @@ -3841,7 +4232,7 @@ sp_css_attr_unset_text(SPCSSAttr *css) sp_repr_css_set_property(css, "kerning", NULL); // not implemented yet sp_repr_css_set_property(css, "dominant-baseline", NULL); // not implemented yet sp_repr_css_set_property(css, "alignment-baseline", NULL); // not implemented yet - sp_repr_css_set_property(css, "baseline-shift", NULL); // not implemented yet + sp_repr_css_set_property(css, "baseline-shift", NULL); return css; } @@ -3872,6 +4263,7 @@ sp_css_attr_unset_uris(SPCSSAttr *css) if (is_url(sp_repr_css_property(css, "color-profile", NULL))) sp_repr_css_set_property(css, "color-profile", NULL); if (is_url(sp_repr_css_property(css, "cursor", NULL))) sp_repr_css_set_property(css, "cursor", NULL); if (is_url(sp_repr_css_property(css, "filter", NULL))) sp_repr_css_set_property(css, "filter", NULL); + if (is_url(sp_repr_css_property(css, "marker", NULL))) sp_repr_css_set_property(css, "marker", NULL); if (is_url(sp_repr_css_property(css, "marker-start", NULL))) sp_repr_css_set_property(css, "marker-start", NULL); if (is_url(sp_repr_css_property(css, "marker-mid", NULL))) sp_repr_css_set_property(css, "marker-mid", NULL); if (is_url(sp_repr_css_property(css, "marker-end", NULL))) sp_repr_css_set_property(css, "marker-end", NULL);