X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fscreen_song.c;h=d7b6d2c51d5b4feb7e52be03d6d39f67bb838064;hb=6305a540396ba2936673c1ddd0d2fbfeac3dcb9e;hp=8250f1623d6949389b40df3cecc3ceab203fce84;hpb=ced48779aaa0408b6ff9ed558aca9d0e12be2400;p=ncmpc.git

diff --git a/src/screen_song.c b/src/screen_song.c
index 8250f16..d7b6d2c 100644
--- a/src/screen_song.c
+++ b/src/screen_song.c
@@ -1,5 +1,5 @@
 /* ncmpc (Ncurses MPD Client)
- * (c) 2004-2010 The Music Player Daemon Project
+ * (c) 2004-2017 The Music Player Daemon Project
  * Project homepage: http://musicpd.org
  *
  * This program is free software; you can redistribute it and/or modify
@@ -25,7 +25,7 @@
 #include "i18n.h"
 #include "screen.h"
 #include "charset.h"
-#include "utils.h"
+#include "time_format.h"
 #include "mpdclient.h"
 
 #include <mpd/client.h>
@@ -112,19 +112,6 @@ screen_song_clear(void)
 	}
 }
 
-static void
-screen_song_paint(void);
-
-/**
- * Repaint and update the screen.
- */
-static void
-screen_song_repaint(void)
-{
-	screen_song_paint();
-	wrefresh(lw->w);
-}
-
 static const char *
 screen_song_list_callback(unsigned idx, gcc_unused void *data)
 {
@@ -135,7 +122,7 @@ screen_song_list_callback(unsigned idx, gcc_unused void *data)
 
 
 static void
-screen_song_init(WINDOW *w, int cols, int rows)
+screen_song_init(WINDOW *w, unsigned cols, unsigned rows)
 {
 	for (unsigned i = 0; i < G_N_ELEMENTS(tag_labels); ++i) {
 		if (tag_labels[i] != NULL) {
@@ -173,7 +160,7 @@ screen_song_exit(void)
 }
 
 static void
-screen_song_resize(int cols, int rows)
+screen_song_resize(unsigned cols, unsigned rows)
 {
 	list_window_resize(lw, cols, rows);
 }
@@ -226,9 +213,12 @@ screen_song_append(const char *label, const char *value, unsigned label_col)
 
 		char *p = g_strdup(value_iter);
 		unsigned width = utf8_cut_width(p, value_col);
-		if (width == 0)
+		if (width == 0) {
 			/* not enough room for anything - bail out */
+			g_free(entry);
+			g_free(p);
 			break;
+		}
 
 		*entry_iter = 0;
 
@@ -371,21 +361,31 @@ audio_format_to_string(char *buffer, size_t size,
 {
 #if LIBMPDCLIENT_CHECK_VERSION(2,10,0)
 	if (format->bits == MPD_SAMPLE_FORMAT_FLOAT) {
-		g_snprintf(buffer, size, _("%u:f:%u"),
+		g_snprintf(buffer, size, "%u:f:%u",
 			   format->sample_rate,
 			   format->channels);
 		return;
 	}
 
 	if (format->bits == MPD_SAMPLE_FORMAT_DSD) {
-		g_snprintf(buffer, size, _("%u:dsd:%u"),
+		if (format->sample_rate > 0 &&
+		    format->sample_rate % 44100 == 0) {
+			/* use shortcuts such as "dsd64" which implies the
+			   sample rate */
+			g_snprintf(buffer, size, "dsd%u:%u",
+				   format->sample_rate * 8 / 44100,
+				   format->channels);
+			return;
+		}
+
+		g_snprintf(buffer, size, "%u:dsd:%u",
 			   format->sample_rate,
 			   format->channels);
 		return;
 	}
 #endif
 
-	g_snprintf(buffer, size, _("%u:%u:%u"),
+	g_snprintf(buffer, size, "%u:%u:%u",
 		   format->sample_rate, format->bits,
 		   format->channels);
 }
@@ -449,14 +449,14 @@ screen_song_update(struct mpdclient *c)
 		mpdclient_handle_error(c);
 
 	list_window_set_length(lw, current.lines->len);
-	screen_song_repaint();
+	screen_song_paint();
 }
 
 static bool
 screen_song_cmd(struct mpdclient *c, command_t cmd)
 {
 	if (list_window_scroll_cmd(lw, cmd)) {
-		screen_song_repaint();
+		screen_song_paint();
 		return true;
 	}
 
@@ -502,7 +502,7 @@ screen_song_cmd(struct mpdclient *c, command_t cmd)
 	if (screen_find(lw, cmd, screen_song_list_callback, NULL)) {
 		/* center the row */
 		list_window_center(lw, lw->selected);
-		screen_song_repaint();
+		screen_song_paint();
 		return true;
 	}