X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Frrd_fetch.c;h=7c7234dbedb82789a2f1472a6ee7324425048162;hb=51c3d3fb997c22e1ee828470413f1e84989e1f6c;hp=ad3bdb3821c7f8949e4f7b09420058092a904997;hpb=ba531669d795b10244c358135249016c5898519b;p=pkg-rrdtool.git diff --git a/src/rrd_fetch.c b/src/rrd_fetch.c index ad3bdb3..7c7234d 100644 --- a/src/rrd_fetch.c +++ b/src/rrd_fetch.c @@ -1,9 +1,9 @@ /***************************************************************************** - * RRDtool 1.3rc6 Copyright by Tobi Oetiker, 1997-2008 + * RRDtool 1.3.8 Copyright by Tobi Oetiker, 1997-2009 ***************************************************************************** * rrd_fetch.c read date from an rrd to use for further processing ***************************************************************************** - * $Id: rrd_fetch.c 1380 2008-05-26 08:56:58Z oetiker $ + * $Id: rrd_fetch.c 1801 2009-05-19 13:45:05Z oetiker $ * $Log$ * Revision 1.8 2004/05/18 18:53:03 oetiker * big spell checking patch -- slif@bellsouth.net @@ -52,6 +52,10 @@ * *****************************************************************************/ +#ifdef WIN32 +#include +#endif + #include "rrd_tool.h" #include "rrd_is_thread_safe.h" @@ -73,7 +77,7 @@ int rrd_fetch( time_t start_tmp = 0, end_tmp = 0; const char *cf; - struct rrd_time_value start_tv, end_tv; + rrd_time_value_t start_tv, end_tv; char *parsetime_error = NULL; struct option long_options[] = { {"resolution", required_argument, 0, 'r'}, @@ -86,8 +90,8 @@ int rrd_fetch( opterr = 0; /* initialize getopt */ /* init start and end time */ - parsetime("end-24h", &start_tv); - parsetime("now", &end_tv); + rrd_parsetime("end-24h", &start_tv); + rrd_parsetime("now", &end_tv); while (1) { int option_index = 0; @@ -100,13 +104,13 @@ int rrd_fetch( switch (opt) { case 's': - if ((parsetime_error = parsetime(optarg, &start_tv))) { + if ((parsetime_error = rrd_parsetime(optarg, &start_tv))) { rrd_set_error("start time: %s", parsetime_error); return -1; } break; case 'e': - if ((parsetime_error = parsetime(optarg, &end_tv))) { + if ((parsetime_error = rrd_parsetime(optarg, &end_tv))) { rrd_set_error("end time: %s", parsetime_error); return -1; } @@ -121,7 +125,7 @@ int rrd_fetch( } - if (proc_start_end(&start_tv, &end_tv, &start_tmp, &end_tmp) == -1) { + if (rrd_proc_start_end(&start_tv, &end_tv, &start_tmp, &end_tmp) == -1) { return -1; } @@ -227,7 +231,7 @@ int rrd_fetch_fn( } for (i = 0; (unsigned long) i < rrd.stat_head->ds_cnt; i++) { - if ((((*ds_namv)[i]) = malloc(sizeof(char) * DS_NAM_SIZE)) == NULL) { + if ((((*ds_namv)[i]) = (char*)malloc(sizeof(char) * DS_NAM_SIZE)) == NULL) { rrd_set_error("malloc fetch ds_namv entry"); goto err_free_ds_namv; } @@ -327,7 +331,7 @@ int rrd_fetch_fn( ** database is the one with time stamp (t+s) which means t to t+s. */ *ds_cnt = rrd.stat_head->ds_cnt; - if (((*data) = malloc(*ds_cnt * rows * sizeof(rrd_value_t))) == NULL) { + if (((*data) = (rrd_value_t *)malloc(*ds_cnt * rows * sizeof(rrd_value_t))) == NULL) { rrd_set_error("malloc fetch data area"); goto err_free_all_ds_namv; } @@ -355,21 +359,27 @@ int rrd_fetch_fn( /* fill the gap at the start if needs be */ - if (start_offset <= 0) - rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1; - else - rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1 + start_offset; - - if (rrd_seek(rrd_file, (rra_base + (rra_pointer * (*ds_cnt) - * sizeof(rrd_value_t))), + if (*start <= rra_end_time && *end >= rra_start_time - *step){ + + if (start_offset <= 0) + rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1; + else + rra_pointer = rrd.rra_ptr[chosen_rra].cur_row + 1 + start_offset; + + rra_pointer = rra_pointer % (signed) rrd.rra_def[chosen_rra].row_cnt; + + if (rrd_seek(rrd_file, (rra_base + (rra_pointer * (*ds_cnt) + * sizeof(rrd_value_t))), SEEK_SET) != 0) { - rrd_set_error("seek error in RRA"); - goto err_free_data; - } + rrd_set_error("seek error in RRA"); + goto err_free_data; + } #ifdef DEBUG - fprintf(stderr, "First Seek: rra_base %lu rra_pointer %lu\n", + fprintf(stderr, "First Seek: rra_base %lu rra_pointer %lu\n", rra_base, rra_pointer); #endif + } + /* step trough the array */ for (i = start_offset; @@ -433,6 +443,8 @@ int rrd_fetch_fn( } rrd_close(rrd_file); + rrd_free(&rrd); + return (0); err_free_data: free(*data);