X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fpencil-context.cpp;h=5aa9efbd91f7add0250a9bc6c6bf9e95d86201a0;hb=b26887f4a85399d9d5598b8523d56da89dc385fd;hp=894b5cd71878f986f131359ed36c02f76e571540;hpb=1d0b394330fa71e860830f533fc62a8b9aa5a72b;p=inkscape.git diff --git a/src/pencil-context.cpp b/src/pencil-context.cpp index 894b5cd71..5aa9efbd9 100644 --- a/src/pencil-context.cpp +++ b/src/pencil-context.cpp @@ -27,10 +27,11 @@ #include "message-context.h" #include "modifier-fns.h" #include "sp-path.h" -#include "prefs-utils.h" +#include "preferences.h" #include "snap.h" #include "pixmaps/cursor-pencil.xpm" -#include "display/bezier-utils.h" +#include <2geom/sbasis-to-bezier.h> +#include <2geom/bezier-utils.h> #include "display/canvas-bpath.h" #include #include "libnr/in-svg-plane.h" @@ -41,6 +42,7 @@ #include "desktop-style.h" #include "macros.h" #include "display/curve.h" +#include "livarot/Path.h" static void sp_pencil_context_class_init(SPPencilContextClass *klass); static void sp_pencil_context_init(SPPencilContext *pc); @@ -52,16 +54,18 @@ static gint pencil_handle_button_press(SPPencilContext *const pc, GdkEventButton static gint pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mevent); static gint pencil_handle_button_release(SPPencilContext *const pc, GdkEventButton const &revent); static gint pencil_handle_key_press(SPPencilContext *const pc, guint const keyval, guint const state); +static gint pencil_handle_key_release(SPPencilContext *const pc, guint const keyval, guint const state); -static void spdc_set_startpoint(SPPencilContext *pc, NR::Point const p); -static void spdc_set_endpoint(SPPencilContext *pc, NR::Point const p); +static void spdc_set_startpoint(SPPencilContext *pc, Geom::Point const p); +static void spdc_set_endpoint(SPPencilContext *pc, Geom::Point const p); static void spdc_finish_endpoint(SPPencilContext *pc); -static void spdc_add_freehand_point(SPPencilContext *pc, NR::Point p, guint state); +static void spdc_add_freehand_point(SPPencilContext *pc, Geom::Point p, guint state); static void fit_and_split(SPPencilContext *pc); - +static void interpolate(SPPencilContext *pc); +static void sketch_interpolate(SPPencilContext *pc); static SPDrawContextClass *pencil_parent_class; -static NR::Point pencil_drag_origin_w(0, 0); +static Geom::Point pencil_drag_origin_w(0, 0); static bool pencil_within_tolerance = false; /** @@ -121,7 +125,11 @@ sp_pencil_context_init(SPPencilContext *pc) pc->npoints = 0; pc->state = SP_PENCIL_CONTEXT_IDLE; - pc->req_tangent = NR::Point(0, 0); + pc->req_tangent = Geom::Point(0, 0); + + // since SPPencilContext is not properly constructed... + pc->sketch_interpolation = Geom::Piecewise >(); + pc->sketch_n = 0; } /** @@ -130,7 +138,8 @@ sp_pencil_context_init(SPPencilContext *pc) static void sp_pencil_context_setup(SPEventContext *ec) { - if (prefs_get_int_attribute("tools.freehand.pencil", "selcue", 0) != 0) { + Inkscape::Preferences *prefs = Inkscape::Preferences::get(); + if (prefs->getBool("/tools/freehand/pencil/selcue")) { ec->enableSelectionCue(); } @@ -152,7 +161,7 @@ sp_pencil_context_dispose(GObject *object) /** Snaps new node relative to the previous node. */ static void -spdc_endpoint_snap(SPPencilContext const *pc, NR::Point &p, guint const state) +spdc_endpoint_snap(SPPencilContext const *pc, Geom::Point &p, guint const state) { if ((state & GDK_CONTROL_MASK)) { //CTRL enables constrained snapping spdc_endpoint_snap_rotation(pc, p, pc->p[0], state); @@ -192,6 +201,10 @@ sp_pencil_context_root_handler(SPEventContext *const ec, GdkEvent *event) ret = pencil_handle_key_press(pc, get_group0_keyval (&event->key), event->key.state); break; + case GDK_KEY_RELEASE: + ret = pencil_handle_key_release(pc, get_group0_keyval (&event->key), event->key.state); + break; + default: break; } @@ -222,15 +235,15 @@ pencil_handle_button_press(SPPencilContext *const pc, GdkEventButton const &beve return TRUE; } - NR::Point const button_w(bevent.x, bevent.y); + Geom::Point const button_w(bevent.x, bevent.y); /* Find desktop coordinates */ - NR::Point p = pc->desktop->w2d(button_w); + Geom::Point p = pc->desktop->w2d(button_w); /* Test whether we hit any anchor. */ SPDrawAnchor *anchor = spdc_test_inside(pc, button_w); - pencil_drag_origin_w = NR::Point(bevent.x,bevent.y); + pencil_drag_origin_w = Geom::Point(bevent.x,bevent.y); pencil_within_tolerance = true; switch (pc->state) { @@ -240,8 +253,14 @@ pencil_handle_button_press(SPPencilContext *const pc, GdkEventButton const &beve break; default: /* Set first point of sequence */ + SnapManager &m = desktop->namedview->snap_manager; + m.setup(desktop); + if (bevent.state & GDK_CONTROL_MASK) { - freehand_create_single_dot(event_context, p, "tools.freehand.pencil", bevent.state); + if (!(bevent.state & GDK_SHIFT_MASK)) { + m.freeSnapReturnByRef(p, Inkscape::SNAPSOURCE_NODE_HANDLE); + } + spdc_create_single_dot(event_context, p, "/tools/freehand/pencil", bevent.state); ret = true; break; } @@ -251,17 +270,15 @@ pencil_handle_button_press(SPPencilContext *const pc, GdkEventButton const &beve } else { if (!(bevent.state & GDK_SHIFT_MASK)) { - // This is the first click of a new curve; deselect item so that // this curve is not combined with it (unless it is drawn from its // anchor, which is handled by the sibling branch above) selection->clear(); desktop->messageStack()->flash(Inkscape::NORMAL_MESSAGE, _("Creating new path")); - SnapManager &m = desktop->namedview->snap_manager; - m.setup(desktop); - m.freeSnapReturnByRef(Inkscape::Snapper::SNAPPOINT_NODE, p); + m.freeSnapReturnByRef(p, Inkscape::SNAPSOURCE_NODE_HANDLE); } else if (selection->singleItem() && SP_IS_PATH(selection->singleItem())) { desktop->messageStack()->flash(Inkscape::NORMAL_MESSAGE, _("Appending to selected path")); + m.freeSnapReturnByRef(p, Inkscape::SNAPSOURCE_NODE_HANDLE); } } pc->sa = anchor; @@ -278,6 +295,8 @@ pencil_handle_button_press(SPPencilContext *const pc, GdkEventButton const &beve static gint pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mevent) { + SPDesktop *const dt = pc->desktop; + if ((mevent.state & GDK_CONTROL_MASK) && (mevent.state & GDK_BUTTON1_MASK)) { // mouse was accidentally moved during Ctrl+click; // ignore the motion and create a single point @@ -285,7 +304,6 @@ pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mev return TRUE; } gint ret = FALSE; - SPDesktop *const dt = pc->desktop; SPEventContext *event_context = SP_EVENT_CONTEXT(pc); if (event_context->space_panning || mevent.state & GDK_BUTTON2_MASK || mevent.state & GDK_BUTTON3_MASK) { @@ -303,15 +321,15 @@ pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mev } /* Find desktop coordinates */ - NR::Point p = dt->w2d(NR::Point(mevent.x, mevent.y)); + Geom::Point p = dt->w2d(Geom::Point(mevent.x, mevent.y)); /* Test whether we hit any anchor. */ - SPDrawAnchor *anchor = spdc_test_inside(pc, NR::Point(mevent.x, mevent.y)); + SPDrawAnchor *anchor = spdc_test_inside(pc, Geom::Point(mevent.x, mevent.y)); if (pencil_within_tolerance) { - gint const tolerance = prefs_get_int_attribute_limited("options.dragtolerance", - "value", 0, 0, 100); - if ( NR::LInfty( NR::Point(mevent.x,mevent.y) - pencil_drag_origin_w ) < tolerance ) { + Inkscape::Preferences *prefs = Inkscape::Preferences::get(); + gint const tolerance = prefs->getIntLimited("/options/dragtolerance/value", 0, 0, 100); + if ( Geom::LInfty( Geom::Point(mevent.x,mevent.y) - pencil_drag_origin_w ) < tolerance ) { return FALSE; // Do not drag if we're within tolerance from origin. } } @@ -327,7 +345,9 @@ pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mev if (anchor) { p = anchor->dp; } else { - spdc_endpoint_snap(pc, p, mevent.state); + Geom::Point ptnr(p); + spdc_endpoint_snap(pc, ptnr, mevent.state); + p = ptnr; } spdc_set_endpoint(pc, p); ret = TRUE; @@ -335,7 +355,11 @@ pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mev default: /* We may be idle or already freehand */ if ( mevent.state & GDK_BUTTON1_MASK && pc->is_drawing ) { + if (pc->state == SP_PENCIL_CONTEXT_IDLE) { + sp_event_context_discard_delayed_snap_event(event_context); + } pc->state = SP_PENCIL_CONTEXT_FREEHAND; + if ( !pc->sa && !pc->green_anchor ) { /* Create green anchor */ pc->green_anchor = sp_draw_anchor_new(pc, pc->green_curve, TRUE, pc->p[0]); @@ -346,12 +370,9 @@ pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mev */ if (anchor) { p = anchor->dp; - } else if ((mevent.state & GDK_SHIFT_MASK) == 0) { - SnapManager &m = dt->namedview->snap_manager; - m.setup(dt, NULL); - m.freeSnapReturnByRef(Inkscape::Snapper::SNAPPOINT_NODE, p); } - if ( pc->npoints != 0 ) { // buttonpress may have happened before we entered draw context! + + if ( pc->npoints != 0) { // buttonpress may have happened before we entered draw context! spdc_add_freehand_point(pc, p, mevent.state); ret = TRUE; } @@ -374,6 +395,11 @@ pencil_handle_motion_notify(SPPencilContext *const pc, GdkEventMotion const &mev pc->_message_context->clear(); pc->anchor_statusbar = false; } + if (sp_event_context_knot_mouseover(pc)) { + SnapManager &m = dt->namedview->snap_manager; + m.setup(dt); + m.preSnap(Inkscape::SnapCandidatePoint(p, Inkscape::SNAPSOURCE_NODE_HANDLE)); + } } break; } @@ -392,10 +418,10 @@ pencil_handle_button_release(SPPencilContext *const pc, GdkEventButton const &re pc->is_drawing = false; /* Find desktop coordinates */ - NR::Point p = dt->w2d(NR::Point(revent.x, revent.y)); + Geom::Point p = dt->w2d(Geom::Point(revent.x, revent.y)); /* Test whether we hit any anchor. */ - SPDrawAnchor *anchor = spdc_test_inside(pc, NR::Point(revent.x, + SPDrawAnchor *anchor = spdc_test_inside(pc, Geom::Point(revent.x, revent.y)); switch (pc->state) { @@ -419,28 +445,45 @@ pencil_handle_button_release(SPPencilContext *const pc, GdkEventButton const &re spdc_set_endpoint(pc, p); spdc_finish_endpoint(pc); pc->state = SP_PENCIL_CONTEXT_IDLE; + sp_event_context_discard_delayed_snap_event(event_context); ret = TRUE; break; case SP_PENCIL_CONTEXT_FREEHAND: - /* Finish segment now */ - /// \todo fixme: Clean up what follows (Lauris) - if (anchor) { - p = anchor->dp; - } - pc->ea = anchor; - /* Write curves to object */ + if (revent.state & GDK_MOD1_MASK) { + /* sketch mode: interpolate the sketched path and improve the current output path with the new interpolation. don't finish sketch */ - dt->messageStack()->flash(Inkscape::NORMAL_MESSAGE, _("Finishing freehand")); + sketch_interpolate(pc); - spdc_concat_colors_and_flush(pc, FALSE); - pc->sa = NULL; - pc->ea = NULL; - if (pc->green_anchor) { - pc->green_anchor = sp_draw_anchor_destroy(pc->green_anchor); + if (pc->green_anchor) { + pc->green_anchor = sp_draw_anchor_destroy(pc->green_anchor); + } + + pc->state = SP_PENCIL_CONTEXT_SKETCH; + } else { + /* Finish segment now */ + /// \todo fixme: Clean up what follows (Lauris) + if (anchor) { + p = anchor->dp; + } + pc->ea = anchor; + /* Write curves to object */ + + dt->messageStack()->flash(Inkscape::NORMAL_MESSAGE, _("Finishing freehand")); + + interpolate(pc); + spdc_concat_colors_and_flush(pc, FALSE); + pc->sa = NULL; + pc->ea = NULL; + if (pc->green_anchor) { + pc->green_anchor = sp_draw_anchor_destroy(pc->green_anchor); + } + pc->state = SP_PENCIL_CONTEXT_IDLE; + // reset sketch mode too + pc->sketch_n = 0; } - pc->state = SP_PENCIL_CONTEXT_IDLE; ret = TRUE; break; + case SP_PENCIL_CONTEXT_SKETCH: default: break; } @@ -457,7 +500,7 @@ pencil_handle_button_release(SPPencilContext *const pc, GdkEventButton const &re } static void -pencil_cancel (SPPencilContext *const pc) +pencil_cancel (SPPencilContext *const pc) { if (pc->grab) { /* Release grab now */ @@ -466,8 +509,8 @@ pencil_cancel (SPPencilContext *const pc) } pc->is_drawing = false; - pc->state = SP_PENCIL_CONTEXT_IDLE; + sp_event_context_discard_delayed_snap_event(SP_EVENT_CONTEXT(pc)); pc->red_curve->reset(); sp_canvas_bpath_set_bpath(SP_CANVAS_BPATH(pc->red_bpath), NULL); @@ -486,7 +529,6 @@ pencil_cancel (SPPencilContext *const pc) sp_canvas_end_forced_full_redraws(pc->desktop->canvas); } - static gint pencil_handle_key_press(SPPencilContext *const pc, guint const keyval, guint const state) { @@ -504,7 +546,7 @@ pencil_handle_key_press(SPPencilContext *const pc, guint const keyval, guint con case GDK_Escape: if (pc->npoints != 0) { // if drawing, cancel, otherwise pass it up for deselecting - if (pc->is_drawing) { + if (pc->state != SP_PENCIL_CONTEXT_IDLE) { pencil_cancel (pc); ret = TRUE; } @@ -514,7 +556,7 @@ pencil_handle_key_press(SPPencilContext *const pc, guint const keyval, guint con case GDK_Z: if (mod_ctrl_only(state) && pc->npoints != 0) { // if drawing, cancel, otherwise pass it up for undo - if (pc->is_drawing) { + if (pc->state != SP_PENCIL_CONTEXT_IDLE) { pencil_cancel (pc); ret = TRUE; } @@ -523,10 +565,47 @@ pencil_handle_key_press(SPPencilContext *const pc, guint const keyval, guint con case GDK_g: case GDK_G: if (mod_shift_only(state)) { - sp_selection_to_guides(); + sp_selection_to_guides(SP_EVENT_CONTEXT(pc)->desktop); ret = true; } break; + case GDK_Alt_L: + case GDK_Alt_R: + case GDK_Meta_L: + case GDK_Meta_R: + if (pc->state == SP_PENCIL_CONTEXT_IDLE) { + pc->desktop->messageStack()->flash(Inkscape::NORMAL_MESSAGE, _("Sketch mode: holding Alt interpolates between sketched paths. Release Alt to finalize.")); + } + break; + default: + break; + } + return ret; +} + +static gint +pencil_handle_key_release(SPPencilContext *const pc, guint const keyval, guint const /*state*/) +{ + gint ret = FALSE; + switch (keyval) { + case GDK_Alt_L: + case GDK_Alt_R: + case GDK_Meta_L: + case GDK_Meta_R: + if (pc->state == SP_PENCIL_CONTEXT_SKETCH) { + spdc_concat_colors_and_flush(pc, FALSE); + pc->sketch_n = 0; + pc->sa = NULL; + pc->ea = NULL; + if (pc->green_anchor) { + pc->green_anchor = sp_draw_anchor_destroy(pc->green_anchor); + } + pc->state = SP_PENCIL_CONTEXT_IDLE; + sp_event_context_discard_delayed_snap_event(SP_EVENT_CONTEXT(pc)); + pc->desktop->messageStack()->flash(Inkscape::NORMAL_MESSAGE, _("Finishing freehand sketch")); + ret = TRUE; + } + break; default: break; } @@ -537,7 +616,7 @@ pencil_handle_key_press(SPPencilContext *const pc, guint const keyval, guint con * Reset points and set new starting point. */ static void -spdc_set_startpoint(SPPencilContext *const pc, NR::Point const p) +spdc_set_startpoint(SPPencilContext *const pc, Geom::Point const p) { pc->npoints = 0; pc->red_curve_is_valid = false; @@ -557,7 +636,7 @@ spdc_set_startpoint(SPPencilContext *const pc, NR::Point const p) * We change RED curve. */ static void -spdc_set_endpoint(SPPencilContext *const pc, NR::Point const p) +spdc_set_endpoint(SPPencilContext *const pc, Geom::Point const p) { if (pc->npoints == 0) { return; @@ -595,7 +674,7 @@ static void spdc_finish_endpoint(SPPencilContext *const pc) { if ( ( pc->red_curve->is_empty() ) - || ( pc->red_curve->first_point() == pc->red_curve->second_point() ) ) + || ( *(pc->red_curve->first_point()) == *(pc->red_curve->second_point()) ) ) { pc->red_curve->reset(); sp_canvas_bpath_set_bpath(SP_CANVAS_BPATH(pc->red_bpath), NULL); @@ -607,8 +686,9 @@ spdc_finish_endpoint(SPPencilContext *const pc) } } + static void -spdc_add_freehand_point(SPPencilContext *pc, NR::Point p, guint /*state*/) +spdc_add_freehand_point(SPPencilContext *pc, Geom::Point p, guint /*state*/) { g_assert( pc->npoints > 0 ); g_return_if_fail(unsigned(pc->npoints) < G_N_ELEMENTS(pc->p)); @@ -616,6 +696,7 @@ spdc_add_freehand_point(SPPencilContext *pc, NR::Point p, guint /*state*/) if ( ( p != pc->p[ pc->npoints - 1 ] ) && in_svg_plane(p) ) { + pc->ps.push_back(p); pc->p[pc->npoints++] = p; fit_and_split(pc); } @@ -627,21 +708,174 @@ square(double const x) return x * x; } +static void +interpolate(SPPencilContext *pc) +{ + if ( pc->ps.size() <= 1 ) { + return; + } + + Inkscape::Preferences *prefs = Inkscape::Preferences::get(); + double const tol = prefs->getDoubleLimited("/tools/freehand/pencil/tolerance", 10.0, 1.0, 100.0) * 0.4; + double const tolerance_sq = 0.02 * square( pc->desktop->w2d().descrim() * + tol) * exp(0.2*tol - 2); + + g_assert(is_zero(pc->req_tangent) + || is_unit_vector(pc->req_tangent)); + Geom::Point const tHatEnd(0, 0); + + guint n_points = pc->ps.size(); + pc->green_curve->reset(); + pc->red_curve->reset(); + pc->red_curve_is_valid = false; + + Geom::Point * b = g_new(Geom::Point, 4*n_points); + Geom::Point * points = g_new(Geom::Point, 4*n_points); + for (unsigned int i = 0; i < pc->ps.size(); i++) { + points[i] = pc->ps[i]; + } + + // worst case gives us a segment per point + int max_segs = 4*n_points; + + int const n_segs = Geom::bezier_fit_cubic_r(b, points, n_points, + tolerance_sq, max_segs); + + if ( n_segs > 0) + { + /* Fit and draw and reset state */ + pc->green_curve->moveto(b[0]); + for (int c = 0; c < n_segs; c++) { + pc->green_curve->curveto(b[4*c+1], b[4*c+2], b[4*c+3]); + } + sp_canvas_bpath_set_bpath(SP_CANVAS_BPATH(pc->red_bpath), pc->green_curve); + + /* Fit and draw and copy last point */ + g_assert(!pc->green_curve->is_empty()); + + /* Set up direction of next curve. */ + { + Geom::CubicBezier const * last_seg = dynamic_cast(pc->green_curve->last_segment()); + g_assert( last_seg ); // Relevance: validity of (*last_seg)[2] + pc->p[0] = last_seg->finalPoint(); + pc->npoints = 1; + Geom::Point const req_vec( pc->p[0] - (*last_seg)[2] ); + pc->req_tangent = ( ( Geom::is_zero(req_vec) || !in_svg_plane(req_vec) ) + ? Geom::Point(0, 0) + : Geom::unit_vector(req_vec) ); + } + } + g_free(b); + g_free(points); + pc->ps.clear(); +} + + +/* interpolates the sketched curve and tweaks the current sketch interpolation*/ +static void +sketch_interpolate(SPPencilContext *pc) +{ + if ( pc->ps.size() <= 1 ) { + return; + } + + Inkscape::Preferences *prefs = Inkscape::Preferences::get(); + double const tol = prefs->getDoubleLimited("/tools/freehand/pencil/tolerance", 10.0, 1.0, 100.0) * 0.4; + double const tolerance_sq = 0.02 * square( pc->desktop->w2d().descrim() * + tol) * exp(0.2*tol - 2); + + bool average_all_sketches = prefs->getBool("/tools/freehand/pencil/average_all_sketches", true); + + g_assert(is_zero(pc->req_tangent) + || is_unit_vector(pc->req_tangent)); + Geom::Point const tHatEnd(0, 0); + + guint n_points = pc->ps.size(); + pc->red_curve->reset(); + pc->red_curve_is_valid = false; + + Geom::Point * b = g_new(Geom::Point, 4*n_points); + Geom::Point * points = g_new(Geom::Point, 4*n_points); + for (unsigned i = 0; i < pc->ps.size(); i++) { + points[i] = pc->ps[i]; + } + + // worst case gives us a segment per point + int max_segs = 4*n_points; + + int const n_segs = Geom::bezier_fit_cubic_r(b, points, n_points, + tolerance_sq, max_segs); + + if ( n_segs > 0) + { + Geom::Path fit(b[0]); + for (int c = 0; c < n_segs; c++) { + fit.appendNew(b[4*c+1], b[4*c+2], b[4*c+3]); + } + Geom::Piecewise > fit_pwd2 = fit.toPwSb(); + + double t =0.; + if ( pc->sketch_n > 0 ) { + if (average_all_sketches) { + // Average = (sum of all) / n + // = (sum of all + new one) / n+1 + // = ((old average)*n + new one) / n+1 + t = pc->sketch_n / (pc->sketch_n + 1.); + } else { + t = 0.5; + } + pc->sketch_interpolation = Geom::lerp(t, fit_pwd2, pc->sketch_interpolation); + // simplify path, to eliminate small segments + Path *path = new Path; + path->LoadPathVector(Geom::path_from_piecewise(pc->sketch_interpolation, 0.01)); + path->Simplify(0.5); + Geom::PathVector *pathv = path->MakePathVector(); + pc->sketch_interpolation = (*pathv)[0].toPwSb(); + delete path; + delete pathv; + } else { + pc->sketch_interpolation = fit_pwd2; + } + pc->sketch_n++; + + pc->green_curve->reset(); + pc->green_curve->set_pathvector(Geom::path_from_piecewise(pc->sketch_interpolation, 0.01)); + sp_canvas_bpath_set_bpath(SP_CANVAS_BPATH(pc->red_bpath), pc->green_curve); + + /* Fit and draw and copy last point */ + g_assert(!pc->green_curve->is_empty()); + + /* Set up direction of next curve. */ + { + Geom::CubicBezier const * last_seg = dynamic_cast(pc->green_curve->last_segment()); + g_assert( last_seg ); // Relevance: validity of (*last_seg)[2] + pc->p[0] = last_seg->finalPoint(); + pc->npoints = 1; + Geom::Point const req_vec( pc->p[0] - (*last_seg)[2] ); + pc->req_tangent = ( ( Geom::is_zero(req_vec) || !in_svg_plane(req_vec) ) + ? Geom::Point(0, 0) + : Geom::unit_vector(req_vec) ); + } + } + g_free(b); + g_free(points); + pc->ps.clear(); +} + static void fit_and_split(SPPencilContext *pc) { g_assert( pc->npoints > 1 ); - double const tol = prefs_get_double_attribute_limited("tools.freehand.pencil", "tolerance", 10.0, 1.0, 100.0); - double const tolerance_sq = 0.02 * square( NR::expansion(pc->desktop->w2d()) * tol) - * exp(0.2*tol - 2); + double const tolerance_sq = 0; - NR::Point b[4]; + Geom::Point b[4]; g_assert(is_zero(pc->req_tangent) || is_unit_vector(pc->req_tangent)); - NR::Point const tHatEnd(0, 0); - int const n_segs = sp_bezier_fit_cubic_full(b, NULL, pc->p, pc->npoints, - pc->req_tangent, tHatEnd, tolerance_sq, 1); + Geom::Point const tHatEnd(0, 0); + int const n_segs = Geom::bezier_fit_cubic_full(b, NULL, pc->p, pc->npoints, + pc->req_tangent, tHatEnd, + tolerance_sq, 1); if ( n_segs > 0 && unsigned(pc->npoints) < G_N_ELEMENTS(pc->p) ) { @@ -662,10 +896,10 @@ fit_and_split(SPPencilContext *pc) g_assert( last_seg ); // Relevance: validity of (*last_seg)[2] pc->p[0] = last_seg->finalPoint(); pc->npoints = 1; - NR::Point const req_vec( pc->p[0] - (*last_seg)[2] ); - pc->req_tangent = ( ( NR::is_zero(req_vec) || !in_svg_plane(req_vec) ) - ? NR::Point(0, 0) - : NR::unit_vector(req_vec) ); + Geom::Point const req_vec( pc->p[0] - (*last_seg)[2] ); + pc->req_tangent = ( ( Geom::is_zero(req_vec) || !in_svg_plane(req_vec) ) + ? Geom::Point(0, 0) + : Geom::unit_vector(req_vec) ); } pc->green_curve->append_continuous(pc->red_curve, 0.0625);