X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fexec.c;h=4c45dc158a267951cde5a8d608fe25be905f0a61;hb=d13a04dc3645a21acecc14a4174837766ecb6a2b;hp=a90563346f70673857a7588330eb9568774f5751;hpb=94e562250296b1435e3e48cd302055d89c4c702b;p=collectd.git

diff --git a/src/exec.c b/src/exec.c
old mode 100755
new mode 100644
index a9056334..4c45dc15
--- a/src/exec.c
+++ b/src/exec.c
@@ -18,11 +18,12 @@
  * 51 Franklin St, Fifth Floor, Boston, MA  02110-1301 USA
  *
  * Authors:
- *   Florian octo Forster <octo at verplant.org>
+ *   Florian octo Forster <octo at collectd.org>
  *   Sebastian Harl <sh at tokkee.org>
  *   Peter Holik <peter at holik.at>
  **/
 
+#define _DEFAULT_SOURCE
 #define _BSD_SOURCE /* For setgroups */
 
 #include "collectd.h"
@@ -125,7 +126,7 @@ static int exec_config_exec (oconfig_item_t *ci) /* {{{ */
     return (-1);
   }
 
-  pl = (program_list_t *) malloc (sizeof (program_list_t));
+  pl = malloc (sizeof (*pl));
   if (pl == NULL)
   {
     ERROR ("exec plugin: malloc failed.");
@@ -162,7 +163,7 @@ static int exec_config_exec (oconfig_item_t *ci) /* {{{ */
     return (-1);
   }
 
-  pl->argv = (char **) malloc (ci->values_num * sizeof (char *));
+  pl->argv = malloc (ci->values_num * sizeof (*pl->argv));
   if (pl->argv == NULL)
   {
     ERROR ("exec plugin: malloc failed.");
@@ -354,18 +355,7 @@ static void reset_signal_mask (void) /* {{{ */
   sigprocmask (SIG_SETMASK, &ss, /* old mask = */ NULL);
 } /* }}} void reset_signal_mask */
 
-static void close_pipe(int fd_pipe[2])
-{
-  if(fd_pipe[0] != -1) {
-    close(fd_pipe[0]);
-  }
-
-  if(fd_pipe[1] != -1) {
-    close(fd_pipe[1]);
-  }
-}
-
-static int create_pipe(int fd_pipe[2])
+static int create_pipe (int fd_pipe[2]) /* {{{ */
 {
   char errbuf[1024];
   int status;
@@ -379,7 +369,16 @@ static int create_pipe(int fd_pipe[2])
   }
 
   return 0;
-}
+} /* }}} int create_pipe */
+
+static void close_pipe (int fd_pipe[2]) /* {{{ */
+{
+  if (fd_pipe[0] != -1)
+    close (fd_pipe[0]);
+
+  if (fd_pipe[1] != -1)
+    close (fd_pipe[1]);
+} /* }}} void close_pipe */
 
 /*
  * Creates three pipes (one for reading, one for writing and one for errors),
@@ -407,9 +406,10 @@ static int fork_child (program_list_t *pl, int *fd_in, int *fd_out, int *fd_err)
   if (pl->pid != 0)
     return (-1);
 
-  if(create_pipe(fd_pipe_in) == -1 || create_pipe(fd_pipe_out) == -1 || create_pipe(fd_pipe_err) == -1) {
+  if ((create_pipe(fd_pipe_in) == -1)
+      || (create_pipe(fd_pipe_out) == -1)
+      || (create_pipe(fd_pipe_err) == -1))
     goto failed;
-  }
 
   sp_ptr = NULL;
   status = getpwnam_r (pl->user, &sp, nambuf, sizeof (nambuf), &sp_ptr);
@@ -869,8 +869,7 @@ static int exec_notification (const notification_t *n, /* {{{ */
     if (pl->pid != 0)
       continue;
 
-    pln = (program_list_and_notification_t *) malloc (sizeof
-        (program_list_and_notification_t));
+    pln = malloc (sizeof (*pln));
     if (pln == NULL)
     {
       ERROR ("exec plugin: malloc failed.");