X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fcore%2Fstore.c;h=401780e054bad02bf160bb807a971f02af0808a7;hb=b76ed3a2a95b45fb9a75cfd01613d826bebc9bb9;hp=d185431f976de168213aa769ceee8bd2a7f16482;hpb=130c971dd9197cd1e1724ea80b25c44d2cdd9b01;p=sysdb.git diff --git a/src/core/store.c b/src/core/store.c index d185431..401780e 100644 --- a/src/core/store.c +++ b/src/core/store.c @@ -32,8 +32,8 @@ #include "sysdb.h" #include "core/store-private.h" #include "core/plugin.h" +#include "utils/avltree.h" #include "utils/error.h" -#include "utils/llist.h" #include @@ -49,7 +49,7 @@ * private variables */ -static sdb_llist_t *host_list = NULL; +static sdb_avltree_t *hosts = NULL; static pthread_rwlock_t host_lock = PTHREAD_RWLOCK_INITIALIZER; /* @@ -58,6 +58,7 @@ static pthread_rwlock_t host_lock = PTHREAD_RWLOCK_INITIALIZER; static sdb_type_t sdb_host_type; static sdb_type_t sdb_service_type; +static sdb_type_t sdb_metric_type; static sdb_type_t sdb_attribute_type; static int @@ -102,10 +103,13 @@ sdb_host_init(sdb_object_t *obj, va_list ap) if (ret) return ret; - sobj->services = sdb_llist_create(); + sobj->services = sdb_avltree_create(); if (! sobj->services) return -1; - sobj->attributes = sdb_llist_create(); + sobj->metrics = sdb_avltree_create(); + if (! sobj->metrics) + return -1; + sobj->attributes = sdb_avltree_create(); if (! sobj->attributes) return -1; return 0; @@ -120,9 +124,11 @@ sdb_host_destroy(sdb_object_t *obj) store_obj_destroy(obj); if (sobj->services) - sdb_llist_destroy(sobj->services); + sdb_avltree_destroy(sobj->services); + if (sobj->metrics) + sdb_avltree_destroy(sobj->metrics); if (sobj->attributes) - sdb_llist_destroy(sobj->attributes); + sdb_avltree_destroy(sobj->attributes); } /* sdb_host_destroy */ static int @@ -136,7 +142,7 @@ sdb_service_init(sdb_object_t *obj, va_list ap) if (ret) return ret; - sobj->attributes = sdb_llist_create(); + sobj->attributes = sdb_avltree_create(); if (! sobj->attributes) return -1; return 0; @@ -151,9 +157,45 @@ sdb_service_destroy(sdb_object_t *obj) store_obj_destroy(obj); if (sobj->attributes) - sdb_llist_destroy(sobj->attributes); + sdb_avltree_destroy(sobj->attributes); } /* sdb_service_destroy */ +static int +sdb_metric_init(sdb_object_t *obj, va_list ap) +{ + sdb_metric_t *sobj = METRIC(obj); + int ret; + + /* this will consume the first argument (type) of ap */ + ret = store_obj_init(obj, ap); + if (ret) + return ret; + + sobj->attributes = sdb_avltree_create(); + if (! sobj->attributes) + return -1; + + sobj->store.type = sobj->store.id = NULL; + return 0; +} /* sdb_metric_init */ + +static void +sdb_metric_destroy(sdb_object_t *obj) +{ + sdb_metric_t *sobj = METRIC(obj); + assert(obj); + + store_obj_destroy(obj); + + if (sobj->attributes) + sdb_avltree_destroy(sobj->attributes); + + if (sobj->store.type) + free(sobj->store.type); + if (sobj->store.id) + free(sobj->store.id); +} /* sdb_metric_destroy */ + static int sdb_attr_init(sdb_object_t *obj, va_list ap) { @@ -194,6 +236,12 @@ static sdb_type_t sdb_service_type = { sdb_service_destroy }; +static sdb_type_t sdb_metric_type = { + sizeof(sdb_metric_t), + sdb_metric_init, + sdb_metric_destroy +}; + static sdb_type_t sdb_attribute_type = { sizeof(sdb_attribute_t), sdb_attr_init, @@ -207,93 +255,66 @@ static sdb_type_t sdb_attribute_type = { static sdb_host_t * lookup_host(const char *name) { - return HOST(sdb_llist_search_by_name(host_list, name)); + return HOST(sdb_avltree_lookup(hosts, name)); } /* lookup_host */ -/* The host_lock has to be acquired before calling this function. */ static int -store_obj(const char *hostname, int type, const char *name, - sdb_time_t last_update, sdb_store_obj_t **updated_obj) +record_backend(sdb_store_obj_t *obj) { - char *host_cname = NULL, *cname = NULL; - char **tmp; - - sdb_llist_t *parent_list; - sdb_store_obj_t *old, *new; const sdb_plugin_info_t *info; - - int status = 0; + char **tmp; size_t i; - if (last_update <= 0) - last_update = sdb_gettime(); - - assert((type == 0) - || (type == SDB_HOST) - || (type == SDB_SERVICE) - || (type == SDB_ATTRIBUTE)); + info = sdb_plugin_current(); + if (! info) + return 0; - assert(hostname || (type == SDB_HOST)); - assert((! hostname) - || (type == SDB_SERVICE) - || (type == SDB_ATTRIBUTE)); + for (i = 0; i < obj->backends_num; ++i) + if (!strcasecmp(obj->backends[i], info->plugin_name)) + return 0; - if (! host_list) - if (! (host_list = sdb_llist_create())) - return -1; - parent_list = host_list; + tmp = realloc(obj->backends, + (obj->backends_num + 1) * sizeof(*obj->backends)); + if (! tmp) + return -1; - if (type == SDB_HOST) { - cname = sdb_plugin_cname(strdup(name)); - if (! cname) { - sdb_log(SDB_LOG_ERR, "store: strdup failed"); - return -1; - } - name = cname; - } + obj->backends = tmp; + obj->backends[obj->backends_num] = strdup(info->plugin_name); + if (! obj->backends[obj->backends_num]) + return -1; - if (hostname) { - sdb_host_t *host; + ++obj->backends_num; + return 0; +} /* record_backend */ - host_cname = sdb_plugin_cname(strdup(hostname)); - if (! host_cname) { - sdb_log(SDB_LOG_ERR, "store: strdup failed"); - free(cname); - return -1; - } - hostname = host_cname; - - host = lookup_host(hostname); - if (! host) { - sdb_log(SDB_LOG_ERR, "store: Failed to store %s '%s' - " - "host '%s' not found", SDB_STORE_TYPE_TO_NAME(type), - name, hostname); - free(host_cname); - free(cname); - return -1; - } +static int +store_obj(sdb_avltree_t *parent_tree, int type, const char *name, + sdb_time_t last_update, sdb_store_obj_t **updated_obj) +{ + sdb_store_obj_t *old, *new; + int status = 0; - if (type == SDB_ATTRIBUTE) - parent_list = host->attributes; - else - parent_list = host->services; - } + assert(parent_tree); - if (type == SDB_HOST) - old = STORE_OBJ(sdb_llist_search_by_name(host_list, name)); - else - old = STORE_OBJ(sdb_llist_search_by_name(parent_list, name)); + if (last_update <= 0) + last_update = sdb_gettime(); + old = STORE_OBJ(sdb_avltree_lookup(parent_tree, name)); if (old) { if (old->last_update > last_update) { sdb_log(SDB_LOG_DEBUG, "store: Cannot update %s '%s' - " - "value too old (%"PRIscTIME" < %"PRIscTIME")", + "value too old (%"PRIsdbTIME" < %"PRIsdbTIME")", SDB_STORE_TYPE_TO_NAME(type), name, last_update, old->last_update); /* don't report an error; the object may be updated by multiple * backends */ status = 1; } + else if (old->last_update == last_update) { + /* don't report an error and also don't even log this to avoid + * excessive noise on high sampling frequencies */ + status = 1; + } else { sdb_time_t interval = last_update - old->last_update; old->last_update = last_update; @@ -307,6 +328,7 @@ store_obj(const char *hostname, int type, const char *name, } new = old; + sdb_object_deref(SDB_OBJ(old)); } else { if (type == SDB_ATTRIBUTE) { @@ -316,15 +338,18 @@ store_obj(const char *hostname, int type, const char *name, } else { sdb_type_t t; - t = type == SDB_HOST ? sdb_host_type : sdb_service_type; + t = type == SDB_HOST + ? sdb_host_type + : type == SDB_SERVICE + ? sdb_service_type + : sdb_metric_type; new = STORE_OBJ(sdb_object_create(name, t, type, last_update)); } if (new) { - status = sdb_llist_insert_sorted(parent_list, SDB_OBJ(new), - sdb_object_cmp_by_name); + status = sdb_avltree_insert(parent_tree, SDB_OBJ(new)); - /* pass control to the list or destroy in case of an error */ + /* pass control to the tree or destroy in case of an error */ sdb_object_deref(SDB_OBJ(new)); } else { @@ -336,9 +361,6 @@ store_obj(const char *hostname, int type, const char *name, } } - free(host_cname); - free(cname); - if (status < 0) return status; assert(new); @@ -346,27 +368,65 @@ store_obj(const char *hostname, int type, const char *name, if (updated_obj) *updated_obj = new; - info = sdb_plugin_current(); - if (! info) + if (record_backend(new)) + return -1; + return status; +} /* store_obj */ + +static int +store_attr(sdb_avltree_t *attributes, const char *key, const sdb_data_t *value, + sdb_time_t last_update) +{ + sdb_store_obj_t *attr = NULL; + int status; + + status = store_obj(attributes, SDB_ATTRIBUTE, key, last_update, &attr); + if (status) return status; - for (i = 0; i < new->backends_num; ++i) - if (!strcasecmp(new->backends[i], info->plugin_name)) - return status; + /* don't update unchanged values */ + if (! sdb_data_cmp(&ATTR(attr)->value, value)) + return status; - tmp = realloc(new->backends, - (new->backends_num + 1) * sizeof(*new->backends)); - if (! tmp) + assert(attr); + if (sdb_data_copy(&ATTR(attr)->value, value)) return -1; + return status; +} /* store_attr */ - new->backends = tmp; - new->backends[new->backends_num] = strdup(info->plugin_name); - if (! new->backends[new->backends_num]) - return -1; +/* The host_lock has to be acquired before calling this function. */ +static sdb_avltree_t * +get_host_children(const char *hostname, int type) +{ + char *cname = NULL; + sdb_host_t *host; - ++new->backends_num; - return status; -} /* store_obj */ + assert(hostname); + assert((type == SDB_SERVICE) || (type == SDB_METRIC) + || (type == SDB_ATTRIBUTE)); + + if (! hosts) + return NULL; + + cname = sdb_plugin_cname(strdup(hostname)); + if (! cname) { + sdb_log(SDB_LOG_ERR, "store: strdup failed"); + return NULL; + } + + host = lookup_host(cname); + free(cname); + if (! host) + return NULL; + + sdb_object_deref(SDB_OBJ(host)); + if (type == SDB_ATTRIBUTE) + return host->attributes; + else if (type == SDB_METRIC) + return host->metrics; + else + return host->services; +} /* get_host_children */ /* * store_common_tojson serializes common object attributes to JSON. @@ -381,6 +441,7 @@ store_common_tojson(sdb_store_obj_t *obj, sdb_strbuf_t *buf) char interval_str[64]; size_t i; + /* TODO: make time and interval formats configurable */ if (! sdb_strftime(time_str, sizeof(time_str), "%F %T %z", obj->last_update)) snprintf(time_str, sizeof(time_str), ""); @@ -404,20 +465,23 @@ store_common_tojson(sdb_store_obj_t *obj, sdb_strbuf_t *buf) } /* store_common_tojson */ /* - * store_obj_tojson serializes attribute / service objects to JSON. + * store_obj_tojson serializes attribute / metric / service objects to JSON. * * The function never returns an error. Rather, an error message will be part * of the serialized data. */ static void -store_obj_tojson(sdb_llist_t *list, int type, sdb_strbuf_t *buf) +store_obj_tojson(sdb_avltree_t *tree, int type, sdb_strbuf_t *buf, + sdb_store_matcher_t *filter, int flags) { - sdb_llist_iter_t *iter; + sdb_avltree_iter_t *iter; - assert((type == SDB_ATTRIBUTE) || (type == SDB_SERVICE)); + assert((type == SDB_ATTRIBUTE) + || (type == SDB_METRIC) + || (type == SDB_SERVICE)); sdb_strbuf_append(buf, "["); - iter = sdb_llist_get_iter(list); + iter = sdb_avltree_get_iter(tree); if (! iter) { char errbuf[1024]; sdb_log(SDB_LOG_ERR, "store: Failed to retrieve %ss: %s\n", @@ -428,11 +492,14 @@ store_obj_tojson(sdb_llist_t *list, int type, sdb_strbuf_t *buf) } /* has_next returns false if the iterator is NULL */ - while (sdb_llist_iter_has_next(iter)) { - sdb_store_obj_t *sobj = STORE_OBJ(sdb_llist_iter_get_next(iter)); + while (sdb_avltree_iter_has_next(iter)) { + sdb_store_obj_t *sobj = STORE_OBJ(sdb_avltree_iter_get_next(iter)); assert(sobj); assert(sobj->type == type); + if (filter && (! sdb_store_matcher_matches(filter, sobj, NULL))) + continue; + sdb_strbuf_append(buf, "{\"name\": \"%s\", ", SDB_OBJ(sobj)->name); if (sobj->type == SDB_ATTRIBUTE) { char tmp[sdb_data_strlen(&ATTR(sobj)->value) + 1]; @@ -440,18 +507,84 @@ store_obj_tojson(sdb_llist_t *list, int type, sdb_strbuf_t *buf) SDB_DOUBLE_QUOTED); sdb_strbuf_append(buf, "\"value\": %s, ", tmp); } - store_common_tojson(sobj, buf); + + if ((sobj->type == SDB_SERVICE) + && (! (flags & SDB_SKIP_ATTRIBUTES))) { + sdb_strbuf_append(buf, ", \"attributes\": "); + store_obj_tojson(SVC(sobj)->attributes, SDB_ATTRIBUTE, + buf, filter, flags); + } + else if ((sobj->type == SDB_METRIC) + && (! (flags & SDB_SKIP_ATTRIBUTES))) { + sdb_strbuf_append(buf, ", \"attributes\": "); + store_obj_tojson(METRIC(sobj)->attributes, SDB_ATTRIBUTE, + buf, filter, flags); + } sdb_strbuf_append(buf, "}"); - if (sdb_llist_iter_has_next(iter)) + if (sdb_avltree_iter_has_next(iter)) sdb_strbuf_append(buf, ","); } - sdb_llist_iter_destroy(iter); + sdb_avltree_iter_destroy(iter); sdb_strbuf_append(buf, "]"); } /* store_obj_tojson */ +/* + * ts_tojson serializes a time-series to JSON. + * + * The function never returns an error. Rather, an error message will be part + * of the serialized data. + */ +static void +ts_tojson(sdb_timeseries_t *ts, sdb_strbuf_t *buf) +{ + char start_str[64]; + char end_str[64]; + + size_t i; + + /* TODO: make time format configurable */ + if (! sdb_strftime(start_str, sizeof(start_str), + "%F %T %z", ts->start)) + snprintf(start_str, sizeof(start_str), ""); + start_str[sizeof(start_str) - 1] = '\0'; + if (! sdb_strftime(end_str, sizeof(end_str), + "%F %T %z", ts->end)) + snprintf(end_str, sizeof(end_str), ""); + end_str[sizeof(end_str) - 1] = '\0'; + + sdb_strbuf_append(buf, "{\"start\": \"%s\", \"end\": \"%s\", {", + start_str, end_str); + + for (i = 0; i < ts->data_names_len; ++i) { + size_t j; + sdb_strbuf_append(buf, "\"%s\": [", ts->data_names[i]); + + for (j = 0; j < ts->data_len; ++j) { + char time_str[64]; + + if (! sdb_strftime(time_str, sizeof(time_str), + "%F %T %z", ts->data[i][j].timestamp)) + snprintf(time_str, sizeof(time_str), ""); + time_str[sizeof(time_str) - 1] = '\0'; + + sdb_strbuf_append(buf, "{\"timestamp\": \"%s\", " + "\"value\": \"%f\"}", time_str, ts->data[i][j].value); + + if (j < ts->data_len - 1) + sdb_strbuf_append(buf, ","); + } + + if (i < ts->data_names_len - 1) + sdb_strbuf_append(buf, "],"); + else + sdb_strbuf_append(buf, "]"); + } + sdb_strbuf_append(buf, "}}"); +} /* ts_tojson */ + /* * public API */ @@ -459,23 +592,35 @@ store_obj_tojson(sdb_llist_t *list, int type, sdb_strbuf_t *buf) void sdb_store_clear(void) { - sdb_llist_destroy(host_list); - host_list = NULL; + sdb_avltree_destroy(hosts); + hosts = NULL; } /* sdb_store_clear */ int sdb_store_host(const char *name, sdb_time_t last_update) { - int status; + char *cname = NULL; + int status = 0; if (! name) return -1; + cname = sdb_plugin_cname(strdup(name)); + if (! cname) { + sdb_log(SDB_LOG_ERR, "store: strdup failed"); + return -1; + } + pthread_rwlock_wrlock(&host_lock); - status = store_obj(/* hostname = */ NULL, - /* stored object = */ SDB_HOST, name, last_update, - /* updated_obj = */ NULL); + if (! hosts) + if (! (hosts = sdb_avltree_create())) + status = -1; + + if (! status) + status = store_obj(hosts, SDB_HOST, cname, last_update, NULL); pthread_rwlock_unlock(&host_lock); + + free(cname); return status; } /* sdb_store_host */ @@ -503,7 +648,6 @@ sdb_store_get_host(const char *name) if (! host) return NULL; - sdb_object_ref(SDB_OBJ(host)); return STORE_OBJ(host); } /* sdb_store_get_host */ @@ -512,27 +656,23 @@ sdb_store_attribute(const char *hostname, const char *key, const sdb_data_t *value, sdb_time_t last_update) { - int status; - - sdb_store_obj_t *updated_attr = NULL; + sdb_avltree_t *attrs; + int status = 0; if ((! hostname) || (! key)) return -1; pthread_rwlock_wrlock(&host_lock); - status = store_obj(hostname, - /* stored object = */ SDB_ATTRIBUTE, key, last_update, - &updated_attr); - - if (status >= 0) { - assert(updated_attr); - sdb_data_free_datum(&ATTR(updated_attr)->value); - if (sdb_data_copy(&ATTR(updated_attr)->value, value)) { - sdb_object_deref(SDB_OBJ(updated_attr)); - status = -1; - } + attrs = get_host_children(hostname, SDB_ATTRIBUTE); + if (! attrs) { + sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - " + "host '%s' not found", key, hostname); + status = -1; } + if (! status) + status = store_attr(attrs, key, value, last_update); + pthread_rwlock_unlock(&host_lock); return status; } /* sdb_store_attribute */ @@ -541,40 +681,269 @@ int sdb_store_service(const char *hostname, const char *name, sdb_time_t last_update) { - int status; + sdb_avltree_t *services; + + int status = 0; if ((! hostname) || (! name)) return -1; pthread_rwlock_wrlock(&host_lock); - status = store_obj(hostname, - /* stored object = */ SDB_SERVICE, name, last_update, - /* updated obj = */ NULL); + services = get_host_children(hostname, SDB_SERVICE); + if (! services) { + sdb_log(SDB_LOG_ERR, "store: Failed to store service '%s' - " + "host '%s' not found", name, hostname); + status = -1; + } + + if (! status) + status = store_obj(services, SDB_SERVICE, name, last_update, NULL); pthread_rwlock_unlock(&host_lock); return status; } /* sdb_store_service */ int -sdb_store_host_tojson(sdb_store_obj_t *h, sdb_strbuf_t *buf, int flags) +sdb_store_service_attr(const char *hostname, const char *service, + const char *key, const sdb_data_t *value, sdb_time_t last_update) { - sdb_host_t *host; + sdb_avltree_t *services; + sdb_service_t *svc; + int status = 0; - if ((! h) || (h->type != SDB_HOST) || (! buf)) + if ((! hostname) || (! service) || (! key)) + return -1; + + pthread_rwlock_wrlock(&host_lock); + services = get_host_children(hostname, SDB_SERVICE); + if (! services) { + sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' " + "for service '%s' - host '%ss' not found", + key, service, hostname); + pthread_rwlock_unlock(&host_lock); + return -1; + } + + svc = SVC(sdb_avltree_lookup(services, service)); + if (! svc) { + sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - " + "service '%s/%s' not found", key, hostname, service); + status = -1; + } + + if (! status) + status = store_attr(svc->attributes, key, value, last_update); + + sdb_object_deref(SDB_OBJ(svc)); + pthread_rwlock_unlock(&host_lock); + return status; +} /* sdb_store_service_attr */ + +int +sdb_store_metric(const char *hostname, const char *name, + sdb_metric_store_t *store, sdb_time_t last_update) +{ + sdb_store_obj_t *obj = NULL; + sdb_metric_t *metric; + + sdb_avltree_t *metrics; + + int status = 0; + + if ((! hostname) || (! name)) + return -1; + if (store && ((! store->type) || (! store->id))) return -1; - host = HOST(h); + pthread_rwlock_wrlock(&host_lock); + metrics = get_host_children(hostname, SDB_METRIC); + if (! metrics) { + sdb_log(SDB_LOG_ERR, "store: Failed to store metric '%s' - " + "host '%s' not found", name, hostname); + status = -1; + } + + if (! status) + status = store_obj(metrics, SDB_METRIC, name, last_update, &obj); + + if (status || (! store)) { + pthread_rwlock_unlock(&host_lock); + return status; + } + + assert(obj); + metric = METRIC(obj); + + if ((! metric->store.type) || strcasecmp(metric->store.type, store->type)) { + if (metric->store.type) + free(metric->store.type); + metric->store.type = strdup(store->type); + } + if ((! metric->store.id) || strcasecmp(metric->store.id, store->id)) { + if (metric->store.id) + free(metric->store.id); + metric->store.id = strdup(store->id); + } + + if ((! metric->store.type) || (! metric->store.id)) { + if (metric->store.type) + free(metric->store.type); + if (metric->store.id) + free(metric->store.id); + metric->store.type = metric->store.id = NULL; + status = -1; + } + pthread_rwlock_unlock(&host_lock); + return status; +} /* sdb_store_metric */ + +int +sdb_store_metric_attr(const char *hostname, const char *metric, + const char *key, const sdb_data_t *value, sdb_time_t last_update) +{ + sdb_avltree_t *metrics; + sdb_metric_t *m; + int status = 0; + + if ((! hostname) || (! metric) || (! key)) + return -1; + + pthread_rwlock_wrlock(&host_lock); + metrics = get_host_children(hostname, SDB_METRIC); + if (! metrics) { + sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' " + "for metric '%s' - host '%s' not found", + key, metric, hostname); + pthread_rwlock_unlock(&host_lock); + return -1; + } + + m = METRIC(sdb_avltree_lookup(metrics, metric)); + if (! m) { + sdb_log(SDB_LOG_ERR, "store: Failed to store attribute '%s' - " + "metric '%s/%s' not found", key, hostname, metric); + status = -1; + } + + if (! status) + status = store_attr(m->attributes, key, value, last_update); + + sdb_object_deref(SDB_OBJ(m)); + pthread_rwlock_unlock(&host_lock); + return status; +} /* sdb_store_metric_attr */ + +int +sdb_store_fetch_timeseries(const char *hostname, const char *metric, + sdb_timeseries_opts_t *opts, sdb_strbuf_t *buf) +{ + sdb_avltree_t *metrics; + sdb_metric_t *m; + + sdb_timeseries_t *ts; + + if ((! hostname) || (! metric) || (! opts) || (! buf)) + return -1; + + pthread_rwlock_rdlock(&host_lock); + metrics = get_host_children(hostname, SDB_METRIC); + if (! metrics) { + sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' " + "- host '%s' not found", hostname, metric, hostname); + pthread_rwlock_unlock(&host_lock); + return -1; + } + + m = METRIC(sdb_avltree_lookup(metrics, metric)); + if (! m) { + sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' " + "- metric '%s' not found", hostname, metric, metric); + pthread_rwlock_unlock(&host_lock); + return -1; + } + + if ((! m->store.type) || (! m->store.id)) { + sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' " + "- no data-store configured for the stored metric", + hostname, metric); + pthread_rwlock_unlock(&host_lock); + return -1; + } + + { + char type[strlen(m->store.type) + 1]; + char id[strlen(m->store.id) + 1]; + + strncpy(type, m->store.type, sizeof(type)); + strncpy(id, m->store.id, sizeof(id)); + pthread_rwlock_unlock(&host_lock); + + ts = sdb_plugin_fetch_timeseries(type, id, opts); + if (! ts) { + sdb_log(SDB_LOG_ERR, "store: Failed to fetch time-series '%s/%s' " + "- %s fetcher callback returned no data for '%s'", + hostname, metric, type, id); + return -1; + } + } + + ts_tojson(ts, buf); + sdb_timeseries_destroy(ts); + return 0; +} /* sdb_store_fetch_timeseries */ + +int +sdb_store_get_field(sdb_store_obj_t *obj, int field, sdb_data_t *res) +{ + if ((! obj) || (! res)) + return -1; + + switch (field) { + case SDB_FIELD_LAST_UPDATE: + res->type = SDB_TYPE_DATETIME; + res->data.datetime = obj->last_update; + break; + case SDB_FIELD_AGE: + res->type = SDB_TYPE_DATETIME; + res->data.datetime = sdb_gettime() - obj->last_update; + break; + case SDB_FIELD_INTERVAL: + res->type = SDB_TYPE_DATETIME; + res->data.datetime = obj->interval; + break; + case SDB_FIELD_BACKEND: + /* TODO: add support for storing array values in a data object + * for now, fall thru to the error case */ + default: + return -1; + } + return 0; +} /* sdb_store_get_field */ + +int +sdb_store_host_tojson(sdb_store_obj_t *h, sdb_strbuf_t *buf, + sdb_store_matcher_t *filter, int flags) +{ + sdb_host_t *host = HOST(h); + + if ((! h) || (h->type != SDB_HOST) || (! buf)) + return -1; sdb_strbuf_append(buf, "{\"name\": \"%s\", ", SDB_OBJ(host)->name); store_common_tojson(h, buf); if (! (flags & SDB_SKIP_ATTRIBUTES)) { sdb_strbuf_append(buf, ", \"attributes\": "); - store_obj_tojson(host->attributes, SDB_ATTRIBUTE, buf); + store_obj_tojson(host->attributes, SDB_ATTRIBUTE, buf, filter, flags); + } + + if (! (flags & SDB_SKIP_METRICS)) { + sdb_strbuf_append(buf, ", \"metrics\": "); + store_obj_tojson(host->metrics, SDB_METRIC, buf, filter, flags); } if (! (flags & SDB_SKIP_SERVICES)) { sdb_strbuf_append(buf, ", \"services\": "); - store_obj_tojson(host->services, SDB_SERVICE, buf); + store_obj_tojson(host->services, SDB_SERVICE, buf, filter, flags); } sdb_strbuf_append(buf, "}"); @@ -582,37 +951,45 @@ sdb_store_host_tojson(sdb_store_obj_t *h, sdb_strbuf_t *buf, int flags) } /* sdb_store_host_tojson */ int -sdb_store_tojson(sdb_strbuf_t *buf, int flags) +sdb_store_tojson(sdb_strbuf_t *buf, sdb_store_matcher_t *filter, int flags) { - sdb_llist_iter_t *host_iter; + sdb_avltree_iter_t *host_iter; + size_t len; if (! buf) return -1; pthread_rwlock_rdlock(&host_lock); - host_iter = sdb_llist_get_iter(host_list); + host_iter = sdb_avltree_get_iter(hosts); if (! host_iter) { pthread_rwlock_unlock(&host_lock); return -1; } - sdb_strbuf_append(buf, "{\"hosts\":["); + sdb_strbuf_append(buf, "["); + + len = sdb_strbuf_len(buf); + while (sdb_avltree_iter_has_next(host_iter)) { + sdb_store_obj_t *host; - while (sdb_llist_iter_has_next(host_iter)) { - sdb_store_obj_t *host = STORE_OBJ(sdb_llist_iter_get_next(host_iter)); + host = STORE_OBJ(sdb_avltree_iter_get_next(host_iter)); assert(host); - if (sdb_store_host_tojson(host, buf, flags)) - return -1; + if (filter && (! sdb_store_matcher_matches(filter, host, NULL))) + continue; - if (sdb_llist_iter_has_next(host_iter)) + if (sdb_strbuf_len(buf) > len) sdb_strbuf_append(buf, ","); + len = sdb_strbuf_len(buf); + + if (sdb_store_host_tojson(host, buf, filter, flags)) + return -1; } - sdb_strbuf_append(buf, "]}"); + sdb_strbuf_append(buf, "]"); - sdb_llist_iter_destroy(host_iter); + sdb_avltree_iter_destroy(host_iter); pthread_rwlock_unlock(&host_lock); return 0; } /* sdb_store_tojson */ @@ -621,18 +998,20 @@ sdb_store_tojson(sdb_strbuf_t *buf, int flags) int sdb_store_iterate(sdb_store_iter_cb cb, void *user_data) { - sdb_llist_iter_t *host_iter; + sdb_avltree_iter_t *host_iter; int status = 0; pthread_rwlock_rdlock(&host_lock); - host_iter = sdb_llist_get_iter(host_list); + host_iter = sdb_avltree_get_iter(hosts); if (! host_iter) status = -1; /* has_next returns false if the iterator is NULL */ - while (sdb_llist_iter_has_next(host_iter)) { - sdb_store_obj_t *host = STORE_OBJ(sdb_llist_iter_get_next(host_iter)); + while (sdb_avltree_iter_has_next(host_iter)) { + sdb_store_obj_t *host; + + host = STORE_OBJ(sdb_avltree_iter_get_next(host_iter)); assert(host); if (cb(host, user_data)) { @@ -641,7 +1020,7 @@ sdb_store_iterate(sdb_store_iter_cb cb, void *user_data) } } - sdb_llist_iter_destroy(host_iter); + sdb_avltree_iter_destroy(host_iter); pthread_rwlock_unlock(&host_lock); return status; } /* sdb_store_iterate */