X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fconn-avoid-ref.cpp;h=fbceb4eb5467096df8a220045e8c4af010aa4ef3;hb=ef9d155a8149d4793471047b3836db719b9e0292;hp=d832a34b4b81491a31d3c9ea234cf1cbc3868090;hpb=3fea53c3e91bfe887e67441426326944d802bf68;p=inkscape.git diff --git a/src/conn-avoid-ref.cpp b/src/conn-avoid-ref.cpp index d832a34b4..fbceb4eb5 100644 --- a/src/conn-avoid-ref.cpp +++ b/src/conn-avoid-ref.cpp @@ -15,7 +15,7 @@ #include "conn-avoid-ref.h" #include "libnr/nr-rect-ops.h" #include "libavoid/polyutil.h" -#include "libavoid/incremental.h" +#include "libavoid/router.h" #include "libavoid/connector.h" #include "xml/simple-node.cpp" #include "document.h" @@ -27,6 +27,8 @@ #include "inkscape.h" +using Avoid::Router; + static Avoid::Polygn avoid_item_poly(SPItem const *item); @@ -44,9 +46,10 @@ SPAvoidRef::~SPAvoidRef() { _transformed_connection.disconnect(); if (shapeRef) { + Router *router = shapeRef->router(); // shapeRef is finalised by delShape, // so no memory is lost here. - Avoid::delShape(shapeRef); + router->delShape(shapeRef); shapeRef = NULL; } } @@ -71,12 +74,24 @@ void SPAvoidRef::handleSettingChange(void) if (desktop == NULL) { return; } - + if (sp_desktop_document(desktop) != item->document) { + // We don't want to go any further if the active desktop's document + // isn't the same as the document that this item is part of. This + // case can happen if a new document is loaded from the file chooser + // or via the recent file menu. In this case, we can end up here + // as a rersult of a sp_document_ensure_up_to_date performed on a + // document not yet attached to the active desktop. + return; + } + if (new_setting == setting) { // Don't need to make any changes return; } + setting = new_setting; + Router *router = item->document->router; + _transformed_connection.disconnect(); if (new_setting) { _transformed_connection = item->connectTransformed( @@ -90,10 +105,10 @@ void SPAvoidRef::handleSettingChange(void) // Get a unique ID for the item. GQuark itemID = g_quark_from_string(id); - shapeRef = new Avoid::ShapeRef(itemID, poly); + shapeRef = new Avoid::ShapeRef(router, itemID, poly); Avoid::freePoly(poly); - Avoid::addShape(shapeRef); + router->addShape(shapeRef); } } else @@ -102,10 +117,9 @@ void SPAvoidRef::handleSettingChange(void) // shapeRef is finalised by delShape, // so no memory is lost here. - Avoid::delShape(shapeRef); + router->delShape(shapeRef); shapeRef = NULL; } - setting = new_setting; } @@ -115,7 +129,7 @@ GSList *SPAvoidRef::getAttachedShapes(const unsigned int type) Avoid::IntList shapes; GQuark shapeId = g_quark_from_string(item->id); - Avoid::attachedShapes(shapes, shapeId, type); + item->document->router->attachedShapes(shapes, shapeId, type); Avoid::IntList::iterator finish = shapes.end(); for (Avoid::IntList::iterator i = shapes.begin(); i != finish; ++i) { @@ -139,7 +153,7 @@ GSList *SPAvoidRef::getAttachedConnectors(const unsigned int type) Avoid::IntList conns; GQuark shapeId = g_quark_from_string(item->id); - Avoid::attachedConns(conns, shapeId, type); + item->document->router->attachedConns(conns, shapeId, type); Avoid::IntList::iterator finish = conns.end(); for (Avoid::IntList::iterator i = conns.begin(); i != finish; ++i) { @@ -245,10 +259,10 @@ void avoid_item_move(NR::Matrix const *mp, SPItem *moved_item) Avoid::ShapeRef *shapeRef = moved_item->avoidRef->shapeRef; g_assert(shapeRef); + Router *router = moved_item->document->router; Avoid::Polygn poly = avoid_item_poly(moved_item); if (poly.pn > 0) { - // moveShape actually destroys the old shapeRef and returns a new one. - moved_item->avoidRef->shapeRef = Avoid::moveShape(shapeRef, &poly); + router->moveShape(shapeRef, &poly); Avoid::freePoly(poly); } } @@ -258,9 +272,9 @@ void init_avoided_shape_geometry(SPDesktop *desktop) { // Don't count this as changes to the document, // it is basically just llate initialisation. - SPDocument *document = SP_DT_DOCUMENT(desktop); - gboolean saved = sp_document_get_undo_sensitive(document); - sp_document_set_undo_sensitive(document, FALSE); + SPDocument *document = sp_desktop_document(desktop); + bool saved = sp_document_get_undo_sensitive(document); + sp_document_set_undo_sensitive(document, false); bool initialised = false; GSList *items = get_avoided_items(NULL, desktop->currentRoot(), desktop,