X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fclient%2Fsock.c;h=6a1e49ff541cabb049ecc4119f83feb490592759;hb=1b6c4d55037135271c66b43e81691c5131d9813b;hp=b60bad45e2cf97d47d2c101513c030f4a27fff5e;hpb=ab6e6823b628af93e1f5d95ab1677e8843d913af;p=sysdb.git diff --git a/src/client/sock.c b/src/client/sock.c index b60bad4..6a1e49f 100644 --- a/src/client/sock.c +++ b/src/client/sock.c @@ -33,9 +33,11 @@ #include "utils/error.h" #include "utils/strbuf.h" #include "utils/proto.h" +#include "utils/os.h" #include +#include #include #include @@ -49,6 +51,8 @@ #include #include +#include + /* * private data types */ @@ -56,13 +60,28 @@ struct sdb_client { char *address; int fd; - _Bool eof; + bool eof; + + ssize_t (*read)(sdb_client_t *, sdb_strbuf_t *, size_t); + ssize_t (*write)(sdb_client_t *, const void *, size_t); }; /* * private helper functions */ +static ssize_t +client_read(sdb_client_t *client, sdb_strbuf_t *buf, size_t n) +{ + return sdb_strbuf_read(buf, client->fd, n); +} /* client_read */ + +static ssize_t +client_write(sdb_client_t *client, const void *buf, size_t n) +{ + return sdb_write(client->fd, n, buf); +} /* client_write */ + static int connect_unixsock(sdb_client_t *client, const char *address) { @@ -90,6 +109,42 @@ connect_unixsock(sdb_client_t *client, const char *address) return client->fd; } /* connect_unixsock */ +static int +connect_tcp(sdb_client_t *client, const char *address) +{ + struct addrinfo *ai, *ai_list = NULL; + int status; + + if ((status = sdb_resolve(SDB_NET_TCP, address, &ai_list))) { + sdb_log(SDB_LOG_ERR, "Failed to resolve '%s': %s", + address, gai_strerror(status)); + return -1; + } + + for (ai = ai_list; ai != NULL; ai = ai->ai_next) { + client->fd = socket(ai->ai_family, ai->ai_socktype, ai->ai_protocol); + if (client->fd < 0) { + char errbuf[1024]; + sdb_log(SDB_LOG_ERR, "Failed to open socket: %s", + sdb_strerror(errno, errbuf, sizeof(errbuf))); + continue; + } + + if (connect(client->fd, ai->ai_addr, ai->ai_addrlen)) { + char host[1024], port[32], errbuf[1024]; + sdb_client_close(client); + getnameinfo(ai->ai_addr, ai->ai_addrlen, host, sizeof(host), + port, sizeof(port), NI_NUMERICHOST | NI_NUMERICSERV); + sdb_log(SDB_LOG_ERR, "Failed to connect to '%s:%s': %s", + host, port, sdb_strerror(errno, errbuf, sizeof(errbuf))); + continue; + } + break; + } + freeaddrinfo(ai_list); + return client->fd; +} /* connect_tcp */ + /* * public API */ @@ -111,6 +166,9 @@ sdb_client_create(const char *address) client->fd = -1; client->eof = 1; + client->read = client_read; + client->write = client_write; + client->address = strdup(address); if (! client->address) { sdb_client_destroy(client); @@ -149,14 +207,14 @@ sdb_client_connect(sdb_client_t *client, const char *username) if (client->fd >= 0) return -1; - if (!strncasecmp(client->address, "unix:", strlen("unix:"))) - connect_unixsock(client, client->address + strlen("unix:")); - else if (*client->address == '/') + if (*client->address == '/') connect_unixsock(client, client->address); - else { - sdb_log(SDB_LOG_ERR, "Unknown address type: %s", client->address); - return -1; - } + else if (!strncasecmp(client->address, "unix:", strlen("unix:"))) + connect_unixsock(client, client->address + strlen("unix:")); + else if (!strncasecmp(client->address, "tcp:", strlen("tcp:"))) + connect_tcp(client, client->address + strlen("tcp:")); + else + connect_tcp(client, client->address); if (client->fd < 0) return -1; @@ -166,7 +224,7 @@ sdb_client_connect(sdb_client_t *client, const char *username) if (! username) username = ""; - status = sdb_client_send(client, CONNECTION_STARTUP, + status = sdb_client_send(client, SDB_CONNECTION_STARTUP, (uint32_t)strlen(username), username); if (status < 0) { char errbuf[1024]; @@ -179,7 +237,7 @@ sdb_client_connect(sdb_client_t *client, const char *username) buf = sdb_strbuf_create(64); rstatus = 0; status = sdb_client_recv(client, &rstatus, buf); - if ((status > 0) && (rstatus == CONNECTION_OK)) { + if ((status > 0) && (rstatus == SDB_CONNECTION_OK)) { sdb_strbuf_destroy(buf); return 0; } @@ -193,8 +251,14 @@ sdb_client_connect(sdb_client_t *client, const char *username) sdb_log(SDB_LOG_ERR, "Encountered end-of-file while waiting " "for server response"); - if (rstatus != CONNECTION_OK) { - sdb_log(SDB_LOG_ERR, "Access denied for user '%s'", username); + if (rstatus == SDB_CONNECTION_ERROR) { + sdb_log(SDB_LOG_ERR, "Access denied for user '%s': %s", + username, sdb_strbuf_string(buf)); + status = -((int)rstatus); + } + else if (rstatus != SDB_CONNECTION_OK) { + sdb_log(SDB_LOG_ERR, "Received unsupported authentication request " + "(status %d) during startup", (int)rstatus); status = -((int)rstatus); } @@ -238,14 +302,71 @@ sdb_client_close(sdb_client_t *client) client->eof = 1; } /* sdb_client_close */ +ssize_t +sdb_client_rpc(sdb_client_t *client, + uint32_t cmd, uint32_t msg_len, const char *msg, + uint32_t *code, sdb_strbuf_t *buf) +{ + uint32_t rcode = 0; + ssize_t status; + + if (! buf) + return -1; + + if (sdb_client_send(client, cmd, msg_len, msg) < 0) { + char errbuf[1024]; + sdb_strbuf_sprintf(buf, "Failed to send %s message to server: %s", + SDB_CONN_MSGTYPE_TO_STRING(cmd), + sdb_strerror(errno, errbuf, sizeof(errbuf))); + if (code) + *code = SDB_CONNECTION_ERROR; + return -1; + } + + while (42) { + size_t offset = sdb_strbuf_len(buf); + + status = sdb_client_recv(client, &rcode, buf); + if (status < 0) { + char errbuf[1024]; + sdb_strbuf_sprintf(buf, "Failed to receive server response: %s", + sdb_strerror(errno, errbuf, sizeof(errbuf))); + if (code) + *code = SDB_CONNECTION_ERROR; + return status; + } + + if (rcode == SDB_CONNECTION_LOG) { + uint32_t prio = 0; + if (sdb_proto_unmarshal_int32(SDB_STRBUF_STR(buf), &prio) < 0) { + sdb_log(SDB_LOG_WARNING, "Received a LOG message " + "with invalid or missing priority"); + prio = (uint32_t)SDB_LOG_ERR; + } + sdb_log((int)prio, "%s", sdb_strbuf_string(buf) + offset); + sdb_strbuf_skip(buf, offset, sdb_strbuf_len(buf) - offset); + continue; + } + break; + } + + if (code) + *code = rcode; + return status; +} /* sdb_client_rpc */ + ssize_t sdb_client_send(sdb_client_t *client, uint32_t cmd, uint32_t msg_len, const char *msg) { + char buf[2 * sizeof(uint32_t) + msg_len]; + if ((! client) || (! client->fd)) return -1; + if (sdb_proto_marshal(buf, sizeof(buf), cmd, msg_len, msg) < 0) + return -1; - return sdb_proto_send_msg(client->fd, cmd, msg_len, msg); + return client->write(client, buf, sizeof(buf)); } /* sdb_client_send */ ssize_t @@ -271,11 +392,11 @@ sdb_client_recv(sdb_client_t *client, while (42) { ssize_t status; - if (sdb_proto_select(client->fd, SDB_PROTO_SELECTIN)) + if (sdb_select(client->fd, SDB_SELECTIN)) return -1; errno = 0; - status = sdb_strbuf_read(buf, client->fd, req); + status = client->read(client, buf, req); if (status < 0) { if ((errno == EAGAIN) || (errno == EWOULDBLOCK)) continue; @@ -292,9 +413,15 @@ sdb_client_recv(sdb_client_t *client, continue; if (rstatus == UINT32_MAX) { + const char *str = sdb_strbuf_string(buf) + data_offset; + size_t len = sdb_strbuf_len(buf) - data_offset; + ssize_t n; + /* retrieve status and data len */ - rstatus = sdb_proto_get_int(buf, data_offset); - rlen = sdb_proto_get_int(buf, data_offset + sizeof(rstatus)); + assert(len >= 2 * sizeof(uint32_t)); + n = sdb_proto_unmarshal_int32(str, len, &rstatus); + str += n; len -= (size_t)n; + sdb_proto_unmarshal_int32(str, len, &rlen); if (! rlen) break; @@ -322,7 +449,7 @@ sdb_client_recv(sdb_client_t *client, return (ssize_t)total; } /* sdb_client_recv */ -_Bool +bool sdb_client_eof(sdb_client_t *client) { if ((! client) || (client->fd < 0))