X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=src%2Fclient%2Fsock.c;h=66b83a70009f16921ef70f8e487ae14eabe454dd;hb=9db2593faeb3a394545b27f44d3ed96fce51cd99;hp=f4f4c556e82012c99927c721fe98697933c939d0;hpb=c396513ae6f1ed149a7cd5cd6979a019aff6c327;p=sysdb.git

diff --git a/src/client/sock.c b/src/client/sock.c
index f4f4c55..66b83a7 100644
--- a/src/client/sock.c
+++ b/src/client/sock.c
@@ -26,6 +26,7 @@
  */
 
 #include "client/sock.h"
+#include "utils/error.h"
 #include "utils/strbuf.h"
 #include "utils/proto.h"
 
@@ -63,15 +64,22 @@ connect_unixsock(sdb_client_t *client, const char *address)
 	struct sockaddr_un sa;
 
 	client->fd = socket(AF_UNIX, SOCK_STREAM, /* protocol = */ 0);
-	if (client->fd < 0)
+	if (client->fd < 0) {
+		char errbuf[1024];
+		sdb_log(SDB_LOG_ERR, "Failed to open socket: %s",
+				sdb_strerror(errno, errbuf, sizeof(errbuf)));
 		return -1;
+	}
 
 	sa.sun_family = AF_UNIX;
 	strncpy(sa.sun_path, address, sizeof(sa.sun_path));
 	sa.sun_path[sizeof(sa.sun_path) - 1] = '\0';
 
 	if (connect(client->fd, (struct sockaddr *)&sa, sizeof(sa))) {
+		char errbuf[1024];
 		sdb_client_close(client);
+		sdb_log(SDB_LOG_ERR, "Failed to connect to '%s': %s",
+				sa.sun_path, sdb_strerror(errno, errbuf, sizeof(errbuf)));
 		return -1;
 	}
 	return client->fd;
@@ -90,14 +98,17 @@ sdb_client_create(const char *address)
 		return NULL;
 
 	client = malloc(sizeof(*client));
-	if (! client)
+	if (! client) {
+		sdb_log(SDB_LOG_ERR, "Out of memory");
 		return NULL;
+	}
 	memset(client, 0, sizeof(*client));
 	client->fd = -1;
 
 	client->address = strdup(address);
 	if (! client->address) {
 		sdb_client_destroy(client);
+		sdb_log(SDB_LOG_ERR, "Out of memory");
 		return NULL;
 	}
 
@@ -120,8 +131,12 @@ sdb_client_destroy(sdb_client_t *client)
 } /* sdb_client_destroy */
 
 int
-sdb_client_connect(sdb_client_t *client)
+sdb_client_connect(sdb_client_t *client, const char *username)
 {
+	sdb_strbuf_t *buf;
+	ssize_t status;
+	uint32_t rstatus;
+
 	if ((! client) || (! client->address))
 		return -1;
 
@@ -132,11 +147,46 @@ sdb_client_connect(sdb_client_t *client)
 		connect_unixsock(client, client->address + strlen("unix:"));
 	else if (*client->address == '/')
 		connect_unixsock(client, client->address);
-	else
+	else {
+		sdb_log(SDB_LOG_ERR, "Unknown address type: %s", client->address);
 		return -1;
+	}
 
 	if (client->fd < 0)
 		return -1;
+
+	/* XXX */
+	if (! username)
+		username = "";
+
+	status = sdb_client_send(client, CONNECTION_STARTUP,
+			(uint32_t)strlen(username), username);
+	if (status < 0) {
+		char errbuf[1024];
+		sdb_client_close(client);
+		sdb_log(SDB_LOG_ERR, "Failed to send STARTUP message to server: %s",
+				sdb_strerror(errno, errbuf, sizeof(errbuf)));
+		return (int)status;
+	}
+
+	buf = sdb_strbuf_create(64);
+	rstatus = 0;
+	status = sdb_client_recv(client, &rstatus, buf);
+	if (status < 0) {
+		char errbuf[1024];
+		sdb_client_close(client);
+		sdb_strbuf_destroy(buf);
+		sdb_log(SDB_LOG_ERR, "Failed to receive server response: %s",
+				sdb_strerror(errno, errbuf, sizeof(errbuf)));
+		return (int)status;
+	}
+
+	if (rstatus != CONNECTION_OK) {
+		sdb_client_close(client);
+		sdb_strbuf_destroy(buf);
+		sdb_log(SDB_LOG_ERR, "Access denied for user '%s'", username);
+		return -((int)rstatus);
+	}
 	return 0;
 } /* sdb_client_connect */
 
@@ -183,11 +233,13 @@ sdb_client_recv(sdb_client_t *client,
 	while (42) {
 		ssize_t status;
 
+		/* XXX: use select */
+
 		errno = 0;
 		status = sdb_strbuf_read(buf, client->fd, req);
 		if (status < 0) {
 			if ((errno == EAGAIN) || (errno == EWOULDBLOCK))
-				break;
+				continue;
 			return status;
 		}
 		else if (! status) /* EOF */
@@ -213,6 +265,12 @@ sdb_client_recv(sdb_client_t *client,
 			break;
 	}
 
+	if (total != req) {
+		/* unexpected EOF; clear partially read data */
+		sdb_strbuf_skip(buf, data_offset, sdb_strbuf_len(buf));
+		return 0;
+	}
+
 	if (rstatus != UINT32_MAX)
 		/* remove status,len */
 		sdb_strbuf_skip(buf, data_offset, 2 * sizeof(rstatus));