X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;f=plugins%2Fcheck_nagios.c;h=45514f1a98aaf4e370ae295bbfbeb2c38dbf0af1;hb=7c69ccaee2baba7d1e8347b8b9e1f45a18551a6c;hp=bb2ae6dd8ef7c58c7e057ab454bb88b9dcf0210a;hpb=230d67e18ad368773f2302485d0b55f50f654e3f;p=nagiosplug.git diff --git a/plugins/check_nagios.c b/plugins/check_nagios.c index bb2ae6d..45514f1 100644 --- a/plugins/check_nagios.c +++ b/plugins/check_nagios.c @@ -20,11 +20,11 @@ const char *progname = "check_nagios"; const char *revision = "$Revision$"; -const char *copyright = "1999-2003"; +const char *copyright = "1999-2004"; const char *email = "nagiosplug-devel@lists.sourceforge.net"; #include "common.h" -#include "popen.h" +#include "runcmd.h" #include "utils.h" int process_arguments (int, char **); @@ -49,29 +49,34 @@ main (int argc, char **argv) char *temp_ptr; FILE *fp; int procuid = 0; + int procpid = 0; int procppid = 0; int procvsz = 0; int procrss = 0; float procpcpu = 0; char procstat[8]; +#ifdef PS_USES_PROCETIME + char procetime[MAX_INPUT_BUFFER]; +#endif /* PS_USES_PROCETIME */ char procprog[MAX_INPUT_BUFFER]; char *procargs; int pos, cols; int expected_cols = PS_COLS - 1; const char *zombie = "Z"; char *temp_string; + output chld_out, chld_err; + size_t i; setlocale (LC_ALL, ""); bindtextdomain (PACKAGE, LOCALEDIR); textdomain (PACKAGE); - if (process_arguments (argc, argv) != OK) - usage (_("check_nagios: could not parse arguments\n")); + if (process_arguments (argc, argv) == ERROR) + usage_va(_("Could not parse arguments")); - /* Set signal handling and alarm */ + /* Set signal handling and alarm timeout */ if (signal (SIGALRM, timeout_alarm_handler) == SIG_ERR) { - printf (_("Cannot catch SIGALRM")); - return STATE_UNKNOWN; + usage_va(_("Cannot catch SIGALRM")); } /* handle timeouts gracefully... */ @@ -80,17 +85,20 @@ main (int argc, char **argv) /* open the status log */ fp = fopen (status_log, "r"); if (fp == NULL) { - printf (_("CRITICAL - Cannot open status log for reading!\n")); - return STATE_CRITICAL; + die (STATE_CRITICAL, "NAGIOS %s: %s\n", _("CRITICAL"), _("Cannot open status log for reading!")); } /* get the date/time of the last item updated in the log */ while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, fp)) { - temp_ptr = strtok (input_buffer, "]"); - temp_entry_time = - (temp_ptr == NULL) ? 0L : strtoul (temp_ptr + 1, NULL, 10); - if (temp_entry_time > latest_entry_time) + if ((temp_ptr = strstr (input_buffer, "created=")) != NULL) { + temp_entry_time = strtoul (temp_ptr + 8, NULL, 10); latest_entry_time = temp_entry_time; + break; + } else if ((temp_ptr = strtok (input_buffer, "]")) != NULL) { + temp_entry_time = strtoul (temp_ptr + 1, NULL, 10); + if (temp_entry_time > latest_entry_time) + latest_entry_time = temp_entry_time; + } } fclose (fp); @@ -98,43 +106,33 @@ main (int argc, char **argv) printf("command: %s\n", PS_COMMAND); /* run the command to check for the Nagios process.. */ - child_process = spopen (PS_COMMAND); - if (child_process == NULL) { - printf (_("Could not open pipe: %s\n"), PS_COMMAND); - return STATE_UNKNOWN; - } - - child_stderr = fdopen (child_stderr_array[fileno (child_process)], "r"); - if (child_stderr == NULL) { - printf (_("Could not open stderr for %s\n"), PS_COMMAND); - } - - fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_process); + if((result = np_runcmd(PS_COMMAND, &chld_out, &chld_err, 0)) != 0) + result = STATE_WARNING; /* count the number of matching Nagios processes... */ - while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_process)) { - cols = sscanf (input_buffer, PS_FORMAT, PS_VARLIST); - /* Zombie processes do not give a procprog command */ - if ( cols == (expected_cols - 1) && strstr(procstat, zombie) ) { - cols = expected_cols; - /* Set some value for procargs for the strip command further below - Seen to be a problem on some Solaris 7 and 8 systems */ - input_buffer[pos] = '\n'; - input_buffer[pos+1] = 0x0; - } + for(i = 0; i < chld_out.lines; i++) { + cols = sscanf (chld_out.line[i], PS_FORMAT, PS_VARLIST); + /* Zombie processes do not give a procprog command */ + if ( cols == (expected_cols - 1) && strstr(procstat, zombie) ) { + cols = expected_cols; + /* Set some value for procargs for the strip command further below + * Seen to be a problem on some Solaris 7 and 8 systems */ + chld_out.line[i][pos] = '\n'; + chld_out.line[i][pos+1] = 0x0; + } if ( cols >= expected_cols ) { - asprintf (&procargs, "%s", input_buffer + pos); + asprintf (&procargs, "%s", chld_out.line[i] + pos); strip (procargs); - + /* Some ps return full pathname for command. This removes path */ - temp_string = strtok ((char *)procprog, "/"); - while (temp_string) { - strcpy(procprog, temp_string); - temp_string = strtok (NULL, "/"); - } + temp_string = strtok ((char *)procprog, "/"); + while (temp_string) { + strcpy(procprog, temp_string); + temp_string = strtok (NULL, "/"); + } /* May get empty procargs */ - if (!strstr(procargs, argv[0]) && strstr(procprog, process_string) && strcmp(procargs,"")) { + if (!strstr(procargs, argv[0]) && strstr(procargs, process_string) && strcmp(procargs,"")) { proc_entries++; if (verbose >= 2) { printf (_("Found process: %s %s\n"), procprog, procargs); @@ -144,36 +142,36 @@ main (int argc, char **argv) } /* If we get anything on stderr, at least set warning */ - while (fgets (input_buffer, MAX_INPUT_BUFFER - 1, child_stderr)) - result = max_state (result, STATE_WARNING); - - /* close stderr */ - (void) fclose (child_stderr); - - /* close the pipe */ - if (spclose (child_process)) + if(chld_err.buflen) result = max_state (result, STATE_WARNING); /* reset the alarm handler */ alarm (0); if (proc_entries == 0) { - printf (_("Could not locate a running Nagios process!\n")); - return STATE_CRITICAL; + die (STATE_CRITICAL, "NAGIOS %s: %s\n", _("CRITICAL"), _("Could not locate a running Nagios process!")); } - result = STATE_OK; + if (latest_entry_time == 0L) { + die (STATE_CRITICAL, "NAGIOS %s: %s\n", _("CRITICAL"), _("Cannot parse Nagios log file for valid time")); + } time (¤t_time); - if ((int)(current_time - latest_entry_time) > (expire_minutes * 60)) + if ((int)(current_time - latest_entry_time) > (expire_minutes * 60)) { result = STATE_WARNING; + } else { + result = STATE_OK; + } - printf - (_("Nagios %s: located %d process%s, status log updated %d second%s ago\n"), - (result == STATE_OK) ? "ok" : "problem", proc_entries, - (proc_entries == 1) ? "" : "es", - (int) (current_time - latest_entry_time), - ((int) (current_time - latest_entry_time) == 1) ? "" : "s"); + printf ("NAGIOS %s: ", (result == STATE_OK) ? _("OK") : _("WARNING")); + printf (ngettext ("%d process", "%d processes", proc_entries), proc_entries); + printf (", "); + printf ( + ngettext ("status log updated %d second ago", + "status log updated %d seconds ago", + (int) (current_time - latest_entry_time) ), + (int) (current_time - latest_entry_time) ); + printf ("\n"); return result; } @@ -206,8 +204,7 @@ process_arguments (int argc, char **argv) expire_minutes = atoi (argv[2]); else die (STATE_UNKNOWN, - _("Expiration time must be an integer (seconds)\nType '%s -h' for additional help\n"), - progname); + _("Expiration time must be an integer (seconds)\n")); process_string = argv[3]; return OK; } @@ -219,10 +216,6 @@ process_arguments (int argc, char **argv) break; switch (c) { - case '?': /* print short usage statement if args not parsable */ - printf (_("%s: Unknown argument: %c\n\n"), progname, optopt); - print_usage (); - exit (STATE_UNKNOWN); case 'h': /* help */ print_help (); exit (STATE_OK); @@ -240,24 +233,22 @@ process_arguments (int argc, char **argv) expire_minutes = atoi (optarg); else die (STATE_UNKNOWN, - _("Expiration time must be an integer (seconds)\nType '%s -h' for additional help\n"), - progname); + _("Expiration time must be an integer (seconds)\n")); break; case 'v': verbose++; break; + default: /* print short usage_va statement if args not parsable */ + usage_va(_("Unknown argument - %s"), optarg); } } if (status_log == NULL) - die (STATE_UNKNOWN, - _("You must provide the status_log\nType '%s -h' for additional help\n"), - progname); - else if (process_string == NULL) - die (STATE_UNKNOWN, - _("You must provide a process string\nType '%s -h' for additional help\n"), - progname); + die (STATE_UNKNOWN, _("You must provide the status_log\n")); + + if (process_string == NULL) + die (STATE_UNKNOWN, _("You must provide a process string\n")); return OK; } @@ -272,29 +263,26 @@ print_help (void) printf (_(COPYRIGHT), copyright, email); printf (_("\ -This plugin attempts to check the status of the Nagios process on the local\n\ +This plugin checks the status of the Nagios process on the local\n\ machine. The plugin will check to make sure the Nagios status log is no older\n\ -than the number of minutes specified by the option. It also\n\ -uses the /bin/ps command to check for a process matching whatever you specify\n\ -by the argument.\n")); +than the number of minutes specified by the expires option. It also\n\ +checks the process table for a process matching the command argument.\n\n")); print_usage (); printf (_(UT_HELP_VRSN)); printf (_("\ --F, --filename=FILE\n\ + -F, --filename=FILE\n\ Name of the log file to check\n\ --e, --expires=INTEGER\n\ - Seconds aging afterwhich logfile is condsidered stale\n\ --C, --command=STRING\n\ - Command to search for in process table\n")); + -e, --expires=INTEGER\n\ + Minutes aging after which logfile is considered stale\n\ + -C, --command=STRING\n\ + Substring to search for in process arguments\n")); printf (_("\ Example:\n\ - ./check_nagios -e 5 \\\ - -F /usr/local/nagios/var/status.log \\\ - -C /usr/local/nagios/bin/nagios\n")); + ./check_nagios -e 5 -F /usr/local/nagios/var/status.log -C /usr/local/nagios/bin/nagios\n")); } @@ -302,7 +290,6 @@ Example:\n\ void print_usage (void) { - printf (_("\ -Usage: %s -F -e -C \n"), - progname); + printf ("\ +Usage: %s -F -e -C \n", progname); }