X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;ds=sidebyside;f=t%2Funit%2Fcore%2Fdata_test.c;h=71dae2acbb65f673d011d935e562eba65243a495;hb=967d9181f6329ca00b910c0c458b1c6b60f2a0d6;hp=e8567b1ad61c1f2cb2c1a3cf0f72874a93cdfcc9;hpb=b134ee0677f2dd15cb22197e332ea44f47b688f4;p=sysdb.git

diff --git a/t/unit/core/data_test.c b/t/unit/core/data_test.c
index e8567b1..71dae2a 100644
--- a/t/unit/core/data_test.c
+++ b/t/unit/core/data_test.c
@@ -25,8 +25,12 @@
  * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+#if HAVE_CONFIG_H
+#	include "config.h"
+#endif
+
 #include "core/data.h"
-#include "libsysdb_test.h"
+#include "testutils.h"
 
 #include <assert.h>
 #include <check.h>
@@ -225,10 +229,41 @@ END_TEST
 
 START_TEST(test_cmp)
 {
+	regex_t dummy_re;
 	int64_t int_values1[] = { 1, 2, 3 };
 	int64_t int_values2[] = { 1, 3, 2 };
+	double dec_values1[] = { 12.34, 47.11 };
+	double dec_values2[] = { 47.11, 12.34 };
 	char *string_values1[] = { "a", "b", "c" };
 	char *string_values2[] = { "a", "c", "b" };
+	sdb_time_t dt_values1[] = { 4711, 1234567890123456789L };
+	sdb_time_t dt_values2[] = { 1234567890123456789L, 4711 };
+	struct {
+		size_t length;
+		unsigned char *datum;
+	} bin_values1[] = {
+		{ 3, (unsigned char *)"\x1\x2\x3" },
+		{ 4, (unsigned char *)"\x42\x0\xa\x1b" },
+	};
+	struct {
+		size_t length;
+		unsigned char *datum;
+	} bin_values2[] = {
+		{ 4, (unsigned char *)"\x42\x0\xa\x1b" },
+		{ 3, (unsigned char *)"\x1\x2\x3" },
+	};
+	struct {
+		char *raw;
+		regex_t regex;
+	} re_values1[] = {
+		{ "dummy regex A", dummy_re },
+	};
+	struct {
+		char *raw;
+		regex_t regex;
+	} re_values2[] = {
+		{ "dummy regex B", dummy_re },
+	};
 
 	struct {
 		sdb_data_t d1;
@@ -405,6 +440,27 @@ START_TEST(test_cmp)
 			{ SDB_TYPE_REGEX, { .re = { "a", empty_re } } },
 			1,
 		},
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_INTEGER, { .array = { 0, NULL } } },
+			{ SDB_TYPE_ARRAY | SDB_TYPE_INTEGER, { .array = { 0, NULL } } },
+			0,
+		},
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_INTEGER, { .array = { 0, NULL } } },
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values1), int_values1 } },
+			},
+			-1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values1), int_values1 } },
+			},
+			{ SDB_TYPE_ARRAY | SDB_TYPE_INTEGER, { .array = { 0, NULL } } },
+			1,
+		},
 		{
 			{
 				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
@@ -438,6 +494,60 @@ START_TEST(test_cmp)
 			},
 			1,
 		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dec_values1), dec_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dec_values1), dec_values1 } },
+			},
+			0,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dec_values1), dec_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dec_values2), dec_values2 } },
+			},
+			-1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dec_values2), dec_values2 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dec_values1), dec_values1 } },
+			},
+			1,
+		},
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_STRING, { .array = { 0, NULL } } },
+			{ SDB_TYPE_ARRAY | SDB_TYPE_STRING, { .array = { 0, NULL } } },
+			0,
+		},
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_STRING, { .array = { 0, NULL } } },
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values1), string_values1 } },
+			},
+			-1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values1), string_values1 } },
+			},
+			{ SDB_TYPE_ARRAY | SDB_TYPE_STRING, { .array = { 0, NULL } } },
+			1,
+		},
 		{
 			{
 				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
@@ -471,6 +581,105 @@ START_TEST(test_cmp)
 			},
 			1,
 		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DATETIME,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dt_values1), dt_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DATETIME,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dt_values1), dt_values1 } },
+			},
+			0,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DATETIME,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dt_values1), dt_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DATETIME,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dt_values2), dt_values2 } },
+			},
+			-1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DATETIME,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dt_values2), dt_values2 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_DATETIME,
+				{ .array = { SDB_STATIC_ARRAY_LEN(dt_values1), dt_values1 } },
+			},
+			1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_BINARY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(bin_values1), bin_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_BINARY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(bin_values1), bin_values1 } },
+			},
+			0,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_BINARY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(bin_values1), bin_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_BINARY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(bin_values2), bin_values2 } },
+			},
+			-1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_BINARY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(bin_values2), bin_values2 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_BINARY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(bin_values1), bin_values1 } },
+			},
+			1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_REGEX,
+				{ .array = { SDB_STATIC_ARRAY_LEN(re_values1), re_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_REGEX,
+				{ .array = { SDB_STATIC_ARRAY_LEN(re_values1), re_values1 } },
+			},
+			0,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_REGEX,
+				{ .array = { SDB_STATIC_ARRAY_LEN(re_values1), re_values1 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_REGEX,
+				{ .array = { SDB_STATIC_ARRAY_LEN(re_values2), re_values2 } },
+			},
+			-1,
+		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_REGEX,
+				{ .array = { SDB_STATIC_ARRAY_LEN(re_values2), re_values2 } },
+			},
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_REGEX,
+				{ .array = { SDB_STATIC_ARRAY_LEN(re_values1), re_values1 } },
+			},
+			1,
+		},
 	};
 
 	size_t i;
@@ -707,6 +916,7 @@ START_TEST(test_strcmp)
 			{ SDB_TYPE_STRING, { .string = "/regex/" } },
 			0,
 		},
+		/* TODO: add support for arrays */
 	};
 
 	size_t i;
@@ -730,21 +940,51 @@ END_TEST
 START_TEST(test_inarray)
 {
 	int64_t int_values[] = { 47, 11, 64 };
+	int64_t int_values2[] = { 64, 11 };
+	int64_t int_values3[] = { 47, 11, 42 };
 	double dec_values[] = { 12.3, 47.11, 64.0 };
+	double dec_values2[] = { 12.3, 47.11 };
+	double dec_values3[] = { 2.3, 47.11 };
 	char *string_values[] = { "foo", "bar", "qux", "baz" };
+	char *string_values2[] = { "qux", "bar" };
+	char *string_values3[] = { "foo", "bar", "qux", "baz", "bay" };
 
 	sdb_data_t int_array = {
 		SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
 		{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } }
 	};
+	sdb_data_t int_array2 = {
+		SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+		{ .array = { SDB_STATIC_ARRAY_LEN(int_values2), int_values2 } }
+	};
+	sdb_data_t int_array3 = {
+		SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+		{ .array = { SDB_STATIC_ARRAY_LEN(int_values3), int_values3 } }
+	};
 	sdb_data_t dec_array = {
 		SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
 		{ .array = { SDB_STATIC_ARRAY_LEN(dec_values), dec_values } }
 	};
+	sdb_data_t dec_array2 = {
+		SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+		{ .array = { SDB_STATIC_ARRAY_LEN(dec_values2), dec_values2 } }
+	};
+	sdb_data_t dec_array3 = {
+		SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+		{ .array = { SDB_STATIC_ARRAY_LEN(dec_values3), dec_values3 } }
+	};
 	sdb_data_t string_array = {
 		SDB_TYPE_ARRAY | SDB_TYPE_STRING,
 		{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } }
 	};
+	sdb_data_t string_array2 = {
+		SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+		{ .array = { SDB_STATIC_ARRAY_LEN(string_values2), string_values2 } }
+	};
+	sdb_data_t string_array3 = {
+		SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+		{ .array = { SDB_STATIC_ARRAY_LEN(string_values3), string_values3 } }
+	};
 
 	struct {
 		sdb_data_t value;
@@ -756,8 +996,6 @@ START_TEST(test_inarray)
 		{ { SDB_TYPE_INTEGER, { .integer = 64    } }, int_array,    1 },
 		{ { SDB_TYPE_INTEGER, { .integer = 65    } }, int_array,    0 },
 		{ { SDB_TYPE_NULL,    { .integer = 0     } }, int_array,    0 },
-		{ int_array, { SDB_TYPE_INTEGER, { .integer = 47    } },    0 },
-		{ int_array, int_array, 0 },
 		{ { SDB_TYPE_DECIMAL, { .decimal = 12.3  } }, dec_array,    1 },
 		{ { SDB_TYPE_DECIMAL, { .decimal = 47.11 } }, dec_array,    1 },
 		{ { SDB_TYPE_DECIMAL, { .decimal = 64.0  } }, dec_array,    1 },
@@ -773,6 +1011,46 @@ START_TEST(test_inarray)
 		{ { SDB_TYPE_STRING,  { .string  = "ba"  } }, string_array, 0 },
 		{ { SDB_TYPE_STRING,  { .string  = "abc" } }, string_array, 0 },
 		{ { SDB_TYPE_NULL,    { .integer = 0     } }, string_array, 0 },
+		{ int_array, { SDB_TYPE_INTEGER, { .integer = 47 } },       0 },
+		{ int_array,     int_array,    1 },
+		{ int_array2,    int_array,    1 },
+		{ int_array3,    int_array,    0 },
+		{ dec_array2,    int_array,    0 },
+		{ string_array2, int_array,    0 },
+		{ dec_array,     dec_array,    1 },
+		{ dec_array2,    dec_array,    1 },
+		{ dec_array3,    dec_array,    0 },
+		{ int_array2,    dec_array,    0 },
+		{ string_array2, dec_array,    0 },
+		{ string_array,  string_array, 1 },
+		{ string_array2, string_array, 1 },
+		{ string_array3, string_array, 0 },
+		{ int_array2,    string_array, 0 },
+		{ dec_array2,    string_array, 0 },
+		{
+			{ SDB_TYPE_INTEGER | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			int_array, 1,
+		},
+		{
+			{ SDB_TYPE_INTEGER | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			dec_array, 0,
+		},
+		{
+			{ SDB_TYPE_DECIMAL | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			dec_array, 1,
+		},
+		{
+			{ SDB_TYPE_DECIMAL | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			int_array, 0,
+		},
+		{
+			{ SDB_TYPE_STRING | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			string_array, 1,
+		},
+		{
+			{ SDB_TYPE_STRING | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			dec_array, 0,
+		},
 	};
 
 	size_t i;
@@ -794,6 +1072,93 @@ START_TEST(test_inarray)
 }
 END_TEST
 
+START_TEST(test_array_get)
+{
+	int64_t int_values[] = { 47, 11, 64 };
+	double dec_values[] = { 12.3, 47.11, 64.0 };
+	char *string_values[] = { "foo", "bar", "qux", "baz" };
+
+	sdb_data_t int_array = {
+		SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+		{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } }
+	};
+	sdb_data_t dec_array = {
+		SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL,
+		{ .array = { SDB_STATIC_ARRAY_LEN(dec_values), dec_values } }
+	};
+	sdb_data_t string_array = {
+		SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+		{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } }
+	};
+
+	struct {
+		sdb_data_t array;
+		size_t i;
+		sdb_data_t expected;
+	} golden_data[] = {
+		{ int_array, 0, { SDB_TYPE_INTEGER, { .integer = 47 } } },
+		{ int_array, 1, { SDB_TYPE_INTEGER, { .integer = 11 } } },
+		{ int_array, 2, { SDB_TYPE_INTEGER, { .integer = 64 } } },
+		{ int_array, 3, { -1, { .integer = 0 } } },
+		{ dec_array, 0, { SDB_TYPE_DECIMAL, { .decimal = 12.3 } } },
+		{ dec_array, 1, { SDB_TYPE_DECIMAL, { .decimal = 47.11 } } },
+		{ dec_array, 2, { SDB_TYPE_DECIMAL, { .decimal = 64.0 } } },
+		{ dec_array, 3, { -1, { .integer = 0 } } },
+		{ string_array, 0, { SDB_TYPE_STRING, { .string = "foo" } } },
+		{ string_array, 1, { SDB_TYPE_STRING, { .string = "bar" } } },
+		{ string_array, 2, { SDB_TYPE_STRING, { .string = "qux" } } },
+		{ string_array, 3, { SDB_TYPE_STRING, { .string = "baz" } } },
+		{ string_array, 4, { -1, { .integer = 0 } } },
+		{ { SDB_TYPE_INTEGER, { .integer = 666 } }, 0, { -1, { .integer = 0 } } },
+		{ { SDB_TYPE_INTEGER, { .integer = 666 } }, 1, { -1, { .integer = 0 } } },
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_INTEGER, { .array = { 0, NULL } } },
+			0, { -1, { .integer = 0 } },
+		},
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_DECIMAL, { .array = { 0, NULL } } },
+			0, { -1, { .integer = 0 } },
+		},
+		{
+			{ SDB_TYPE_ARRAY | SDB_TYPE_STRING, { .array = { 0, NULL } } },
+			0, { -1, { .integer = 0 } },
+		},
+	};
+
+	size_t i;
+
+	for (i = 0; i < SDB_STATIC_ARRAY_LEN(golden_data); ++i) {
+		char a_str[1024] = "", v_str[1024] = "", exp_str[1024] = "";
+		sdb_data_t value = SDB_DATA_INIT;
+		int check;
+
+		sdb_data_format(&golden_data[i].array,
+				a_str, sizeof(a_str), SDB_UNQUOTED);
+		sdb_data_format(&golden_data[i].expected,
+				exp_str, sizeof(exp_str), SDB_UNQUOTED);
+
+		check = sdb_data_array_get(&golden_data[i].array,
+				golden_data[i].i, &value);
+
+		sdb_data_format(&value, v_str, sizeof(v_str), SDB_UNQUOTED);
+
+		if (golden_data[i].expected.type < 0) {
+			fail_unless(check < 0,
+					"sdb_data_array_get(%s, %zu) = %d (%s); expected: <0",
+					a_str, golden_data[i].i, check, v_str);
+			continue;
+		}
+
+		fail_unless(check == 0,
+				"sdb_data_array_get(%s, %zu) = %d; expected: 0",
+				a_str, golden_data[i].i, check);
+		fail_unless(! sdb_data_cmp(&value, &golden_data[i].expected),
+				"sdb_data_array_get(%s, %zu) -> '%s'; expected: '%s'",
+				a_str, golden_data[i].i, v_str, exp_str);
+	}
+}
+END_TEST
+
 START_TEST(test_parse_op)
 {
 	struct {
@@ -836,8 +1201,12 @@ START_TEST(test_expr_eval)
 	sdb_data_t err = { -1, { .integer = 0 } };
 
 	int64_t int_values[] = { 47, 11, 23 };
+	int64_t expected_int_append[] = { 47, 11, 23, 42 };
+	int64_t expected_int_prepend[] = { 42, 47, 11, 23 };
 	int64_t expected_int_concat[] = { 47, 11, 23, 47, 11, 23 };
 	char *string_values[] = { "foo", "bar", "qux" "baz" };
+	char *expected_string_append[] = { "foo", "bar", "qux" "baz", "bay" };
+	char *expected_string_prepend[] = { "bay", "foo", "bar", "qux" "baz" };
 	char *expected_string_concat[] =
 		{ "foo", "bar", "qux" "baz", "foo", "bar", "qux" "baz" };
 
@@ -1002,6 +1371,44 @@ START_TEST(test_expr_eval)
 				} },
 			},
 		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+			{ SDB_TYPE_INTEGER, { .integer = 42 }, },
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+				{ .array = {
+						SDB_STATIC_ARRAY_LEN(expected_int_append),
+						expected_int_append
+				} },
+			},
+		},
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 42 }, },
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_INTEGER,
+				{ .array = {
+						SDB_STATIC_ARRAY_LEN(expected_int_prepend),
+						expected_int_prepend
+				} },
+			},
+		},
 		{
 			{
 				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
@@ -1024,6 +1431,108 @@ START_TEST(test_expr_eval)
 				} },
 			},
 		},
+		{
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+			{ SDB_TYPE_STRING, { .string = "bay" } },
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+				{ .array = {
+						SDB_STATIC_ARRAY_LEN(expected_string_append),
+						expected_string_append
+				} },
+			},
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "bay" } },
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_ARRAY | SDB_TYPE_STRING,
+				{ .array = {
+						SDB_STATIC_ARRAY_LEN(expected_string_prepend),
+						expected_string_prepend
+				} },
+			},
+		},
+		{
+			{ SDB_TYPE_INTEGER | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			{
+				SDB_TYPE_INTEGER | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_INTEGER | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+		},
+		{
+			{
+				SDB_TYPE_INTEGER | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+			{ SDB_TYPE_INTEGER | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_INTEGER | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+		},
+		{
+			{ SDB_TYPE_STRING | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			{
+				SDB_TYPE_STRING | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_STRING | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+		},
+		{
+			{
+				SDB_TYPE_STRING | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+			{ SDB_TYPE_STRING | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			err,
+			err,
+			err,
+			err,
+			err,
+			{
+				SDB_TYPE_STRING | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+		},
 		{
 			{ SDB_TYPE_NULL, { .integer = 0 } },
 			{ SDB_TYPE_NULL, { .integer = 0 } },
@@ -1199,6 +1708,237 @@ START_TEST(test_expr_eval)
 			{ SDB_TYPE_DATETIME, { .datetime = 0 } },
 			err,
 		},
+		/* unsupported type-mismatches */
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_STRING, { .string = "20.0" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_BINARY, { .binary = { 4, (unsigned char *)"20.0" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_INTEGER, { .integer = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_DECIMAL, { .decimal = 20.0 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_STRING, { .string = "20" } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_DATETIME, { .datetime = 20 } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_BINARY, { .binary = { 2, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_BINARY, { .binary = { 3, (unsigned char *)"20" } } },
+			err, err, err, err, err, err,
+		},
+		{
+			{ SDB_TYPE_REGEX, { .re = { ".", empty_re } } },
+			{ SDB_TYPE_REGEX + 1, { .integer = 0 } },
+			err, err, err, err, err, err,
+		},
 	};
 
 	size_t i;
@@ -1220,6 +1960,7 @@ START_TEST(test_expr_eval)
 		for (j = 0; j < SDB_STATIC_ARRAY_LEN(tests); ++j) {
 			sdb_data_t res;
 			int check;
+			int type1, type2, type;
 
 			char d1_str[64] = "", d2_str[64] = "";
 			sdb_data_format(&golden_data[i].d1, d1_str, sizeof(d1_str),
@@ -1227,12 +1968,29 @@ START_TEST(test_expr_eval)
 			sdb_data_format(&golden_data[i].d2, d2_str, sizeof(d2_str),
 					SDB_DOUBLE_QUOTED);
 
+			type1 = golden_data[i].d1.type;
+			type2 = golden_data[i].d2.type;
+			if (sdb_data_isnull(&golden_data[i].d1))
+				type1 = SDB_TYPE_NULL;
+			if (sdb_data_isnull(&golden_data[i].d2))
+				type2 = SDB_TYPE_NULL;
+			type = sdb_data_expr_type(tests[j].op, type1, type2);
+
 			check = sdb_data_expr_eval(tests[j].op,
 					&golden_data[i].d1, &golden_data[i].d2, &res);
 			fail_unless((check == 0) == (tests[j].expected.type != -1),
 					"sdb_data_expr_eval(%s, %s, %s) = %d; expected: %d",
 					SDB_DATA_OP_TO_STRING(tests[j].op), d1_str, d2_str, check,
 					tests[j].expected.type == -1 ? -1 : 0);
+
+			fail_unless(tests[j].expected.type == type,
+					"sdb_data_expr_eval(%s, %s, %s) expected to evaluate "
+					"to type %d while sdb_data_expr_type(%d, %d, %d) "
+					"predicted type %d", SDB_DATA_OP_TO_STRING(tests[j].op),
+					d1_str, d2_str, tests[j].expected.type,
+					tests[j].op, golden_data[i].d1.type,
+					golden_data[i].d2.type, type);
+
 			if (tests[j].expected.type == -1)
 				continue;
 
@@ -1267,6 +2025,9 @@ END_TEST
 
 START_TEST(test_format)
 {
+	int64_t int_values[] = { 47, 11, 23 };
+	char *string_values[] = { "foo", "bar", "qux", "baz" };
+
 	struct {
 		sdb_data_t datum;
 		const char *expected;
@@ -1314,6 +2075,24 @@ START_TEST(test_format)
 			{ SDB_TYPE_REGEX, { .re = { "some regex", empty_re } } },
 			"\"/some regex/\"",
 		},
+		{
+			{ SDB_TYPE_INTEGER | SDB_TYPE_ARRAY, { .array = { 0, NULL } } },
+			"[]",
+		},
+		{
+			{
+				SDB_TYPE_INTEGER | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(int_values), int_values } },
+			},
+			"[47, 11, 23]",
+		},
+		{
+			{
+				SDB_TYPE_STRING | SDB_TYPE_ARRAY,
+				{ .array = { SDB_STATIC_ARRAY_LEN(string_values), string_values } },
+			},
+			"[\"foo\", \"bar\", \"qux\", \"baz\"]",
+		},
 	};
 
 	size_t i;
@@ -1393,42 +2172,37 @@ START_TEST(test_parse)
 				golden_data[i].input, type);
 
 		if (type == SDB_TYPE_STRING)
-			fail_unless(golden_data[i].input == result.data.string,
-					"sdb_data_parse(%s, %d, <d>) modified input string",
+			fail_unless(golden_data[i].input != result.data.string,
+					"sdb_data_parse(%s, %d, <d>) copied input string",
 					golden_data[i].input, type);
 		if (type == SDB_TYPE_BINARY)
-			fail_unless(golden_data[i].input == (char *)result.data.binary.datum,
-					"sdb_data_parse(%s, %d, <d>) modified input string",
+			fail_unless(golden_data[i].input != (char *)result.data.binary.datum,
+					"sdb_data_parse(%s, %d, <d>) copied input string",
 					golden_data[i].input, type);
-		if (type == SDB_TYPE_REGEX) {
+		if (type == SDB_TYPE_REGEX)
 			fail_unless(golden_data[i].input != result.data.re.raw,
 					"sdb_data_parse(%s, %d, <d>) copied input string",
 					golden_data[i].input, type);
-			sdb_data_free_datum(&result);
-		}
+		sdb_data_free_datum(&result);
 	}
 }
 END_TEST
 
-Suite *
-core_data_suite(void)
+TEST_MAIN("core::data")
 {
-	Suite *s = suite_create("core::data");
-	TCase *tc;
-
-	tc = tcase_create("core");
+	TCase *tc = tcase_create("core");
 	tcase_add_test(tc, test_data);
 	tcase_add_test(tc, test_cmp);
 	tcase_add_test(tc, test_strcmp);
 	tcase_add_test(tc, test_inarray);
+	tcase_add_test(tc, test_array_get);
 	tcase_add_test(tc, test_parse_op);
 	tcase_add_test(tc, test_expr_eval);
 	tcase_add_test(tc, test_format);
 	tcase_add_test(tc, test_parse);
-	suite_add_tcase(s, tc);
-
-	return s;
-} /* core_data_suite */
+	ADD_TCASE(tc);
+}
+TEST_MAIN_END
 
 /* vim: set tw=78 sw=4 ts=4 noexpandtab : */