X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;ds=sidebyside;f=src%2Fcore%2Fstore_expr.c;h=5e15f5350b9ca26d16564317e46957e8285fbcd3;hb=026ce2bb377f4055e3a0a1d20a2f91e5a73a49b0;hp=11370bb438455f6fcf3b08a34a4bcfa5607a98af;hpb=3a98a4db16092c17a70dffe71adaf9459fa9db2a;p=sysdb.git

diff --git a/src/core/store_expr.c b/src/core/store_expr.c
index 11370bb..5e15f53 100644
--- a/src/core/store_expr.c
+++ b/src/core/store_expr.c
@@ -39,6 +39,7 @@
 #include "core/object.h"
 
 #include <assert.h>
+#include <stdbool.h>
 #include <stdlib.h>
 #include <string.h>
 
@@ -55,6 +56,7 @@ struct sdb_store_expr_iter {
 
 	sdb_data_t array;
 	size_t array_idx;
+	bool free_array;
 
 	sdb_store_matcher_t *filter;
 };
@@ -167,7 +169,7 @@ sdb_store_expr_fieldvalue(int field)
 	sdb_data_t value = { SDB_TYPE_INTEGER, { .integer = field } };
 	sdb_store_expr_t *e;
 
-	if ((field < SDB_FIELD_NAME) || (SDB_FIELD_BACKEND < field))
+	if ((field < SDB_FIELD_NAME) || (SDB_FIELD_TIMESERIES < field))
 		return NULL;
 	e = SDB_STORE_EXPR(sdb_object_create("store-fieldvalue", expr_type,
 				FIELD_VALUE, NULL, NULL, &value));
@@ -286,7 +288,12 @@ sdb_store_expr_iterable(sdb_store_expr_t *expr, int context)
 		if ((context != SDB_HOST) && (context != SDB_SERVICE)
 				&& (context != SDB_METRIC) && (context != SDB_ATTRIBUTE))
 			return 0;
-		return expr->data.data.integer == SDB_FIELD_BACKEND;
+		if (expr->data.data.integer == SDB_FIELD_BACKEND)
+			return 1;
+		else if (expr->data.data.integer == SDB_FIELD_VALUE)
+			/* we don't current support this just like when using
+			 * the attribute[<name>] syntax */
+			return 0;
 	}
 	else if (! expr->type) {
 		return !!(expr->data.type & SDB_TYPE_ARRAY);
@@ -301,11 +308,14 @@ sdb_store_expr_iter(sdb_store_expr_t *expr, sdb_store_obj_t *obj,
 	sdb_store_expr_iter_t *iter;
 	sdb_avltree_iter_t *tree = NULL;
 	sdb_data_t array = SDB_DATA_INIT;
+	bool free_array = 0;
 
-	if ((! expr) || (! obj))
+	if (! expr)
 		return NULL;
 
 	if (expr->type == TYPED_EXPR) {
+		if (! obj)
+			return NULL;
 		if (obj->type == SDB_HOST) {
 			if (expr->data.data.integer == SDB_SERVICE)
 				tree = sdb_avltree_get_iter(HOST(obj)->services);
@@ -324,6 +334,8 @@ sdb_store_expr_iter(sdb_store_expr_t *expr, sdb_store_obj_t *obj,
 		}
 	}
 	else if (expr->type == FIELD_VALUE) {
+		if (! obj)
+			return NULL;
 		if (expr->data.data.integer == SDB_FIELD_BACKEND) {
 			/* while scanning the store, we hold a read lock, so it's safe to
 			 * access the data without copying */
@@ -336,15 +348,27 @@ sdb_store_expr_iter(sdb_store_expr_t *expr, sdb_store_obj_t *obj,
 		if (expr->data.type & SDB_TYPE_ARRAY)
 			array = expr->data;
 	}
-	else
-		return NULL;
+	else {
+		sdb_data_t value = SDB_DATA_INIT;
+		if (sdb_store_expr_eval(expr, obj, &value, filter))
+			return NULL;
+		if (! (value.type & SDB_TYPE_ARRAY)) {
+			sdb_data_free_datum(&value);
+			return NULL;
+		}
+		array = value;
+		free_array = 1;
+	}
 
 	if ((! tree) && (array.type == SDB_TYPE_NULL))
 		return NULL;
 
 	iter = calloc(1, sizeof(*iter));
-	if (! iter)
+	if (! iter) {
+		if (free_array)
+			sdb_data_free_datum(&array);
 		return NULL;
+	}
 
 	sdb_object_ref(SDB_OBJ(obj));
 	sdb_object_ref(SDB_OBJ(expr));
@@ -354,6 +378,7 @@ sdb_store_expr_iter(sdb_store_expr_t *expr, sdb_store_obj_t *obj,
 	iter->expr = expr;
 	iter->tree = tree;
 	iter->array = array;
+	iter->free_array = free_array;
 	iter->filter = filter;
 	return iter;
 } /* sdb_store_expr_iter */
@@ -370,6 +395,8 @@ sdb_store_expr_iter_destroy(sdb_store_expr_iter_t *iter)
 		sdb_avltree_iter_destroy(iter->tree);
 	iter->tree = NULL;
 
+	if (iter->free_array)
+		sdb_data_free_datum(&iter->array);
 	iter->array = null;
 	iter->array_idx = 0;
 
@@ -385,8 +412,21 @@ sdb_store_expr_iter_has_next(sdb_store_expr_iter_t *iter)
 	if (! iter)
 		return 0;
 
-	if (iter->tree)
+	if (iter->tree) {
+		/* this function may be called before get_next,
+		 * so we'll have to apply filters here as well */
+		if (iter->filter) {
+			sdb_store_obj_t *child;
+			while ((child = STORE_OBJ(sdb_avltree_iter_peek_next(iter->tree)))) {
+				if (sdb_store_matcher_matches(iter->filter, child, NULL))
+					break;
+				(void)sdb_avltree_iter_get_next(iter->tree);
+			}
+		}
+
 		return sdb_avltree_iter_has_next(iter->tree);
+	}
+
 	return iter->array_idx < iter->array.data.array.length;
 } /* sdb_store_expr_iter_has_next */
 
@@ -411,16 +451,19 @@ sdb_store_expr_iter_get_next(sdb_store_expr_iter_t *iter)
 					&& (! sdb_store_matcher_matches(iter->filter, child, NULL)))
 				continue;
 
-			if (sdb_store_expr_eval(iter->expr, iter->obj, &ret, iter->filter))
+			if (sdb_store_expr_eval(iter->expr, child, &ret, iter->filter))
 				return null;
 			break;
 		}
 
 		/* Skip over any filtered objects */
-		if (iter->filter)
-			while ((child = STORE_OBJ(sdb_avltree_iter_peek_next(iter->tree))))
+		if (iter->filter) {
+			while ((child = STORE_OBJ(sdb_avltree_iter_peek_next(iter->tree)))) {
 				if (sdb_store_matcher_matches(iter->filter, child, NULL))
 					break;
+				(void)sdb_avltree_iter_get_next(iter->tree);
+			}
+		}
 
 		return ret;
 	}