X-Git-Url: https://git.tokkee.org/?a=blobdiff_plain;ds=sidebyside;f=builtin-tag.c;h=28c36fdcd1658968ff7c3e2f1d6ba6f364f99592;hb=44c36d1ccc9a40bfb31910dfd7e18d59fa8be502;hp=4a4a88c10b4b2f9e55662bd4c1c17051ae7e6aac;hpb=356eff534cfb181cb65f92240692ff4306e3212a;p=git.git

diff --git a/builtin-tag.c b/builtin-tag.c
index 4a4a88c10..28c36fdcd 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -226,19 +226,17 @@ static int do_sign(struct strbuf *buffer)
 
 	if (write_in_full(gpg.in, buffer->buf, buffer->len) != buffer->len) {
 		close(gpg.in);
+		close(gpg.out);
 		finish_command(&gpg);
 		return error("gpg did not accept the tag data");
 	}
 	close(gpg.in);
-	gpg.close_in = 0;
 	len = strbuf_read(buffer, gpg.out, 1024);
+	close(gpg.out);
 
 	if (finish_command(&gpg) || !len || len < 0)
 		return error("gpg failed to sign the tag");
 
-	if (len < 0)
-		return error("could not read the entire signature from gpg.");
-
 	return 0;
 }