diff --git a/src/ipvs.c b/src/ipvs.c
index 4c6305864941e4d9572d72ec59326c8679365d25..87eee108a79410853b6f02e107697b7a358f465a 100644 (file)
--- a/src/ipvs.c
+++ b/src/ipvs.c
#define log_err(...) ERROR ("ipvs: " __VA_ARGS__)
#define log_info(...) INFO ("ipvs: " __VA_ARGS__)
-
/*
* private variables
*/
-
-static int sockfd = -1;
-
+static int sockfd = -1;
/*
* libipvs API
*/
-
static struct ip_vs_get_services *ipvs_get_services (void)
{
struct ip_vs_getinfo ipvs_info;
return ret;
} /* ip_vs_get_dests */
-
/*
* collectd plugin API and helper functions
*/
-
static int cipvs_init (void)
{
struct ip_vs_getinfo ipvs_info;
log_err ("cipvs_init: getsockopt() failed: %s",
sstrerror (errno, errbuf, sizeof (errbuf)));
close (sockfd);
+ sockfd = -1;
return -1;
}
log_err ("cipvs_init: IPVS version too old (%d.%d.%d < %d.%d.%d)",
NVERSION (ipvs_info.version), 1, 1, 4);
close (sockfd);
+ sockfd = -1;
return -1;
}
else {
/* inet_ntoa() returns a pointer to a statically allocated buffer
* I hope non-glibc systems behave the same */
- len = snprintf (pi, size, "%s_%s%u", inet_ntoa (addr),
+ len = ssnprintf (pi, size, "%s_%s%u", inet_ntoa (addr),
(se->protocol == IPPROTO_TCP) ? "TCP" : "UDP",
ntohs (se->port));
/* inet_ntoa() returns a pointer to a statically allocated buffer
* I hope non-glibc systems behave the same */
- len = snprintf (ti, size, "%s_%u", inet_ntoa (addr),
+ len = ssnprintf (ti, size, "%s_%u", inet_ntoa (addr),
ntohs (de->port));
if ((0 > len) || (size <= len)) {
vl.values = values;
vl.values_len = 1;
- vl.time = time (NULL);
vl.interval = interval_g;
- strcpy (vl.host, hostname_g);
- strcpy (vl.plugin, "ipvs");
- strcpy (vl.plugin_instance, pi);
- strcpy (vl.type_instance, (NULL != ti) ? ti : "total");
+ sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+ sstrncpy (vl.plugin, "ipvs", sizeof (vl.plugin));
+ sstrncpy (vl.plugin_instance, pi, sizeof (vl.plugin_instance));
+ sstrncpy (vl.type, "connections", sizeof (vl.type));
+ sstrncpy (vl.type_instance, (NULL != ti) ? ti : "total",
+ sizeof (vl.type_instance));
- plugin_dispatch_values ("connections", &vl);
+ plugin_dispatch_values (&vl);
return;
} /* cipvs_submit_connections */
vl.values = values;
vl.values_len = 2;
- vl.time = time (NULL);
vl.interval = interval_g;
- strcpy (vl.host, hostname_g);
- strcpy (vl.plugin, "ipvs");
- strcpy (vl.plugin_instance, pi);
- strcpy (vl.type_instance, (NULL != ti) ? ti : "total");
+ sstrncpy (vl.host, hostname_g, sizeof (vl.host));
+ sstrncpy (vl.plugin, "ipvs", sizeof (vl.plugin));
+ sstrncpy (vl.plugin_instance, pi, sizeof (vl.plugin_instance));
+ sstrncpy (vl.type, t, sizeof (vl.type));
+ sstrncpy (vl.type_instance, (NULL != ti) ? ti : "total",
+ sizeof (vl.type_instance));
- plugin_dispatch_values (t, &vl);
+ plugin_dispatch_values (&vl);
return;
} /* cipvs_submit_if */
char ti[DATA_MAX_NAME_LEN];
- if (0 != get_ti (de, ti, DATA_MAX_NAME_LEN))
+ if (0 != get_ti (de, ti, sizeof (ti)))
return;
cipvs_submit_connections (pi, ti, stats.conns);
int i = 0;
- if (0 != get_pi (se, pi, DATA_MAX_NAME_LEN))
+ if (0 != get_pi (se, pi, sizeof (pi)))
return;
cipvs_submit_connections (pi, NULL, stats.conns);
static int cipvs_read (void)
{
struct ip_vs_get_services *services = NULL;
-
int i = 0;
+ if (sockfd < 0)
+ return (-1);
+
if (NULL == (services = ipvs_get_services ()))
return -1;
static int cipvs_shutdown (void)
{
- close (sockfd);
+ if (sockfd >= 0)
+ close (sockfd);
+ sockfd = -1;
+
return 0;
} /* cipvs_shutdown */
} /* module_register */
/* vim: set sw=4 ts=4 tw=78 noexpandtab : */
-