meson.build: define _GNU_SOURCE for getaddrinfo() and sigaction() with glibc

[ncmpc.git] / src / colors.c

diff --git a/src/colors.c b/src/colors.c
index 2c1a2d04922571224e11bf3d7cff1f762b16b365..5a79fd9bbfff8b2c6a7967e499af18df19c98544 100644 (file)
--- a/src/colors.c
+++ b/src/colors.c
@@ -80,7 +80,7 @@ colors_lookup_by_name(const char *name)
        return NULL;
 }
 
-static int
+static void
 colors_update_pair(enum color id)
 {
        assert(id > 0 && id < COLOR_END);
@@ -93,7 +93,6 @@ colors_update_pair(enum color id)
        init_pair(id,
                (fg < 0 ? -1 : fg),
                (bg < 0 ? -1 : bg));
-       return 0;
 }
 
 int
@@ -166,13 +165,13 @@ colors_str2color(const char *str)
 /* This function is called from conf.c before curses have been started,
  * it adds the definition to the color_definition_list and init_color() is
  * done in colors_start() */
-int
+bool
 colors_define(const char *name, short r, short g, short b)
 {
        int color = colors_str2color(name);
 
        if (color < 0)
-               return color;
+               return false;
 
        color_definition_entry_t *entry =
                g_malloc(sizeof(color_definition_entry_t));
@@ -183,10 +182,10 @@ colors_define(const char *name, short r, short g, short b)
 
        color_definition_list = g_list_append(color_definition_list, entry);
 
-       return 0;
+       return true;
 }
 
-int
+bool
 colors_assign(const char *name, const char *value)
 {
        color_entry_t *entry = colors_lookup_by_name(name);
@@ -194,19 +193,18 @@ colors_assign(const char *name, const char *value)
        if (!entry) {
                fprintf(stderr, "%s: %s",
                        _("Unknown color field"), name);
-               return -1;
+               return false;
        }
 
        const int color = colors_str2color(value);
        if (color == COLOR_ERROR)
-               return -1;
+               return false;
 
        entry->color = color;
-       return 0;
+       return true;
 }
 
-
-int
+void
 colors_start(void)
 {
        if (has_colors()) {
@@ -242,22 +240,13 @@ colors_start(void)
 
        /* free the color_definition_list */
        if (color_definition_list) {
-               GList *list = color_definition_list;
-
-               while (list) {
-                       g_free(list->data);
-                       list=list->next;
-               }
-
-               g_list_free(color_definition_list);
+               g_list_free_full(color_definition_list, g_free);
                color_definition_list = NULL;
        }
-
-       return 0;
 }
 #endif
 
-int
+void
 colors_use(WINDOW *w, enum color id)
 {
        color_entry_t *entry = &colors[id];
@@ -281,6 +270,4 @@ colors_use(WINDOW *w, enum color id)
 #ifdef ENABLE_COLORS
        }
 #endif
-
-       return 0;
 }