Fix some warnings (on cygwin) to allow -Werror

[git.git] / pager.c

diff --git a/pager.c b/pager.c
index 3bfed025996bbdc31aebd4a7b096236c538a4e75..6b5c9e44b4ded338ddb344ae454d83a685b7569a 100644 (file)
--- a/pager.c
+++ b/pager.c
@@ -1,12 +1,13 @@
 #include "cache.h"
 
-#include <sys/select.h>
-
 /*
- * This is split up from the rest of git so that we might do
- * something different on Windows, for example.
+ * This is split up from the rest of git so that we can do
+ * something different on Windows.
  */
 
+static int spawned_pager;
+
+#ifndef __MINGW32__
 static void run_pager(const char *pager)
 {
        /*
@@ -22,17 +23,40 @@ static void run_pager(const char *pager)
        execlp(pager, pager, NULL);
        execl("/bin/sh", "sh", "-c", pager, NULL);
 }
+#else
+#include "run-command.h"
+
+static const char *pager_argv[] = { "sh", "-c", NULL, NULL };
+static struct child_process pager_process = {
+       .argv = pager_argv,
+       .in = -1
+};
+static void wait_for_pager(void)
+{
+       fflush(stdout);
+       fflush(stderr);
+       /* signal EOF to pager */
+       close(1);
+       close(2);
+       finish_command(&pager_process);
+}
+#endif
 
 void setup_pager(void)
 {
+#ifndef __MINGW32__
        pid_t pid;
        int fd[2];
+#endif
        const char *pager = getenv("GIT_PAGER");
 
        if (!isatty(1))
                return;
-       if (!pager)
+       if (!pager) {
+               if (!pager_program)
+                       git_config(git_default_config, NULL);
                pager = pager_program;
+       }
        if (!pager)
                pager = getenv("PAGER");
        if (!pager)
@@ -40,8 +64,9 @@ void setup_pager(void)
        else if (!*pager || !strcmp(pager, "cat"))
                return;
 
-       pager_in_use = 1; /* means we are emitting to terminal */
+       spawned_pager = 1; /* means we are emitting to terminal */
 
+#ifndef __MINGW32__
        if (pipe(fd) < 0)
                return;
        pid = fork();
@@ -54,6 +79,7 @@ void setup_pager(void)
        /* return in the child */
        if (!pid) {
                dup2(fd[1], 1);
+               dup2(fd[1], 2);
                close(fd[0]);
                close(fd[1]);
                return;
@@ -68,4 +94,29 @@ void setup_pager(void)
        run_pager(pager);
        die("unable to execute pager '%s'", pager);
        exit(255);
+#else
+       /* spawn the pager */
+       pager_argv[2] = pager;
+       if (start_command(&pager_process))
+               return;
+
+       /* original process continues, but writes to the pipe */
+       dup2(pager_process.in, 1);
+       dup2(pager_process.in, 2);
+       close(pager_process.in);
+
+       /* this makes sure that the parent terminates after the pager */
+       atexit(wait_for_pager);
+#endif
+}
+
+int pager_in_use(void)
+{
+       const char *env;
+
+       if (spawned_pager)
+               return 1;
+
+       env = getenv("GIT_PAGER_IN_USE");
+       return env ? git_config_bool("GIT_PAGER_IN_USE", env) : 0;
 }