Code

Handle core.symlinks=false case in merge-recursive.
[git.git] / merge-recursive.c
index d78f58d8d2463c49bf14d3639ec60772b232f7f9..c96e1a734cb0c258cd4adb4f00e247abdf804640 100644 (file)
@@ -3,13 +3,6 @@
  * Fredrik Kuivinen.
  * The thieves were Alex Riesen and Johannes Schindelin, in June/July 2006
  */
-#include <stdarg.h>
-#include <string.h>
-#include <assert.h>
-#include <sys/wait.h>
-#include <sys/types.h>
-#include <sys/stat.h>
-#include <time.h>
 #include "cache.h"
 #include "cache-tree.h"
 #include "commit.h"
 #include "diffcore.h"
 #include "run-command.h"
 #include "tag.h"
-
+#include "unpack-trees.h"
 #include "path-list.h"
-
-/*#define DEBUG*/
-
-#ifdef DEBUG
-#define debug(...) fprintf(stderr, __VA_ARGS__)
-#else
-#define debug(...) do { ; /* nothing */ } while (0)
-#endif
-
-#ifdef DEBUG
-#include "quote.h"
-static void show_ce_entry(const char *tag, struct cache_entry *ce)
-{
-       if (tag && *tag &&
-           (ce->ce_flags & htons(CE_VALID))) {
-               static char alttag[4];
-               memcpy(alttag, tag, 3);
-               if (isalpha(tag[0]))
-                       alttag[0] = tolower(tag[0]);
-               else if (tag[0] == '?')
-                       alttag[0] = '!';
-               else {
-                       alttag[0] = 'v';
-                       alttag[1] = tag[0];
-                       alttag[2] = ' ';
-                       alttag[3] = 0;
-               }
-               tag = alttag;
-       }
-
-       fprintf(stderr,"%s%06o %s %d\t",
-                       tag,
-                       ntohl(ce->ce_mode),
-                       sha1_to_hex(ce->sha1),
-                       ce_stage(ce));
-       write_name_quoted("", 0, ce->name,
-                       '\n', stderr);
-       fputc('\n', stderr);
-}
-
-static void ls_files(void) {
-       int i;
-       for (i = 0; i < active_nr; i++) {
-               struct cache_entry *ce = active_cache[i];
-               show_ce_entry("", ce);
-       }
-       fprintf(stderr, "---\n");
-       if (0) ls_files(); /* avoid "unused" warning */
-}
-#endif
+#include "xdiff-interface.h"
 
 /*
  * A virtual commit has
@@ -93,24 +37,25 @@ static struct commit *make_virtual_commit(struct tree *tree, const char *comment
        commit->tree = tree;
        commit->util = (void*)comment;
        *(int*)commit->object.sha1 = virtual_id++;
+       /* avoid warnings */
+       commit->object.parsed = 1;
        return commit;
 }
 
 /*
- * TODO: we should not have to copy the SHA1s around, but rather reference
- * them. That way, sha_eq() is just sha1 == sha2.
+ * Since we use get_tree_entry(), which does not put the read object into
+ * the object pool, we cannot rely on a == b.
  */
 static int sha_eq(const unsigned char *a, const unsigned char *b)
 {
        if (!a && !b)
                return 2;
-       return a && b && memcmp(a, b, 20) == 0;
+       return a && b && hashcmp(a, b) == 0;
 }
 
 /*
- * TODO: check if we can just reuse the active_cache structure: it is already
- * sorted (by name, stage).
- * Only problem: do not write it when flushing the cache.
+ * Since we want to write the index eventually, we cannot reuse the index
+ * for these (temporary) data.
  */
 struct stage_data
 {
@@ -122,32 +67,80 @@ struct stage_data
        unsigned processed:1;
 };
 
-static struct path_list currentFileSet = {NULL, 0, 0, 1};
-static struct path_list currentDirectorySet = {NULL, 0, 0, 1};
+struct output_buffer
+{
+       struct output_buffer *next;
+       char *str;
+};
 
-static int output_indent = 0;
+static struct path_list current_file_set = {NULL, 0, 0, 1};
+static struct path_list current_directory_set = {NULL, 0, 0, 1};
 
-static void output(const char *fmt, ...)
+static int call_depth = 0;
+static int verbosity = 2;
+static int buffer_output = 1;
+static int do_progress = 1;
+static unsigned last_percent;
+static unsigned merged_cnt;
+static unsigned total_cnt;
+static volatile sig_atomic_t progress_update;
+static struct output_buffer *output_list, *output_end;
+
+static int show (int v)
+{
+       return (!call_depth && verbosity >= v) || verbosity >= 5;
+}
+
+static void output(int v, const char *fmt, ...)
 {
        va_list args;
-       int i;
-       for (i = output_indent; i--;)
-               fputs("  ", stdout);
        va_start(args, fmt);
-       vfprintf(stdout, fmt, args);
+       if (buffer_output && show(v)) {
+               struct output_buffer *b = xmalloc(sizeof(*b));
+               nfvasprintf(&b->str, fmt, args);
+               b->next = NULL;
+               if (output_end)
+                       output_end->next = b;
+               else
+                       output_list = b;
+               output_end = b;
+       } else if (show(v)) {
+               int i;
+               for (i = call_depth; i--;)
+                       fputs("  ", stdout);
+               vfprintf(stdout, fmt, args);
+               fputc('\n', stdout);
+       }
        va_end(args);
-       fputc('\n', stdout);
+}
+
+static void flush_output()
+{
+       struct output_buffer *b, *n;
+       for (b = output_list; b; b = n) {
+               int i;
+               for (i = call_depth; i--;)
+                       fputs("  ", stdout);
+               fputs(b->str, stdout);
+               fputc('\n', stdout);
+               n = b->next;
+               free(b->str);
+               free(b);
+       }
+       output_list = NULL;
+       output_end = NULL;
 }
 
 static void output_commit_title(struct commit *commit)
 {
        int i;
-       for (i = output_indent; i--;)
+       flush_output();
+       for (i = call_depth; i--;)
                fputs("  ", stdout);
        if (commit->util)
                printf("virtual %s\n", (char *)commit->util);
        else {
-               printf("%s ", sha1_to_hex(commit->object.sha1));
+               printf("%s ", find_unique_abbrev(commit->object.sha1, DEFAULT_ABBREV));
                if (parse_commit(commit) != 0)
                        printf("(bad commit)\n");
                else {
@@ -165,33 +158,37 @@ static void output_commit_title(struct commit *commit)
        }
 }
 
-static const char *original_index_file;
-static const char *temporary_index_file;
-static int cache_dirty = 0;
+static void progress_interval(int signum)
+{
+       progress_update = 1;
+}
 
-static int flush_cache(void)
+static void setup_progress_signal(void)
 {
-       /* flush temporary index */
-       struct lock_file *lock = xcalloc(1, sizeof(struct lock_file));
-       int fd = hold_lock_file_for_update(lock, getenv("GIT_INDEX_FILE"));
-       if (fd < 0)
-               die("could not lock %s", temporary_index_file);
-       if (write_cache(fd, active_cache, active_nr) ||
-                       close(fd) || commit_lock_file(lock))
-               die ("unable to write %s", getenv("GIT_INDEX_FILE"));
-       discard_cache();
-       cache_dirty = 0;
-       return 0;
+       struct sigaction sa;
+       struct itimerval v;
+
+       memset(&sa, 0, sizeof(sa));
+       sa.sa_handler = progress_interval;
+       sigemptyset(&sa.sa_mask);
+       sa.sa_flags = SA_RESTART;
+       sigaction(SIGALRM, &sa, NULL);
+
+       v.it_interval.tv_sec = 1;
+       v.it_interval.tv_usec = 0;
+       v.it_value = v.it_interval;
+       setitimer(ITIMER_REAL, &v, NULL);
 }
 
-static void setup_index(int temp)
+static void display_progress()
 {
-       const char *idx = temp ? temporary_index_file: original_index_file;
-       if (cache_dirty)
-               die("fatal: cache changed flush_cache();");
-       unlink(temporary_index_file);
-       setenv("GIT_INDEX_FILE", idx, 1);
-       discard_cache();
+       unsigned percent = total_cnt ? merged_cnt * 100 / total_cnt : 0;
+       if (progress_update || percent != last_percent) {
+               fprintf(stderr, "%4u%% (%u/%u) done\r",
+                       percent, merged_cnt, total_cnt);
+               progress_update = 0;
+               last_percent = percent;
+       }
 }
 
 static struct cache_entry *make_cache_entry(unsigned int mode,
@@ -207,7 +204,7 @@ static struct cache_entry *make_cache_entry(unsigned int mode,
        size = cache_entry_size(len);
        ce = xcalloc(1, size);
 
-       memcpy(ce->sha1, sha1, 20);
+       hashcpy(ce->sha1, sha1);
        memcpy(ce->name, path, len);
        ce->ce_flags = create_ce_flags(len, stage);
        ce->ce_mode = create_ce_mode(mode);
@@ -222,9 +219,6 @@ static int add_cacheinfo(unsigned int mode, const unsigned char *sha1,
                const char *path, int stage, int refresh, int options)
 {
        struct cache_entry *ce;
-       if (!cache_dirty)
-               read_cache_from(getenv("GIT_INDEX_FILE"));
-       cache_dirty++;
        ce = make_cache_entry(mode, sha1 ? sha1 : null_sha1, path, stage, refresh);
        if (!ce)
                return error("cache_addinfo failed: %s", strerror(cache_errno));
@@ -242,86 +236,62 @@ static int add_cacheinfo(unsigned int mode, const unsigned char *sha1,
  */
 static int index_only = 0;
 
-/*
- * TODO: this can be streamlined by refactoring builtin-read-tree.c
- */
-static int git_read_tree(const struct tree *tree)
-{
-#if 0
-       fprintf(stderr, "GIT_INDEX_FILE='%s' git-read-tree %s\n",
-               getenv("GIT_INDEX_FILE"),
-               sha1_to_hex(tree->object.sha1));
-#endif
-       int rc;
-       const char *argv[] = { "git-read-tree", NULL, NULL, };
-       if (cache_dirty)
-               die("read-tree with dirty cache");
-       argv[1] = sha1_to_hex(tree->object.sha1);
-       rc = run_command_v(2, argv);
-       return rc < 0 ? -1: rc;
-}
-
-/*
- * TODO: this can be streamlined by refactoring builtin-read-tree.c
- */
-static int git_merge_trees(const char *update_arg,
+static int git_merge_trees(int index_only,
                           struct tree *common,
                           struct tree *head,
                           struct tree *merge)
 {
-#if 0
-       fprintf(stderr, "GIT_INDEX_FILE='%s' git-read-tree %s -m %s %s %s\n",
-               getenv("GIT_INDEX_FILE"),
-               update_arg,
-               sha1_to_hex(common->object.sha1),
-               sha1_to_hex(head->object.sha1),
-               sha1_to_hex(merge->object.sha1));
-#endif
        int rc;
-       const char *argv[] = {
-               "git-read-tree", NULL, "-m", NULL, NULL, NULL,
-               NULL,
-       };
-       if (cache_dirty)
-               flush_cache();
-       argv[1] = update_arg;
-       argv[3] = sha1_to_hex(common->object.sha1);
-       argv[4] = sha1_to_hex(head->object.sha1);
-       argv[5] = sha1_to_hex(merge->object.sha1);
-       rc = run_command_v(6, argv);
-       return rc < 0 ? -1: rc;
+       struct object_list *trees = NULL;
+       struct unpack_trees_options opts;
+
+       memset(&opts, 0, sizeof(opts));
+       if (index_only)
+               opts.index_only = 1;
+       else
+               opts.update = 1;
+       opts.merge = 1;
+       opts.head_idx = 2;
+       opts.fn = threeway_merge;
+
+       object_list_append(&common->object, &trees);
+       object_list_append(&head->object, &trees);
+       object_list_append(&merge->object, &trees);
+
+       rc = unpack_trees(trees, &opts);
+       cache_tree_free(&active_cache_tree);
+       return rc;
+}
+
+static int unmerged_index(void)
+{
+       int i;
+       for (i = 0; i < active_nr; i++) {
+               struct cache_entry *ce = active_cache[i];
+               if (ce_stage(ce))
+                       return 1;
+       }
+       return 0;
 }
 
-/*
- * TODO: this can be streamlined by refactoring builtin-write-tree.c
- */
 static struct tree *git_write_tree(void)
 {
-#if 0
-       fprintf(stderr, "GIT_INDEX_FILE='%s' git-write-tree\n",
-               getenv("GIT_INDEX_FILE"));
-#endif
-       FILE *fp;
-       int rc;
-       char buf[41];
-       unsigned char sha1[20];
-       int ch;
-       unsigned i = 0;
-       if (cache_dirty)
-               flush_cache();
-       fp = popen("git-write-tree 2>/dev/null", "r");
-       while ((ch = fgetc(fp)) != EOF)
-               if (i < sizeof(buf)-1 && ch >= '0' && ch <= 'f')
-                       buf[i++] = ch;
-               else
-                       break;
-       rc = pclose(fp);
-       if (rc == -1 || WEXITSTATUS(rc))
-               return NULL;
-       buf[i] = '\0';
-       if (get_sha1(buf, sha1) != 0)
+       struct tree *result = NULL;
+
+       if (unmerged_index())
                return NULL;
-       return lookup_tree(sha1);
+
+       if (!active_cache_tree)
+               active_cache_tree = cache_tree();
+
+       if (!cache_tree_fully_valid(active_cache_tree) &&
+           cache_tree_update(active_cache_tree,
+                             active_cache, active_nr, 0, 0) < 0)
+               die("error building trees");
+
+       result = lookup_tree(active_cache_tree->sha1);
+
+       return result;
 }
 
 static int save_files_dirs(const unsigned char *sha1,
@@ -329,15 +299,15 @@ static int save_files_dirs(const unsigned char *sha1,
                unsigned int mode, int stage)
 {
        int len = strlen(path);
-       char *newpath = malloc(baselen + len + 1);
+       char *newpath = xmalloc(baselen + len + 1);
        memcpy(newpath, base, baselen);
        memcpy(newpath + baselen, path, len);
        newpath[baselen + len] = '\0';
 
        if (S_ISDIR(mode))
-               path_list_insert(newpath, &currentDirectorySet);
+               path_list_insert(newpath, &current_directory_set);
        else
-               path_list_insert(newpath, &currentFileSet);
+               path_list_insert(newpath, &current_file_set);
        free(newpath);
 
        return READ_TREE_RECURSIVE;
@@ -346,13 +316,9 @@ static int save_files_dirs(const unsigned char *sha1,
 static int get_files_dirs(struct tree *tree)
 {
        int n;
-       debug("get_files_dirs ...\n");
-       if (read_tree_recursive(tree, "", 0, 0, NULL, save_files_dirs) != 0) {
-               debug("  get_files_dirs done (0)\n");
+       if (read_tree_recursive(tree, "", 0, 0, NULL, save_files_dirs) != 0)
                return 0;
-       }
-       n = currentFileSet.nr + currentDirectorySet.nr;
-       debug("  get_files_dirs done (%d)\n", n);
+       n = current_file_set.nr + current_directory_set.nr;
        return n;
 }
 
@@ -378,7 +344,7 @@ static struct stage_data *insert_stage_data(const char *path,
 }
 
 /*
- * Create a dictionary mapping file names to CacheEntry objects. The
+ * Create a dictionary mapping file names to stage_data objects. The
  * dictionary contains one entry for every path with a non-zero stage entry.
  */
 static struct path_list *get_unmerged(void)
@@ -387,14 +353,14 @@ static struct path_list *get_unmerged(void)
        int i;
 
        unmerged->strdup_paths = 1;
-       if (!cache_dirty) {
-               read_cache_from(getenv("GIT_INDEX_FILE"));
-               cache_dirty++;
-       }
-       for (i = 0; i < active_nr; i++) {
+       total_cnt += active_nr;
+
+       for (i = 0; i < active_nr; i++, merged_cnt++) {
                struct path_list_item *item;
                struct stage_data *e;
                struct cache_entry *ce = active_cache[i];
+               if (do_progress)
+                       display_progress();
                if (!ce_stage(ce))
                        continue;
 
@@ -405,7 +371,7 @@ static struct path_list *get_unmerged(void)
                }
                e = item->util;
                e->stages[ce_stage(ce)].mode = ntohl(ce->ce_mode);
-               memcpy(e->stages[ce_stage(ce)].sha, ce->sha1, 20);
+               hashcpy(e->stages[ce_stage(ce)].sha, ce->sha1);
        }
 
        return unmerged;
@@ -420,25 +386,20 @@ struct rename
 };
 
 /*
- * Get information of all renames which occured between 'oTree' and
- * 'tree'. We need the three trees in the merge ('oTree', 'aTree' and
- * 'bTree') to be able to associate the correct cache entries with
- * the rename information. 'tree' is always equal to either aTree or bTree.
+ * Get information of all renames which occurred between 'o_tree' and
+ * 'tree'. We need the three trees in the merge ('o_tree', 'a_tree' and
+ * 'b_tree') to be able to associate the correct cache entries with
+ * the rename information. 'tree' is always equal to either a_tree or b_tree.
  */
 static struct path_list *get_renames(struct tree *tree,
-                                       struct tree *oTree,
-                                       struct tree *aTree,
-                                       struct tree *bTree,
+                                       struct tree *o_tree,
+                                       struct tree *a_tree,
+                                       struct tree *b_tree,
                                        struct path_list *entries)
 {
        int i;
        struct path_list *renames;
        struct diff_options opts;
-#ifdef DEBUG
-       time_t t = time(0);
-
-       debug("getRenames ...\n");
-#endif
 
        renames = xcalloc(1, sizeof(struct path_list));
        diff_setup(&opts);
@@ -447,7 +408,7 @@ static struct path_list *get_renames(struct tree *tree,
        opts.output_format = DIFF_FORMAT_NO_OUTPUT;
        if (diff_setup_done(&opts) < 0)
                die("diff setup failed");
-       diff_tree_sha1(oTree->object.sha1, tree->object.sha1, "", &opts);
+       diff_tree_sha1(o_tree->object.sha1, tree->object.sha1, "", &opts);
        diffcore_std(&opts);
        for (i = 0; i < diff_queued_diff.nr; ++i) {
                struct path_list_item *item;
@@ -463,14 +424,14 @@ static struct path_list *get_renames(struct tree *tree,
                item = path_list_lookup(re->pair->one->path, entries);
                if (!item)
                        re->src_entry = insert_stage_data(re->pair->one->path,
-                                       oTree, aTree, bTree, entries);
+                                       o_tree, a_tree, b_tree, entries);
                else
                        re->src_entry = item->util;
 
                item = path_list_lookup(re->pair->two->path, entries);
                if (!item)
                        re->dst_entry = insert_stage_data(re->pair->two->path,
-                                       oTree, aTree, bTree, entries);
+                                       o_tree, a_tree, b_tree, entries);
                else
                        re->dst_entry = item->util;
                item = path_list_insert(pair->one->path, renames);
@@ -479,14 +440,12 @@ static struct path_list *get_renames(struct tree *tree,
        opts.output_format = DIFF_FORMAT_NO_OUTPUT;
        diff_queued_diff.nr = 0;
        diff_flush(&opts);
-#ifdef DEBUG
-       debug("  getRenames done in %ld\n", time(0)-t);
-#endif
        return renames;
 }
 
-int update_stages(const char *path, struct diff_filespec *o,
-               struct diff_filespec *a, struct diff_filespec *b, int clear)
+static int update_stages(const char *path, struct diff_filespec *o,
+                        struct diff_filespec *a, struct diff_filespec *b,
+                        int clear)
 {
        int options = ADD_CACHE_OK_TO_ADD | ADD_CACHE_OK_TO_REPLACE;
        if (clear)
@@ -513,7 +472,7 @@ static int remove_path(const char *name)
        if (ret)
                return ret;
        len = strlen(name);
-       dirs = malloc(len+1);
+       dirs = xmalloc(len+1);
        memcpy(dirs, name, len);
        dirs[len] = '\0';
        while ((slash = strrchr(name, '/'))) {
@@ -526,26 +485,16 @@ static int remove_path(const char *name)
        return ret;
 }
 
-/* General TODO: unC99ify the code: no declaration after code */
-/* General TODO: no javaIfiCation: rename updateCache to update_cache */
-/*
- * TODO: once we no longer call external programs, we'd probably be better off
- * not setting / getting the environment variable GIT_INDEX_FILE all the time.
- */
-int remove_file(int clean, const char *path)
+static int remove_file(int clean, const char *path, int no_wd)
 {
-       int updateCache = index_only || clean;
-       int updateWd = !index_only;
+       int update_cache = index_only || clean;
+       int update_working_directory = !index_only && !no_wd;
 
-       if (updateCache) {
-               if (!cache_dirty)
-                       read_cache_from(getenv("GIT_INDEX_FILE"));
-               cache_dirty++;
+       if (update_cache) {
                if (remove_file_from_cache(path))
                        return -1;
        }
-       if (updateWd)
-       {
+       if (update_working_directory) {
                unlink(path);
                if (errno != ENOENT || errno != EISDIR)
                        return -1;
@@ -559,26 +508,26 @@ static char *unique_path(const char *path, const char *branch)
        char *newpath = xmalloc(strlen(path) + 1 + strlen(branch) + 8 + 1);
        int suffix = 0;
        struct stat st;
-       char *p = newpath + strlen(newpath);
+       char *p = newpath + strlen(path);
        strcpy(newpath, path);
-       strcat(newpath, "~");
+       *(p++) = '~';
        strcpy(p, branch);
        for (; *p; ++p)
                if ('/' == *p)
                        *p = '_';
-       while (path_list_has_path(&currentFileSet, newpath) ||
-              path_list_has_path(&currentDirectorySet, newpath) ||
+       while (path_list_has_path(&current_file_set, newpath) ||
+              path_list_has_path(&current_directory_set, newpath) ||
               lstat(newpath, &st) == 0)
                sprintf(p, "_%d", suffix++);
 
-       path_list_insert(newpath, &currentFileSet);
+       path_list_insert(newpath, &current_file_set);
        return newpath;
 }
 
 static int mkdir_p(const char *path, unsigned long mode)
 {
-       /* path points to cache entries, so strdup before messing with it */
-       char *buf = strdup(path);
+       /* path points to cache entries, so xstrdup before messing with it */
+       char *buf = xstrdup(path);
        int result = safe_create_leading_directories(buf);
        free(buf);
        return result;
@@ -587,7 +536,7 @@ static int mkdir_p(const char *path, unsigned long mode)
 static void flush_buffer(int fd, const char *buf, unsigned long size)
 {
        while (size > 0) {
-               long ret = xwrite(fd, buf, size);
+               long ret = write_in_full(fd, buf, size);
                if (ret < 0) {
                        /* Ignore epipe */
                        if (errno == EPIPE)
@@ -601,27 +550,27 @@ static void flush_buffer(int fd, const char *buf, unsigned long size)
        }
 }
 
-void update_file_flags(const unsigned char *sha,
-                      unsigned mode,
-                      const char *path,
-                      int update_cache,
-                      int update_wd)
+static void update_file_flags(const unsigned char *sha,
+                             unsigned mode,
+                             const char *path,
+                             int update_cache,
+                             int update_wd)
 {
        if (index_only)
                update_wd = 0;
 
        if (update_wd) {
-               char type[20];
+               enum object_type type;
                void *buf;
                unsigned long size;
 
-               buf = read_sha1_file(sha, type, &size);
+               buf = read_sha1_file(sha, &type, &size);
                if (!buf)
                        die("cannot read object %s '%s'", sha1_to_hex(sha), path);
-               if (strcmp(type, blob_type) != 0)
+               if (type != OBJ_BLOB)
                        die("blob expected for %s '%s'", sha1_to_hex(sha), path);
 
-               if (S_ISREG(mode)) {
+               if (S_ISREG(mode) || (!has_symlinks && S_ISLNK(mode))) {
                        int fd;
                        if (mkdir_p(path, 0777))
                                die("failed to create path %s: %s", path, strerror(errno));
@@ -636,12 +585,13 @@ void update_file_flags(const unsigned char *sha,
                        flush_buffer(fd, buf, size);
                        close(fd);
                } else if (S_ISLNK(mode)) {
-                       char *lnk = malloc(size + 1);
+                       char *lnk = xmalloc(size + 1);
                        memcpy(lnk, buf, size);
                        lnk[size] = '\0';
                        mkdir_p(path, 0777);
-                       unlink(lnk);
+                       unlink(path);
                        symlink(lnk, path);
+                       free(lnk);
                } else
                        die("do not know what to do with %06o %s '%s'",
                            mode, sha1_to_hex(sha), path);
@@ -650,10 +600,10 @@ void update_file_flags(const unsigned char *sha,
                add_cacheinfo(mode, sha, path, 0, update_wd, ADD_CACHE_OK_TO_ADD);
 }
 
-void update_file(int clean,
-               const unsigned char *sha,
-               unsigned mode,
-               const char *path)
+static void update_file(int clean,
+                       const unsigned char *sha,
+                       unsigned mode,
+                       const char *path)
 {
        update_file_flags(sha, mode, path, index_only || clean, !index_only);
 }
@@ -668,29 +618,26 @@ struct merge_file_info
                 merge:1;
 };
 
-static char *git_unpack_file(const unsigned char *sha1, char *path)
+static void fill_mm(const unsigned char *sha1, mmfile_t *mm)
 {
-       void *buf;
-       char type[20];
        unsigned long size;
-       int fd;
+       enum object_type type;
 
-       buf = read_sha1_file(sha1, type, &size);
-       if (!buf || strcmp(type, blob_type))
-               die("unable to read blob object %s", sha1_to_hex(sha1));
+       if (!hashcmp(sha1, null_sha1)) {
+               mm->ptr = xstrdup("");
+               mm->size = 0;
+               return;
+       }
 
-       strcpy(path, ".merge_file_XXXXXX");
-       fd = mkstemp(path);
-       if (fd < 0)
-               die("unable to create temp-file");
-       flush_buffer(fd, buf, size);
-       close(fd);
-       return path;
+       mm->ptr = read_sha1_file(sha1, &type, &size);
+       if (!mm->ptr || type != OBJ_BLOB)
+               die("unable to read blob object %s", sha1_to_hex(sha1));
+       mm->size = size;
 }
 
 static struct merge_file_info merge_file(struct diff_filespec *o,
                struct diff_filespec *a, struct diff_filespec *b,
-               const char *branch1Name, const char *branch2Name)
+               const char *branch1, const char *branch2)
 {
        struct merge_file_info result;
        result.merge = 0;
@@ -700,10 +647,10 @@ static struct merge_file_info merge_file(struct diff_filespec *o,
                result.clean = 0;
                if (S_ISREG(a->mode)) {
                        result.mode = a->mode;
-                       memcpy(result.sha, a->sha1, 20);
+                       hashcpy(result.sha, a->sha1);
                } else {
                        result.mode = b->mode;
-                       memcpy(result.sha, b->sha1, 20);
+                       hashcpy(result.sha, b->sha1);
                }
        } else {
                if (!sha_eq(a->sha1, o->sha1) && !sha_eq(b->sha1, o->sha1))
@@ -712,60 +659,50 @@ static struct merge_file_info merge_file(struct diff_filespec *o,
                result.mode = a->mode == o->mode ? b->mode: a->mode;
 
                if (sha_eq(a->sha1, o->sha1))
-                       memcpy(result.sha, b->sha1, 20);
+                       hashcpy(result.sha, b->sha1);
                else if (sha_eq(b->sha1, o->sha1))
-                       memcpy(result.sha, a->sha1, 20);
+                       hashcpy(result.sha, a->sha1);
                else if (S_ISREG(a->mode)) {
-                       int code = 1, fd;
-                       struct stat st;
-                       char orig[PATH_MAX];
-                       char src1[PATH_MAX];
-                       char src2[PATH_MAX];
-                       const char *argv[] = {
-                               "merge", "-L", NULL, "-L", NULL, "-L", NULL,
-                               src1, orig, src2,
-                               NULL
-                       };
-                       char *la, *lb, *lo;
-
-                       git_unpack_file(o->sha1, orig);
-                       git_unpack_file(a->sha1, src1);
-                       git_unpack_file(b->sha1, src2);
-
-                       argv[2] = la = strdup(mkpath("%s/%s", branch1Name, a->path));
-                       argv[6] = lb = strdup(mkpath("%s/%s", branch2Name, b->path));
-                       argv[4] = lo = strdup(mkpath("orig/%s", o->path));
-
-#if 0
-                       printf("%s %s %s %s %s %s %s %s %s %s\n",
-                              argv[0], argv[1], argv[2], argv[3], argv[4],
-                              argv[5], argv[6], argv[7], argv[8], argv[9]);
-#endif
-                       code = run_command_v(10, argv);
-
-                       free(la);
-                       free(lb);
-                       free(lo);
-                       if (code && code < -256) {
-                               die("Failed to execute 'merge'. merge(1) is used as the "
-                                   "file-level merge tool. Is 'merge' in your path?");
-                       }
-                       fd = open(src1, O_RDONLY);
-                       if (fd < 0 || fstat(fd, &st) < 0 ||
-                                       index_fd(result.sha, fd, &st, 1,
-                                               "blob"))
-                               die("Unable to add %s to database", src1);
-
-                       unlink(orig);
-                       unlink(src1);
-                       unlink(src2);
-
-                       result.clean = WEXITSTATUS(code) == 0;
+                       mmfile_t orig, src1, src2;
+                       mmbuffer_t result_buf;
+                       xpparam_t xpp;
+                       char *name1, *name2;
+                       int merge_status;
+
+                       name1 = xstrdup(mkpath("%s:%s", branch1, a->path));
+                       name2 = xstrdup(mkpath("%s:%s", branch2, b->path));
+
+                       fill_mm(o->sha1, &orig);
+                       fill_mm(a->sha1, &src1);
+                       fill_mm(b->sha1, &src2);
+
+                       memset(&xpp, 0, sizeof(xpp));
+                       merge_status = xdl_merge(&orig,
+                                                &src1, name1,
+                                                &src2, name2,
+                                                &xpp, XDL_MERGE_ZEALOUS,
+                                                &result_buf);
+                       free(name1);
+                       free(name2);
+                       free(orig.ptr);
+                       free(src1.ptr);
+                       free(src2.ptr);
+
+                       if ((merge_status < 0) || !result_buf.ptr)
+                               die("Failed to execute internal merge");
+
+                       if (write_sha1_file(result_buf.ptr, result_buf.size,
+                                           blob_type, result.sha))
+                               die("Unable to add %s to database",
+                                   a->path);
+
+                       free(result_buf.ptr);
+                       result.clean = (merge_status == 0);
                } else {
                        if (!(S_ISLNK(a->mode) || S_ISLNK(b->mode)))
                                die("cannot merge modes?");
 
-                       memcpy(result.sha, a->sha1, 20);
+                       hashcpy(result.sha, a->sha1);
 
                        if (!sha_eq(a->sha1, b->sha1))
                                result.clean = 0;
@@ -784,22 +721,22 @@ static void conflict_rename_rename(struct rename *ren1,
        int delp = 0;
        const char *ren1_dst = ren1->pair->two->path;
        const char *ren2_dst = ren2->pair->two->path;
-       const char *dstName1 = ren1_dst;
-       const char *dstName2 = ren2_dst;
-       if (path_list_has_path(&currentDirectorySet, ren1_dst)) {
-               dstName1 = del[delp++] = unique_path(ren1_dst, branch1);
-               output("%s is a directory in %s adding as %s instead",
-                      ren1_dst, branch2, dstName1);
-               remove_file(0, ren1_dst);
+       const char *dst_name1 = ren1_dst;
+       const char *dst_name2 = ren2_dst;
+       if (path_list_has_path(&current_directory_set, ren1_dst)) {
+               dst_name1 = del[delp++] = unique_path(ren1_dst, branch1);
+               output(1, "%s is a directory in %s added as %s instead",
+                      ren1_dst, branch2, dst_name1);
+               remove_file(0, ren1_dst, 0);
        }
-       if (path_list_has_path(&currentDirectorySet, ren2_dst)) {
-               dstName2 = del[delp++] = unique_path(ren2_dst, branch2);
-               output("%s is a directory in %s adding as %s instead",
-                      ren2_dst, branch1, dstName2);
-               remove_file(0, ren2_dst);
+       if (path_list_has_path(&current_directory_set, ren2_dst)) {
+               dst_name2 = del[delp++] = unique_path(ren2_dst, branch2);
+               output(1, "%s is a directory in %s added as %s instead",
+                      ren2_dst, branch1, dst_name2);
+               remove_file(0, ren2_dst, 0);
        }
-       update_stages(dstName1, NULL, ren1->pair->two, NULL, 1);
-       update_stages(dstName2, NULL, NULL, ren2->pair->two, 1);
+       update_stages(dst_name1, NULL, ren1->pair->two, NULL, 1);
+       update_stages(dst_name2, NULL, NULL, ren2->pair->two, 1);
        while (delp--)
                free(del[delp]);
 }
@@ -807,11 +744,11 @@ static void conflict_rename_rename(struct rename *ren1,
 static void conflict_rename_dir(struct rename *ren1,
                                const char *branch1)
 {
-       char *newPath = unique_path(ren1->pair->two->path, branch1);
-       output("Renaming %s to %s instead", ren1->pair->one->path, newPath);
-       remove_file(0, ren1->pair->two->path);
-       update_file(0, ren1->pair->two->sha1, ren1->pair->two->mode, newPath);
-       free(newPath);
+       char *new_path = unique_path(ren1->pair->two->path, branch1);
+       output(1, "Renamed %s to %s instead", ren1->pair->one->path, new_path);
+       remove_file(0, ren1->pair->two->path, 0);
+       update_file(0, ren1->pair->two->sha1, ren1->pair->two->mode, new_path);
+       free(new_path);
 }
 
 static void conflict_rename_rename_2(struct rename *ren1,
@@ -819,74 +756,75 @@ static void conflict_rename_rename_2(struct rename *ren1,
                                     struct rename *ren2,
                                     const char *branch2)
 {
-       char *newPath1 = unique_path(ren1->pair->two->path, branch1);
-       char *newPath2 = unique_path(ren2->pair->two->path, branch2);
-       output("Renaming %s to %s and %s to %s instead",
-              ren1->pair->one->path, newPath1,
-              ren2->pair->one->path, newPath2);
-       remove_file(0, ren1->pair->two->path);
-       update_file(0, ren1->pair->two->sha1, ren1->pair->two->mode, newPath1);
-       update_file(0, ren2->pair->two->sha1, ren2->pair->two->mode, newPath2);
-       free(newPath2);
-       free(newPath1);
+       char *new_path1 = unique_path(ren1->pair->two->path, branch1);
+       char *new_path2 = unique_path(ren2->pair->two->path, branch2);
+       output(1, "Renamed %s to %s and %s to %s instead",
+              ren1->pair->one->path, new_path1,
+              ren2->pair->one->path, new_path2);
+       remove_file(0, ren1->pair->two->path, 0);
+       update_file(0, ren1->pair->two->sha1, ren1->pair->two->mode, new_path1);
+       update_file(0, ren2->pair->two->sha1, ren2->pair->two->mode, new_path2);
+       free(new_path2);
+       free(new_path1);
 }
 
-/* General TODO: get rid of all the debug messages */
-static int process_renames(struct path_list *renamesA,
-                          struct path_list *renamesB,
-                          const char *branchNameA,
-                          const char *branchNameB)
+static int process_renames(struct path_list *a_renames,
+                          struct path_list *b_renames,
+                          const char *a_branch,
+                          const char *b_branch)
 {
-       int cleanMerge = 1, i, j;
-       struct path_list byDstA = {NULL, 0, 0, 0}, byDstB = {NULL, 0, 0, 0};
+       int clean_merge = 1, i, j;
+       struct path_list a_by_dst = {NULL, 0, 0, 0}, b_by_dst = {NULL, 0, 0, 0};
        const struct rename *sre;
 
-       for (i = 0; i < renamesA->nr; i++) {
-               sre = renamesA->items[i].util;
-               path_list_insert(sre->pair->two->path, &byDstA)->util
+       for (i = 0; i < a_renames->nr; i++) {
+               sre = a_renames->items[i].util;
+               path_list_insert(sre->pair->two->path, &a_by_dst)->util
                        = sre->dst_entry;
        }
-       for (i = 0; i < renamesB->nr; i++) {
-               sre = renamesB->items[i].util;
-               path_list_insert(sre->pair->two->path, &byDstB)->util
+       for (i = 0; i < b_renames->nr; i++) {
+               sre = b_renames->items[i].util;
+               path_list_insert(sre->pair->two->path, &b_by_dst)->util
                        = sre->dst_entry;
        }
 
-       for (i = 0, j = 0; i < renamesA->nr || j < renamesB->nr;) {
+       for (i = 0, j = 0; i < a_renames->nr || j < b_renames->nr;) {
                int compare;
                char *src;
                struct path_list *renames1, *renames2, *renames2Dst;
                struct rename *ren1 = NULL, *ren2 = NULL;
-               const char *branchName1, *branchName2;
+               const char *branch1, *branch2;
                const char *ren1_src, *ren1_dst;
 
-               if (i >= renamesA->nr) {
+               if (i >= a_renames->nr) {
                        compare = 1;
-                       ren2 = renamesB->items[j++].util;
-               } else if (j >= renamesB->nr) {
+                       ren2 = b_renames->items[j++].util;
+               } else if (j >= b_renames->nr) {
                        compare = -1;
-                       ren1 = renamesA->items[i++].util;
+                       ren1 = a_renames->items[i++].util;
                } else {
-                       compare = strcmp(renamesA->items[i].path,
-                                       renamesB->items[j].path);
-                       ren1 = renamesA->items[i++].util;
-                       ren2 = renamesB->items[j++].util;
+                       compare = strcmp(a_renames->items[i].path,
+                                       b_renames->items[j].path);
+                       if (compare <= 0)
+                               ren1 = a_renames->items[i++].util;
+                       if (compare >= 0)
+                               ren2 = b_renames->items[j++].util;
                }
 
                /* TODO: refactor, so that 1/2 are not needed */
                if (ren1) {
-                       renames1 = renamesA;
-                       renames2 = renamesB;
-                       renames2Dst = &byDstB;
-                       branchName1 = branchNameA;
-                       branchName2 = branchNameB;
+                       renames1 = a_renames;
+                       renames2 = b_renames;
+                       renames2Dst = &b_by_dst;
+                       branch1 = a_branch;
+                       branch2 = b_branch;
                } else {
                        struct rename *tmp;
-                       renames1 = renamesB;
-                       renames2 = renamesA;
-                       renames2Dst = &byDstA;
-                       branchName1 = branchNameB;
-                       branchName2 = branchNameA;
+                       renames1 = b_renames;
+                       renames2 = a_renames;
+                       renames2Dst = &a_by_dst;
+                       branch1 = b_branch;
+                       branch2 = a_branch;
                        tmp = ren2;
                        ren2 = ren1;
                        ren1 = tmp;
@@ -912,31 +850,31 @@ static int process_renames(struct path_list *renamesA,
                        ren2->dst_entry->processed = 1;
                        ren2->processed = 1;
                        if (strcmp(ren1_dst, ren2_dst) != 0) {
-                               cleanMerge = 0;
-                               output("CONFLICT (rename/rename): "
+                               clean_merge = 0;
+                               output(1, "CONFLICT (rename/rename): "
                                       "Rename %s->%s in branch %s "
                                       "rename %s->%s in %s",
-                                      src, ren1_dst, branchName1,
-                                      src, ren2_dst, branchName2);
-                               conflict_rename_rename(ren1, branchName1, ren2, branchName2);
+                                      src, ren1_dst, branch1,
+                                      src, ren2_dst, branch2);
+                               conflict_rename_rename(ren1, branch1, ren2, branch2);
                        } else {
-                               remove_file(1, ren1_src);
                                struct merge_file_info mfi;
+                               remove_file(1, ren1_src, 1);
                                mfi = merge_file(ren1->pair->one,
                                                 ren1->pair->two,
                                                 ren2->pair->two,
-                                                branchName1,
-                                                branchName2);
+                                                branch1,
+                                                branch2);
                                if (mfi.merge || !mfi.clean)
-                                       output("Renaming %s->%s", src, ren1_dst);
+                                       output(1, "Renamed %s->%s", src, ren1_dst);
 
                                if (mfi.merge)
-                                       output("Auto-merging %s", ren1_dst);
+                                       output(2, "Auto-merged %s", ren1_dst);
 
                                if (!mfi.clean) {
-                                       output("CONFLICT (content): merge conflict in %s",
+                                       output(1, "CONFLICT (content): merge conflict in %s",
                                               ren1_dst);
-                                       cleanMerge = 0;
+                                       clean_merge = 0;
 
                                        if (!index_only)
                                                update_stages(ren1_dst,
@@ -952,63 +890,61 @@ static int process_renames(struct path_list *renamesA,
                        struct path_list_item *item;
                        /* we only use sha1 and mode of these */
                        struct diff_filespec src_other, dst_other;
-                       int tryMerge, stage = renamesA == renames1 ? 3: 2;
+                       int try_merge, stage = a_renames == renames1 ? 3: 2;
 
-                       remove_file(1, ren1_src);
+                       remove_file(1, ren1_src, index_only || stage == 3);
 
-                       memcpy(src_other.sha1,
-                                       ren1->src_entry->stages[stage].sha, 20);
+                       hashcpy(src_other.sha1, ren1->src_entry->stages[stage].sha);
                        src_other.mode = ren1->src_entry->stages[stage].mode;
-                       memcpy(dst_other.sha1,
-                                       ren1->dst_entry->stages[stage].sha, 20);
+                       hashcpy(dst_other.sha1, ren1->dst_entry->stages[stage].sha);
                        dst_other.mode = ren1->dst_entry->stages[stage].mode;
 
-                       tryMerge = 0;
+                       try_merge = 0;
 
-                       if (path_list_has_path(&currentDirectorySet, ren1_dst)) {
-                               cleanMerge = 0;
-                               output("CONFLICT (rename/directory): Rename %s->%s in %s "
+                       if (path_list_has_path(&current_directory_set, ren1_dst)) {
+                               clean_merge = 0;
+                               output(1, "CONFLICT (rename/directory): Renamed %s->%s in %s "
                                       " directory %s added in %s",
-                                      ren1_src, ren1_dst, branchName1,
-                                      ren1_dst, branchName2);
-                               conflict_rename_dir(ren1, branchName1);
+                                      ren1_src, ren1_dst, branch1,
+                                      ren1_dst, branch2);
+                               conflict_rename_dir(ren1, branch1);
                        } else if (sha_eq(src_other.sha1, null_sha1)) {
-                               cleanMerge = 0;
-                               output("CONFLICT (rename/delete): Rename %s->%s in %s "
+                               clean_merge = 0;
+                               output(1, "CONFLICT (rename/delete): Renamed %s->%s in %s "
                                       "and deleted in %s",
-                                      ren1_src, ren1_dst, branchName1,
-                                      branchName2);
+                                      ren1_src, ren1_dst, branch1,
+                                      branch2);
                                update_file(0, ren1->pair->two->sha1, ren1->pair->two->mode, ren1_dst);
                        } else if (!sha_eq(dst_other.sha1, null_sha1)) {
-                               const char *newPath;
-                               cleanMerge = 0;
-                               tryMerge = 1;
-                               output("CONFLICT (rename/add): Rename %s->%s in %s. "
+                               const char *new_path;
+                               clean_merge = 0;
+                               try_merge = 1;
+                               output(1, "CONFLICT (rename/add): Renamed %s->%s in %s. "
                                       "%s added in %s",
-                                      ren1_src, ren1_dst, branchName1,
-                                      ren1_dst, branchName2);
-                               newPath = unique_path(ren1_dst, branchName2);
-                               output("Adding as %s instead", newPath);
-                               update_file(0, dst_other.sha1, dst_other.mode, newPath);
+                                      ren1_src, ren1_dst, branch1,
+                                      ren1_dst, branch2);
+                               new_path = unique_path(ren1_dst, branch2);
+                               output(1, "Added as %s instead", new_path);
+                               update_file(0, dst_other.sha1, dst_other.mode, new_path);
                        } else if ((item = path_list_lookup(ren1_dst, renames2Dst))) {
                                ren2 = item->util;
-                               cleanMerge = 0;
+                               clean_merge = 0;
                                ren2->processed = 1;
-                               output("CONFLICT (rename/rename): Rename %s->%s in %s. "
-                                      "Rename %s->%s in %s",
-                                      ren1_src, ren1_dst, branchName1,
-                                      ren2->pair->one->path, ren2->pair->two->path, branchName2);
-                               conflict_rename_rename_2(ren1, branchName1, ren2, branchName2);
+                               output(1, "CONFLICT (rename/rename): Renamed %s->%s in %s. "
+                                      "Renamed %s->%s in %s",
+                                      ren1_src, ren1_dst, branch1,
+                                      ren2->pair->one->path, ren2->pair->two->path, branch2);
+                               conflict_rename_rename_2(ren1, branch1, ren2, branch2);
                        } else
-                               tryMerge = 1;
+                               try_merge = 1;
 
-                       if (tryMerge) {
+                       if (try_merge) {
                                struct diff_filespec *o, *a, *b;
                                struct merge_file_info mfi;
                                src_other.path = (char *)ren1_src;
 
                                o = ren1->pair->one;
-                               if (renamesA == renames1) {
+                               if (a_renames == renames1) {
                                        a = ren1->pair->two;
                                        b = &src_other;
                                } else {
@@ -1016,16 +952,16 @@ static int process_renames(struct path_list *renamesA,
                                        a = &src_other;
                                }
                                mfi = merge_file(o, a, b,
-                                               branchNameA, branchNameB);
+                                               a_branch, b_branch);
 
                                if (mfi.merge || !mfi.clean)
-                                       output("Renaming %s => %s", ren1_src, ren1_dst);
+                                       output(1, "Renamed %s => %s", ren1_src, ren1_dst);
                                if (mfi.merge)
-                                       output("Auto-merging %s", ren1_dst);
+                                       output(2, "Auto-merged %s", ren1_dst);
                                if (!mfi.clean) {
-                                       output("CONFLICT (rename/modify): Merge conflict in %s",
+                                       output(1, "CONFLICT (rename/modify): Merge conflict in %s",
                                               ren1_dst);
-                                       cleanMerge = 0;
+                                       clean_merge = 0;
 
                                        if (!index_only)
                                                update_stages(ren1_dst,
@@ -1035,191 +971,165 @@ static int process_renames(struct path_list *renamesA,
                        }
                }
        }
-       path_list_clear(&byDstA, 0);
-       path_list_clear(&byDstB, 0);
+       path_list_clear(&a_by_dst, 0);
+       path_list_clear(&b_by_dst, 0);
 
-       if (cache_dirty)
-               flush_cache();
-       return cleanMerge;
+       return clean_merge;
 }
 
 static unsigned char *has_sha(const unsigned char *sha)
 {
-       return memcmp(sha, null_sha1, 20) == 0 ? NULL: (unsigned char *)sha;
+       return is_null_sha1(sha) ? NULL: (unsigned char *)sha;
 }
 
 /* Per entry merge function */
 static int process_entry(const char *path, struct stage_data *entry,
-                        const char *branch1Name,
-                        const char *branch2Name)
+                        const char *branch1,
+                        const char *branch2)
 {
        /*
        printf("processing entry, clean cache: %s\n", index_only ? "yes": "no");
        print_index_entry("\tpath: ", entry);
        */
-       int cleanMerge = 1;
-       unsigned char *oSha = has_sha(entry->stages[1].sha);
-       unsigned char *aSha = has_sha(entry->stages[2].sha);
-       unsigned char *bSha = has_sha(entry->stages[3].sha);
-       unsigned oMode = entry->stages[1].mode;
-       unsigned aMode = entry->stages[2].mode;
-       unsigned bMode = entry->stages[3].mode;
-
-       if (oSha && (!aSha || !bSha)) {
+       int clean_merge = 1;
+       unsigned char *o_sha = has_sha(entry->stages[1].sha);
+       unsigned char *a_sha = has_sha(entry->stages[2].sha);
+       unsigned char *b_sha = has_sha(entry->stages[3].sha);
+       unsigned o_mode = entry->stages[1].mode;
+       unsigned a_mode = entry->stages[2].mode;
+       unsigned b_mode = entry->stages[3].mode;
+
+       if (o_sha && (!a_sha || !b_sha)) {
                /* Case A: Deleted in one */
-               if ((!aSha && !bSha) ||
-                   (sha_eq(aSha, oSha) && !bSha) ||
-                   (!aSha && sha_eq(bSha, oSha))) {
+               if ((!a_sha && !b_sha) ||
+                   (sha_eq(a_sha, o_sha) && !b_sha) ||
+                   (!a_sha && sha_eq(b_sha, o_sha))) {
                        /* Deleted in both or deleted in one and
                         * unchanged in the other */
-                       if (aSha)
-                               output("Removing %s", path);
-                       remove_file(1, path);
+                       if (a_sha)
+                               output(2, "Removed %s", path);
+                       /* do not touch working file if it did not exist */
+                       remove_file(1, path, !a_sha);
                } else {
                        /* Deleted in one and changed in the other */
-                       cleanMerge = 0;
-                       if (!aSha) {
-                               output("CONFLICT (delete/modify): %s deleted in %s "
+                       clean_merge = 0;
+                       if (!a_sha) {
+                               output(1, "CONFLICT (delete/modify): %s deleted in %s "
                                       "and modified in %s. Version %s of %s left in tree.",
-                                      path, branch1Name,
-                                      branch2Name, branch2Name, path);
-                               update_file(0, bSha, bMode, path);
+                                      path, branch1,
+                                      branch2, branch2, path);
+                               update_file(0, b_sha, b_mode, path);
                        } else {
-                               output("CONFLICT (delete/modify): %s deleted in %s "
+                               output(1, "CONFLICT (delete/modify): %s deleted in %s "
                                       "and modified in %s. Version %s of %s left in tree.",
-                                      path, branch2Name,
-                                      branch1Name, branch1Name, path);
-                               update_file(0, aSha, aMode, path);
+                                      path, branch2,
+                                      branch1, branch1, path);
+                               update_file(0, a_sha, a_mode, path);
                        }
                }
 
-       } else if ((!oSha && aSha && !bSha) ||
-                  (!oSha && !aSha && bSha)) {
+       } else if ((!o_sha && a_sha && !b_sha) ||
+                  (!o_sha && !a_sha && b_sha)) {
                /* Case B: Added in one. */
-               const char *addBranch;
-               const char *otherBranch;
+               const char *add_branch;
+               const char *other_branch;
                unsigned mode;
                const unsigned char *sha;
                const char *conf;
 
-               if (aSha) {
-                       addBranch = branch1Name;
-                       otherBranch = branch2Name;
-                       mode = aMode;
-                       sha = aSha;
+               if (a_sha) {
+                       add_branch = branch1;
+                       other_branch = branch2;
+                       mode = a_mode;
+                       sha = a_sha;
                        conf = "file/directory";
                } else {
-                       addBranch = branch2Name;
-                       otherBranch = branch1Name;
-                       mode = bMode;
-                       sha = bSha;
+                       add_branch = branch2;
+                       other_branch = branch1;
+                       mode = b_mode;
+                       sha = b_sha;
                        conf = "directory/file";
                }
-               if (path_list_has_path(&currentDirectorySet, path)) {
-                       const char *newPath = unique_path(path, addBranch);
-                       cleanMerge = 0;
-                       output("CONFLICT (%s): There is a directory with name %s in %s. "
-                              "Adding %s as %s",
-                              conf, path, otherBranch, path, newPath);
-                       remove_file(0, path);
-                       update_file(0, sha, mode, newPath);
+               if (path_list_has_path(&current_directory_set, path)) {
+                       const char *new_path = unique_path(path, add_branch);
+                       clean_merge = 0;
+                       output(1, "CONFLICT (%s): There is a directory with name %s in %s. "
+                              "Added %s as %s",
+                              conf, path, other_branch, path, new_path);
+                       remove_file(0, path, 0);
+                       update_file(0, sha, mode, new_path);
                } else {
-                       output("Adding %s", path);
+                       output(2, "Added %s", path);
                        update_file(1, sha, mode, path);
                }
-       } else if (!oSha && aSha && bSha) {
-               /* Case C: Added in both (check for same permissions). */
-               if (sha_eq(aSha, bSha)) {
-                       if (aMode != bMode) {
-                               cleanMerge = 0;
-                               output("CONFLICT: File %s added identically in both branches, "
-                                      "but permissions conflict %06o->%06o",
-                                      path, aMode, bMode);
-                               output("CONFLICT: adding with permission: %06o", aMode);
-                               update_file(0, aSha, aMode, path);
-                       } else {
-                               /* This case is handled by git-read-tree */
-                               assert(0 && "This case must be handled by git-read-tree");
-                       }
-               } else {
-                       const char *newPath1, *newPath2;
-                       cleanMerge = 0;
-                       newPath1 = unique_path(path, branch1Name);
-                       newPath2 = unique_path(path, branch2Name);
-                       output("CONFLICT (add/add): File %s added non-identically "
-                              "in both branches. Adding as %s and %s instead.",
-                              path, newPath1, newPath2);
-                       remove_file(0, path);
-                       update_file(0, aSha, aMode, newPath1);
-                       update_file(0, bSha, bMode, newPath2);
-               }
-
-       } else if (oSha && aSha && bSha) {
+       } else if (a_sha && b_sha) {
+               /* Case C: Added in both (check for same permissions) and */
                /* case D: Modified in both, but differently. */
+               const char *reason = "content";
                struct merge_file_info mfi;
                struct diff_filespec o, a, b;
 
-               output("Auto-merging %s", path);
+               if (!o_sha) {
+                       reason = "add/add";
+                       o_sha = (unsigned char *)null_sha1;
+               }
+               output(2, "Auto-merged %s", path);
                o.path = a.path = b.path = (char *)path;
-               memcpy(o.sha1, oSha, 20);
-               o.mode = oMode;
-               memcpy(a.sha1, aSha, 20);
-               a.mode = aMode;
-               memcpy(b.sha1, bSha, 20);
-               b.mode = bMode;
+               hashcpy(o.sha1, o_sha);
+               o.mode = o_mode;
+               hashcpy(a.sha1, a_sha);
+               a.mode = a_mode;
+               hashcpy(b.sha1, b_sha);
+               b.mode = b_mode;
 
                mfi = merge_file(&o, &a, &b,
-                                branch1Name, branch2Name);
+                                branch1, branch2);
 
                if (mfi.clean)
                        update_file(1, mfi.sha, mfi.mode, path);
                else {
-                       cleanMerge = 0;
-                       output("CONFLICT (content): Merge conflict in %s", path);
+                       clean_merge = 0;
+                       output(1, "CONFLICT (%s): Merge conflict in %s",
+                                       reason, path);
 
                        if (index_only)
                                update_file(0, mfi.sha, mfi.mode, path);
                        else
                                update_file_flags(mfi.sha, mfi.mode, path,
-                                             0 /* updateCache */, 1 /* updateWd */);
+                                             0 /* update_cache */, 1 /* update_working_directory */);
                }
        } else
                die("Fatal merge failure, shouldn't happen.");
 
-       if (cache_dirty)
-               flush_cache();
-
-       return cleanMerge;
+       return clean_merge;
 }
 
 static int merge_trees(struct tree *head,
                       struct tree *merge,
                       struct tree *common,
-                      const char *branch1Name,
-                      const char *branch2Name,
+                      const char *branch1,
+                      const char *branch2,
                       struct tree **result)
 {
        int code, clean;
        if (sha_eq(common->object.sha1, merge->object.sha1)) {
-               output("Already uptodate!");
+               output(0, "Already uptodate!");
                *result = head;
                return 1;
        }
 
-       code = git_merge_trees(index_only ? "-i": "-u", common, head, merge);
+       code = git_merge_trees(index_only, common, head, merge);
 
        if (code != 0)
                die("merging of trees %s and %s failed",
                    sha1_to_hex(head->object.sha1),
                    sha1_to_hex(merge->object.sha1));
 
-       *result = git_write_tree();
-
-       if (!*result) {
+       if (unmerged_index()) {
                struct path_list *entries, *re_head, *re_merge;
                int i;
-               path_list_clear(&currentFileSet, 1);
-               path_list_clear(&currentDirectorySet, 1);
+               path_list_clear(&current_file_set, 1);
+               path_list_clear(&current_directory_set, 1);
                get_files_dirs(head);
                get_files_dirs(merge);
 
@@ -1227,111 +1137,148 @@ static int merge_trees(struct tree *head,
                re_head  = get_renames(head, common, head, merge, entries);
                re_merge = get_renames(merge, common, head, merge, entries);
                clean = process_renames(re_head, re_merge,
-                               branch1Name, branch2Name);
-               for (i = 0; i < entries->nr; i++) {
+                               branch1, branch2);
+               total_cnt += entries->nr;
+               for (i = 0; i < entries->nr; i++, merged_cnt++) {
                        const char *path = entries->items[i].path;
                        struct stage_data *e = entries->items[i].util;
-                       if (e->processed)
-                               continue;
-                       if (!process_entry(path, e, branch1Name, branch2Name))
+                       if (!e->processed
+                               && !process_entry(path, e, branch1, branch2))
                                clean = 0;
+                       if (do_progress)
+                               display_progress();
                }
 
                path_list_clear(re_merge, 0);
                path_list_clear(re_head, 0);
                path_list_clear(entries, 1);
 
-               if (clean || index_only)
-                       *result = git_write_tree();
-               else
-                       *result = NULL;
-       } else {
-               clean = 1;
-               printf("merging of trees %s and %s resulted in %s\n",
-                      sha1_to_hex(head->object.sha1),
-                      sha1_to_hex(merge->object.sha1),
-                      sha1_to_hex((*result)->object.sha1));
        }
+       else
+               clean = 1;
+
+       if (index_only)
+               *result = git_write_tree();
 
        return clean;
 }
 
+static struct commit_list *reverse_commit_list(struct commit_list *list)
+{
+       struct commit_list *next = NULL, *current, *backup;
+       for (current = list; current; current = backup) {
+               backup = current->next;
+               current->next = next;
+               next = current;
+       }
+       return next;
+}
+
 /*
  * Merge the commits h1 and h2, return the resulting virtual
- * commit object and a flag indicating the cleaness of the merge.
+ * commit object and a flag indicating the cleanness of the merge.
  */
-static
-int merge(struct commit *h1,
-                         struct commit *h2,
-                         const char *branch1Name,
-                         const char *branch2Name,
-                         int callDepth /* =0 */,
-                         struct commit *ancestor /* =None */,
-                         struct commit **result)
+static int merge(struct commit *h1,
+                struct commit *h2,
+                const char *branch1,
+                const char *branch2,
+                struct commit_list *ca,
+                struct commit **result)
 {
-       struct commit_list *ca = NULL, *iter;
-       struct commit *mergedCA;
+       struct commit_list *iter;
+       struct commit *merged_common_ancestors;
        struct tree *mrtree;
        int clean;
 
-       output("Merging:");
-       output_commit_title(h1);
-       output_commit_title(h2);
+       if (show(4)) {
+               output(4, "Merging:");
+               output_commit_title(h1);
+               output_commit_title(h2);
+       }
 
-       if (ancestor)
-               commit_list_insert(ancestor, &ca);
-       else
+       if (!ca) {
                ca = get_merge_bases(h1, h2, 1);
+               ca = reverse_commit_list(ca);
+       }
 
-       output("found %u common ancestor(s):", commit_list_count(ca));
-       for (iter = ca; iter; iter = iter->next)
-               output_commit_title(iter->item);
+       if (show(5)) {
+               output(5, "found %u common ancestor(s):", commit_list_count(ca));
+               for (iter = ca; iter; iter = iter->next)
+                       output_commit_title(iter->item);
+       }
 
-       mergedCA = pop_commit(&ca);
+       merged_common_ancestors = pop_commit(&ca);
+       if (merged_common_ancestors == NULL) {
+               /* if there is no common ancestor, make an empty tree */
+               struct tree *tree = xcalloc(1, sizeof(struct tree));
+
+               tree->object.parsed = 1;
+               tree->object.type = OBJ_TREE;
+               pretend_sha1_file(NULL, 0, OBJ_TREE, tree->object.sha1);
+               merged_common_ancestors = make_virtual_commit(tree, "ancestor");
+       }
 
        for (iter = ca; iter; iter = iter->next) {
-               output_indent = callDepth + 1;
+               call_depth++;
                /*
                 * When the merge fails, the result contains files
                 * with conflict markers. The cleanness flag is
-                * ignored, it was never acutally used, as result of
-                * merge_trees has always overwritten it: the commited
+                * ignored, it was never actually used, as result of
+                * merge_trees has always overwritten it: the committed
                 * "conflicts" were already resolved.
                 */
-               merge(mergedCA, iter->item,
+               discard_cache();
+               merge(merged_common_ancestors, iter->item,
                      "Temporary merge branch 1",
                      "Temporary merge branch 2",
-                     callDepth + 1,
                      NULL,
-                     &mergedCA);
-               output_indent = callDepth;
+                     &merged_common_ancestors);
+               call_depth--;
 
-               if (!mergedCA)
+               if (!merged_common_ancestors)
                        die("merge returned no commit");
        }
 
-       if (callDepth == 0) {
-               setup_index(0 /* $GIT_DIR/index */);
+       discard_cache();
+       if (!call_depth) {
+               read_cache();
                index_only = 0;
-       } else {
-               setup_index(1 /* temporary index */);
-               git_read_tree(h1->tree);
+       } else
                index_only = 1;
-       }
 
-       clean = merge_trees(h1->tree, h2->tree, mergedCA->tree,
-                           branch1Name, branch2Name, &mrtree);
+       clean = merge_trees(h1->tree, h2->tree, merged_common_ancestors->tree,
+                           branch1, branch2, &mrtree);
 
-       if (!ancestor && (clean || index_only)) {
+       if (index_only) {
                *result = make_virtual_commit(mrtree, "merged tree");
                commit_list_insert(h1, &(*result)->parents);
                commit_list_insert(h2, &(*result)->parents->next);
-       } else
-               *result = NULL;
-
+       }
+       if (!call_depth && do_progress) {
+               /* Make sure we end at 100% */
+               if (!total_cnt)
+                       total_cnt = 1;
+               merged_cnt = total_cnt;
+               progress_update = 1;
+               display_progress();
+               fputc('\n', stderr);
+       }
+       flush_output();
        return clean;
 }
 
+static const char *better_branch_name(const char *branch)
+{
+       static char githead_env[8 + 40 + 1];
+       char *name;
+
+       if (strlen(branch) != 40)
+               return branch;
+       sprintf(githead_env, "GITHEAD_%s", branch);
+       name = getenv(githead_env);
+       return name ? name : branch;
+}
+
 static struct commit *get_ref(const char *ref)
 {
        unsigned char sha1[20];
@@ -1340,6 +1287,9 @@ static struct commit *get_ref(const char *ref)
        if (get_sha1(ref, sha1))
                die("Could not resolve ref '%s'", ref);
        object = deref_tag(parse_object(sha1), ref, strlen(ref));
+       if (object->type == OBJ_TREE)
+               return make_virtual_commit((struct tree*)object,
+                       better_branch_name(ref));
        if (object->type != OBJ_COMMIT)
                return NULL;
        if (parse_commit((struct commit *)object))
@@ -1347,20 +1297,29 @@ static struct commit *get_ref(const char *ref)
        return (struct commit *)object;
 }
 
+static int merge_config(const char *var, const char *value)
+{
+       if (!strcasecmp(var, "merge.verbosity")) {
+               verbosity = git_config_int(var, value);
+               return 0;
+       }
+       return git_default_config(var, value);
+}
+
 int main(int argc, char *argv[])
 {
-       static const char *bases[2];
+       static const char *bases[20];
        static unsigned bases_count = 0;
        int i, clean;
        const char *branch1, *branch2;
        struct commit *result, *h1, *h2;
+       struct commit_list *ca = NULL;
+       struct lock_file *lock = xcalloc(1, sizeof(struct lock_file));
+       int index_fd;
 
-       original_index_file = getenv("GIT_INDEX_FILE");
-
-       if (!original_index_file)
-               original_index_file = strdup(git_path("index"));
-
-       temporary_index_file = strdup(git_path("mrg-rcrsv-tmp-idx"));
+       git_config(merge_config);
+       if (getenv("GIT_MERGE_VERBOSITY"))
+               verbosity = strtol(getenv("GIT_MERGE_VERBOSITY"), NULL, 10);
 
        if (argc < 4)
                die("Usage: %s <base>... -- <head> <remote> ...\n", argv[0]);
@@ -1373,26 +1332,39 @@ int main(int argc, char *argv[])
        }
        if (argc - i != 3) /* "--" "<head>" "<remote>" */
                die("Not handling anything other than two heads merge.");
+       if (verbosity >= 5) {
+               buffer_output = 0;
+               do_progress = 0;
+       }
+       else
+               do_progress = isatty(1);
 
        branch1 = argv[++i];
        branch2 = argv[++i];
-       printf("Merging %s with %s\n", branch1, branch2);
 
        h1 = get_ref(branch1);
        h2 = get_ref(branch2);
 
-       if (bases_count == 1) {
-               struct commit *ancestor = get_ref(bases[0]);
-               clean = merge(h1, h2, branch1, branch2, 0, ancestor, &result);
-       } else
-               clean = merge(h1, h2, branch1, branch2, 0, NULL, &result);
+       branch1 = better_branch_name(branch1);
+       branch2 = better_branch_name(branch2);
+
+       if (do_progress)
+               setup_progress_signal();
+       if (show(3))
+               printf("Merging %s with %s\n", branch1, branch2);
+
+       index_fd = hold_lock_file_for_update(lock, get_index_file(), 1);
 
-       if (cache_dirty)
-               flush_cache();
+       for (i = 0; i < bases_count; i++) {
+               struct commit *ancestor = get_ref(bases[i]);
+               ca = commit_list_insert(ancestor, &ca);
+       }
+       clean = merge(h1, h2, branch1, branch2, ca, &result);
+
+       if (active_cache_changed &&
+           (write_cache(index_fd, active_cache, active_nr) ||
+            close(index_fd) || commit_lock_file(lock)))
+                       die ("unable to write %s", get_index_file());
 
        return clean ? 0: 1;
 }
-
-/*
-vim: sw=8 noet
-*/