Code

Replaced in_array calls with in_array_strict
[gosa.git] / gosa-plugins / fai / admin / fai / class_faiPackage.inc
index 8201e1a40a7ed6da3bafb67fc0a1ca1b902b4230..703f197cbf68a50531adedcc830c9d7f017882bf 100644 (file)
@@ -33,24 +33,21 @@ class faiPackage extends plugin
   var $FAIdebianRelease          = ""; // The selected release
   var $FAIdebianSection          = array(); // selected section
   var $FAIinstallMethod          = "aptitude"; // hard coded
-  var $mirror                    = ""; // selected mirror
 
-  var $servers          = array();  // All available servers
-  var $releases         = array();  // All possible releases 
   var $sections         = array();  // All section types
 
   var $list             = NULL;
 
-  var $mirrors          = array();  // The combination of server/release/section
-  var $confDir          = "";
   var $usedPackages     = array();
   var $buffer           = NULL; 
-  var $strID            ="";
-  var $newDialogShown   =false;
+  var $newDialogShown   = false;
 
   var $FAIstate         = "";
   var $view_logged      = FALSE;
   var $base;
+  var $FAIpackage ;
+
+  var $packageSelect ;
 
   var $FAIinstallMethods  = array( "install", "ninstall", "remove", 
       "dselect-upgrade", "taskinst", "taskrm",
@@ -70,18 +67,14 @@ class faiPackage extends plugin
     if($dn != "new"){
       $this->dn =$dn;
 
-      /* Get FAIstate */
-      if(isset($this->attrs['FAIstate'][0])){
-        $this->FAIstate = $this->attrs['FAIstate'][0];
-      }
-
       /* Check if there are already some packages in this list 
        */
       $this->usedPackages = array();
       if(isset($this->attrs['FAIpackage'])){
         unset($this->attrs['FAIpackage']['count']);
         foreach($this->attrs['FAIpackage'] as $pkg){
-          $this->usedPackages[$pkg] = $pkg;
+          $name = preg_replace("/\-$/","",$pkg);
+          $this->usedPackages[$name] = $pkg;
         }
         ksort($this->usedPackages);
       }  
@@ -89,7 +82,7 @@ class faiPackage extends plugin
       /* Fetch all package configurations from ldap 
        */
       $PackageFilter = "";
-      foreach($this->usedPackages as $name){
+      foreach($this->usedPackages as $name => $value){
         $PackageFilter .= "(FAIpackage=".$name.")";
       }
       $PackageFilter = "(&(objectClass=FAIdebconfInfo)(|".$PackageFilter."))";
@@ -116,7 +109,7 @@ class faiPackage extends plugin
         $tmp['Type']  = $attr['FAIvariableType'][0];
 
         if (isset($attr['FAIvariableContent'][0])){
-          if(!in_array($attr['FAIvariableType'],array("multiselect"))){
+          if(!in_array_strict($attr['FAIvariableType'],array("multiselect"))){
             $tmp['Value'] = $attr['FAIvariableContent'][0];
           }else{
             $content = array();        
@@ -129,20 +122,13 @@ class faiPackage extends plugin
         }
       }
 
-      if (isset($this->attrs['FAIdebianSection']['count'])){
-        unset($this->attrs['FAIdebianSection']['count']);
-      }
-      if((isset($this->attrs['FAIdebianSection']))&&(is_array($this->attrs['FAIdebianSection']))){
-        $this->FAIdebianSection = array();
-        foreach($this->attrs['FAIdebianSection'] as $sec){
+      $this->FAIdebianSection = array();
+      if(isset($this->attrs['FAIdebianSection'])){
+        for($i = 0 ; $i < $this->attrs['FAIdebianSection']['count'] ; $i++ ){ 
+          $sec = $this->attrs['FAIdebianSection'][$i];
           $this->FAIdebianSection[$sec]=$sec;
         }
       }
-
-      if((isset($this->attrs['FAIdebianSection']))&&(is_string($this->attrs['FAIdebianSection']))){
-        $this->FAIdebianSection=array($this->attrs['FAIdebianSection']=>$this->attrs['FAIdebianSection']) ;
-      }
-      $this->confDir = CONFIG_DIR."/fai/";
       $this->FAIpackage = array();
 
     } // ENDE  dn != new  
@@ -157,6 +143,23 @@ class faiPackage extends plugin
     if ($this->dn != "new"){
       $this->newDialogShown= true;
     }
+    $this->is_new = FALSE;
+    if($this->dn == "new"){
+      $this->is_new =TRUE;
+    }
+
+    /* Generate package list */
+    $this->list= $this->genPkgs(TRUE);
+
+    // Prepare lists
+    $this->packageList = new sortableListing();
+    $this->packageList->setDeleteable(false);
+    $this->packageList->setEditable(false);
+    $this->packageList->setWidth("100%");
+    $this->packageList->setHeight("200px");
+    $this->packageList->setColspecs(array('20px','*','*','100px','60px'));
+    $this->packageList->setHeader(array(_("Status"),_("Name"),_("Description"),_("Version")));
+    $this->packageList->setDefaultSortColumn(1);
   }
 
 
@@ -174,20 +177,22 @@ class faiPackage extends plugin
     $smarty= get_smarty();
     $display= "";
 
-    $smarty->assign( "FAIinstallMethods", $this->FAIinstallMethods );
-
+    /******
+     * Initialize a new Package List with release and section name
+     ******/
+    
     if(!$this->is_account){
 
       /* Assemble release name */
-      $faifilter = session::get('faifilter');
-      $tmp= preg_replace('/,'.normalizePreg(get_ou('faiou')).'.*$/', '', $faifilter['branch']);
+      $release = $this->parent->parent->fai_release;
+      $tmp= preg_replace('/[,]*'.preg_quote(get_ou("faiManagement", "faiBaseRDN"), '/').'.*$/i', '', $release);
       $tmp= preg_replace('/ou=/', '', $tmp);
-      $rev= array_reverse(split(',', $tmp));
-      $this->FAIdebianRelease= "";
+      $rev= array_reverse(explode(',', $tmp));
+      $this->FAIdebianRelease= "/";
       foreach ($rev as $part){
         $this->FAIdebianRelease.= "/$part";
       }
-      $this->FAIdebianRelease= preg_replace('#^/#', '', $this->FAIdebianRelease);
+      $this->FAIdebianRelease= preg_replace('#^[/]*#', '', $this->FAIdebianRelease);
 
       /* Assemble sections */
       $repos= $this->getServerInfos();
@@ -199,93 +204,191 @@ class faiPackage extends plugin
       /* Assign Repository settings*/ 
       $this->is_account     = true;
     }
+  
+
+    /******
+     * Add 
+     ******/
+
+    if(isset($_POST['AddManualpkg']) && 
+        isset($_POST['addPpkgsText']) &&
+        strlen($_POST['addPpkgsText']) && 
+        $this->acl_is_writeable("FAIpackage") && 
+        !preg_match("/freeze/",$this->FAIstate)){
+
+      // Check all splitted packages for valid package names
+      $add_packages = preg_split( "/[\s,]+/", get_post('addPpkgsText'), -1, PREG_SPLIT_NO_EMPTY );
+      if( is_array($add_packages) ) {
+        $valid_packages = array();
+        $invalid_packages = array();
+        foreach ($add_packages as $value) {
+          if(!preg_match( "/^[a-z0-9][-0-9a-z+\.]+$/",$value)){
+            $invalid_packages[] = trim($value);
+          }else{
+            $valid_packages[] = trim($value);
+          }
+        }
+        if(count($invalid_packages)){
+          $str = implode(", ",$invalid_packages);
+          msg_dialog::display(_("Invalid package names"), 
+              sprintf(_("The following package names don't match the Debian policy: %s"),$str),
+              ERROR_DIALOG);
+        }
 
-    /* Assign variables */
-    foreach($this->attributes as $attrs){
-      $smarty->assign($attrs,$this->$attrs);
-    }
 
-    /* Generate package list */
-    $this->list= $this->genPkgs();
+        // If we have a complete list of valid packages, add them
+        if(count($valid_packages)){
 
-    /* + was pressed to open the package dialog */
-    if(isset($_POST['Addpkg']) && $this->acl_is_writeable("FAIpackage")){
-      $this->dialog = new faiPackageEntry($this->config, $this->dn,$this->list,$this->usedPackages);
-      $this->is_dialog =true;
-    }
+          foreach($valid_packages as $key =>  $value){
+            if(array_key_exists($value,$this->usedPackages)) {
+              unset($valid_packages[$key]);
+            }
+          }
 
-    /* Delete selected package */ 
-    if(isset($_POST['Delpkg']) && $this->acl_is_writeable("FAIpackage")){
-      if($this->FAIstate != "freeze"){
-        foreach($_POST['usedPackages'] as $del){
-          if(isset($this->usedPackages[$del])){
-            unset($this->usedPackages[$del]);
+          // Query SI-Deamon for additional package information
+          $daemon       = new gosaSupportDaemon();
+          $query_attrs  = array("distribution", "package","version", "section", "description", "timestamp");
+          $do_si_query  = true;
+
+
+          foreach ($valid_packages as $value) {
+            
+            if( $do_si_query == true ) {
+              $res = $daemon->FAI_get_packages($this->FAIdebianRelease,$query_attrs,array($value),0,1);
+              if( ! $daemon->is_error()){
+                
+                if(count($res)){
+
+                  // We just use the last answer - there shouldn't be multiple
+                  $res_attrs = array_pop( $res );
+                  $this->list[$value] = $res_attrs;
+                  $this->usedPackages[$value] = $res_attrs['PACKAGE'];
+
+                }else{
+                  $this->usedPackages[$value] = $value;
+                }
+              }else{
+                msg_dialog::display(_("Service infrastructure"),
+                    msgPool::siError($daemon->get_error()),
+                    ERROR_DIALOG);
+                $do_si_query = false;
+              }
+            }
           }
+
+          ksort($this->usedPackages);
+
+          /* Generate package list */
+          $this->list= $this->genPkgs(TRUE);
         }
       }
     }
 
-    /* Abort package selection dialog */ 
-    if(isset($_POST['CancelSubObject'])){
-      $this->dialog = false;
-      $this->is_dialog=false;
+    // Open the packageSelect dialog to allow adding packages out of a list.
+    if(isset($_POST['Addpkg']) && $this->acl_is_writeable("FAIpackage") && !preg_match("/freeze/",$this->FAIstate)){
+      $this->packageSelect = new packageSelect($this->config, get_userinfo());
+      session::set('packageSelect_Release',$this->FAIdebianRelease);
+      $this->dialog =true;
     }
 
-    /* attach new packages */
-    if(isset($_POST['SaveSubObject'])) {
-      if($this->FAIstate != "freeze"){
-        $this->dialog->save_object();
-        if(count($this->dialog->check())){
-          foreach($this->dialog->check() as $msgs){
-            msg_dialog::display(_("Error"), $msgs, ERROR_DIALOG);
+    // Close packageSelect dialog.
+    if(isset($_POST['packageSelect_cancel'])){
+      $this->packageSelect = FALSE;
+      $this->dialog =FALSE;
+    }
+
+    // Close packageSelect dialog and add the selected packages.
+    if(isset($_POST['packageSelect_save']) && $this->packageSelect instanceOf packageSelect){
+      if(!preg_match("/freeze/i", $this->FAIstate)){
+        $use = $this->packageSelect->save();
+
+        foreach($use as $pkg){
+          $item = array();
+          for($i =0; $i < $pkg['count']; $i++){
+            $item[$pkg[$i]] = $pkg[$pkg[$i]][0];
           }
-        }else{
-          $use = $this->dialog->save();
-          $this->usedPackages = $use;
-          $this->dialog = false;
-          $this->is_dialog=false;
-          ksort($this->usedPackages);
+          $this->usedPackages[$item['PACKAGE']] = $item['PACKAGE']; 
         }
-      }else{
-        $this->dialog = false;
-        $this->is_dialog=false;
+
+        ksort($this->usedPackages);
+
+        /* Generate package list */
+        $this->list= $this->genPkgs(TRUE);
       }
+      $this->packageSelect = FALSE;
+      $this->dialog =FALSE;
     }
 
-    /* Configuration dialog open*/
-    if((isset($_POST['Conpkg']))&&(isset($_POST['usedPackages']))&&(!empty($_POST['usedPackages'][0])) && $this->acl_is_writeable("FAIdebconfInfo")){
-      $path = CONFIG_DIR."/fai/".$this->FAIdebianRelease."/debconf.d";
-      $pkg_config = array();
-      $pkg = $_POST['usedPackages'][0];
+    // Display package add dialog 
+    if($this->packageSelect instanceOf packageSelect){
 
-      if(isset($this->ConfiguredPackages[$pkg])){
-        $pkg_config = $this->ConfiguredPackages[$pkg];
+      session::set('filterBlacklist', array('PACKAGE' => $this->usedPackages));
+      return $this->packageSelect->execute();
+    }
+
+
+    /* Check image Posts 
+     */
+    foreach($_POST as $name => $value){
+
+      /******
+       * Mark as removed  
+       ******/
+      
+      if(!preg_match('/freeze/i', $this->FAIstate) && preg_match("/^removal_package_/",$name)){
+        $id = @postDecode(preg_replace("/^removal_package_(.*)$/","\\1",$name));
+        if(isset($this->usedPackages[$id])){
+          $pkg = $this->usedPackages[$id]; 
+          if (preg_match('/\-$/', $pkg)){
+            $pkg= preg_replace('/\-$/', '', $pkg);
+          } else {
+            $pkg= preg_replace('/$/', '-', $pkg);
+          }
+          $this->usedPackages[$id] = $pkg;
+        }
+        break;
       }
 
-      $this->dialog = new faiPackageConfiguration($this->config, $this->dn,$pkg, $this->FAIdebianRelease , $pkg_config);
-      $this->is_dialog =true;
-    }
+      /******
+       * Delete Pkgs   
+       ******/
+      if(!preg_match('/freeze/i', $this->FAIstate) && preg_match("/^remove_package_/",$name)){
+        $id = @postDecode(preg_replace("/^remove_package_(.*)$/","\\1",$name));
+        if(isset($this->usedPackages[$id])){
+          unset($this->usedPackages[$id]);
+        }
+        break;
+      }
 
-    /* Configuration dialog open*/
-    if($this->FAIstate != "freeze" && $this->acl_is_writeable("FAIpackage")){
-      if((isset($_POST['Markpkg']))&&(isset($_POST['usedPackages']))&&(!empty($_POST['usedPackages']))){
-        foreach($_POST['usedPackages'] as $pkg){
-          if (isset($this->usedPackages[$pkg])){
-            unset($this->usedPackages[$pkg]);
-            if (preg_match('/^-/', $pkg)){
-              $pkg= preg_replace('/^-/', '', $pkg);
-            } else {
-              $pkg= preg_replace('/^/', '-', $pkg);
-            }
-            $this->usedPackages[$pkg]= $pkg;
+      /******
+       * Configure Pkgs   
+       ******/
+      if(!preg_match('/freeze/i', $this->FAIstate) && preg_match("/^configure_package_/",$name)){
+        $pkg = @postDecode(preg_replace("/^configure_package_(.*)$/","\\1",$name));
+         
+        if(isset($this->usedPackages[$pkg])){
+
+          /* Configuration dialog open*/
+          $pkg_config = array();
+          if(isset($this->ConfiguredPackages[$pkg])){
+            $pkg_config = $this->ConfiguredPackages[$pkg];
           }
+          $this->dialog = new faiPackageConfiguration($this->config, $this->dn,$pkg, $this->FAIdebianRelease , $pkg_config);
+          $this->is_dialog =true;
         }
+        break;
       }
     }
 
+    /* Abort package selection dialog */ 
+    if(isset($_POST['CancelSubObject'])){
+      $this->dialog = false;
+      $this->is_dialog=false;
+    }
+
     /* Save Configuration */
     if(isset($_POST['SaveObjectConfig'])){
-      if($this->FAIstate != "freeze"){
+      if(!preg_match("/^freeze/", $this->FAIstate)){
         $this->ConfiguredPackages= array_merge($this->ConfiguredPackages,$this->dialog->save());
       }
       $this->dialog = false;
@@ -300,9 +403,77 @@ class faiPackage extends plugin
 
     /* Display dialog */ 
     if($this->is_dialog){
+      $this->dialog->save_object();
       return $this->dialog->execute();
     }
 
+
+    /******
+     * Display UI / HTML / smarty 
+     ******/
+
+    /* Create list to display a list of all currently used packages
+     */
+    $data = $lData = array();
+    if(is_array($this->usedPackages)){
+        foreach($this->usedPackages as $usedName => $name){
+
+            /* Append message if package is configured */
+            $configured = image('images/empty.png');
+            if(isset($this->ConfiguredPackages[$usedName])){
+                $configured = image('plugins/fai/images/package_configure.png','',_("Configured"));
+            }
+
+            /* Adapt used name if we're marked for removal */
+            $removal = image('images/empty.png');
+            if (preg_match('/\-$/', $name)){
+                $removal = image('plugins/fai/images/removal_mark.png','',_("Package marked for removal"));
+            }
+
+            /* Get Version */
+            $version = "";
+            if(isset($this->list[$usedName]['VERSION'])){
+                $version = $this->list[$usedName]['VERSION'];
+            }
+
+            /* Get description */
+            $description = "";
+            if(isset($this->list[$usedName]['DESCRIPTION'])){
+                $description = base64_decode($this->list[$usedName]['DESCRIPTION']);
+            }
+
+            $actions= image('plugins/fai/images/removal_mark.png',
+                    'removal_package_'.postEncode($usedName),
+                    _("Mark package for removal"));
+
+            if(isset($this->list[$usedName]['TEMPLATE']) && 
+                    !preg_match('/^freeze/', $this->FAIstate) && $this->acl_is_writeable("FAIdebconfInfo")){
+                $actions.= image('plugins/fai/images/package_configure.png',
+                        'configure_package_'.postEncode($usedName),
+                        _("Configure this package"));
+            }
+            if(!preg_match('/^freeze/', $this->FAIstate) && $this->acl_is_writeable("FAIpackage")){
+                $actions.= image('images/lists/trash.png',
+                        'remove_package_'.postEncode($usedName),
+                        _("Remove this package"));
+            }
+            $data[$usedName] = $usedName;
+            $lData[$usedName] = array('data'=>
+                    array(
+                        $configured."&nbsp;".$removal,
+                        $usedName ,set_post($description), $version, $actions));
+        }
+    }
+    $this->packageList->setAcl($this->getacl("FAIpackage",preg_match('/^freeze/', $this->FAIstate)));
+    $this->packageList->setListData($data,$lData);
+    $this->packageList->update();
+
+    /* Assign variables */
+    foreach($this->attributes as $attrs){
+      $smarty->assign($attrs,set_post($this->$attrs));
+    }
+    $smarty->assign( "FAIinstallMethods", $this->FAIinstallMethods );
+
     /* Assign section to smarty */
     $strsec = "";
     foreach($this->FAIdebianSection as $sec){
@@ -313,40 +484,31 @@ class faiPackage extends plugin
     foreach($tmp['plProvidedAcls'] as $name => $translated){
       $smarty->assign($name."ACL",$this->getacl($name,preg_match("/freeze/",$this->FAIstate)));
     }
-
-    $smarty->assign("releases",$this->releases);
+    $smarty->assign("freeze", preg_match("/freeze/",$this->FAIstate));
+    $smarty->assign("listing",$this->packageList->render());
     $smarty->assign("release" ,$this->FAIdebianRelease);
     $smarty->assign("sections",$this->sections);
     $smarty->assign("section" ,$strsec);
-    $smarty->assign("usedPackages",$this->printUsedPackages());
     $display.= $smarty->fetch(get_template_path('faiPackage.tpl', TRUE));
     return($display);
   }
 
-  /* Delete me, and all my subtrees
+
+  /*! \brief  Removes this packageList from the ldap database 
    */
   function remove_from_parent()
   {
     $ldap = $this->config->get_ldap_link();
     $ldap->cd ($this->dn);
-
-    $faifilter = session::get('faifilter');
-    $use_dn = preg_replace("/".normalizePreg(FAI::get_release_dn($this->dn))."/i", $faifilter['branch'], $this->dn);
-    if($faifilter['branch'] == "main"){
-      $use_dn = $this->dn;
-    }
-
+    $release = $this->parent->parent->fai_release;
+    $use_dn = preg_replace("/".preg_quote(FAI::get_release_dn($this->dn), '/')."/i", $release, $this->dn);
     FAI::prepare_to_save_FAI_object($use_dn,array(),true);
-
     new log("remove","fai/".get_class($this),$use_dn,$this->attributes);
-
     foreach($this->ConfiguredPackages as $pkgname => $attrs){
       foreach($attrs as $name => $attr){
         $pkgdn =  "FAIvariable=".$name.",".$this->dn;
-        $use_dn = preg_replace("/".normalizePreg(FAI::get_release_dn($this->dn))."/i", $faifilter['branch'], $pkgdn);
-        if($faifilter['branch'] == "main"){
-          $use_dn = $obj['dn'];
-        }
+        $use_dn = preg_replace("/".preg_quote(FAI::get_release_dn($this->dn), '/')."/i", $release, $pkgdn);
         FAI::prepare_to_save_FAI_object($use_dn,array(),true);
       }
     }
@@ -354,16 +516,18 @@ class faiPackage extends plugin
   }
 
 
-  /* Save data to object 
+  /*! \brief  Collect all relevant POST vars for this plugin 
    */
   function save_object()
   {
-    if($this->FAIstate == "freeze") return;  
+    if(preg_match("/^freeze/", $this->FAIstate)) return;
     plugin::save_object();
   }
 
 
-  /* Check supplied data */
+  /*! \brief  Check given inputs for this package list
+      @return Array Containing all error messages, or an empty array if no error occured
+   */
   function check()
   {
     /* Call common method to give check the hook */
@@ -377,109 +541,58 @@ class faiPackage extends plugin
       $message[]=_("Please choose a valid release/section combination for your repository setup!");
     }
 
+    /* Ensure that we do not overwrite an allready existing entry 
+     */
+    if($this->is_new){
+      $release = $this->parent->parent->fai_release;
+      $new_dn= 'cn='.$this->cn.",".get_ou("faiPackage", "faiPackageRDN").get_ou("faiManagement", "faiBaseRDN").$release;
+      $res = faiManagement::check_class_name("FAIpackageList",$this->cn,$new_dn);
+      if(isset($res[$this->cn])){
+        $message[] = msgPool::duplicated(_("Name"));
+      }
+    }
     return ($message);
   }
 
-  function printUsedPackages(){
-    $a_ret=array(); 
-    if(is_array($this->usedPackages)) {
-      foreach($this->usedPackages as $usedName){
 
-        $config = 0;
+  /*! \brief  Reload the list of cached packages.
+      @return Returns the currently cached list of packages. 
+   */
+  function genPkgs($force = false)
+  {
+    if(empty($this->FAIdebianRelease)) return;
 
-        foreach($this->ConfiguredPackages as $name => $value){
-          if($name == $usedName){
-            $config ++;
-          }
-        }
+    if(!count($this->buffer) || $force){
+      $q = new gosaSupportDaemon();
+      $attrs = array("distribution", "package","version", "section", "description", "timestamp","template");
 
-        $c_str ="";
-        if($config){
-          $c_str = " - "._("package is configured");
-        }
+      $packages = array_keys($this->usedPackages);
 
-        /* Adapt used name if we're marked for removal */
-        $dsc= "";
-        if (preg_match('/^-/', $usedName)){
-          $dsc= " - "._("Package marked for removal");
-          // Generally a bad idea here, because the toggel triggers on -, not on !
-          //$usedName= preg_replace('/^-/', '! ', $usedName);
-        }else{
-          $usedName2= $usedName;
-        }
-
-        if(isset($this->list[$usedName][1])){
-          $a_ret[$usedName] = $usedName2." [".$this->list[$usedName][1]."]".$c_str.$dsc;
-        }else{
-          $a_ret[$usedName] = $usedName2.$c_str.$dsc;
+      $ret = $q->FAI_get_packages($this->FAIdebianRelease,$attrs,$packages);
+      if($q->is_error()){
+        msg_dialog::display(_("Service infrastructure"),msgPool::siError($q->get_error()),ERROR_DIALOG);
+      }else{
+        foreach($ret as $attr){
+          $this->buffer[$attr['PACKAGE']] = $attr;
         }
       }
     }
-    return($a_ret);
-  }
-
-  function genPkgs()
-  {
-    if($this->buffer === NULL || !count($this->buffer)){
-      $this->buffer = array();
-      $q = new gosaSupportDaemon();
-      $ret = $q->FAI_get_packages($this->FAIdebianRelease);
-      foreach($ret as $attr){
-        $this->buffer[$attr['PACKAGE']] = array($attr['PACKAGE'],$attr['VERSION'],$attr['SECTION'],$attr['DESCRIPTION']);
-      }
-    }
     return $this->buffer;
-#   /* Generate a list off available packages for this mirror, section and release
-#    */
-#   /* Only read this file if it wasn't read before */
-#   $this->buffer = NULL;
-#   if($this->buffer === NULL){
-#     $this->buffer=array();
-#     $a_ret = array();
-#     foreach($this->FAIdebianSection as $sec){
-#       $strID= CONFIG_DIR."/fai/".$this->FAIdebianRelease."/".$sec;
-#
-#       if(!is_file($strID)){
-#         msg_dialog::display(_("Error"), sprintf(_("Package file '%s' does not exist!"), $strID), ERROR_DIALOG);
-#         unset($this->buffer);
-#         return(array());
-#       }
-#       $fp = fopen($strID,"r");
-#
-#       /* Parse every line and create an array */
-#       while(!feof($fp)){
-#         $str= fgets($fp,512);
-#         $stra= split("\|",$str);
-#         if(count($stra)==4){
-#           $a_ret[$stra[0]] = $stra;
-#         break;
-#         }
-#       }
-#       fclose($fp);
-#       /* Save our Data, to avoid reading it again */
-#     }
-#     $this->buffer = $a_ret;
-#     ksort($a_ret);
-#     print_a($this->buffer);
-#     return($a_ret);
-#   }else{
-#     print_a($this->buffer);
-#     return $this->buffer;
-#   }
   }
 
 
-  /* Save to LDAP */
+  /*! \brief Save packages and their configuration to ldap 
+   */
   function save()
   {
 
     /* Assemble release name */
     if($this->FAIdebianRelease == "ClearFromCopyPaste"){
-      $faifilter = session::get('faifilter');
-      $tmp= preg_replace('/,'.normalizePreg(get_ou('faiou')).'.*$/', '', $faifilter['branch']);
+
+      $current_release  = $this->parent->parent->fai_release;
+      $tmp= preg_replace('/,'.preg_quote(get_ou("faiManagement", "faiBaseRDN"), '/').'.*$/i', '', $current_release);
       $tmp= preg_replace('/ou=/', '', $tmp);
-      $rev= array_reverse(split(',', $tmp));
+      $rev= array_reverse(explode(',', $tmp));
       $this->FAIdebianRelease= "";
       foreach ($rev as $part){
         $this->FAIdebianRelease.= "/$part";
@@ -492,7 +605,7 @@ class faiPackage extends plugin
     $ldap = $this->config->get_ldap_link();
 
     $this->attrs['FAIpackage'] = array();
-    foreach($this->usedPackages as $pkg => $obj){
+    foreach($this->usedPackages as $pkg){
       $this->attrs['FAIpackage'][] = $pkg;
     } 
 
@@ -502,9 +615,6 @@ class faiPackage extends plugin
     }
 
     FAI::prepare_to_save_FAI_object($this->dn,$this->attrs);
-    if (!$ldap->success()){
-      msg_dialog::display(_("LDAP error"), msgPool::ldaperror($ldap->get_error(), $this->dn, 0, get_class()));
-    }
     
     if($this->initially_was_account){
       new log("modify","fai/".get_class($this),$this->dn,$this->attributes);
@@ -533,17 +643,25 @@ class faiPackage extends plugin
         $pkgattrs['FAIvariableContent']   = $attr['Value'];
         $pkgdn =  "FAIvariable=".$name.",".$this->dn;
 
-       /* Tag object */
-       $this->tag_attrs($pkgattrs, $pkgdn, $this->gosaUnitTag);
+        /* Tag object */
+        $this->tag_attrs($pkgattrs, $pkgdn, $this->gosaUnitTag);
+
+        if(in_array_strict($pkgattrs['FAIvariableType'],array("boolean","multiselect","password","select","string","text"))){
 
-        if(in_array($pkgattrs['FAIvariableType'],array("boolean","multiselect","password","select","string","text"))){
-          FAI::prepare_to_save_FAI_object($pkgdn,$pkgattrs);
+          if($pkgattrs['FAIvariableType'] == "text" && $pkgattrs['FAIvariableContent'] == ""){
+            gosa_log("Skipped saving FAIvariable '$name' empty string can't be saved.");
+          }else{
+            FAI::prepare_to_save_FAI_object($pkgdn,$pkgattrs);
+          }
         }
       }
     }
   }
 
-  /* Return plugin informations for acl handling */ 
+
+  /*! \brief  Return plugin informations for acl handling 
+      @return Array ACL infos of this plugin.
+   */ 
   static function plInfo()
   {
     return (array( 
@@ -554,20 +672,33 @@ class faiPackage extends plugin
           "plPriority"    => 28,
           "plSection"     => array("administration"),
           "plCategory"    => array("fai"),
+          "plProperties" =>
+          array(
+              array(
+                  "name"          => "faiPackageRDN",
+                  "type"          => "rdn",
+                  "default"       => "ou=packages,",
+                  "description"   => _("RDN for FAI package storage."),
+                  "check"         => "gosaProperty::isRdn",
+                  "migrate"       => "migrate_faiPackageRDN",
+                  "group"         => "plugin",
+                  "mandatory"     => TRUE)),
+
           "plProvidedAcls" => array(
             "cn"                => _("Name"),
             "description"       => _("Description"),
             "FAIpackage"        => _("Packages"),
-            "FAIdebianSection"  => _("Section")."&nbsp;("._("Readonly").")",
+            "FAIdebianSection"  => _("Section")."&nbsp;("._("Read-only").")",
             "FAIinstallMethod"  => _("Install Method"),
             "FAIdebconfInfo"    => _("Package configuration"),
-            "FAIdebianRelease"  => _("Release")."&nbsp;("._("Readonly").")")
+            "FAIdebianRelease"  => _("Release")."&nbsp;("._("Read-only").")")
           ));
   }
 
 
-
-
+  /*! \brief prepares this plugin to be inserted after it was copied or cut.
+      @param Array  All attributes from the source object. 
+   */
   function PrepareForCopyPaste($source)
   {
     plugin::PrepareForCopyPaste($source);
@@ -624,7 +755,7 @@ class faiPackage extends plugin
       $tmp['Type']  = $attr['FAIvariableType'][0];
 
       if (isset($attr['FAIvariableContent'][0])){
-        if(!in_array($attr['FAIvariableType'],array("multiselect"))){
+        if(!in_array_strict($attr['FAIvariableType'],array("multiselect"))){
           $tmp['Value'] = $attr['FAIvariableContent'][0];
         }else{
           $content = array();        
@@ -639,6 +770,9 @@ class faiPackage extends plugin
   }
 
 
+  /*! \brief  Returns a list of all configured servers with repositories.
+      @return Array  All repository server 
+   */
   function getServerInfos()
   {
     $ret = array();
@@ -649,9 +783,9 @@ class faiPackage extends plugin
       if(isset($attrs['FAIrepository'])){
         for($i =0 ; $i < $attrs['FAIrepository']['count']; $i++){
           $obj = $attrs['FAIrepository'][$i];
-          $tmp = split("\|",$obj);
+          $tmp = explode("|",$obj);
           if(count($tmp)==4){
-            foreach(split(",",$tmp[3]) as $sec){
+            foreach(explode(",",$tmp[3]) as $sec){
               if(!empty($sec)){
                 $ret[$tmp[2]][] =  $sec;
               }
@@ -664,6 +798,32 @@ class faiPackage extends plugin
   }
 
 
+  /*! \brief  Used for copy & paste.
+    Returns a HTML input mask, which allows to change the cn of this entry.
+    @param  Array   Array containing current status && a HTML template.
+   */
+  function getCopyDialog()
+  {
+    $vars = array("cn");
+    $smarty = get_smarty();
+    $smarty->assign("cn", set_post($this->cn));
+    $str = $smarty->fetch(get_template_path("paste_generic.tpl",TRUE));
+    $ret = array();
+    $ret['string'] = $str;
+    $ret['status'] = "";
+    return($ret);
+  }
+
+
+  /*! \brief  Used for copy & paste.
+    Some entries must be renamed to avaoid duplicate entries.
+   */
+  function saveCopyDialog()
+  {
+    if(isset($_POST['cn'])){
+      $this->cn = get_post('cn');
+    }
+  }
 }
 
 // vim:tabstop=2:expandtab:shiftwidth=2:filetype=php:syntax:ruler: