commit, merge: initialize static strbuf

[git.git] / builtin-log.c
diff --git a/builtin-log.c b/builtin-log.c

index 9817d6fbeb69393ed321e71b6211a8630b982fab..f4975cf35f7f1555739f7657ee62ed983d18cb84 100644 (file)
--- a/builtin-log.c
+++ b/builtin-log.c
@@ -234,12 +234,8 @@ static int git_log_config(const char *var, const char *value, void *cb)
  {
         if (!strcmp(var, "format.pretty"))
                 return git_config_string(&fmt_pretty, var, value);
-       if (!strcmp(var, "format.subjectprefix")) {
-               if (!value)
-                       config_error_nonbool(var);
-               fmt_patch_subject_prefix = xstrdup(value);
-               return 0;
-       }
+       if (!strcmp(var, "format.subjectprefix"))
+               return git_config_string(&fmt_patch_subject_prefix, var, value);
         if (!strcmp(var, "log.date"))
                 return git_config_string(&default_date_mode, var, value);
         if (!strcmp(var, "log.showroot")) {
@@ -317,7 +313,7 @@ static int show_object(const unsigned char *sha1, int show_tag_object,
  
  static int show_tree_object(const unsigned char *sha1,
                 const char *base, int baselen,
-               const char *pathname, unsigned mode, int stage)
+               const char *pathname, unsigned mode, int stage, void *context)
  {
         printf("%s%s\n", pathname, S_ISDIR(mode) ? "/" : "");
         return 0;
@@ -360,7 +356,7 @@ int cmd_show(int argc, const char **argv, const char *prefix)
                                         t->tag,
                                         diff_get_color_opt(&rev.diffopt, DIFF_RESET));
                         ret = show_object(o->sha1, 1, &rev);
-                       objects[i].item = (struct object *)t->tagged;
+                       objects[i].item = parse_object(t->tagged->sha1);
                         i--;
                         break;
                 }
@@ -370,7 +366,7 @@ int cmd_show(int argc, const char **argv, const char *prefix)
                                         name,
                                         diff_get_color_opt(&rev.diffopt, DIFF_RESET));
                         read_tree_recursive((struct tree *)o, "", 0, 0, NULL,
-                                       show_tree_object);
+                                       show_tree_object, NULL);
                         break;
                 case OBJ_COMMIT:
                         rev.pending.nr = rev.pending.alloc = 0;
@@ -489,12 +485,8 @@ static int git_format_config(const char *var, const char *value, void *cb)
                 add_header(value);
                 return 0;
         }
-       if (!strcmp(var, "format.suffix")) {
-               if (!value)
-                       return config_error_nonbool(var);
-               fmt_patch_suffix = xstrdup(value);
-               return 0;
-       }
+       if (!strcmp(var, "format.suffix"))
+               return git_config_string(&fmt_patch_suffix, var, value);
         if (!strcmp(var, "format.cc")) {
                 if (!value)
                         return config_error_nonbool(var);
@@ -1090,7 +1082,7 @@ static int add_pending_commit(const char *arg, struct rev_info *revs, int flags)
  }
  
  static const char cherry_usage[] =
-"git-cherry [-v] <upstream> [<head>] [<limit>]";
+"git cherry [-v] <upstream> [<head>] [<limit>]";
  int cmd_cherry(int argc, const char **argv, const char *prefix)
  {
         struct rev_info revs;