diff --git a/bindings/java/org/collectd/java/GenericJMXConfMBean.java b/bindings/java/org/collectd/java/GenericJMXConfMBean.java
index eea2d8ab81901b2e375859d9bb55f2f2fd557663..b1fbfb3ec18c14fadf0ae56c845d8ff76a0f5417 100644 (file)
/*
* collectd/java - org/collectd/java/GenericJMXConfMBean.java
- * Copyright (C) 2009 Florian octo Forster
+ * Copyright (C) 2009,2010 Florian octo Forster
*
* This program is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License as published by the
package org.collectd.java;
-import java.util.List;
import java.util.Iterator;
+import java.util.List;
+import java.util.Set;
import java.util.ArrayList;
import javax.management.MBeanServerConnection;
import javax.management.ObjectName;
import javax.management.MalformedObjectNameException;
-
import org.collectd.api.Collectd;
import org.collectd.api.PluginData;
import org.collectd.api.OConfigValue;
{
private String _name; /* name by which this mapping is referenced */
private ObjectName _obj_name;
- private String _instance;
+ private String _instance_prefix;
+ private List<String> _instance_from;
private List<GenericJMXConfValue> _values;
private String getConfigString (OConfigItem ci) /* {{{ */
/*
* <MBean "alias name">
- * Instance "foobar"
* ObjectName "object name"
+ * InstancePrefix "foobar"
+ * InstanceFrom "name"
* <Value />
* <Value />
* :
+ "MBean blocks need exactly one string argument."));
this._obj_name = null;
+ this._instance_prefix = null;
+ this._instance_from = new ArrayList<String> ();
this._values = new ArrayList<GenericJMXConfValue> ();
children = ci.getChildren ();
Collectd.logDebug ("GenericJMXConfMBean: child.getKey () = "
+ child.getKey ());
- if (child.getKey ().equalsIgnoreCase ("Instance"))
- {
- String tmp = getConfigString (child);
- if (tmp != null)
- this._instance = tmp;
- }
- else if (child.getKey ().equalsIgnoreCase ("ObjectName"))
+ if (child.getKey ().equalsIgnoreCase ("ObjectName"))
{
String tmp = getConfigString (child);
if (tmp == null)
+ tmp, e));
}
}
+ else if (child.getKey ().equalsIgnoreCase ("InstancePrefix"))
+ {
+ String tmp = getConfigString (child);
+ if (tmp != null)
+ this._instance_prefix = tmp;
+ }
+ else if (child.getKey ().equalsIgnoreCase ("InstanceFrom"))
+ {
+ String tmp = getConfigString (child);
+ if (tmp != null)
+ this._instance_from.add (tmp);
+ }
else if (child.getKey ().equalsIgnoreCase ("Value"))
{
GenericJMXConfValue cv;
} /* }}} GenericJMXConfMBean (OConfigItem ci) */
- public String getName ()
+ public String getName () /* {{{ */
{
return (this._name);
- }
+ } /* }}} */
- public void query (MBeanServerConnection conn, PluginData pd) /* {{{ */
+ public int query (MBeanServerConnection conn, PluginData pd, /* {{{ */
+ String instance_prefix)
{
- pd.setPluginInstance ((this._instance != null) ? this._instance : "");
+ Set<ObjectName> names;
+ Iterator<ObjectName> iter;
+
+ try
+ {
+ names = conn.queryNames (this._obj_name, /* query = */ null);
+ }
+ catch (Exception e)
+ {
+ Collectd.logError ("GenericJMXConfMBean: queryNames failed: " + e);
+ return (-1);
+ }
+
+ if (names.size () == 0)
+ {
+ Collectd.logWarning ("GenericJMXConfMBean: No MBean matched "
+ + "the ObjectName " + this._obj_name);
+ }
+
+ iter = names.iterator ();
+ while (iter.hasNext ())
+ {
+ ObjectName objName;
+ PluginData pd_tmp;
+ List<String> instanceList;
+ StringBuffer instance;
+
+ objName = iter.next ();
+ pd_tmp = new PluginData (pd);
+ instanceList = new ArrayList<String> ();
+ instance = new StringBuffer ();
+
+ Collectd.logDebug ("GenericJMXConfMBean: objName = "
+ + objName.toString ());
+
+ for (int i = 0; i < this._instance_from.size (); i++)
+ {
+ String propertyName;
+ String propertyValue;
+
+ propertyName = this._instance_from.get (i);
+ propertyValue = objName.getKeyProperty (propertyName);
+ if (propertyValue == null)
+ {
+ Collectd.logError ("GenericJMXConfMBean: "
+ + "No such property in object name: " + propertyName);
+ }
+ else
+ {
+ instanceList.add (propertyValue);
+ }
+ }
+
+ if (instance_prefix != null)
+ instance.append (instance_prefix);
+
+ if (this._instance_prefix != null)
+ instance.append (this._instance_prefix);
+
+ for (int i = 0; i < instanceList.size (); i++)
+ {
+ if (i > 0)
+ instance.append ("-");
+ instance.append (instanceList.get (i));
+ }
+
+ pd_tmp.setPluginInstance (instance.toString ());
+
+ Collectd.logDebug ("GenericJMXConfMBean: instance = " + instance.toString ());
+
+ for (int i = 0; i < this._values.size (); i++)
+ this._values.get (i).query (conn, objName, pd_tmp);
+ }
- for (int i = 0; i < this._values.size (); i++)
- this._values.get (i).query (conn, this._obj_name, pd);
+ return (0);
} /* }}} void query */
}