diff --git a/src/collectd.c b/src/collectd.c
index f8f2fcc5b1b05c4032c0f6866436f98a4931716a..984ff757f3911fdc156717261bbb9c195907930a 100644 (file)
--- a/src/collectd.c
+++ b/src/collectd.c
#include "collectd.h"
#include "common.h"
#include "collectd.h"
#include "common.h"
-#include "network.h"
+#include <sys/types.h>
+#include <sys/socket.h>
+#include <netdb.h>
+
#include "plugin.h"
#include "configfile.h"
#include "plugin.h"
#include "configfile.h"
loop++;
}
loop++;
}
-static int init_global_variables (void)
+static int init_hostname (void)
{
const char *str;
{
const char *str;
+ struct addrinfo ai_hints;
+ struct addrinfo *ai_list;
+ struct addrinfo *ai_ptr;
+ int status;
+
str = global_option_get ("Hostname");
if (str != NULL)
{
strncpy (hostname_g, str, sizeof (hostname_g));
str = global_option_get ("Hostname");
if (str != NULL)
{
strncpy (hostname_g, str, sizeof (hostname_g));
+ hostname_g[sizeof (hostname_g) - 1] = '\0';
+ return (0);
}
}
- else
+
+ if (gethostname (hostname_g, sizeof (hostname_g)) != 0)
{
{
- if (gethostname (hostname_g, sizeof (hostname_g)) != 0)
- {
- fprintf (stderr, "`gethostname' failed and no "
- "hostname was configured.\n");
- return (-1);
- }
+ fprintf (stderr, "`gethostname' failed and no "
+ "hostname was configured.\n");
+ return (-1);
+ }
+
+ str = global_option_get ("FQDNLookup");
+ if ((strcasecmp ("false", str) == 0)
+ || (strcasecmp ("no", str) == 0)
+ || (strcasecmp ("off", str) == 0))
+ return (0);
+
+ memset (&ai_hints, '\0', sizeof (ai_hints));
+ ai_hints.ai_flags = AI_CANONNAME;
+
+ status = getaddrinfo (hostname_g, NULL, &ai_hints, &ai_list);
+ if (status != 0)
+ {
+ ERROR ("Looking up \"%s\" failed. You have set the "
+ "\"FQDNLookup\" option, but I cannot resolve "
+ "my hostname to a fully qualified domain "
+ "name. Please fix you network "
+ "configuration.", hostname_g);
+ return (-1);
}
}
- DEBUG ("hostname_g = %s;", hostname_g);
+
+ for (ai_ptr = ai_list; ai_ptr != NULL; ai_ptr = ai_ptr->ai_next)
+ {
+ if (ai_ptr->ai_canonname == NULL)
+ continue;
+
+ strncpy (hostname_g, ai_ptr->ai_canonname, sizeof (hostname_g));
+ hostname_g[sizeof (hostname_g) - 1] = '\0';
+ break;
+ }
+
+ freeaddrinfo (ai_list);
+ return (0);
+} /* int init_hostname */
+
+static int init_global_variables (void)
+{
+ const char *str;
str = global_option_get ("Interval");
if (str == NULL)
str = global_option_get ("Interval");
if (str == NULL)
}
DEBUG ("interval_g = %i;", interval_g);
}
DEBUG ("interval_g = %i;", interval_g);
+ if (init_hostname () != 0)
+ return (-1);
+ DEBUG ("hostname_g = %s;", hostname_g);
+
return (0);
} /* int init_global_variables */
return (0);
} /* int init_global_variables */
if (mkdir (orig_dir, 0755) == -1)
{
char errbuf[1024];
if (mkdir (orig_dir, 0755) == -1)
{
char errbuf[1024];
- ERROR ("mkdir (%s): %s", orig_dir,
+ ERROR ("change_basedir: mkdir (%s): %s", orig_dir,
sstrerror (errno, errbuf,
sizeof (errbuf)));
return (-1);
sstrerror (errno, errbuf,
sizeof (errbuf)));
return (-1);
/* TODO
* Remove all settings but `-f' and `-C'
*/
/* TODO
* Remove all settings but `-f' and `-C'
*/
-static void exit_usage (char *name)
+static void exit_usage (void)
{
printf ("Usage: "PACKAGE" [OPTIONS]\n\n"
{
printf ("Usage: "PACKAGE" [OPTIONS]\n\n"
#endif
/* Issue all plugins */
#endif
/* Issue all plugins */
- plugin_read_all (&loop);
+ plugin_read_all ();
if (gettimeofday (&tv_now, NULL) < 0)
{
if (gettimeofday (&tv_now, NULL) < 0)
{
struct sigaction sigIntAction;
struct sigaction sigTermAction;
char *configfile = CONFIGFILE;
struct sigaction sigIntAction;
struct sigaction sigTermAction;
char *configfile = CONFIGFILE;
+ int test_config = 0;
const char *basedir;
#if COLLECT_DAEMON
struct sigaction sigChldAction;
const char *basedir;
#if COLLECT_DAEMON
struct sigaction sigChldAction;
{
int c;
{
int c;
- c = getopt (argc, argv, "hC:"
+ c = getopt (argc, argv, "htC:"
#if COLLECT_DAEMON
"fP:"
#endif
#if COLLECT_DAEMON
"fP:"
#endif
case 'C':
configfile = optarg;
break;
case 'C':
configfile = optarg;
break;
+ case 't':
+ test_config = 1;
+ break;
#if COLLECT_DAEMON
case 'P':
global_option_set ("PIDFile", optarg);
#if COLLECT_DAEMON
case 'P':
global_option_set ("PIDFile", optarg);
#endif /* COLLECT_DAEMON */
case 'h':
default:
#endif /* COLLECT_DAEMON */
case 'h':
default:
- exit_usage (argv[0]);
+ exit_usage ();
} /* switch (c) */
} /* while (1) */
} /* switch (c) */
} /* while (1) */
if (init_global_variables () != 0)
return (1);
if (init_global_variables () != 0)
return (1);
+ if (test_config)
+ return (0);
+
#if COLLECT_DAEMON
/*
* fork off child
#if COLLECT_DAEMON
/*
* fork off child