diff --git a/program/src/rrd_open.c b/program/src/rrd_open.c
index b85ceefae6e98e1f0bf3c0b4cce583c6923a2311..443a1a5652a50c01a023a47c6fb51773241d364d 100644 (file)
--- a/program/src/rrd_open.c
+++ b/program/src/rrd_open.c
*****************************************************************************
* $Id$
* $Log$
*****************************************************************************
* $Id$
* $Log$
+ * Revision 1.9 2003/04/29 21:56:49 oetiker
+ * readline in rrd_open.c reads the file in 8 KB blocks, and calls realloc for
+ * each block. realloc is very slow in Mac OS X for huge blocks, e.g. when
+ * restoring databases from huge xml files. This patch finds the size of the
+ * file, and starts out with malloc'ing the full size.
+ * -- Peter Speck <speck@ruc.dk>
+ *
+ * Revision 1.8 2003/04/11 19:43:44 oetiker
+ * New special value COUNT which allows calculations based on the position of a
+ * value within a data set. Bug fix in rrd_rpncalc.c. PREV returned erroneus
+ * value for the second value. Bug fix in rrd_restore.c. Bug causing seek error
+ * when accesing an RRD restored from an xml that holds an RRD version <3.
+ * -- Ruben Justo <ruben@ainek.com>
+ *
+ * Revision 1.7 2003/03/31 21:22:12 oetiker
+ * enables RRDtool updates with microsecond or in case of windows millisecond
+ * precision. This is needed to reduce time measurement error when archive step
+ * is small. (<30s) -- Sasha Mikheev <sasha@avalon-net.co.il>
+ *
* Revision 1.6 2003/02/13 07:05:27 oetiker
* Find attached the patch I promised to send to you. Please note that there
* are three new source files (src/rrd_is_thread_safe.h, src/rrd_thread_safe.c
* Revision 1.6 2003/02/13 07:05:27 oetiker
* Find attached the patch I promised to send to you. Please note that there
* are three new source files (src/rrd_is_thread_safe.h, src/rrd_thread_safe.c
char *mode = NULL;
char *mode = NULL;
+ int version;
+
rrd_init(rrd);
if (rdwr == RRD_READONLY) {
#ifndef WIN32
rrd_init(rrd);
if (rdwr == RRD_READONLY) {
#ifndef WIN32
MYFREAD(rrd->stat_head, stat_head_t, 1)
MYFREAD(rrd->stat_head, stat_head_t, 1)
-
+ version = atoi(rrd->stat_head->version);
+
/* lets do some test if we are on track ... */
if (strncmp(rrd->stat_head->cookie,RRD_COOKIE,4) != 0){
rrd_set_error("'%s' is not an RRD file",file_name);
/* lets do some test if we are on track ... */
if (strncmp(rrd->stat_head->cookie,RRD_COOKIE,4) != 0){
rrd_set_error("'%s' is not an RRD file",file_name);
fclose(*in_file);
return(-1);}
fclose(*in_file);
return(-1);}
- if (atoi(rrd->stat_head->version) > atoi(RRD_VERSION)){
+ if (version > atoi(RRD_VERSION)){
rrd_set_error("can't handle RRD file version %s",
rrd->stat_head->version);
free(rrd->stat_head);
rrd_set_error("can't handle RRD file version %s",
rrd->stat_head->version);
free(rrd->stat_head);
MYFREAD(rrd->ds_def, ds_def_t, rrd->stat_head->ds_cnt)
MYFREAD(rrd->rra_def, rra_def_t, rrd->stat_head->rra_cnt)
MYFREAD(rrd->ds_def, ds_def_t, rrd->stat_head->ds_cnt)
MYFREAD(rrd->rra_def, rra_def_t, rrd->stat_head->rra_cnt)
- MYFREAD(rrd->live_head, live_head_t, 1)
+ /* handle different format for the live_head */
+ if(version < 3) {
+ rrd->live_head = (live_head_t *)malloc(sizeof(live_head_t));
+ if(rrd->live_head == NULL) {
+ rrd_set_error("live_head_t malloc");
+ fclose(*in_file);
+ return (-1);
+ }
+ fread(&rrd->live_head->last_up, sizeof(long), 1, *in_file);
+ rrd->live_head->last_up_usec = 0;
+ }
+ else {
+ MYFREAD(rrd->live_head, live_head_t, 1)
+ }
MYFREAD(rrd->pdp_prep, pdp_prep_t, rrd->stat_head->ds_cnt)
MYFREAD(rrd->cdp_prep, cdp_prep_t, (rrd->stat_head->rra_cnt
* rrd->stat_head->ds_cnt))
MYFREAD(rrd->pdp_prep, pdp_prep_t, rrd->stat_head->ds_cnt)
MYFREAD(rrd->cdp_prep, cdp_prep_t, (rrd->stat_head->rra_cnt
* rrd->stat_head->ds_cnt))
int readfile(char *file_name, char **buffer, int skipfirst){
long writecnt=0,totalcnt = MEMBLK;
int readfile(char *file_name, char **buffer, int skipfirst){
long writecnt=0,totalcnt = MEMBLK;
+ long offset = 0;
FILE *input=NULL;
char c ;
if ((strcmp("-",file_name) == 0)) { input = stdin; }
FILE *input=NULL;
char c ;
if ((strcmp("-",file_name) == 0)) { input = stdin; }
}
}
if (skipfirst){
}
}
if (skipfirst){
- do { c = getc(input); } while (c != '\n' && ! feof(input));
+ do { c = getc(input); offset++; } while (c != '\n' && ! feof(input));
+ }
+ if (strcmp("-",file_name)) {
+ fseek(input, 0, SEEK_END);
+ /* have extra space for detecting EOF without realloc */
+ totalcnt = (ftell(input) + 1) / sizeof(char) - offset;
+ if (totalcnt < MEMBLK)
+ totalcnt = MEMBLK; /* sanitize */
+ fseek(input, offset * sizeof(char), SEEK_SET);
}
}
- if (((*buffer) = (char *) malloc((MEMBLK+4)*sizeof(char))) == NULL) {
+ if (((*buffer) = (char *) malloc((totalcnt+4) * sizeof(char))) == NULL) {
perror("Allocate Buffer:");
exit(1);
};
do{
perror("Allocate Buffer:");
exit(1);
};
do{
- writecnt += fread((*buffer)+writecnt, 1, MEMBLK * sizeof(char) ,input);
+ writecnt += fread((*buffer)+writecnt, 1, (totalcnt - writecnt) * sizeof(char),input);
if (writecnt >= totalcnt){
totalcnt += MEMBLK;
if (((*buffer)=rrd_realloc((*buffer), (totalcnt+4) * sizeof(char)))==NULL){
if (writecnt >= totalcnt){
totalcnt += MEMBLK;
if (((*buffer)=rrd_realloc((*buffer), (totalcnt+4) * sizeof(char)))==NULL){