Code

Check size of path buffer before writing into it
authorGreg Brockman <gdb@MIT.EDU>
Tue, 20 Jul 2010 04:46:21 +0000 (00:46 -0400)
committerJunio C Hamano <gitster@pobox.com>
Sun, 25 Jul 2010 17:33:47 +0000 (10:33 -0700)
This prevents a buffer overrun that could otherwise be triggered by
creating a file called '.git' with contents

  gitdir: (something really long)

Signed-off-by: Greg Brockman <gdb@mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
setup.c

diff --git a/setup.c b/setup.c
index e3781b656d77be94e04c5229e6a190c5fc496490..01e1a6a7c5cb23909a8cc5050a1f7470abfff9eb 100644 (file)
--- a/setup.c
+++ b/setup.c
@@ -153,6 +153,8 @@ static int is_git_directory(const char *suspect)
        char path[PATH_MAX];
        size_t len = strlen(suspect);
 
+       if (PATH_MAX <= len + strlen("/objects"))
+               die("Too long path: %.*s", 60, suspect);
        strcpy(path, suspect);
        if (getenv(DB_ENVIRONMENT)) {
                if (access(getenv(DB_ENVIRONMENT), X_OK))