Code

strbuf.c: remove unnecessary strbuf_grow() from strbuf_getwholeline()
authorBrandon Casey <drafnel@gmail.com>
Thu, 6 Oct 2011 04:21:33 +0000 (23:21 -0500)
committerJunio C Hamano <gitster@pobox.com>
Tue, 18 Oct 2011 20:28:17 +0000 (13:28 -0700)
This use of strbuf_grow() is a historical artifact that was once used to
ensure that strbuf.buf was allocated and properly nul-terminated.  This
was added before the introduction of the slopbuf in b315c5c0, which
guarantees that strbuf.buf always points to a usable nul-terminated string.
So let's remove it.

Signed-off-by: Brandon Casey <drafnel@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
strbuf.c

index 9ff1b597c995780026a32a92fab78a780d60329a..3ad2cc00160fbf24e1e4904bb37ce44e8c414ce5 100644 (file)
--- a/strbuf.c
+++ b/strbuf.c
@@ -357,7 +357,6 @@ int strbuf_getwholeline(struct strbuf *sb, FILE *fp, int term)
 {
        int ch;
 
-       strbuf_grow(sb, 0);
        if (feof(fp))
                return EOF;