Code

git-upload-pack: make sure we close unused pipe ends
authorH. Peter Anvin <hpa@zytor.com>
Tue, 27 Mar 2007 23:45:06 +0000 (16:45 -0700)
committerJunio C Hamano <junkio@cox.net>
Wed, 28 Mar 2007 00:05:12 +0000 (17:05 -0700)
commit465b3518a9ad5080a4b652ef35fb13c61a93e7a4
treea0874d5850747ce0f51b3332f58edfd4b67bcf0d
parent4621af371686f5c787c172c285562ad997281821
git-upload-pack: make sure we close unused pipe ends

Right now, we don't close the read end of the pipe when git-upload-pack
runs git-pack-object, so we hang forever (why don't we get SIGALRM?)
instead of dying with SIGPIPE if the latter dies, which seems to be the
norm if the client disconnects.

Thanks to Johannes Schindelin <Johannes.Schindelin@gmx.de> for
pointing out where this close() needed to go.

This patch has been tested on kernel.org for several weeks and appear
to resolve the problem of git-upload-pack processes hanging around
forever.

Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
upload-pack.c