Code

setup.c:verify_non_filename(): don't die unnecessarily while disambiguating
authorJunio C Hamano <gitster@pobox.com>
Mon, 6 Aug 2007 07:20:06 +0000 (00:20 -0700)
committerJunio C Hamano <gitster@pobox.com>
Mon, 6 Aug 2007 07:25:35 +0000 (00:25 -0700)
commit33a798c880f9a8bed1fe95531349e5e5ef1e0cd2
treee61b0b1fcdb9efdc8fa87b05a90c3959afa929be
parent4e0b2bbc578f8729cf43939acb36e8db02ed8825
setup.c:verify_non_filename(): don't die unnecessarily while disambiguating

If you have a working tree _file_ "foo", attempt to refer to a
branch "foo/bar" without -- to disambiguate, like this:

$ git log foo/bar

tried to make sure that foo/bar cannot be naming a working tree
file "foo/bar" (in which case we would say "which one do you
want?  A rev or a working tree file?  clarify with -- please").
We run lstat("foo/bar") to check that.  If it does not succeed,
there is no ambiguity.

That is good.  But we also checked the error status for the
lstat() and expected it to fail with ENOENT.  In this particular
case, however, it fails with ENOTDIR.  That should be treated as
"expected error" as well.

Signed-off-by: Junio C Hamano <gitster@pobox.com>
setup.c